* Re: [PATCH] docs: mm: Fix number of base pages for 1GB HugeTLB [not found] <20230207114456.2304801-1-usama.arif@bytedance.com> @ 2023-02-08 3:43 ` Muchun Song 2023-02-08 9:51 ` Mike Rapoport 2023-07-25 9:09 ` David Hildenbrand 2 siblings, 0 replies; 6+ messages in thread From: Muchun Song @ 2023-02-08 3:43 UTC (permalink / raw) To: Usama Arif; +Cc: linux-mm, linux-kernel, linux-doc, fam.zheng, liangma On Tue, Feb 7, 2023 at 7:45 PM Usama Arif <usama.arif@bytedance.com> wrote: > > 1GB HugeTLB page consists of 262144 base pages. > > Signed-off-by: Usama Arif <usama.arif@bytedance.com> Thanks for your fix. Acked-by: Muchun Song <songmuchun@bytedance.com> ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] docs: mm: Fix number of base pages for 1GB HugeTLB [not found] <20230207114456.2304801-1-usama.arif@bytedance.com> 2023-02-08 3:43 ` [PATCH] docs: mm: Fix number of base pages for 1GB HugeTLB Muchun Song @ 2023-02-08 9:51 ` Mike Rapoport 2023-07-24 14:05 ` [External] " Usama Arif 2023-07-25 9:09 ` David Hildenbrand 2 siblings, 1 reply; 6+ messages in thread From: Mike Rapoport @ 2023-02-08 9:51 UTC (permalink / raw) To: Usama Arif Cc: songmuchun, linux-mm, linux-kernel, linux-doc, fam.zheng, liangma On Tue, Feb 07, 2023 at 11:44:56AM +0000, Usama Arif wrote: > 1GB HugeTLB page consists of 262144 base pages. > > Signed-off-by: Usama Arif <usama.arif@bytedance.com> Acked-by: Mike Rapoport (IBM) <rppt@kernel.org> > --- > Documentation/mm/vmemmap_dedup.rst | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/mm/vmemmap_dedup.rst b/Documentation/mm/vmemmap_dedup.rst > index a4b12ff906c4..689a6907c70b 100644 > --- a/Documentation/mm/vmemmap_dedup.rst > +++ b/Documentation/mm/vmemmap_dedup.rst > @@ -1,3 +1,4 @@ > + > .. SPDX-License-Identifier: GPL-2.0 > > ========================================= > @@ -17,7 +18,7 @@ HugeTLB pages consist of multiple base page size pages and is supported by many > architectures. See Documentation/admin-guide/mm/hugetlbpage.rst for more > details. On the x86-64 architecture, HugeTLB pages of size 2MB and 1GB are > currently supported. Since the base page size on x86 is 4KB, a 2MB HugeTLB page > -consists of 512 base pages and a 1GB HugeTLB page consists of 4096 base pages. > +consists of 512 base pages and a 1GB HugeTLB page consists of 262144 base pages. > For each base page, there is a corresponding ``struct page``. > > Within the HugeTLB subsystem, only the first 4 ``struct page`` are used to > -- > 2.25.1 > -- Sincerely yours, Mike. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [External] Re: [PATCH] docs: mm: Fix number of base pages for 1GB HugeTLB 2023-02-08 9:51 ` Mike Rapoport @ 2023-07-24 14:05 ` Usama Arif 2023-07-25 6:07 ` Mike Rapoport 0 siblings, 1 reply; 6+ messages in thread From: Usama Arif @ 2023-07-24 14:05 UTC (permalink / raw) To: Mike Rapoport, songmuchun, linux-mm Cc: linux-kernel, linux-doc, fam.zheng, liangma On 08/02/2023 09:51, Mike Rapoport wrote: > On Tue, Feb 07, 2023 at 11:44:56AM +0000, Usama Arif wrote: >> 1GB HugeTLB page consists of 262144 base pages. >> >> Signed-off-by: Usama Arif <usama.arif@bytedance.com> > > Acked-by: Mike Rapoport (IBM) <rppt@kernel.org> > >> --- >> Documentation/mm/vmemmap_dedup.rst | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/mm/vmemmap_dedup.rst b/Documentation/mm/vmemmap_dedup.rst >> index a4b12ff906c4..689a6907c70b 100644 >> --- a/Documentation/mm/vmemmap_dedup.rst >> +++ b/Documentation/mm/vmemmap_dedup.rst >> @@ -1,3 +1,4 @@ >> + >> .. SPDX-License-Identifier: GPL-2.0 >> >> ========================================= >> @@ -17,7 +18,7 @@ HugeTLB pages consist of multiple base page size pages and is supported by many >> architectures. See Documentation/admin-guide/mm/hugetlbpage.rst for more >> details. On the x86-64 architecture, HugeTLB pages of size 2MB and 1GB are >> currently supported. Since the base page size on x86 is 4KB, a 2MB HugeTLB page >> -consists of 512 base pages and a 1GB HugeTLB page consists of 4096 base pages. >> +consists of 512 base pages and a 1GB HugeTLB page consists of 262144 base pages. >> For each base page, there is a corresponding ``struct page``. >> >> Within the HugeTLB subsystem, only the first 4 ``struct page`` are used to >> -- >> 2.25.1 >> > Hi, Was just reading vmemmap_dedup.rst for something and realized that its still 4096 pages for 1G, maybe this patch got missed? Thanks, Usama ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [External] Re: [PATCH] docs: mm: Fix number of base pages for 1GB HugeTLB 2023-07-24 14:05 ` [External] " Usama Arif @ 2023-07-25 6:07 ` Mike Rapoport 2023-07-31 16:03 ` Jonathan Corbet 0 siblings, 1 reply; 6+ messages in thread From: Mike Rapoport @ 2023-07-25 6:07 UTC (permalink / raw) To: Usama Arif, Jonathan Corbet Cc: songmuchun, linux-mm, linux-kernel, linux-doc, fam.zheng, liangma (adding Jon) On Mon, Jul 24, 2023 at 03:05:29PM +0100, Usama Arif wrote: > > > On 08/02/2023 09:51, Mike Rapoport wrote: > > On Tue, Feb 07, 2023 at 11:44:56AM +0000, Usama Arif wrote: > > > 1GB HugeTLB page consists of 262144 base pages. > > > > > > Signed-off-by: Usama Arif <usama.arif@bytedance.com> > > > > Acked-by: Mike Rapoport (IBM) <rppt@kernel.org> > > > > > --- > > > Documentation/mm/vmemmap_dedup.rst | 3 ++- > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > diff --git a/Documentation/mm/vmemmap_dedup.rst b/Documentation/mm/vmemmap_dedup.rst > > > index a4b12ff906c4..689a6907c70b 100644 > > > --- a/Documentation/mm/vmemmap_dedup.rst > > > +++ b/Documentation/mm/vmemmap_dedup.rst > > > @@ -1,3 +1,4 @@ > > > + > > > .. SPDX-License-Identifier: GPL-2.0 > > > ========================================= > > > @@ -17,7 +18,7 @@ HugeTLB pages consist of multiple base page size pages and is supported by many > > > architectures. See Documentation/admin-guide/mm/hugetlbpage.rst for more > > > details. On the x86-64 architecture, HugeTLB pages of size 2MB and 1GB are > > > currently supported. Since the base page size on x86 is 4KB, a 2MB HugeTLB page > > > -consists of 512 base pages and a 1GB HugeTLB page consists of 4096 base pages. > > > +consists of 512 base pages and a 1GB HugeTLB page consists of 262144 base pages. > > > For each base page, there is a corresponding ``struct page``. > > > Within the HugeTLB subsystem, only the first 4 ``struct page`` are used to > > > -- > > > 2.25.1 > > > > > > > Hi, > > Was just reading vmemmap_dedup.rst for something and realized that its still > 4096 pages for 1G, maybe this patch got missed? > > Thanks, > Usama -- Sincerely yours, Mike. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [External] Re: [PATCH] docs: mm: Fix number of base pages for 1GB HugeTLB 2023-07-25 6:07 ` Mike Rapoport @ 2023-07-31 16:03 ` Jonathan Corbet 0 siblings, 0 replies; 6+ messages in thread From: Jonathan Corbet @ 2023-07-31 16:03 UTC (permalink / raw) To: Mike Rapoport, Usama Arif Cc: songmuchun, linux-mm, linux-kernel, linux-doc, fam.zheng, liangma Mike Rapoport <rppt@kernel.org> writes: > (adding Jon) > > On Mon, Jul 24, 2023 at 03:05:29PM +0100, Usama Arif wrote: >> >> >> On 08/02/2023 09:51, Mike Rapoport wrote: >> > On Tue, Feb 07, 2023 at 11:44:56AM +0000, Usama Arif wrote: >> > > 1GB HugeTLB page consists of 262144 base pages. >> > > >> > > Signed-off-by: Usama Arif <usama.arif@bytedance.com> >> > >> > Acked-by: Mike Rapoport (IBM) <rppt@kernel.org> >> > >> > > --- >> > > Documentation/mm/vmemmap_dedup.rst | 3 ++- >> > > 1 file changed, 2 insertions(+), 1 deletion(-) >> > > >> > > diff --git a/Documentation/mm/vmemmap_dedup.rst b/Documentation/mm/vmemmap_dedup.rst >> > > index a4b12ff906c4..689a6907c70b 100644 >> > > --- a/Documentation/mm/vmemmap_dedup.rst >> > > +++ b/Documentation/mm/vmemmap_dedup.rst >> > > @@ -1,3 +1,4 @@ >> > > + >> > > .. SPDX-License-Identifier: GPL-2.0 >> > > ========================================= >> > > @@ -17,7 +18,7 @@ HugeTLB pages consist of multiple base page size pages and is supported by many >> > > architectures. See Documentation/admin-guide/mm/hugetlbpage.rst for more >> > > details. On the x86-64 architecture, HugeTLB pages of size 2MB and 1GB are >> > > currently supported. Since the base page size on x86 is 4KB, a 2MB HugeTLB page >> > > -consists of 512 base pages and a 1GB HugeTLB page consists of 4096 base pages. >> > > +consists of 512 base pages and a 1GB HugeTLB page consists of 262144 base pages. >> > > For each base page, there is a corresponding ``struct page``. >> > > Within the HugeTLB subsystem, only the first 4 ``struct page`` are used to >> > > -- >> > > 2.25.1 >> > > >> > >> >> Hi, >> >> Was just reading vmemmap_dedup.rst for something and realized that its still >> 4096 pages for 1G, maybe this patch got missed? Dug out of the archives and applied, thanks. jon ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] docs: mm: Fix number of base pages for 1GB HugeTLB [not found] <20230207114456.2304801-1-usama.arif@bytedance.com> 2023-02-08 3:43 ` [PATCH] docs: mm: Fix number of base pages for 1GB HugeTLB Muchun Song 2023-02-08 9:51 ` Mike Rapoport @ 2023-07-25 9:09 ` David Hildenbrand 2 siblings, 0 replies; 6+ messages in thread From: David Hildenbrand @ 2023-07-25 9:09 UTC (permalink / raw) To: Usama Arif, songmuchun Cc: linux-mm, linux-kernel, linux-doc, fam.zheng, liangma On 07.02.23 12:44, Usama Arif wrote: > 1GB HugeTLB page consists of 262144 base pages. > > Signed-off-by: Usama Arif <usama.arif@bytedance.com> > --- > Documentation/mm/vmemmap_dedup.rst | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/mm/vmemmap_dedup.rst b/Documentation/mm/vmemmap_dedup.rst > index a4b12ff906c4..689a6907c70b 100644 > --- a/Documentation/mm/vmemmap_dedup.rst > +++ b/Documentation/mm/vmemmap_dedup.rst > @@ -1,3 +1,4 @@ > + > .. SPDX-License-Identifier: GPL-2.0 > > ========================================= > @@ -17,7 +18,7 @@ HugeTLB pages consist of multiple base page size pages and is supported by many > architectures. See Documentation/admin-guide/mm/hugetlbpage.rst for more > details. On the x86-64 architecture, HugeTLB pages of size 2MB and 1GB are > currently supported. Since the base page size on x86 is 4KB, a 2MB HugeTLB page > -consists of 512 base pages and a 1GB HugeTLB page consists of 4096 base pages. > +consists of 512 base pages and a 1GB HugeTLB page consists of 262144 base pages. > For each base page, there is a corresponding ``struct page``. > > Within the HugeTLB subsystem, only the first 4 ``struct page`` are used to Reviewed-by: David Hildenbrand <david@redhat.com> -- Cheers, David / dhildenb ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-07-31 16:04 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20230207114456.2304801-1-usama.arif@bytedance.com>
2023-02-08 3:43 ` [PATCH] docs: mm: Fix number of base pages for 1GB HugeTLB Muchun Song
2023-02-08 9:51 ` Mike Rapoport
2023-07-24 14:05 ` [External] " Usama Arif
2023-07-25 6:07 ` Mike Rapoport
2023-07-31 16:03 ` Jonathan Corbet
2023-07-25 9:09 ` David Hildenbrand
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).