From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CF89C3DA4A for ; Thu, 22 Aug 2024 12:35:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 181B16B0190; Thu, 22 Aug 2024 08:35:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1304F8002A; Thu, 22 Aug 2024 08:35:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EF4E48001E; Thu, 22 Aug 2024 08:35:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id CEDDD6B0190 for ; Thu, 22 Aug 2024 08:35:49 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 6ED2F80640 for ; Thu, 22 Aug 2024 12:35:49 +0000 (UTC) X-FDA: 82479828018.10.1CBB84C Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) by imf28.hostedemail.com (Postfix) with ESMTP id 6071AC0029 for ; Thu, 22 Aug 2024 12:35:47 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ktBnEJNG; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf28.hostedemail.com: domain of asml.silence@gmail.com designates 209.85.218.47 as permitted sender) smtp.mailfrom=asml.silence@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724330081; a=rsa-sha256; cv=none; b=MbiaGVmrLnncCOuzkRDzVBRn1R0dxD6cZ7hWB0T9EMLRyg/OH9u2DGXFO7X4uxHgE6/shI iwAJP5K5++yMDy6krs6JOA3xdoGbdbizxb1uA7/+nT5iQBxupb7EP/xV/kvcNNDH02sbmF I3g46+hSR5Q3e5MFL/wvZpG5MK24GsE= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ktBnEJNG; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf28.hostedemail.com: domain of asml.silence@gmail.com designates 209.85.218.47 as permitted sender) smtp.mailfrom=asml.silence@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724330081; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=q+0dktRKYHl61I/Q2s7ldhzyAfIA2RsHp0cV11cWAX0=; b=NQCPKXtLi7qLKHR9N3VNwoihdvQt4sod2EWHqNTweWwTojRf1a1Uti022+wQmViMkhgbxE u0Tk7JyfFlWS5AHG76i/z+IDR+rws1QZLP94LJR2nJEO20U6tQoNbOdOFy4Gdsar11xEVc wHC2mBkAIuQBrac3J+hPWHUdWmczLHk= Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-a868b8bb0feso101868966b.0 for ; Thu, 22 Aug 2024 05:35:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724330145; x=1724934945; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=q+0dktRKYHl61I/Q2s7ldhzyAfIA2RsHp0cV11cWAX0=; b=ktBnEJNGcvK9LZ9JgPud4H6sEjm3rnACu2LU19/bEgKVgfhzMuEg7RXFa8HBvx/xfQ Sh43AfWJ/BIJoEF11M9zFkTSjmMFkuIl/mnuNO9r7+h7IZNqvjLHe+mZtXSAGXn/zFub 5Njy38pK0QVn2crvkjBA4Bdjgl8aWSwoq4z5qmyYLkP5m9S7arQNPaHX+rPVblc5sbSv ooPoRLfbdjw5cbs6F+2gyDNkaIDUcvH1e+BTL7gmTIYNy67QXUPtKKSho9I5sv+w1uH7 odbwzgoSJAcTuXR+0DQqqF0q0PEn/aamR8bdD4+iAXC6F8sbxU7UJlEp1zJbuDPCYPxK wHDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724330145; x=1724934945; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=q+0dktRKYHl61I/Q2s7ldhzyAfIA2RsHp0cV11cWAX0=; b=sf2gxeDyH/r66lpO+H9elb5XR+J7ZAwdbEkKMYWffxnxNiB5Yi0dqdhuNRUGeRZ7Hd hjXRqQBr9TJPyXopd+4ENTnG2kB5HtgcR8xt+/5+ftx2gf+FJOd5jhkhH0Q3SiRtcvVJ iWO5jkh094vyoLXOOZ1S2rBpKH8he+HDhxSh8zk97bhXy5nzq6JzZQ09AVxmWuFW0n+S QTc5AkhgB2S083WQMhWGZWvFgP08zp3ItTqI49ZAaYltWIpJi4sRv1Tg/d0lY/2Wbwuk FtbnZvPgfNzbyJ8RYpWWjJcIuPt54Wd8fVVAQ5Sdk8RD5qiwY80GS5wglrJBNxole/bo 004A== X-Forwarded-Encrypted: i=1; AJvYcCVW7frDC398pI691FFsWoWD0X2wpWfN2RQgSTmucyl4y012xTfLFUKdbwNgfGnFwWjj3ZodOk+Hhw==@kvack.org X-Gm-Message-State: AOJu0YzxS6endo6IorpIJVSaE0demnxxQA1vIFxrwpeksG6irUJj6yD5 4cvvOHEDiHzFgYfuEaitKrmCFlHxjjZi6ORAp3bMvq272aG9ACR+ X-Google-Smtp-Source: AGHT+IHmPxFiKloNbwibXkt5dnFisWioWsMl8U9+Jx66GEN9vlr/Ynj3g2R9B2OuDv68gFviAFDjBg== X-Received: by 2002:a17:907:d5a7:b0:a7a:ae85:f24d with SMTP id a640c23a62f3a-a866f8c3451mr426343566b.51.1724330145109; Thu, 22 Aug 2024 05:35:45 -0700 (PDT) Received: from [192.168.42.32] ([163.114.131.193]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a869cdd4ef4sm1556266b.166.2024.08.22.05.35.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Aug 2024 05:35:44 -0700 (PDT) Message-ID: Date: Thu, 22 Aug 2024 13:36:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/7] block: introduce blk_validate_write() To: Christoph Hellwig Cc: io-uring@vger.kernel.org, Jens Axboe , Conrad Meyer , linux-block@vger.kernel.org, linux-mm@kvack.org References: <2ef85c782997ad40e923e7640039e0c7795e19da.1724297388.git.asml.silence@gmail.com> Content-Language: en-US From: Pavel Begunkov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 6071AC0029 X-Stat-Signature: ep4ugi8twjthwiuo1tifmxdkgcpi5snd X-Rspam-User: X-HE-Tag: 1724330147-136954 X-HE-Meta: U2FsdGVkX1+mB6VhVwlUnbtrbiNWiu7YVbwFseY2neWMGu/dfHVkHZmV4vboxt2I9tAj+xKGznB9otmJLUdP486qDCVkL40g0/nyz6IMtIi8dKNRPXf1570WD2e3h4zSkbdiKo/YCtQoR09eT727P1SMwJ823wiBz4xB4IvrMCXAyI0jG7G83liC43OcH2d/IcSlYt2HgKkAhH2S9zbk6Ov3kpDGEAD75sUalSrsVdtgB7+pjtqlb0X9Vm7zxuNJ8b+iGRUozc8OHnAv9EmMElOrNSA9GdYMwonom8LXCZHo2IRf4NIhWnP+Tg5yBJmCdyD+lJA9LoItvpb1mJUBrlL6ZMNdHAG0czy7VO+wmdk4qQ3W/fodGklzkJHp5A+/xLtcmiBKA8oNvfqh87sGAcVnFUQ8Lkiccd7oiJ+GzgOUQ6qZJFzvoINZDUtSsojzEMs0YIjK2zvHNzMLyoDdmtBwoMdUFsiKNxfDvMzC2KD/3+tlAdu25Zks7Xg0cOLPZROXEOitWmiOayJKWkqWl5sJdhIg2UzZxQVslTbaHsV/QbCbfuEylEVBNnG6sJLsqBjlyCTMXznm/Ms0m1UiQ9g4NNunMLXbW69w9rhFMj6yxJ/PFFgjnD60rmWEqgJCcOKrELtRp5BY40+kulUeYIOpzHloYZsPKZhbm3q9Bzz3OV4bipV2eZSnfzkT8gQg/WpEhMRR2tFu7YqsNbl8a782QHTRGFFLBVWOwQxMKusN2tVZDHxkP7+dJ8pcERGBi7cMbKZ7QYa33Xl0HfW+GPzyjJkgR1wi/wo2FZYm9QfegpNMtbLb7JRarsijKdhSQuL4QEhp5O4rAGDiIazEUc/2QxLxGr+yvGaqS4iKQdoAv1VlAbA4xl0e6dnPd2uD41mz2iiaMSPEfyox6oxcOdkqW71irMBWUz7Ygyxg2gNk+x3FmJso0HJTcHpTIrEXPBm0oAKMRP2Y7HnBMuz GqU8VqTT eBxiGNUax5WfuIGgKIcTlvzjXdOpvt0AGOEj2Pgd8qXXdwpVtsw/SL4aUhnlqAjeQ6xNizL82ljM+RmlakgkdWsbBvUBbOKShU1WFolINj2My/dj6xQflean4853o8aEpoJ2iIu7+cP9J09uRQDTERLsdtmSCmjdigcctpJarVCqi3Tvoi8Gb00xzhawi1ONzrcRgOZqeo80au/jQ/pzcOen4rY669jqLfYl0cm0rvdgaXHKSMXsfivxqHK9kXAhsaYz3z1xiDUMS6O5bOwD5YRKXdH5BpjeKU6gVl2GkOQpyGBg/SOns3xCeb/Juq9gDgTTYozZOYuCkx5iAErqX2mxJV/xKQB9O+78C6u7UsJrb5+v8OZA3XOFB/Tm4CJA+xLHlMPWym03zrlGgrw134KmxC9Lu77knYf+aV5h7cevHovDahc1t0ItEQ8RwqQ8VGD89jI9sMYruFqY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.404926, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 8/22/24 07:33, Christoph Hellwig wrote: > On Thu, Aug 22, 2024 at 04:35:54AM +0100, Pavel Begunkov wrote: >> In preparation to further changes extract a helper function out of >> blk_ioctl_discard() that validates if it's allowed to do a write-like >> operation for the given range. > > This isn't about a write, it is about a discard. It's used for other commands in the series, all of them are semantically "writes", or modifying data operations if that's better. How would you call it? Some blk_modify_validate_args, maybe? -- Pavel Begunkov