From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 111FCC47083 for ; Wed, 2 Jun 2021 08:59:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AE572613AE for ; Wed, 2 Jun 2021 08:59:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AE572613AE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 43C066B006C; Wed, 2 Jun 2021 04:59:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3EB606B006E; Wed, 2 Jun 2021 04:59:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 23EB56B0070; Wed, 2 Jun 2021 04:59:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0021.hostedemail.com [216.40.44.21]) by kanga.kvack.org (Postfix) with ESMTP id E74C46B006C for ; Wed, 2 Jun 2021 04:59:54 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 710F0181AC9B6 for ; Wed, 2 Jun 2021 08:59:54 +0000 (UTC) X-FDA: 78208186308.20.8D3971B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf27.hostedemail.com (Postfix) with ESMTP id E1D968019366 for ; Wed, 2 Jun 2021 08:59:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622624393; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=G01wiBaLKBgH8SUhvu9oGDvUb9DEe5X1aND1gEIw1Uw=; b=UkjMJobeHic/ZzmJQ1sPI0uDbd9/44M3UNVbTOKLWJeexuvYKcswyZnJ0bZKtDpez4vjON rsSdVl+kHIhKj178Ear+Pwe8VImlHkoocU2t/PyhFhdM/HxGE0ENVi2eX7dMQbYaRhvvqd 7qM0FXxbxzh9Jv41bv3+wW8B3k2ZPec= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-260-PIejMqFNMzS1HLZAnkHdZw-1; Wed, 02 Jun 2021 04:59:49 -0400 X-MC-Unique: PIejMqFNMzS1HLZAnkHdZw-1 Received: by mail-wm1-f72.google.com with SMTP id h18-20020a05600c3512b029018434eb1bd8so1910411wmq.2 for ; Wed, 02 Jun 2021 01:59:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=G01wiBaLKBgH8SUhvu9oGDvUb9DEe5X1aND1gEIw1Uw=; b=FfA+xMwURyoU9/f+acBIYJEXe1JBhIawLVT0YYotou8wt2yPnUjvIZnOKvHbI0iImL FxU6byqO7eMrwWyoM1spI1jV7ya5mYwtdfpITZx1GMnMOKuOPP8uv7efC4US8gS+27eg leNsngCo+OQMKijGLMGOKhgdeGpPUBDJW8lg4V7UMe7mnrGPA+8kqoneJcHJNqYD4l7V 8fzNo/o+UyE2KHkpM0uV3cdWsFYu/xC6b56GpZZNCFfkDYuiHO56pnAHyRi4vEsfUADq kc+MLmDSBMJEqyNuxwSWI5UgAWgkv8i+v7RO1jGAhfYZNOcF2XMIUJk5alpJ2wLWLWwb CTxQ== X-Gm-Message-State: AOAM533WBcsBZEROIElIKbL5IZuRaNtVxh6u75QFa5TRsXTXBf/JDR7D 4hK4Wv3am0WCuG5aBgjfJ0FZxqV47TySI79Z/LkJqOHKyKy0xSwWrxMGW1gDCcQ1SV8hZGYOe1g Z+PESxISaIi4= X-Received: by 2002:a1c:b403:: with SMTP id d3mr30619888wmf.79.1622624388677; Wed, 02 Jun 2021 01:59:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwCtRron1WFQC5Hl070ikJ3dyVvR/vrEL+ewi/Nnf7WjDG+gQRJfo9tqov5kPUU764Ml8sA/A== X-Received: by 2002:a1c:b403:: with SMTP id d3mr30619871wmf.79.1622624388470; Wed, 02 Jun 2021 01:59:48 -0700 (PDT) Received: from [192.168.3.132] (p5b0c6b6d.dip0.t-ipconnect.de. [91.12.107.109]) by smtp.gmail.com with ESMTPSA id m5sm1982332wmq.6.2021.06.02.01.59.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Jun 2021 01:59:48 -0700 (PDT) Subject: Re: [PATCH 1/2] mm,memory_hotplug: align code to fit 80 characters per line To: Max Gurtovoy , akpm@linux-foundation.org, linux-mm@kvack.org Cc: pasha.tatashin@soleen.com, linux-kernel@vger.kernel.org, logang@deltatee.com References: <20210602084752.3534-1-mgurtovoy@nvidia.com> From: David Hildenbrand Organization: Red Hat Message-ID: Date: Wed, 2 Jun 2021 10:59:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210602084752.3534-1-mgurtovoy@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: E1D968019366 Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UkjMJobe; spf=none (imf27.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam04 X-Stat-Signature: 3bmb8jokbqxddgrd31s6kup16dh1z3pb X-HE-Tag: 1622624380-861163 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 02.06.21 10:47, Max Gurtovoy wrote: > The "if" clause can fit to one line. Also while we're here, fix the end > pfn print (use %#lx instead of #%lx). > I think the subject could be more expressive. I'd suggest "mm,memory_hotplug: cleanup alignment checks in check_pfn_span" Reviewed-by: David Hildenbrand > Signed-off-by: Max Gurtovoy > --- > mm/memory_hotplug.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index 70620d0dd923..8c3b423c1141 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -288,10 +288,9 @@ static int check_pfn_span(unsigned long pfn, unsigned long nr_pages, > min_align = PAGES_PER_SUBSECTION; > else > min_align = PAGES_PER_SECTION; > - if (!IS_ALIGNED(pfn, min_align) > - || !IS_ALIGNED(nr_pages, min_align)) { > - WARN(1, "Misaligned __%s_pages start: %#lx end: #%lx\n", > - reason, pfn, pfn + nr_pages - 1); > + if (!IS_ALIGNED(pfn, min_align) || !IS_ALIGNED(nr_pages, min_align)) { > + WARN(1, "Misaligned __%s_pages start: %#lx end: %#lx\n", > + reason, pfn, pfn + nr_pages - 1); > return -EINVAL; > } > return 0; > -- Thanks, David / dhildenb