From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C631FC71135 for ; Mon, 16 Jun 2025 07:45:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4F08B6B0092; Mon, 16 Jun 2025 03:45:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4C8406B0093; Mon, 16 Jun 2025 03:45:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3DDF26B0095; Mon, 16 Jun 2025 03:45:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 2D3306B0092 for ; Mon, 16 Jun 2025 03:45:30 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id C8D57C0737 for ; Mon, 16 Jun 2025 07:45:29 +0000 (UTC) X-FDA: 83560478778.27.3D3E47E Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf04.hostedemail.com (Postfix) with ESMTP id 04C0D40010 for ; Mon, 16 Jun 2025 07:45:27 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ZB2rMIak; spf=pass (imf04.hostedemail.com: domain of hawk@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=hawk@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750059928; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MgtI8Pkz2tCcA3qXUE26pWDw67/eU5fvPXIjqofMVWU=; b=zdWC+z+AevlCQrlOn7HbIBNkgY+LF2ExHOkYScsxROB3thIxehJRXba3zy2MCWTIhEmrtP a9k9f+iCS4h3dzGdkjPIiTXH51RhjPY5eehjzzjzDCSFhtUA/mmUJMP301FAi1wWIrcUsq xVhbNVSDlYV9rB0m4nFvlN5GvO+OvPc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750059928; a=rsa-sha256; cv=none; b=Fpz1eNsTSRf3u3FvtQV6ifnNf11hMayEMrTroereMNMo6kZBrcMtEkslVVa1lIgQ+AuvXk 4mlVC3Yvq2t+q6iehOenHtPjrVM6SdnmiJq4mud4407mbpw9p5ptMeN2FMqsL2m3JtpzLG kMolKZAkzhtVqqIQBqXhg9iK4OmaCDo= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ZB2rMIak; spf=pass (imf04.hostedemail.com: domain of hawk@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=hawk@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 881BB40BF2; Mon, 16 Jun 2025 07:45:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DDAA0C4CEEA; Mon, 16 Jun 2025 07:45:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1750059925; bh=vHO6QCfc9duf+IwovLForDeOanm+zkghY5l8I2+xikM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ZB2rMIakqJgfKo62/tAMf5DkeFCIxlGjrc80HffKBy2eCBOf5Bxwr0xOBX4y7qQcK ij67s4Q8l1+4LABueLyoPaflLEtqi6kx+t8EuEgSdGXRcrq9fBHZ+85zLGRCKiCQRQ UeR4Ot73joKTCuresfP5hqsYw5RErjkWSKeck0O7GhRyv5lU2Aj03DW3DPG22VcaG/ ScjieMek8whWcLEevdAfHWVV6SQCKSF7a9xLzMAj+dayftBm2NkAsjTBGCwsTMuz6P g/QbBzKyvoPDVn9UsfryoY1tK8YDYrB7xVMqtsSOyaFpUpwi3fHnXEfFBAwIP3vVEe LTIOR9zH1ha4A== Message-ID: Date: Mon, 16 Jun 2025 09:45:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 0/9] Split netmem from struct page To: Mina Almasry , Pavel Begunkov Cc: Byungchul Park , willy@infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, kuba@kernel.org, ilias.apalodimas@linaro.org, harry.yoo@oracle.com, akpm@linux-foundation.org, davem@davemloft.net, john.fastabend@gmail.com, andrew+netdev@lunn.ch, toke@redhat.com, tariqt@nvidia.com, edumazet@google.com, pabeni@redhat.com, saeedm@nvidia.com, leon@kernel.org, ast@kernel.org, daniel@iogearbox.net, david@redhat.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, mhocko@suse.com, horms@kernel.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, vishal.moola@gmail.com References: <20250609043225.77229-1-byungchul@sk.com> <8c7c1039-5b9c-4060-8292-87047dfd9845@gmail.com> Content-Language: en-US From: Jesper Dangaard Brouer In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: 04C0D40010 X-Stat-Signature: r48km4uszmo33cet4379r4t8zyegnxcd X-Rspamd-Server: rspam04 X-HE-Tag: 1750059927-180898 X-HE-Meta: U2FsdGVkX19O5QQ6PHjLauMQRMHblAL9zYDF5KDy91McIEXcaNjB3mal9iQyR8U4FffiX+SbRF5zw+TQhfxY0rFr7a+te+09ZQjQlfIBMqgrvflgRePl09e0H7EX7QKWDLdYIV30p8wnoumzercFwxE/xKF9ogCxHa7Bn0NE0EAT9Sz5LqKexwpGFEYOSw2uXwKqJth6eq9GWapKCBZgb3V/vVtbJlnf8ckaOyVK/6wiIrJgr1GBdXwY8yHUzkGaX+nD+rFyBssjjOyp2f3T9MT8vT+pZJ6HXGxo1kMt/2u53hvw1W3K6COnWEaQu9IwpRTBki8XQN5FoP7+yBBq+cQzSqlSgZoLeTrXl1GDulBJx/YuVBMKw6alMIh/1kJG5GcMQmDgcF2xrmEGsoSfvvUVT9LbVD94yfhju5YZiKAeiAU7kVFdOvBQqNYl3+KTsI3HeaRWtm1IqskX6euQazd3mQYdrOA8uFZTrxsTgSLasCaY/yRsYX38jrVDEbv3RseUZqALXB+qEATOgSgK/rBNwMiCGfMo3eQluUgI7J3bOGOZX9W8MBaOVku8hGUzvBrgP295ILwElpTKJKajVOpn0Qz1L0ncg5P5wl6uPEsRYkxKjWpcdsUZoJkYqY0eFaZNuXYPnU8fNVAEbD9mYI0iOubc+L1ysunmzCgbYhIfVWIpx32npaAu5wRGXcYT+gp7V7V+CIt+n8DJtPHrO+vMvcSUbuyh2/O0JHQ2GNAtsUdektLdhpq/P7i8iTOfzdpKOAOn3df/Uqq57i5ITWP2RRPdlVrSM/pdPbAYC+kziLTsBmmtctVlS0pW8NmlyIC+gNEnBwn65ARQdN4D7bDOcQEqZhYHQ7ZuYL6yjGF4LPcN+e/rduI2R/KYr70dDoRrLwOMGqa7znk523NP2k4fGnIEisCBCq4G7sVkBMBsN1cIEg+eCdr1CGPFpiCodn7SXRGoPRvLpiTQm3d o+jjYr06 Soli374k87GGUmwlXbc816iiuHu9RxUcwefOwc29p56uCL9ci+W8MXfnxr02mHPBkGUUxF4nwSejVsgL44LSFuKS/Cl77wch4YeAV3yZG3oIzkqHo7wvhOpyRtyVaGfzeXXjV/U+iXEANr6M3Z2LIexbGgXhjCczVwcv+P5zWpT1aeedmUpWxbCz90IAn9rlSC/YkJgNuyyzTo+hkfJF8CFIXvN2NoWFNoKUkEP+HXQ2pZf8Ubd+7XUuoefNGZykgs24B0z2M+96Ec4Xp3EQhJEfPPQ8gUJz9SYrRt9ssspY/MxcAnaYzT+8MmsEq58Axzem8ltnzeh96XvYsaJzXno1kSFuDSYYoVevUWqR/RX1fV74XQylNIAQEdi+5SrSz3yx/m5wYBQUUXIlahWehMVHE9Ex1EWlRlb32gOnzxngRHH4s6B2LlmNrGg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11/06/2025 22.48, Mina Almasry wrote: > On Wed, Jun 11, 2025 at 7:24 AM Pavel Begunkov wrote: >> >> On 6/9/25 05:32, Byungchul Park wrote: >>> Hi all, >>> >>> In this version, I'm posting non-controversial patches first. I will >>> post the rest more carefully later. In this version, no update has been >>> applied except excluding some patches from the previous version. See >>> the changes below. >> >> fwiw, I tried it with net_iov (zcrx), it didn't blow up during a >> short test. >> > > FWIW, I ran my devmem TCP tests, and pp benchmark regression tests. > Both look good to me. For the pp benchmark: Thanks for verifying micro-benchmarks wasn't affected by this change. > Before: > > Fast path results: > no-softirq-page_pool01 Per elem: 11 cycles(tsc) 4.337 ns > > ptr_ring results: > no-softirq-page_pool02 Per elem: 529 cycles(tsc) 196.073 ns I'm surprised that ptr_ring return is this expensive on your system Mina. I'll reply on the [v4] benchmark import patch, as this needs some more investigations. [v4] https://lore.kernel.org/all/20250615205914.835368-1-almasrymina@google.com/ > slow path results: > no-softirq-page_pool03 Per elem: 554 cycles(tsc) 205.195 ns > > After: > > Fast path results: > no-softirq-page_pool01 Per elem: 11 cycles(tsc) 4.401 ns > > ptr_ring results: > no-softirq-page_pool02 Per elem: 530 cycles(tsc) 196.443 ns > > slow path results: > no-softirq-page_pool03 Per elem: 551 cycles(tsc) 204.287 ns > > >