From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D5C7C3DA6D for ; Tue, 20 May 2025 10:42:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C96066B007B; Tue, 20 May 2025 06:42:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C46A76B0082; Tue, 20 May 2025 06:42:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B34DE6B0083; Tue, 20 May 2025 06:42:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 952036B007B for ; Tue, 20 May 2025 06:42:43 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 407E3E4D3A for ; Tue, 20 May 2025 10:42:43 +0000 (UTC) X-FDA: 83462947806.26.50D3D41 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf22.hostedemail.com (Postfix) with ESMTP id C7BE3C0002 for ; Tue, 20 May 2025 10:42:40 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=futkKxrV; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747737760; a=rsa-sha256; cv=none; b=FgTYZ1U5kVkKUtNr+s0qlhoOUCcMtwAD/ZYn38V/Djsbnddf6oEsOjgB7r21QQtB/ioJgk 81zrTedZ1C816aS/ZTvdkS5ZK8Oddq/4OvNaj7XvVAScZCp/R0R8JiTgH8BefWrUiwI5Mc 2ELKJq2OiN7tZTJP2718vq7EEBt+vhE= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=futkKxrV; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747737760; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Nojfr5VsNFL8Qg1MDovYQSmnqTQxSYHWb0zCaB+p/w8=; b=BixNsda123RyGXGDwqnGCe5IjDKDtnmyYVauVn3GtVpY51PaDlYWG4Xc53Zr3HGRZhTrKr /OLO8539bGDt/9aM8FeBRWlah/eXEXUswzAlVDpaAYPthW5tbUtBkZXoturYzvARA20XxU 7bIZRYBG2ekmcnjum71uup/NOhBWXm0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747737760; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Nojfr5VsNFL8Qg1MDovYQSmnqTQxSYHWb0zCaB+p/w8=; b=futkKxrVBHj91WTGx//LmgvebYS77SByDzeAO4zc4y7ZZgxrgBZCrxXtmDr5Ov7cSeSqaf KcreoIBLJX0vdxMBLcULwCRw3A02sO+DpAGT200y/pS38W8BvZ8x+97hB/wPhqBSuWQycr ot1DEnAsTW8bEAzI4pj4OB2ZRba5U5c= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-373-DX7ApGdWOG-0q_NnGW4Kog-1; Tue, 20 May 2025 06:42:36 -0400 X-MC-Unique: DX7ApGdWOG-0q_NnGW4Kog-1 X-Mimecast-MFC-AGG-ID: DX7ApGdWOG-0q_NnGW4Kog_1747737756 Received: by mail-ed1-f71.google.com with SMTP id 4fb4d7f45d1cf-60007c2cef6so5227254a12.0 for ; Tue, 20 May 2025 03:42:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747737755; x=1748342555; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Nojfr5VsNFL8Qg1MDovYQSmnqTQxSYHWb0zCaB+p/w8=; b=aGqRU5xqNqUBP9bl8myrAXUMl5dOBUrML/TwOc4MsAWhhKrJoX9DAYmkw+MIveb9eG e0MRI0je5Jes3t5k+tsSd+CsqW6/Kes6q7DPpErY8wbaFJ4JtYT2U9C5I1QlmKAzjhcL YPa2PktQwiX+Tag3lUXMXFf6MezS/pALuDamm0XM+Pp+ylu8mixFYjPIasTggThXPO/5 QpPrGx2MnJl7k0PKq0nKdZ4F6BWwXMG7mqRaf75tz8y/KIh+aApWEMPkmM/IscJvg9xW rUs4mpVK9CuW2C8rYpMfWO0dwXk0+zCRMCH8sYTc3hzYd75XY/Hgd1oseB2bWWYZsPiY Je8A== X-Forwarded-Encrypted: i=1; AJvYcCWiSplo8+XJIdCyR+Ls1FwvQ4lV3uN4i6M4qpH4lYR6g2PmUQbWkC8LvdPXZqruPjudkwqToPKLXg==@kvack.org X-Gm-Message-State: AOJu0YxYN3n8i2e8Q0XdGD+gW4YMyRZBv4g1qUZksVgbTDrf3As5eWCB bGn1XXiq0mD5lRqe4/VNhdF2DQe8w/dYYh8D+8s733zpVeqmPCqEqcTTYTAaub+aM6ACcVLlp38 7MLZpI2t7yKDsXOL/lbTth8UIGmppJhrL2nzpx7EbeS6fn4tHubom X-Gm-Gg: ASbGncsg5COo1QwyJM0fcXxiSTyQxIgyQu73uhiqfhKFanl4QHnCAzv5Kt6umlsMx3O lZmKoqD4aeE4vdZO5Yl/gairQjTy76DpE+3ScbGF8gNaAsozspbL7sBi/jqhbLpNwV0Y7fy224t vTqGpmEsfoZZpOax4sV6MF5R51ssYuiS1f3tg6oStqp/7Y4pAnJ+oD1rk/iqGYgwJ3/0dtbtTNN gEIjAxf57Fcmf8pXauAGkho16soHHUIoaRyOCES5K9ewiIdVcUZo3vZ3raDHi3XcpWA1m5Xe/Dr cq7KRXsMkEt9ojdB53h95M+y5BMPLepBxloeUXQxDUdWr4e8xvWG6Ogbm0srPedUHx5HGwiy7hK b/+q9grRY0DjC7Qs94t+hR7RFqaJ/bSs/sEXVpfQ= X-Received: by 2002:a05:6402:909:b0:5fc:8c24:814d with SMTP id 4fb4d7f45d1cf-6009010e4b0mr14682783a12.14.1747737755559; Tue, 20 May 2025 03:42:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF72JLG6asx3WKUC1ArlnTTnKbaD3lNc/q/VMNC0Ggr3/RIk+McvhKUYOM2NdDznrcZzod9KQ== X-Received: by 2002:a05:6402:909:b0:5fc:8c24:814d with SMTP id 4fb4d7f45d1cf-6009010e4b0mr14682760a12.14.1747737755052; Tue, 20 May 2025 03:42:35 -0700 (PDT) Received: from ?IPV6:2003:d8:2f28:7c00:a95e:ac49:f2ad:ab84? (p200300d82f287c00a95eac49f2adab84.dip0.t-ipconnect.de. [2003:d8:2f28:7c00:a95e:ac49:f2ad:ab84]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6005ae3940fsm6950223a12.74.2025.05.20.03.42.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 May 2025 03:42:34 -0700 (PDT) Message-ID: Date: Tue, 20 May 2025 12:42:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 1/5] mm: madvise: refactor madvise_populate() To: Lorenzo Stoakes Cc: Andrew Morton , "Liam R . Howlett" , Vlastimil Babka , Jann Horn , Arnd Bergmann , Christian Brauner , linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, SeongJae Park , Usama Arif References: <96503fba082709bc4894ba4134f9fac1d179ba93.1747686021.git.lorenzo.stoakes@oracle.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: XbK4Ae6z4atUt0Hddv_3FSz7uNZ5l8v8lj9nIYq8bVA_1747737756 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: 9f1n8pptg1w818zrbrj6e8ww59uu6du5 X-Rspam-User: X-Rspamd-Queue-Id: C7BE3C0002 X-Rspamd-Server: rspam06 X-HE-Tag: 1747737760-371652 X-HE-Meta: U2FsdGVkX18S/RIGW6UdEAt5mquXacAgo+dLarPQ/PPZirAD+ILFTejVq9BoJORaEESW0d+ek/sQXPe9LFQyrzAwAK2QwcKpHZlBADafz0Q2e4BDA7p7uD6N4DXibzkH9CIcGaTTEhVFERkLJ8Y1so2gpbjwMg3MeaLRnT0SzZnYGo/5jUA3oevSDB2YcRpDAHIIWdWSDwfeysXQg/dlcfQbkYzy51cIwVqHVUnXvB0PrGvjsdxjRfgKZHgkOvLFZtheLaUT5SCfOERwf+N/Hf1+KtipJjgZARzKJk6wU4o8iHxsBIXWLZ0s2a3j62yyxnjCmE1G7SMWDrZZa+6e9bO5fIBf9jZN04rkxgrQZ4/VFs6finW2ZAclrv0JUvxO1ryIVrbRozYdZke9Z0wcRmgjwIjrHKcQVDwPNmRXE9uv7zwqjOFKY2LpcA4Txuc787O3SuxdguEJkHXwhXgRuU21m43eSYLl5pesteR2ovFOfDFNiWYM02DSbS0lv9F7orvHADPoTG+G8a1yT4o653uk6/HD71r9AP5I1SNjjKaYrLiDZOEQfT487vK/Xd612A/EqdYmvTYw+MMkHzEEjcZToU9oZQ/rdiRvyPiQrCJd9cR01c17lrBbPRWIDkKzRwFUv+qJaH+AEY4EKvuFHwGAPJcTcDQbJvgyZgWYtHnftR/eoO0eNqe1faJl40qxnPww39BeDDKhNkVrwlZ6NGXcAgw63LYleOjGhZbj/SjLhouiy8meeYb5sWkl8M/7AvSBJxD01LLuAlfr/yfLchHa2DO18YVgVsJGSehB73hPDTD3ZuxuxyVDgaKKZeKqMpWWkoWeRsqMNhvTX7zzCuT66A9HX2mJVYWEESB1P6lE3XRJJI6wruAY9RbVqIVBUO2B7n+m/3tFqs2JbUTf/819MQZfnCOcS41Aco8t21ngjZq0BGhfBzrZJLWvHcqDQIJ2J9alZJHWScSp1NP vNI04R4h u2d1VDj2ltWSZJ1MLfXVO6e0pyUFrKjUl43F2Yp3vdhZUEPvWJeJIOMY3kAwknA6kPZ8syGHCMvU3vPM7ePd5gfy1S/+4319DmsP0QQoLgK6rP8ca0CjlR4ayRVaiW0QpxlT7mJS6nfgOXVprDdPuwE1mMF5L5WcJIfPU/E0UkXCLYZIwLI9ZG4U068VBxaSK5IGczHB7Hdc2aB9er4zjpBpC1+ZTHkCdOEnJPrbYG355EmYgNCrd/0gPmythPkEohL1Yi+rVgNN8c1GZMpsTiGDXdXMpZpkv/J2PyPohO+W27vyOK319bWHd8MCZYbtZSFRf9QszkFfuFIPjr6/xY/EW0mswSE778hsh+GiAwaeXFu65cuGVac9/muF0XN9sTmY+qBj4yuHG1UMjzToGp6Mv9maB5l6lTnTR9MbeIc7skK0yuxziJdPD0wds+492URSk24kIBGMXMc1C1zavJfHhJRj3PPDFwnliGe1BxZOO+qsjWm5Y8cEtlQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 20.05.25 12:36, Lorenzo Stoakes wrote: > On Tue, May 20, 2025 at 12:30:24PM +0200, David Hildenbrand wrote: >> On 19.05.25 22:52, Lorenzo Stoakes wrote: >>> Use a for-loop rather than a while with the update of the start argument at >>> the end of the while-loop. >>> >>> This is in preparation for a subsequent commit which modifies this >>> function, we therefore separate the refactoring from the actual change >>> cleanly by separating the two. >>> >>> Signed-off-by: Lorenzo Stoakes >>> --- >>> mm/madvise.c | 39 ++++++++++++++++++++------------------- >>> 1 file changed, 20 insertions(+), 19 deletions(-) >>> >>> diff --git a/mm/madvise.c b/mm/madvise.c >>> index 8433ac9b27e0..63cc69daa4c7 100644 >>> --- a/mm/madvise.c >>> +++ b/mm/madvise.c >>> @@ -967,32 +967,33 @@ static long madvise_populate(struct mm_struct *mm, unsigned long start, >>> int locked = 1; >>> long pages; >>> - while (start < end) { >>> + for (; start < end; start += pages * PAGE_SIZE) { >>> /* Populate (prefault) page tables readable/writable. */ >>> pages = faultin_page_range(mm, start, end, write, &locked); >>> if (!locked) { >>> mmap_read_lock(mm); >>> locked = 1; >>> } >>> - if (pages < 0) { >>> - switch (pages) { >>> - case -EINTR: >>> - return -EINTR; >>> - case -EINVAL: /* Incompatible mappings / permissions. */ >>> - return -EINVAL; >>> - case -EHWPOISON: >>> - return -EHWPOISON; >>> - case -EFAULT: /* VM_FAULT_SIGBUS or VM_FAULT_SIGSEGV */ >>> - return -EFAULT; >>> - default: >>> - pr_warn_once("%s: unhandled return value: %ld\n", >>> - __func__, pages); >>> - fallthrough; >>> - case -ENOMEM: /* No VMA or out of memory. */ >>> - return -ENOMEM; >>> - } >>> + >>> + if (pages >= 0) >>> + continue; >>> + >>> + switch (pages) { >>> + case -EINTR: >>> + return -EINTR; >>> + case -EINVAL: /* Incompatible mappings / permissions. */ >>> + return -EINVAL; >>> + case -EHWPOISON: >>> + return -EHWPOISON; >>> + case -EFAULT: /* VM_FAULT_SIGBUS or VM_FAULT_SIGSEGV */ >>> + return -EFAULT; >>> + default: >>> + pr_warn_once("%s: unhandled return value: %ld\n", >>> + __func__, pages); >>> + fallthrough; >>> + case -ENOMEM: /* No VMA or out of memory. */ >>> + return -ENOMEM; >> >> Can we limit it to what the patch description says? "Use a for-loop rather >> than a while", or will that be a problem for the follow-up patch? > > Well, kind of the point is that we can remove a level of indentation also, which > then makes life easier in subsequent patch. > > Happy to change description or break into two (but that seems a bit over the top > maybe? :>) Probably just mention it, otherwise it looks a bit like unrelated churn :) Acked-by: David Hildenbrand -- Cheers, David / dhildenb