From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA5B4C52D7C for ; Fri, 9 Aug 2024 17:25:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 41D376B0085; Fri, 9 Aug 2024 13:25:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3A7B06B0092; Fri, 9 Aug 2024 13:25:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1D0C46B0098; Fri, 9 Aug 2024 13:25:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id EF6136B0085 for ; Fri, 9 Aug 2024 13:25:45 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 82583C1352 for ; Fri, 9 Aug 2024 17:25:45 +0000 (UTC) X-FDA: 82433384250.05.72011E3 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf10.hostedemail.com (Postfix) with ESMTP id 39095C0026 for ; Fri, 9 Aug 2024 17:25:43 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XbZxEJkJ; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723224309; a=rsa-sha256; cv=none; b=IeYIMAdWL6DOkZgwgLiyzxJA/t+NqqQYiIn8uu+oBKOE0/3Lc0DhUX3DIL4uQ04hTHUUQM PV2B3yOluzGNmOZurEbCeby2PWWe0M56C8o49Mpc/Mtf7XXLYVOURCjY+F2kT28ArF8pWA JTpg4WabVjpbSx5O53V9xUtdmSINvfA= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XbZxEJkJ; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723224309; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=u4wjcaS0nOJw/BDeSInCZohj2LY/TXzLpPqdNfFIyns=; b=q6OJ6GHMSS1SP8k/Z+Dp1FV4JTTmEGj76MDPRmuci11xmVHFmKdqo0ioRx6Uie0qVOZHER XHf+jFEJyg1ClIIQW79eE3D2LiV9s0HyQBYlNf9yettGCLFKcFgCIwTQ0BxrfL343IiJp2 ccpSvxONHw8bQwkjH416/VU8oNBLxgE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723224342; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=u4wjcaS0nOJw/BDeSInCZohj2LY/TXzLpPqdNfFIyns=; b=XbZxEJkJqNjnKs7AKSyULd2MnKApEm8CFJA2X6KAEN9dhMF0MRPKhr0nM1bm0z0WssF2YN jZ13zPyJgJAopQFKN/91KItr7Np7wM7EVAfHgYTYM6t/q24ouxmqmcyqMCEss4opj/i2EX JeDvj+4diIrb9dhXhy15xq7A+bw5EnI= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-295-LdIbF1E0MJ25zumOU0OCfQ-1; Fri, 09 Aug 2024 13:25:41 -0400 X-MC-Unique: LdIbF1E0MJ25zumOU0OCfQ-1 Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-52f0108a53dso2938163e87.0 for ; Fri, 09 Aug 2024 10:25:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723224340; x=1723829140; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=u4wjcaS0nOJw/BDeSInCZohj2LY/TXzLpPqdNfFIyns=; b=DEYk+3hq2rx9vWFKQwgNqSswEjKnYrFugqXB+QC0FblyUKkI+c8l3jFyjvTHzQo5d+ QFTaZKlpugGCa59lJlqCGxyTUbb7I+dE0YIx3/As2+rlYvEL6/BQ6xQM5uUJ/xhguCC2 rZuxEOQ6OJs0l3PzJTqQ2FUsicspG6aPupJZUDAXQ5ZP0P2EPQ+c7rIfiqAf/2135tq4 qt/EQmxSa/Jaa06i4tHbcsFXkDPaHizEa7CKyjAgAX//wUoq3amEXgcCOPZSHRSo3Vnd d6lVttRpfpoHcu2IzJc0xPTMaQlx2tFOQAzCtZR+y0cL3s8mET/b8cl4mzxNkwE/e0lV T68A== X-Gm-Message-State: AOJu0YwcSySeYy86T/HwVXLW52z7Tm7S52qaJXu+iQ2OxcCiLukMsWMo TrSDSKW6F4+Nt7U3PYcglpEDw40e9fNSOARy8o7cgum0Uz1Kbrw+fxw+e00SWw6B3eDKnRGehYq 8UExOojQ82k36lqhnfGnFhJJdDXvB8iy/2b8hfjnjjMB2RZiG X-Received: by 2002:a05:6512:2253:b0:52d:8f80:6444 with SMTP id 2adb3069b0e04-530ee9ec50dmr1632710e87.32.1723224339571; Fri, 09 Aug 2024 10:25:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGNPbtkVWPX9gsyx6+P4sEzTboDQnnV/JoBOPf2QvhGRXHO26n++v13Udxw08CkqWqgv9ADcA== X-Received: by 2002:a05:6512:2253:b0:52d:8f80:6444 with SMTP id 2adb3069b0e04-530ee9ec50dmr1632693e87.32.1723224338872; Fri, 09 Aug 2024 10:25:38 -0700 (PDT) Received: from ?IPV6:2003:d8:2f09:3f00:d228:bd67:7baa:d604? (p200300d82f093f00d228bd677baad604.dip0.t-ipconnect.de. [2003:d8:2f09:3f00:d228:bd67:7baa:d604]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a7dc9d437b0sm854325966b.114.2024.08.09.10.25.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Aug 2024 10:25:38 -0700 (PDT) Message-ID: Date: Fri, 9 Aug 2024 19:25:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 06/19] mm/pagewalk: Check pfnmap early for folio_walk_start() To: Peter Xu Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Sean Christopherson , Oscar Salvador , Jason Gunthorpe , Axel Rasmussen , linux-arm-kernel@lists.infradead.org, x86@kernel.org, Will Deacon , Gavin Shan , Paolo Bonzini , Zi Yan , Andrew Morton , Catalin Marinas , Ingo Molnar , Alistair Popple , Borislav Petkov , Thomas Gleixner , kvm@vger.kernel.org, Dave Hansen , Alex Williamson , Yan Zhao References: <20240809160909.1023470-1-peterx@redhat.com> <20240809160909.1023470-7-peterx@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: 5b3ehnigqgphqu3u84eayqowj8sjp9je X-Rspamd-Queue-Id: 39095C0026 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1723224343-122717 X-HE-Meta: U2FsdGVkX18euVO0kK9ibc3/xrxQeViXePo1RlBTJfC5hGmtoKOn4Mb0aKd8cu0l4t65bteeSPXz76+iTRxKJkUD+X6B1ykt9ItMT83L35bJq5quJTNtinGQMXPjNxJ6cS3y54BMVj0WDVwfi6iBZBBwiogAyC6GEFCqvXxzcdhpZdFuz1EVV2tg8J7o8dGmhdAFPUgedDEUmQ1Qj1Xfib8QbjOB8KYHZTPkU2rLxr9jZy5qS70gzV17DMMDpN2vBrkilE4Lu89KBhavQ1qcYbwqMG8hidC/kgAQHkIM/Zmd1SunXnyHDxXywq3xKHYEKOElzIurwAQ2fAxFm9Gl7ygmy2Tuz3RspRlKb1bP40Hkt+S6ZIBQ3sBjBWuhgKIy2mKXAz6x53gG/qXcAVT/8s335EmS1cLNPaxq0jUAXJmugoQI4IwVj6Unt0QX0TLhhtEum6RYLRQFB8QeirxuiefS5k+EhLvRL0dXJ/HYbz4Dqwp8ZsEuDbHAd7jz0YBMJzzrgMD0ZSGM4kNeaT/idHI+9Gbxc2Lsw3UbOMOIIBDBwmBLHSyCC8m/Orm7tVb73pVfLYWfGpLDLAy3+q7Azsg+Ex5gDBCvxwSkoZI/JSp+/2RK1PU3IhYms/5haKTnyWNLx3/sYfszqhTg3k7AamgC0QU5zFfaOH6vWQh5TtYKcUaDeYIosClGI24Qkd6AjlFx3B5LlAc+2ghTvoEKuzc/kez/3ycvvTSadvg/vgFm2Cfy+1oYSuot8WSuM1Okb3Tfdk+mnl3wv9W/ncqFU5ZD8cFnHmt2PFIdvtM265y5V90S6dSemN1xyTqPwA1xZIUq+GfYJkbNJubTnql3siLLV83nnGjAyg3VyzbmAo5tG2dod+UlRUaCykko7mLeaJbQnBvNNeyxU+ER09fEY+wJzLEVNjgVbocfkL4YiG8pUSzlxbbr5rMeQeJhtseWye1UD808XgtOfdu+XBa FARwg0rn JRJGejE9Y2F6DcuSb+6cmXW2QcyDIAaD9xSa1zd70q/EQ2v+KmOCPWvaAW39Bf0jheSSOEi7g9S6NNF50sp1fGMnZoUcCSdj2qHpdqo2+0FWmYNElco3WWfzUYm1+n0/brt0/2wimmxDKKg+DNgmRqHiA0U9w8UFMW/N2AJjq8BLmuMWCCEx20IhS2xQ8h7+YA7nOhBWB5Wv24uM6QM/f2Vfg8OcL3xR2YO3GDhBf38H6fOsbZV2CwBCPYlm9gePsCWFyKAk7Ie5FvT6Gl124yinUexhNrMyUzHBvJIAhHrtvmc3y/n2KMXGQzqLSt6WKri6rfC7jVReFFrIZ9xvzf9qL7iQRFH1IGrf1EbslcUepuOik8Gt4KH0oNp5BcALqjEfPk2ufSvGrRnF3l+1+gqBZbUxI+ByJvsW3fa2PXPpc2yywuO4aiBdRISBY0K1WL1yzryfWnYeKgdAU9IGUfTetmzNdduAsEpmJRk/XVctIWhaJ71YE3jO6HylLrSmd8B5o X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 09.08.24 18:54, Peter Xu wrote: > On Fri, Aug 09, 2024 at 06:20:06PM +0200, David Hildenbrand wrote: >> On 09.08.24 18:08, Peter Xu wrote: >>> Pfnmaps can always be identified with special bits in the ptes/pmds/puds. >>> However that's unnecessary if the vma is stable, and when it's mapped under >>> VM_PFNMAP | VM_IO. >>> >>> Instead of adding similar checks in all the levels for huge pfnmaps, let >>> folio_walk_start() fail even earlier for these mappings. It's also >>> something gup-slow already does, so make them match. >>> >>> Cc: David Hildenbrand >>> Signed-off-by: Peter Xu >>> --- >>> mm/pagewalk.c | 5 +++++ >>> 1 file changed, 5 insertions(+) >>> >>> diff --git a/mm/pagewalk.c b/mm/pagewalk.c >>> index cd79fb3b89e5..fd3965efe773 100644 >>> --- a/mm/pagewalk.c >>> +++ b/mm/pagewalk.c >>> @@ -727,6 +727,11 @@ struct folio *folio_walk_start(struct folio_walk *fw, >>> p4d_t *p4dp; >>> mmap_assert_locked(vma->vm_mm); >>> + >>> + /* It has no folio backing the mappings at all.. */ >>> + if (vma->vm_flags & (VM_IO | VM_PFNMAP)) >>> + return NULL; >>> + >> >> That is in general not what we want, and we still have some places that >> wrongly hard-code that behavior. >> >> In a MAP_PRIVATE mapping you might have anon pages that we can happily walk. >> >> vm_normal_page() / vm_normal_page_pmd() [and as commented as a TODO, >> vm_normal_page_pud()] should be able to identify PFN maps and reject them, >> no? > > Yep, I think we can also rely on special bit. > > When I was working on this whole series I must confess I am already > confused on the real users of MAP_PRIVATE pfnmaps. E.g. we probably don't > need either PFNMAP for either mprotect/fork/... at least for our use case, > then VM_PRIVATE is even one step further. Yes, it's rather a corner case indeed. > > Here I chose to follow gup-slow, and I suppose you meant that's also wrong? I assume just nobody really noticed, just like nobody noticed that walk_page_test() skips VM_PFNMAP (but not VM_IO :) ). Your process memory stats will likely miss anon folios on COW PFNMAP mappings ... in the rare cases where they exist (e.g., mmap() of /dev/mem). > If so, would it make sense we keep them aligned as of now, and change them > altogether? Or do you think we should just rely on the special bits? GUP already refuses to work on a lot of other stuff, so likely not a good use of time unless somebody complains. But yes, long-term we should make all code either respect that it could happen (and bury less awkward checks in page table walkers) or rip support for MAP_PRIVATE PFNMAP out completely. > > And, just curious: is there any use case you're aware of that can benefit > from caring PRIVATE pfnmaps yet so far, especially in this path? In general MAP_PRIVATE pfnmaps is not really useful on things like MMIO. There was a discussion (in VM_PAT) some time ago whether we could remove MAP_PRIVATE PFNMAPs completely [1]. At least some users still use COW mappings on /dev/mem, although not many (and they might not actually write to these areas). I'm happy if someone wants to try ripping that out, I'm not brave enough :) [1] https://lkml.kernel.org/r/1f2a8ed4-aaff-4be7-b3b6-63d2841a2908@redhat.com > > As far as I read, none of folio_walk_start() users so far should even > stumble on top of a pfnmap, share or private. But that's a fairly quick > glimps only. do_pages_stat()->do_pages_stat_array() should be able to trigger it, if you pass "nodes=NULL" to move_pages(). Maybe s390x could be tricked into it, but likely as you say, most code shouldn't trigger it. The function itself should be handling it correctly as of today, though. -- Cheers, David / dhildenb