public inbox for linux-mm@kvack.org
 help / color / mirror / Atom feed
From: "David Hildenbrand (Arm)" <david@kernel.org>
To: pratmal@google.com
Cc: akpm@linux-foundation.org, shuah@kernel.org,
	yosryahmed@google.com, ljs@kernel.org, Liam.Howlett@oracle.com,
	vbabka@suse.cz, rppt@kernel.org, surenb@google.com,
	mhocko@suse.com, linux-mm@kvack.org,
	linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] selftests/mm: use pattern matching in .gitignore
Date: Thu, 23 Apr 2026 15:28:03 +0200	[thread overview]
Message-ID: <da96efa9-401d-4d11-90cc-00ebff340921@kernel.org> (raw)
In-Reply-To: <20260422190847.216343-1-pratmal@google.com>

On 4/22/26 21:08, pratmal@google.com wrote:
> (Resending to correct David's email address. Apologies for the noise!)
> 

Heh, no worries, I didn't even notice.

As long as you CC one of the mailing lists I'm subscribed to, even mails to my
old RH address will still hit my inbox.

> On 4/22/26 18:04, David Hildenbrand (Arm) wrote:
>> On 4/21/26 20:30, pratmal@google.com wrote:
>>> From: Pratyush Mallick <pratmal@google.com>
>>>
>>> The current .gitignore hardcodes each generated test binary by name,
>>> requiring updates every time a new test is added.
>>>
>>> Switch to the patten-matching approach similar to KVM:selftests.
>>> Ignore everything by default and then allow source extensions (.c, .h, .sh)
>>> and tracked non-source files.
>> That looks pretty nice. Any reason for the RFC? (iow, are you unsure about some
>> side-effects?)
> 
> Exactly that. I verified that the build works fine, however I sent it 
> as an RFC just to be cautious. I wanted to get some feedback in case this 
> might introduce some unwanted behavior that I'm not aware of. :)

After taking a peek at the KVM one, I think what you propose makes perfect sense.

I do wonder, whether we want to make our lives easier and rename
"local_config.h" to something like "local_config.h_gen", so we don't need the
"re-ignore" part.

-- 
Cheers,

David


  reply	other threads:[~2026-04-23 13:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-21 18:30 [RFC PATCH] selftests/mm: use pattern matching in .gitignore pratmal
2026-04-22 18:04 ` David Hildenbrand (Arm)
2026-04-22 19:01   ` pratmal
2026-04-22 19:08   ` pratmal
2026-04-23 13:28     ` David Hildenbrand (Arm) [this message]
2026-04-23 20:22       ` Yosry Ahmed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=da96efa9-401d-4d11-90cc-00ebff340921@kernel.org \
    --to=david@kernel.org \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ljs@kernel.org \
    --cc=mhocko@suse.com \
    --cc=pratmal@google.com \
    --cc=rppt@kernel.org \
    --cc=shuah@kernel.org \
    --cc=surenb@google.com \
    --cc=vbabka@suse.cz \
    --cc=yosryahmed@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox