From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84F77C77B7D for ; Thu, 18 May 2023 13:24:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ED272900005; Thu, 18 May 2023 09:24:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E82E0900003; Thu, 18 May 2023 09:24:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D4A0B900005; Thu, 18 May 2023 09:24:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C58C1900003 for ; Thu, 18 May 2023 09:24:03 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 93D591407FF for ; Thu, 18 May 2023 13:24:03 +0000 (UTC) X-FDA: 80803443966.27.647C767 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by imf02.hostedemail.com (Postfix) with ESMTP id 1FE9A80016 for ; Thu, 18 May 2023 13:24:00 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm3 header.b=j22+C4YH; dkim=pass header.d=messagingengine.com header.s=fm1 header.b=DGPofMjn; spf=pass (imf02.hostedemail.com: domain of arnd@arndb.de designates 66.111.4.29 as permitted sender) smtp.mailfrom=arnd@arndb.de; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684416241; a=rsa-sha256; cv=none; b=Fqao4o5J2bgs+j+EwXHPXFqM1xA+TIgeVzkzBSOlDeDUzg7dz4LKjatyNW7jodWoLi/87a Hj2X4MgEhV+Gu53nnMNfTenIX+NL9sCbzYGgSOlhGCY1b74riPi+xvzGMJLcNuDOdcpTux 6Qx1b4tbU6ScK2JYjnFg9068AuoqAoY= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm3 header.b=j22+C4YH; dkim=pass header.d=messagingengine.com header.s=fm1 header.b=DGPofMjn; spf=pass (imf02.hostedemail.com: domain of arnd@arndb.de designates 66.111.4.29 as permitted sender) smtp.mailfrom=arnd@arndb.de; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684416241; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BVWv0vhTr9e+qvYRpUKo9xFRPGdkIupwe9tb3nd2QZk=; b=eKt4AwubkScmM9QPF2ovnZ8CNZ5uKaSD08MOUBdZd3xJZIC7sojptE269Vvs0kBlp9IaUt ltKLtfRNt5jXzDPqkKf5EcPWXwRWc0KOYUVaa63JM6JeTsp9jsrvX3laJssiG1pyamvCFj AJVZI7NHOMvWwz8OTXT3m6GWrG/mx6s= Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id DD4115C00D3; Thu, 18 May 2023 09:23:59 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute6.internal (MEProxy); Thu, 18 May 2023 09:23:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1684416239; x=1684502639; bh=BV Wv0vhTr9e+qvYRpUKo9xFRPGdkIupwe9tb3nd2QZk=; b=j22+C4YH2NfN7pcO5q EvH8R/qlYzffsaTS6kO7cVnJ4AVmHbZPbGE2dDxXpoxwBZ5URqdNTKYEnWVIn7km YkbRtD6h/CiykyW2awg2rjGfKAKJZOaFnLiZUV3jM/FfhgtKHy+ROjEdPREMsSbn oCLSdBfU3VjIzII5lXIwcwmox0dTse5XtH2zYyy6a/F2rBcGAkqUYgZTMyXIumpk IXrl4zcNsufrnkzLvNWcZmgkv9brPROr6yaypqKlHruyjEvTLUMMZKDvzxAum1bo qVfWH4/99FPqUvIcTsDx054AnQCPgYAT8EOeGtSHoWOmugrfp1mILHQ9sSH18N0T rlIQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1684416239; x=1684502639; bh=BVWv0vhTr9e+q vYRpUKo9xFRPGdkIupwe9tb3nd2QZk=; b=DGPofMjnUL82B7LEdK8TSw2AGvWqH WzyG5IF269ImbZJRyKEPguTVuTHOM0/v4RkiuW6ZTvDtfoXKTyVco3g4J8yjealz lZ0fGsV0Y9Ii7ig08wr3qLAmetjKZsXT9U5pMGQweIfhXY1F+EcobxR79WdpHq0f rztUZrpg7ui7ehaTK/9RC5XtupFoi/+2oNbQADD2vwiv+mI/BGQj813pOue41A38 zOPZdQWtcWRsHLUsh8P+ZfLhL13qDb0NPeo1QTeLVRK4MTy7lA+Qh95ORwTWFMgo 6aTAx+i+es8b+wXBOUmBTMxJUVHzr8RW3BXsqVe0o0wboFplQ0HsyNXZw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeeifedgieegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedftehr nhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrfgrth htvghrnhepvefhffeltdegheeffffhtdegvdehjedtgfekueevgfduffettedtkeekueef hedunecuffhomhgrihhnpehkvghrnhgvlhdrohhrghenucevlhhushhtvghrufhiiigvpe dtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrrhhnugesrghrnhgusgdruggv X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 8F209B60086; Thu, 18 May 2023 09:23:59 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-431-g1d6a3ebb56-fm-20230511.001-g1d6a3ebb Mime-Version: 1.0 Message-Id: In-Reply-To: <20230517134916.717bdcc4ba26e10462157ee9@linux-foundation.org> References: <20230517131936.936840-1-arnd@kernel.org> <20230517134916.717bdcc4ba26e10462157ee9@linux-foundation.org> Date: Thu, 18 May 2023 15:23:39 +0200 From: "Arnd Bergmann" To: "Andrew Morton" , "Arnd Bergmann" Cc: "Nick Terrell" , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] decompressor: provide missing prototypes Content-Type: text/plain X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 1FE9A80016 X-Stat-Signature: 4ms1tjw6g5fnp7pabajdk4bbz31gmebg X-HE-Tag: 1684416240-649867 X-HE-Meta: U2FsdGVkX18GksL+TTKC/PLF+3WEsoYSfJCG027IWJmlkIdeQIuPxdmqPDaAnR1h6KQtMQ9LxLqLNDBDsnxOmkFyr3TP0LCDTHnCpKQNz3U2nBMC6CXrmko56qRGn/ksqYIxEcMXGRVB8gQcqDpo9n4mLFezaGt+az3Em+HuBGMRhjMbBBGVo0ljWsZO3NpeqIBAOvtyV66H1VZWIp0qVSBpqKSOKTAvUV5y65k4CjnqG9zUzTCWTH1oAzVoQOH4IEX61I68tPyTiBhM4doIWfcBW7WV4SsOySohYQMLTrmpui3n+AibCZUBOoJJ6Z8j54GI3E2FupG6H4wTNowKXCjeY91rh8BPSnjhkIzkdnIoV6RfJGT5y7PNzIzrNQmFmDC84YpALRCP9PC1ZwOhttnmWCm+WW13QQOBw7ZWnDP8JEqnygmf0WS+tRgrmtqbNFm0HAkMUYQpoY7p9Jg1OGOh5cTjh68uPWqW8Db6I62sNOsB29tZa98wLj6ClsUSwaBJcxnoI/y2EVGBPCoWZ+9XX5Zl2B6T84A1Kk4AWf50j0ufTiN+khjly6b6TI0u+pWy8EwCOkY4hTo7LKBktJsY1eFlmT942cVpCccDXa/E3z5uHusbXM6cCAVyoXmCbdwIcjNIIHnCpbhOcagb+ukWLxWTjhkJxOq879gtk7KAvpk8k0IqMfQxwYKQnhGfzj5RVTJMsJoYd9JHMiaYwSB74GoyZeZrwckRlnRH+ApomkmyvS9heDt/0TL8PkmLyVml9kkVPzBv7dghOFB2cglhDx6wuMsZINGN69Bi+jhJ8SHX8dOvYcGnhZ3bAwOtNrwXuVFmhsdU95SaYWTN/AENoHpgj3BQBcXf62x3Z3wE6Mnb1vte6vFNo2ZKx4qZfjaMQk1SBQfhX57ZYJfnodIunMP1SSyf2IrLLDHB8IdA3O/5V/Av5DAAO4fZeaIxWznkF3QKLpRHQFL5trX FjJq2m8W 6lhXnoQVAhVeQni3OG+gKasxELnQ1Q07SFpdKP0oZN40eYXodHp5brMewj3IbCmGbNE86Ngwe3JHhDBDHAEfOSJacFkj6US9p0dV5vVddZ0XCxNQ0WULjQtxURbg7ZAO5RjlPKDAK4UwOO3VX2SzNGzALhdBgkhHS5b87aMNIUkXsfff+xl1SlpcP6A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, May 17, 2023, at 22:49, Andrew Morton wrote: > On Wed, 17 May 2023 15:19:31 +0200 Arnd Bergmann wrote: > >> From: Arnd Bergmann >> >> The entry points for the decompressor don't always have a prototype >> included in the .c file: >> >> lib/decompress_inflate.c:42:17: error: no previous prototype for '__gunzip' [-Werror=missing-prototypes] >> lib/decompress_unxz.c:251:17: error: no previous prototype for 'unxz' [-Werror=missing-prototypes] >> lib/decompress_unzstd.c:331:17: error: no previous prototype for 'unzstd' [-Werror=missing-prototypes] >> >> include the correct headers for unxz and unzstd, and mark the >> inflate function above as unconditionally 'static' to avoid >> these warnings. > > These are errors, not warnings? > > Under what circumstances do they occur? Running "make W=1" turns these errors on as warnings, enabling CONFIG_WERROR turns all warnings into errors. > Shouldn't we cc:stable? If so, do we have a suitable Fixes: target? I have sent 140 patches for these, there is probably no point in backporting them all. My hope is that we can enable -Wmissing-prototypes by default after these are all merged, but that patch would not get backported either. I meant to include a link with the explanations to https://people.kernel.org/arnd/missing-prototype-warnings-in-the-kernel in my series but didn't have that in the separate patches. Arnd