From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64346C433EF for ; Mon, 13 Sep 2021 08:39:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0E2F960FBF for ; Mon, 13 Sep 2021 08:39:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0E2F960FBF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id A4AC06B0072; Mon, 13 Sep 2021 04:39:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9FA4E6B0073; Mon, 13 Sep 2021 04:39:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 89C256B0074; Mon, 13 Sep 2021 04:39:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0105.hostedemail.com [216.40.44.105]) by kanga.kvack.org (Postfix) with ESMTP id 7A62C6B0072 for ; Mon, 13 Sep 2021 04:39:57 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 411DC180AD83E for ; Mon, 13 Sep 2021 08:39:57 +0000 (UTC) X-FDA: 78581902434.24.F3CCDDC Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf24.hostedemail.com (Postfix) with ESMTP id E3273B0000A1 for ; Mon, 13 Sep 2021 08:39:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631522396; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Qkh8UgFVl9fcTGcCRJyDzip+nuo9SQ5NmsQm19TA6E0=; b=MVxX8AWdiytzPZ/91ZV8b1ALAtbhd7umsR9pxOVeFFq5wxDuEi0QPINue/x2xa4VQdhgEX Vq3z03u7wkENOXHjj7neJShOovpsTJHLBq48P19lXxmlqj/ivSe/ErlfBqJgmWxP8ofGYe 16VIbnIx28hchZ3JMW/9oCRYbOXUArA= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-194-Fyd8BCjbMBShIet0CVv86A-1; Mon, 13 Sep 2021 04:39:53 -0400 X-MC-Unique: Fyd8BCjbMBShIet0CVv86A-1 Received: by mail-wm1-f70.google.com with SMTP id c187-20020a1c35c4000000b00304b489f2d8so2768754wma.6 for ; Mon, 13 Sep 2021 01:39:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=Qkh8UgFVl9fcTGcCRJyDzip+nuo9SQ5NmsQm19TA6E0=; b=vE14h0wv3+0fwAu+b/PA5bj07kuZ7g44bFbQe9bk3wruwaceP6yDoJMdiUN3WWB7Sq OFFJ63gGpYPEv3U1H/H+jQwk8pxRsnZGRGZfEq7TlzOMDLwzFZliGs2NKVtl4rAjzTeo TScNV5pphq2oGjqWscE5Za/YSswfhy3ytHj2z5h4qancr2ctZF5ey+C0kPvFUV7BV3sM DqwViEo8EeF6YjPtLH9yVCkVPfyarmOn5VQ3mda5ZlFAE4Vuhxd2B31EeGTVHCdBPSP9 jiZQAAxl+ia0TN/TxY1kxpVfi052L09ItOJAOtfflBJ2W79EapDgVB0BahrD6qlZBgWP XBWQ== X-Gm-Message-State: AOAM532O51gvC3nefAQBO1gxFMlMn2dZRDvi1aerhyheI+dCxO5Y7lt0 7fNoQL9WopI8BfyOZiW/rfgEuO+ZS57gapeJGxJjmldEFTl8MWGSTurueNomcxQuktYwdhq9gnp uS4FpYU528Kk= X-Received: by 2002:a7b:ca4b:: with SMTP id m11mr7083455wml.175.1631522392183; Mon, 13 Sep 2021 01:39:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx/D3Y7lVlgBNtmvGh9HKIR+hqZc3s5012NHyOrvf9JQKKmSvXm6gO4l8dgoM9l1SWWLRB5Kg== X-Received: by 2002:a7b:ca4b:: with SMTP id m11mr7083437wml.175.1631522392013; Mon, 13 Sep 2021 01:39:52 -0700 (PDT) Received: from [192.168.3.132] (p5b0c6576.dip0.t-ipconnect.de. [91.12.101.118]) by smtp.gmail.com with ESMTPSA id b16sm6854977wrp.82.2021.09.13.01.39.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Sep 2021 01:39:51 -0700 (PDT) Subject: Re: [PATCH] mm/memory_hotplug: Add static qualifier for online_policy_to_str To: Tang Yizhou Cc: osalvador@suse.de, mhocko@kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20210913024534.26161-1-tangyizhou@huawei.com> From: David Hildenbrand Organization: Red Hat Message-ID: Date: Mon, 13 Sep 2021 10:39:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210913024534.26161-1-tangyizhou@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MVxX8AWd; spf=none (imf24.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Stat-Signature: 1ezofrh14bzzncnca58afeqg8s8zansp X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: E3273B0000A1 X-HE-Tag: 1631522396-736358 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 13.09.21 04:45, Tang Yizhou wrote: > online_policy_to_str is only used in memory_hotplug.c and should be > defined as static. > > Signed-off-by: Tang Yizhou > --- > mm/memory_hotplug.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index 0488eed3327c..4ea91c3ff768 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -57,7 +57,7 @@ enum { > ONLINE_POLICY_AUTO_MOVABLE, > }; > > -const char *online_policy_to_str[] = { > +static const char * const online_policy_to_str[] = { > [ONLINE_POLICY_CONTIG_ZONES] = "contig-zones", > [ONLINE_POLICY_AUTO_MOVABLE] = "auto-movable", > }; > Indeed, thanks Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb