From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05A4EC7115C for ; Wed, 25 Jun 2025 16:47:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 995336B00C6; Wed, 25 Jun 2025 12:47:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 944E86B00C8; Wed, 25 Jun 2025 12:47:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 80CE86B00C9; Wed, 25 Jun 2025 12:47:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 70B5E6B00C6 for ; Wed, 25 Jun 2025 12:47:50 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id F00E5BA5B0 for ; Wed, 25 Jun 2025 16:47:49 +0000 (UTC) X-FDA: 83594504658.21.3CF9725 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf26.hostedemail.com (Postfix) with ESMTP id B270F14000A for ; Wed, 25 Jun 2025 16:47:47 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hJyxPrLj; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750870067; a=rsa-sha256; cv=none; b=b8KBC3+1Vjms2/0Owcme3rWLnXgGTsX3Yu4V6G8nwU8IM6ODRJHH6aSSoflfB6ykw9gDVV a/XqecKwrEQZ+vtIBdna/KNvO6TPYCh5bX/obDlaM029I2ro38Dhb3YFLkcFa+ceptBqF+ R5RgA36lcb9kXlE/hdaR6Vp+232E7pk= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hJyxPrLj; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750870067; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9M1vHfXIFS9l+R39Mf9youJQuWwRJBkeTDzWO25k2Ts=; b=fpEr4U2cYpPJTggtNQQOTm/6eV4HR8xZAouZttG4FjS9D3V0w9s8G+VEe8ug6MzO+n3r0Z qZRqddF5A6X5dLGYybjzpGiiQLCO0n3VV+Fw4rMC7U3e76afnyGONeJS8kHbDSYtm6km+C cYR/aBx8U73I7jvXSvN9AsURqka7BuI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750870067; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=9M1vHfXIFS9l+R39Mf9youJQuWwRJBkeTDzWO25k2Ts=; b=hJyxPrLj/i8+FzXB4cFp1OGXESZHLUkEj7anSWhnSN0L7IaNH4rqY/SfwnC7gNLl9c2sqf tRchCNX9CrTiVFNYdFUhTUpZsAQMs99a1P5YIGmvKVt5IJbhqzGMqt7HEf4SquCG3pzW48 JlLeNA+s/hQSTc+Ruw8l2sEmrIidA10= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-494-BPoFwvL-PNObnQd04Cl5cw-1; Wed, 25 Jun 2025 12:47:45 -0400 X-MC-Unique: BPoFwvL-PNObnQd04Cl5cw-1 X-Mimecast-MFC-AGG-ID: BPoFwvL-PNObnQd04Cl5cw_1750870064 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3a523ce0bb2so17635f8f.0 for ; Wed, 25 Jun 2025 09:47:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750870064; x=1751474864; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=9M1vHfXIFS9l+R39Mf9youJQuWwRJBkeTDzWO25k2Ts=; b=PKhw2Pg1opjjJafKrQWrOIYm9+WlyIkXMAJjVB3lvukv19XGmARg/0ne9UusDd9Fr+ 8+ngtyhcQCxp2Lx+2LjsPV5z9yfUHVHI3h2e+l91vdcLe3wb65O5XWSJZL9+sgLFMHYU xZP4noFcgfLs+yOCq9YxbVsravrvYkGUl3mvR+lOCEv9gQSIYka8nD1Q6iDoFNbj2fLa Nk7f7wGSjmZl7gDXTAs0SOSue7o4EFTKOKfMIEKbNXmBGXp0JOQFXwycvb8GfNzGAz98 yWp8lvubhcFTfQvgPb99hSPDd2AjhPn/MIGcSF3emESgufgXlGhFnti14Bo06sIg7Fp+ Wq8Q== X-Forwarded-Encrypted: i=1; AJvYcCU2bY9T8Dwy3pqjtNE1kkVWYwmK3KwBsk4OnmSvyTJtiN54mT8xDJQxiDh8G4FK/SAn7d0/alGo1w==@kvack.org X-Gm-Message-State: AOJu0Yz5esi5VcEoHAD3rQOzH3dQDURP7/Elun0Vu+zdmVfeDB/MFlM3 k51K8G3xaPuL/8ID+fADK7yojzBGi39iYvzGRHPA8py6ezTk6RB5XqNqlzjrYTvfW1ku7jNDsmd qdpSCxpFWaIGG80ejOZscKxAH2KR0FOkBlbJXInXXWGx/a9CuTSXD X-Gm-Gg: ASbGncuSGR/J6pky97F3CdxTmQfI0rov6zKA9KrQqFTPPnYW0rj3RyXYnLsoQsdjPWJ nwKJaXNRGdeNaRpmS2aUBPQ1m8M5LIpskuaIs8Gqq25yrYS8+k06+8h1MitIYwuAxkfTAIw0Aa3 nFi+5gpe03sXy60W56AO8p5/RpBF9fdL1+DVFDuMr+a2KrHqP4+q2MdlU4CToiOrJtSV4s1tes/ oD+rTqKicCdadQ4XP4sfMFhyBRZaa/Yx3hcRUb+uLuTI7SwrD1P6BkLZQKIPRj4AAVwp4l5sWkW vPQ+WSVOzke9/i1JBaEyvm21dbBDv11HTZ6MpQD6yXFNUoTMZKbMq1ZtnajrZ4BkAiFiMuuTtCW GPrzx3IOSJkHHJSV32Ck6bpDYdr6Y7DwQt42mOV99t4w1 X-Received: by 2002:a05:6000:1888:b0:3a4:f038:af74 with SMTP id ffacd0b85a97d-3a6ed65b664mr3237864f8f.51.1750870064317; Wed, 25 Jun 2025 09:47:44 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF9YekvGRPkYe/kZTrXaL/81esEkFz4ElnXXiExctA2VcZJSnui1u8qYRsgiNhzuyyjmJbBvg== X-Received: by 2002:a05:6000:1888:b0:3a4:f038:af74 with SMTP id ffacd0b85a97d-3a6ed65b664mr3237838f8f.51.1750870063878; Wed, 25 Jun 2025 09:47:43 -0700 (PDT) Received: from ?IPV6:2003:d8:2f12:1b00:5d6b:db26:e2b7:12? (p200300d82f121b005d6bdb26e2b70012.dip0.t-ipconnect.de. [2003:d8:2f12:1b00:5d6b:db26:e2b7:12]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a6e80f2b8fsm5089801f8f.59.2025.06.25.09.47.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Jun 2025 09:47:43 -0700 (PDT) Message-ID: Date: Wed, 25 Jun 2025 18:47:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 1/1] mm/debug_vm_pgtable: Use a swp_entry_t input value for swap tests To: Gerald Schaefer , Anshuman Khandual Cc: Andrew Morton , Matthew Wilcox , LKML , linux-mm , linux-s390@vger.kernel.org References: <20250623184321.927418-1-gerald.schaefer@linux.ibm.com> <20250623184321.927418-2-gerald.schaefer@linux.ibm.com> <9fb04185-5b71-46c0-b62c-0e0e6ee59e6e@arm.com> <20250625182846.5bce1aaf@thinkpad-T15> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250625182846.5bce1aaf@thinkpad-T15> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: OCcOsE6IWe_XJjgRapu3kVRyxehT-zXPZRL402UPegM_1750870064 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: gj8ca1pmaabrjgsjxwi6ryuz6me13kd1 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: B270F14000A X-Rspam-User: X-HE-Tag: 1750870067-430027 X-HE-Meta: U2FsdGVkX1/uYGG8U7ATz6Av4BewP7od7MoSrEJz1FwXAoNkECQFnY6jHgIZLSFOMfsAvzkOnUMdJYMUyZRvjeNxOyCFwwcUadfVMZ7AtaK1wFJ9ez8eCqxC4RuqZSvbXn6T2H+NCiPDgtSspr7uQe+SvWvqFeZWBUD//vZfhmGphnejJK+Naq4QLQudzEvF0ENyl9LwTLPPej44XkA4YH8kWvZdls/1XgkHgwftFvxJkDthvGn/5oLJOZSiiRdU2Kfe+NcGmb18Au1xJB60zGOWSZ0LA9T2h3R4KgPonxlpDa5NtwiZwoBS+MvKhXzRsUFK5qK+yVtBaDjOr5zyqy9mk8L46JUSjHdm5OWv9NjR8L5uV0V5pu3Wn++9sR/ZmniMIYLYUJocAVKvxvHl+OzP9OpbWJ5GA8MZT6FWwZwuTQOfQHrIKx7y4f0tO25A8ZE+nwgXz/JNntMh3LAKNyhexQixA58E401wIu6KiBSjt4YiGYoVNle6kIvmKGrWPI3DJ5w/WYw/x/8e7a9cn6eL4pWfQOo796fXHprZZnVIXGqfj/dW/RtfQLaqPWmDkxf2VClj1q89CawgopxeSG0pQ3ZdFuhMkyg91rMmfs6gHyX8lMGOdZ047LzK22JS8+rEDXj7+bU6PlX/ntl1tmSdvEY+JHTL4z74hzrM0eDJkG3LARtyEtJPXUjY0uUvwGiyTDBOwH0qYhZolCJIYQvmA55o5DBzpj5jWQcNQVprglvfAgjG0ADS5KLg+QXzV+rrul+AI11AgJ5t8IScT0XbOW424qPuDmNqLmZinU7vZNjBSxL+dRo5JL6/yDtXnt4V36csaXKPIro3EI13jAqHAFd1HOTHVrWI+j1lfZWRZju/SRPaL399IXjaSBOOuxl8HpxLqg06puA/3sUzEye1X1R0EW6HWBPLn7kk1v4s6Q6sGAXj1Kxc166N6UjCxtJFuiD3wXxZZjXUajb jrtbhxVx 3wp6ThIZ1sQL8/2NoyAkY2v4Sw6AQ/79OsJRCZrGZiCT5N6G1huOqPpxhkKHu2VMxnr76HIbkEzASffday3V+Ut4iS3mDMuLP1D9D0TrBgFF8RDIJbjhdE4+Ezw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > [...] >>> @@ -1166,6 +1173,7 @@ static void __init init_fixed_pfns(struct pgtable_debug_args *args) >>> >>> static int __init init_args(struct pgtable_debug_args *args) >>> { >>> + unsigned long max_swap_offset; >>> struct page *page = NULL; >>> int ret = 0; >>> >>> @@ -1248,6 +1256,11 @@ static int __init init_args(struct pgtable_debug_args *args) >>> >>> init_fixed_pfns(args); >>> >>> + /* See generic_max_swapfile_size(): probe the maximum offset */ >>> + max_swap_offset = swp_offset(pte_to_swp_entry(swp_entry_to_pte(swp_entry(0, ~0UL)))); >> Why not directly use generic_max_swapfile_size() which is doing exact same thing. >> >> unsigned long generic_max_swapfile_size(void) >> { >> return swp_offset(pte_to_swp_entry( >> swp_entry_to_pte(swp_entry(0, ~0UL)))) + 1; >> } > > Good question. I just moved this code here from pte_swap_exclusive_tests(), > see above, and did not think about that. Now I also wonder why > generic_max_swapfile_size() wasn't used before. > > But it is not exactly the same thing, there is an extra "+ 1" there. > Maybe that is the reason, but I don't really understand the details / > difference, and therefore would not want to change it. > > David, do you remember why you didn't use generic_max_swapfile_size() > in your pte_swap_exclusive_tests()? Excellent question. If only I would remember :) generic_max_swapfile_size() resides in mm/swapfile.c, which is only around with CONFIG_SWAP. It makes sense to have that function only if there are ... actual swapfiles. These checks here are independent of CONFIG_SWAP (at least in theory -- for migration entries etc we don't need CONFIG_SWAP), and we simply want to construct a swap PTE with all possible bits set. -- Cheers, David / dhildenb