From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DD9BC54ED1 for ; Tue, 27 May 2025 16:36:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0B9CF6B00D5; Tue, 27 May 2025 12:36:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 090FD6B00D6; Tue, 27 May 2025 12:36:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F104D6B00D7; Tue, 27 May 2025 12:36:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D17DB6B00D5 for ; Tue, 27 May 2025 12:36:00 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 0DE631209B7 for ; Tue, 27 May 2025 16:36:00 +0000 (UTC) X-FDA: 83489239680.25.C5EACED Received: from dggsgout12.his.huawei.com (dggsgout12.his.huawei.com [45.249.212.56]) by imf14.hostedemail.com (Postfix) with ESMTP id 33CD2100004 for ; Tue, 27 May 2025 16:35:55 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf14.hostedemail.com: domain of pulehui@huaweicloud.com designates 45.249.212.56 as permitted sender) smtp.mailfrom=pulehui@huaweicloud.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748363758; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=a+U/A5qpcE7ejRMDcNfbFzv/oqHp679xXrxGH3YgUOM=; b=Nlx1miGrwti3GiwW5k4nucXLhIDBs/IcHz/vlF9lKM24/kTpNdiwju7+RC93PQHiSfiRB5 HjtuULOFIAZJvPdjMZRKF/KHeodwhyCFW9SaNm2Po1eNMzlm46CXVeqPm8HwR/ycJNbdhL 6+DbBV/Tc6bE0yOKc3ba+KbJOWsW0Gs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748363758; a=rsa-sha256; cv=none; b=8a4QpGbQqxOBjoiag4myJA4lUMxtKZNm85/74wOyLcr2y7cT2rOg0m285iOjByIE4uj1pS JgN1WR0cHUJR/VFE3WbSAv0w7vXHKQm/U4MLDKH1VrkL8Q5nA5VDB966L4Ox9OLvzUCV2U B+AEbQEprrRE3O8RNsXJpZD17wDFx/Y= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf14.hostedemail.com: domain of pulehui@huaweicloud.com designates 45.249.212.56 as permitted sender) smtp.mailfrom=pulehui@huaweicloud.com Received: from mail.maildlp.com (unknown [172.19.93.142]) by dggsgout12.his.huawei.com (SkyGuard) with ESMTP id 4b6JCK6dcLz4f3jd8 for ; Wed, 28 May 2025 00:35:25 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.252]) by mail.maildlp.com (Postfix) with ESMTP id 3501A1A07BB for ; Wed, 28 May 2025 00:35:51 +0800 (CST) Received: from [10.67.109.184] (unknown [10.67.109.184]) by APP3 (Coremail) with SMTP id _Ch0CgC3CMPm6TVoloXvNQ--.37494S2; Wed, 28 May 2025 00:35:51 +0800 (CST) Message-ID: Date: Wed, 28 May 2025 00:35:50 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v2 1/2] mm/mremap: Fix uprobe anon page be overwritten when expanding vma during mremap Content-Language: en-US To: Oleg Nesterov Cc: mhiramat@kernel.org, peterz@infradead.org, akpm@linux-foundation.org, Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, vbabka@suse.cz, jannh@google.com, pfalcato@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org, pulehui@huawei.com References: <20250527132351.2050820-1-pulehui@huaweicloud.com> <20250527132351.2050820-2-pulehui@huaweicloud.com> <20250527153007.GD8333@redhat.com> From: Pu Lehui In-Reply-To: <20250527153007.GD8333@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CM-TRANSID:_Ch0CgC3CMPm6TVoloXvNQ--.37494S2 X-Coremail-Antispam: 1UD129KBjvdXoW7JryfCF4fGw47GFyftr1xAFb_yoWfurgE9w nFkrykWryUWr1Yq3W7Xan2yr4qg3W5GF1UJ3s8X342grn8Xan8Cr45X34rtry8GFs2vrnI 9FyUX3y5ur1a9jkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbIxYFVCjjxCrM7AC8VAFwI0_Gr0_Xr1l1xkIjI8I6I8E6xAIw20E Y4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l8cAvFVAK0II2c7xJM28CjxkF64kEwV A0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVW7JVWDJwA2z4x0Y4vE2Ix0cI8IcVCY1x02 67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVAFwI0_Gr1j6F4UJwA2z4x0Y4vEx4A2jsIEc7 CjxVAFwI0_Gr1j6F4UJwAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAq x4xG6I80ewAv7VC0I7IYx2IY67AKxVWUXVWUAwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6x CaFVCjc4AY6r1j6r4UM4x0Y48IcVAKI48JM4IIrI8v6xkF7I0E8cxan2IY04v7MxkF7I0E n4kS14v26r1q6r43MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I 0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWU tVW8ZwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcV CY1x0267AKxVW8JVWxJwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAF wI0_Jr0_Gr1lIxAIcVC2z280aVCY1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa 7IU10PfPUUUUU== X-CM-SenderInfo: psxovxtxl6x35dzhxuhorxvhhfrp/ X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 33CD2100004 X-Stat-Signature: 5ycooj86pkhusq83ju488ih88hyfjbhj X-Rspam-User: X-HE-Tag: 1748363755-204539 X-HE-Meta: U2FsdGVkX1+HHnULL4zJ1lRGSqTYVb9JZhyOLL1V5lpdmTR0rQMM6R4oV0rOnC5TCAjzgKN7N+fDW3NM4cDcVHfrsnxJtrkUBquFmopdT82Iz7FWIJyH5q+Sil58JXIZH5aDGHqYGbJscB3ZTZfJBDujPPX1dpK0kIcbKOtYP7aYYwysCFJsFLvpqpN3CCAHMHK9L+amsT6WAp3mWefUy/bnjWbpWrfXbkHeKP+z/IjCxc5eNL++NSypARaI9ima8Wd6erpaMpENToWJ+REA9UnEHmphE6LSJZXT/DCOgMze5ziGEIMCV8nxYgT8M7dwXpuGJRorwrLrkUfYO+g9jD4WBEpKl0liXyaHBl2BOD9Bn5K6ooOn3JRrqvYAb50zdxEw/QGVwBYydBjpbYCD8sS/Sh83Q6tyjmOz3EPRKYxI+LVicPL4FOIrgQ+3Mi0hDfcrLnyIo+pfaGeIrCDIMu6cpHxVqfmpzzZWvLjnwHlebCpURiQGSEirheI6TD7ddpy4hJPFXueebIqCNL2lXVccpgu8Ay18B1w1Ts4BedB3doG9n3FmvXELwjpRordItrz+ZLtJ/IBX35jWCgHyEMTcy/ueb+xWuoV42TwboMMrEfPj2O6UiBIYxmYGk0HJ2mCA7GQ2t2m9STjQMhQQaa2NdANulIe/YcMToVEpNYXRlUs/Cxr1d+2oMGRk3dyykDnnZkWVJ3flKqxu1z6L26P/fDjK0sxdxOz17SXBYOnOCHOu2VQMhvR3rvbBsfRMzs7w8n46x6ClcbS4xiVerFlpjPkKwQnHSf6RetCfY92B+4nytujca2G7x+o5nSH/lBPzb3hJWcVtea6gtWm/foQjgsnjrYlYTRjpvfvx2TtQE4hAx1IutKkluUTrV+MHniA7geDl+zey5mmzBC3AvI4wkWuOgjGLkSKfnxLLZCvHx94uW2xiLpVcRkIARskZpIJTikQaV+oI0JBUltQ FfCumZAy +dzYF1KDIUgYB2oX+qfOg5apXSweDDKHFlxbmIik2OYwuLcP68O02Lis/wLZnpdALmc/InuBhVDrrOVfW1L6DTdl5MrrNxJ31uRNQNSW8Zr4Hzcwyy2X6YJAQUewrHttvt/TdOf9kC+Ld7/898N2aM34i+E7n38lw1/7kXZKWEDnP448v290OJJSumDWPLDyY7Bl8aHsUpVI9fcSUbatyKPRT9w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/5/27 23:30, Oleg Nesterov wrote: > Not that this is really important, but the test-case looks broken, > > On 05/27, Pu Lehui wrote: >> >> #define _GNU_SOURCE >> #include >> #include >> #include >> #include >> #include >> >> int main(int argc, char *argv[]) >> { >> int fd = open(FNAME, O_RDWR|O_CREAT, 0600); > > FNAME is not defined > >> struct perf_event_attr attr = { >> .type = 9, > > Cough ;) Yes I too used perf_event_attr.type == 9 when I wrote another > test-case. Because I am lazy and this is what I see in > /sys/bus/event_source/devices/uprobe/type on my machine. > > But me should not assume that perf_pmu_register(&perf_uprobe) -> idr_alloc() > will return 9. > >> write(fd, "x", 1); > > looks unnecessary. > > Oleg. Oops...Thanks Oleg, I think I should thoroughly verify it. Perhaps I shouldn't be working on patches so late at night.🥱