From: Dan Magenheimer <dan.magenheimer@oracle.com>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Chris Mason <chris.mason@oracle.com>,
viro@zeniv.linux.org.uk, akpm@linux-foundation.org,
adilger@sun.com, tytso@mit.edu, mfasheh@suse.com,
Joel Becker <joel.becker@oracle.com>,
matthew@wil.cx, linux-btrfs@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-ext4@vger.kernel.org, ocfs2-devel@oss.oracle.com,
linux-mm@kvack.org, ngupta@vflare.org, JBeulich@novell.com,
Kurt Hackel <kurt.hackel@oracle.com>,
npiggin@kernel.dk, Dave Mccracken <dave.mccracken@oracle.com>,
riel@redhat.com, avi@redhat.com,
Konrad Wilk <konrad.wilk@oracle.com>,
mel@csn.ul.ie, yinghan@google.com, gthelen@google.com
Subject: RE: [PATCH V4 3/8] Cleancache: core ops functions and configuration
Date: Mon, 30 Aug 2010 17:40:42 -0700 (PDT) [thread overview]
Message-ID: <dbb9f012-c09a-438f-99d0-4fbc40428f58@default> (raw)
In-Reply-To: <4C7C3521.7090403@goop.org>
> > +#ifdef CONFIG_CLEANCACHE
> > +#define cleancache_enabled (cleancache_ops.init_fs)
>
> Pointers can be used in a boolean context, but it would probably be
> cleaner to have this evaluate to a proper boolean type. Also I'd
> probably go with an all-caps macro name rather than making it look like
> a variable.
OK, thanks, will fix.
> > +/* useful stats available in /sys/kernel/mm/cleancache */
> > +static unsigned long succ_gets;
> > +static unsigned long failed_gets;
> > +static unsigned long puts;
> > +static unsigned long flushes;
>
> I'd probably give these very generic-sounding names some slightly
> unique
> prefix just to help out people looking at "nm" output or using ctags.
>
> > +static int get_key(struct inode *inode, struct cleancache_filekey
> *key)
>
> Ditto.
OK, will do.
Thanks for the feedback!
Dan
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2010-08-31 0:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-30 22:31 [PATCH V4 3/8] Cleancache: core ops functions and configuration Dan Magenheimer
2010-08-30 22:48 ` Jeremy Fitzhardinge
2010-08-31 0:40 ` Dan Magenheimer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dbb9f012-c09a-438f-99d0-4fbc40428f58@default \
--to=dan.magenheimer@oracle.com \
--cc=JBeulich@novell.com \
--cc=adilger@sun.com \
--cc=akpm@linux-foundation.org \
--cc=avi@redhat.com \
--cc=chris.mason@oracle.com \
--cc=dave.mccracken@oracle.com \
--cc=gthelen@google.com \
--cc=jeremy@goop.org \
--cc=joel.becker@oracle.com \
--cc=konrad.wilk@oracle.com \
--cc=kurt.hackel@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=matthew@wil.cx \
--cc=mel@csn.ul.ie \
--cc=mfasheh@suse.com \
--cc=ngupta@vflare.org \
--cc=npiggin@kernel.dk \
--cc=ocfs2-devel@oss.oracle.com \
--cc=riel@redhat.com \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
--cc=yinghan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).