From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7E66C433EF for ; Thu, 12 May 2022 13:38:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7A3246B0074; Thu, 12 May 2022 09:38:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 72C9B6B007E; Thu, 12 May 2022 09:38:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5A7026B0080; Thu, 12 May 2022 09:38:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 445BB6B0074 for ; Thu, 12 May 2022 09:38:02 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id B386E58C for ; Thu, 12 May 2022 13:38:01 +0000 (UTC) X-FDA: 79457194362.23.BE32888 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf06.hostedemail.com (Postfix) with ESMTP id BB96E1800B8 for ; Thu, 12 May 2022 13:37:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652362680; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=N8e+gXdF4Rt32wAzlMm0HLoNXNQ/0Ieuz5/O4oeRXo4=; b=hNhif9kRbq52zu86Cbt+AzojTQuexxUTnvhzgVS4eRH9thd0sCrUkjN2e3+KF5twCgOS4G /i/Sae7Vfi7w7YRK4Ku739twdqQvEIlW2ubtaI0WSH/P4zOmJ+5ak1qMk5dO+WWNk7x5xz xQ3NgXejmn8B4yzYDUpYUUz7kOc6aRQ= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-207-WAKY-ycpMaa6aboRtZp2Ug-1; Thu, 12 May 2022 09:37:59 -0400 X-MC-Unique: WAKY-ycpMaa6aboRtZp2Ug-1 Received: by mail-wm1-f69.google.com with SMTP id e9-20020a05600c4e4900b00394779649b1so4415857wmq.3 for ; Thu, 12 May 2022 06:37:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=N8e+gXdF4Rt32wAzlMm0HLoNXNQ/0Ieuz5/O4oeRXo4=; b=nB3RT7aK6B0YsNUwzHlWO6t0L2x9wCcKTohBke+CkTcBGr4ZhFDp31Ui8yQGGlFJjf 5QY8qPu9/wwll+cYebq4S2zHIpriks57F9Rowq60f6qwdk2lWAglJKSlTsuSoGR3REoq 81ZAD+YhKg7ct4ADQ0g1X8friFgXUurSFt8CWdTXnRaUqdaq9D7o86Zb6zPzZ9I6Er3b wrTrYanAn3Ynioz8OegM6YBdNiGyJEqTIwS10pL1vbFyWectqMn20U4FAVRwnO6Umgf1 Wu1EkYzUzy0t0nPqqggC/j4Voz3LhWZX2MXK/8V1OXdT1iCSn9m16ly/RcD/62tl2a6P qM8g== X-Gm-Message-State: AOAM533vynYOJTHc0TBBzkFHBdl59c8Xd0vijgGgT3YPVaLaRpG0GYg3 PpAykxldWh0HH0qP9cuqiWqyY3c558kMVce5eXRLZU9zQ0NSHRyWojsBDwEkahVYb4hSd2QI7F+ 4dDJG8ExOGEc= X-Received: by 2002:a5d:61c2:0:b0:20a:d92f:9056 with SMTP id q2-20020a5d61c2000000b0020ad92f9056mr26892244wrv.652.1652362677944; Thu, 12 May 2022 06:37:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzY1zewJ/fqnODYg7imJ16tz9qpZ3ZbXXs9WgoASNTNxE1AvunXIx9bUiuPLdC2yb6LwlVkSg== X-Received: by 2002:a5d:61c2:0:b0:20a:d92f:9056 with SMTP id q2-20020a5d61c2000000b0020ad92f9056mr26892230wrv.652.1652362677713; Thu, 12 May 2022 06:37:57 -0700 (PDT) Received: from ?IPV6:2003:cb:c701:d200:ee5d:1275:f171:136d? (p200300cbc701d200ee5d1275f171136d.dip0.t-ipconnect.de. [2003:cb:c701:d200:ee5d:1275:f171:136d]) by smtp.gmail.com with ESMTPSA id y25-20020a1c4b19000000b0039489e1bbd6sm2553468wma.47.2022.05.12.06.37.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 May 2022 06:37:56 -0700 (PDT) Message-ID: Date: Thu, 12 May 2022 15:37:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH 07/15] mm/swap: remove unneeded p != NULL check in __swap_duplicate To: Miaohe Lin , akpm@linux-foundation.org Cc: willy@infradead.org, vbabka@suse.cz, dhowells@redhat.com, neilb@suse.de, apopple@nvidia.com, surenb@google.com, peterx@redhat.com, naoya.horiguchi@nec.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220509131416.17553-1-linmiaohe@huawei.com> <20220509131416.17553-8-linmiaohe@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220509131416.17553-8-linmiaohe@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: BB96E1800B8 X-Stat-Signature: h3d68tfzqwaspgacenon3fpg7dxe59oc Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hNhif9kR; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf06.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com X-Rspam-User: X-HE-Tag: 1652362678-968017 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 09.05.22 15:14, Miaohe Lin wrote: > If p is NULL, __swap_duplicate will already return -EINVAL. So if we > reach here, p must be non-NULL. > > Signed-off-by: Miaohe Lin Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb