From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D20AC83F1B for ; Thu, 17 Jul 2025 09:00:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E7ECF8D0018; Thu, 17 Jul 2025 05:00:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E2EA28D0011; Thu, 17 Jul 2025 05:00:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D44408D0018; Thu, 17 Jul 2025 05:00:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C340B8D0011 for ; Thu, 17 Jul 2025 05:00:24 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 6EC7FC06AA for ; Thu, 17 Jul 2025 09:00:24 +0000 (UTC) X-FDA: 83673160368.18.E342770 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) by imf14.hostedemail.com (Postfix) with ESMTP id 8D77210000F for ; Thu, 17 Jul 2025 09:00:21 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=STr+G78o; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf14.hostedemail.com: domain of xiaoyao.li@intel.com designates 192.198.163.17 as permitted sender) smtp.mailfrom=xiaoyao.li@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752742822; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mxpltL2MwXG5qLmncDglfnSpqmBPWgVuiFMAjvj5yVk=; b=R1Zw72Rmf/f9KQJOQfjtGFR9rJ/CMCNJupxyexDzyDIwJIYpYfjhJVTs4TexVW+OgU1/cA 2OGfgEMfqpxOS/+ODs92ePk18QftVoLenCG3yCJpJIBJ00Kjfe4SRzXKlpEY5qgue4PfcZ p9TSL/YfGaq29I3wdNF1/pZrD19sEBI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752742822; a=rsa-sha256; cv=none; b=lccvg1jL5giddHVhccuTPOvgL7GEId6ZKk4oD8LN40cdidZoeaUd/IOld+R4VDwIvMoqXn aiXtsWFbEOyOwA4DKotxd9zYcb1bCOx1zYW0elvnAy/i9qvBc4Lr7Who8FTN0S7rrNL5Q+ ZlP9omlYgWr6qwkHJQaWifHuSFhFrt0= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=STr+G78o; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf14.hostedemail.com: domain of xiaoyao.li@intel.com designates 192.198.163.17 as permitted sender) smtp.mailfrom=xiaoyao.li@intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1752742821; x=1784278821; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=aGbM7IqfeuS/6bF/kHs79qT5aNiBDtA03RdS80GdaYQ=; b=STr+G78oxikYynwrPScHa6W1Y5ozyRXDiqW6zUvCZ18B4Y1Tabk+woRv 4JJrYVM43XniWn23dyQ/8WV2x9cQ0B+qes3SSK7NajqYWZcA7SxgJFyL6 +tDkOeYRCBbSUIjpwXPXrHb4iaAWANrO6HPnycTUFyqFlj2wx+l9rxBh0 qvSr43XfzNaVyUiH1z7TCERJ7HxNn/7U8egMzznVCkeuvjCp1faymzliG QESDobelImHn9pRYzV66HUA4rSIOlBuloJdoFDyUQqF5H2gegPn8nZZq6 RoCOWuCZyf1ghFG2lhb62cfCgOwrYZBFIkAm4DWloNQz7SvTtRed3Tk02 g==; X-CSE-ConnectionGUID: O3NRh4aYQKKtgbyc8z94sw== X-CSE-MsgGUID: n5wBTcx/RuepS8CeMoJ9+Q== X-IronPort-AV: E=McAfee;i="6800,10657,11493"; a="54947384" X-IronPort-AV: E=Sophos;i="6.16,318,1744095600"; d="scan'208";a="54947384" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jul 2025 02:00:20 -0700 X-CSE-ConnectionGUID: grRhNT59TOae6QFdno4wGg== X-CSE-MsgGUID: /gOPa19PR0iPIjZ0z+7J7A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,318,1744095600"; d="scan'208";a="158292638" Received: from xiaoyaol-hp-g830.ccr.corp.intel.com (HELO [10.124.247.1]) ([10.124.247.1]) by fmviesa008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jul 2025 02:00:06 -0700 Message-ID: Date: Thu, 17 Jul 2025 17:00:03 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v14 04/21] KVM: x86: Introduce kvm->arch.supports_gmem To: Fuad Tabba Cc: Ackerley Tng , kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org, kvmarm@lists.linux.dev, pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, mail@maciej.szmigiero.name, david@redhat.com, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com, peterx@redhat.com, pankaj.gupta@amd.com, ira.weiny@intel.com References: <20250715093350.2584932-1-tabba@google.com> <20250715093350.2584932-5-tabba@google.com> Content-Language: en-US From: Xiaoyao Li In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: 9fzonmwk1ejqrr31tt9sk3ebe5u5ja7a X-Rspamd-Queue-Id: 8D77210000F X-Rspamd-Server: rspam10 X-Rspam-User: X-HE-Tag: 1752742821-400249 X-HE-Meta: U2FsdGVkX19EtXuhTzme5sVgMiVayDcFzdjhaz+p0uBs7etXRxILRpWd734paziGCBZFWV87ZJhKfQNYdWn/EL7+YifOHwJugFR1BGAG5YDC1M8pCfjjjBkfsAQpC3yVAjP3ZLG06i4uJKbDL90dpTJHLi8di4M7Q4Aa+jBQBcD6/h0wGr2oosUgxwwus9o89b9yMIjbvltVMWwsEsq/snrCDiTFdO15APPPKtg7QXQl2hbfaAUUeMjI2324R62dB/PsZx1wTBRbz4NZk3f8wb3/bLFIs03cFBW80GHwdau4/3jmrCW+F4+Qk3BiytGU2b+J7hc7LlbKEpKWmB9nxnPZBFW9ochui6CNdqmoPDo+YPsAM6sz5lyL3ahiFeG0oWJI7IAj3rqr2KLaGM1X5/bgsKXmi94JcTj+YlFED/H3WH+MlfU5SSFKf3noVpUP7wAEVfkeYVNLhs85segrzuhLPsFWTMQY8Liw6Jeq0eg84FzOdK1aG2rALijKD1TkNsfVxMwtJeX75g4Kjot5mlxU2YxHmzqi+I/j6dhjGOQmEp+VjoXa0M+yOduXZJEO1G2Y5CFzfHtUYWvZTOZg/Goyq3rE5kVLgxHO0bgduXW/Be/uaeQmGReCKcwsgRP1adztQ2vWDj8W8fC1w70K2P9uolZajEKjjcoKRWBkAWPSWlArzWnX31kCEFxR6aEx4HmgqmMyh8RhKHh7ajwTS68O4/qY/eWJXWvxfyzBOXxhSteHYxMzSy1iR6WpyBeRrEOGbyY+DdPxpzbp/xG83p+l2T83x2PCuIIB3yEBI7TvqeObrn8FFbE0Gyy+nAGWvL2WWMVdu93SfWie9Rd1vJkx98IGp2ZLTpHziNW/aRv2xzq3Sj/q7tT0IKBIcMNvGKK0Ff6oKeMcP52YhU/5clwsM8LDq2Q01OluyDyhY2UrHlvGhn2yS/cOrbAyv0JbNzJbLvHz9Gfuw21CThw TOJCobTv +O9AARiy/fd7OduCSkgAKnkStP2XQNB4MrpigP4gjGE72l9TCy+joHcz/aaLit+y7tJox06w9sy0mA0qwxnNwC7Z9FdBhpUFvP4pglTnObC/LfnfkeizYAULwyXKptfnTTQAZ1MJjcprPtsYfoLYYzmr8D/7Y8P9l+e54hu87UEfQ37VVOxaUUUvLHdXZujx0nlfPkCDEeoga0QHusDXj9kvIImZ0goiTWAlnFGiyUZqvRoGwUEj1HStACTFlZQMkEjNJcEvYGcPiK2kVXwdGQ5R7f2XweQqUahqCjX4FvMUCF/Uhn8oDftT0sViRjSYE8SIBoVigVwO9O2nhXeRF2UdHcg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 7/17/2025 4:49 PM, Fuad Tabba wrote: > On Thu, 17 Jul 2025 at 02:48, Xiaoyao Li wrote: >> On 7/17/2025 8:12 AM, Ackerley Tng wrote: >>> Xiaoyao Li writes: >>> ... >>>> >>>> Btw, it seems that supports_gmem can be enabled for all the types of VM? >>>> >>> For now, not really, because supports_gmem allows mmap support, and mmap >>> support enables KVM_MEMSLOT_GMEM_ONLY, and KVM_MEMSLOT_GMEM_ONLY will >>> mean that shared faults also get faulted from guest_memfd. >> No, mmap support is checked by kvm_arch_supports_gmem_mmap() which is >> independent to whether gmem is supported. > It is dependent on gmem support: > > kvm_arch_supports_gmem_mmap(kvm) depends on > CONFIG_KVM_GMEM_SUPPORTS_MMAP, which in turn selects KVM_GMEM. My bad that my words leads to misunderstanding. What I wanted to express it that support_gmem doesn't mean mmap support is allowed, there is additional specific guard for mmap support via kvm_arch_supports_gmem_mmap().