From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73694C3DA4B for ; Mon, 15 Jul 2024 16:21:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 089736B0095; Mon, 15 Jul 2024 12:21:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0121C6B0096; Mon, 15 Jul 2024 12:21:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D806C6B0098; Mon, 15 Jul 2024 12:21:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B71726B0095 for ; Mon, 15 Jul 2024 12:21:35 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 678F61A0137 for ; Mon, 15 Jul 2024 16:21:35 +0000 (UTC) X-FDA: 82342502550.04.0EE9CE2 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf27.hostedemail.com (Postfix) with ESMTP id 2B76140021 for ; Mon, 15 Jul 2024 16:21:32 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=L4wjSu1R; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721060464; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FhQwthqdOwp7wCdTkaE+tXfAhMlT2gApJoQckxJNldI=; b=VsYoo7+hREDTr5zrF6yiMmYIqAnUVB6J0bpMoCxiZZMj0FqQIPNqAWjqZ5dY2zLJ7pCNkn /PdNrjcLnqJRU9AKUT0AbYEQzrM1oct7997z7LOouwKqDmwZ+7dJ/TLttpxHOjizb3WnVx X/xan1dAMG/MZ9GO4sOyV3ITE7ckXeE= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=L4wjSu1R; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721060464; a=rsa-sha256; cv=none; b=T5bjt25bGf1ZzKfFpiQ31XKPP1rkeC7dBQP0yfFdGUcn6OFtuoB5yM9/6fEpDXjQCBvrxs KQrylZ50D1MS0ft7kOSS7LWvHE5NkVqaDoo28S2eg5hG8pSCljqHrj0tRBfpl4zNOtYVuv ULzfVxO1u3byqh2I8+xNPZnbNR+brwU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1721060492; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=FhQwthqdOwp7wCdTkaE+tXfAhMlT2gApJoQckxJNldI=; b=L4wjSu1RKJpJK/CGxcXDNxJ0KgQVscSSyPdu572KJPmSyKBFC/eSTK7kRsGk1kOfvuT685 2c08v3xyspXh9AtUloIELHhzQFzPVt45aGTIijXwqawQVW9gv20+yJAtQ0HMlPCrj/ersW 1C1v6aajKzHVOWYetnqmljis/kRUHt0= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-556-WdH4meh9O86oHxBsy8Ivjw-1; Mon, 15 Jul 2024 12:21:28 -0400 X-MC-Unique: WdH4meh9O86oHxBsy8Ivjw-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-42794cb8251so28985265e9.2 for ; Mon, 15 Jul 2024 09:21:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721060487; x=1721665287; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=FhQwthqdOwp7wCdTkaE+tXfAhMlT2gApJoQckxJNldI=; b=uTjYQx0DAPgSSg5fsyNPTc/PVtOylAFCeG650nMV3uKFJ88kegmtWA52xmkEytRR/d jxHGJdvDsE9mp+T6Bu32eX01skUSq/CWcpdE+0OSLf2WgtITPNV18egtsrzkgquh/g2/ cIVy6Mrt5xYe1mqIQHdgxQbMPU5r5yXpFgHLyPuBDXgJ37QkEEx7bdJdH4sTS695cyN0 ZaisVsA07opIaAzqgcvfA3J79wQwMerP1LkkNZcoRIjhfQGvkmjOq9abQLZTB8ea8vE9 nRbLQWmQXHIk9OlMSi1AQEKLWIfcdS+IleIPliJwdXSxZhBw1xBDfslGpygDFUhMmvOo 180A== X-Forwarded-Encrypted: i=1; AJvYcCXBqfokjunOCUAOy39yAAQixBSxvnlSSq9mzWkpyk/jsCyGiUK+HfC1zS7XXY1VdGQy0vgoSBDx3i/lLIIYnGU94PY= X-Gm-Message-State: AOJu0Yw8Ev8csIpds7lyayagJXUS8EUfeRb9/f3zZR0zdpu67ALC//+h iyDHvxPVwMkktMtEcyplO3MSKWO6CZ7qOoKd4pI7txMSlgsVQ5f6pdp0CnxYQAwl1eTDqqypSqj BAeWIUrK6TmS7BLV/Zyd2hFgFzUTYVd4NWS4/VBrNZiKXRZqJ X-Received: by 2002:a05:600c:a086:b0:426:6087:198f with SMTP id 5b1f17b1804b1-427b88d06b4mr901035e9.39.1721060487538; Mon, 15 Jul 2024 09:21:27 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHUMz8cu7y7PXAMQogYWxHoUpKtVPhZXk097I1U4qf/GI6hwmzSyG8UfIW6zkCDKDp+puRdrg== X-Received: by 2002:a05:600c:a086:b0:426:6087:198f with SMTP id 5b1f17b1804b1-427b88d06b4mr900865e9.39.1721060487157; Mon, 15 Jul 2024 09:21:27 -0700 (PDT) Received: from [10.0.229.2] (ip-037-024-227-121.um08.pools.vodafone-ip.de. [37.24.227.121]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3680dafb91csm6915360f8f.74.2024.07.15.09.21.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Jul 2024 09:21:26 -0700 (PDT) Message-ID: Date: Mon, 15 Jul 2024 18:21:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 00/20] mm/zsmalloc: add zpdesc memory descriptor for zswap.zpool To: Alex Shi , alexs@kernel.org, Vitaly Wool , Miaohe Lin , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, minchan@kernel.org, willy@infradead.org, senozhatsky@chromium.org, 42.hyeyoo@gmail.com, Yosry Ahmed , nphamcs@gmail.com References: <20240708063344.1096626-1-alexs@kernel.org> <8007538a-5680-4e43-b204-21ce62943eee@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <8007538a-5680-4e43-b204-21ce62943eee@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: t8omytkbywdtyqfkmwmw9dqachxbo66s X-Rspam-User: X-Rspamd-Queue-Id: 2B76140021 X-Rspamd-Server: rspam02 X-HE-Tag: 1721060492-961517 X-HE-Meta: U2FsdGVkX1+F3R91ozZMGp7b9r2UWbsoLT3adcFLJyhyeK+1Ybhp6bMtnJAoklealJirlSz6sr9SxcOR1eIKTI0/FcRZEJO9BHFxwm8b+32QLQZ9u1T56uFviRKgEbVwBf0pUUgXfC/D6CXlMqcoqdZrO2ONHnnz91HX1/mf1wK+zhD4gmov1o7DcFvbdRXs5Q59gcYMsXxJo25+XHcmkHsEe/upeYsf2liHJfGqWbcrFAKiOGfcYBpvQyq/pz471D5zJW8hCXPt7ltDFbjbnne4Oem4zY2Zpy79F1EGYuIFGCQXvHJJZirYStfUyPWyQhRfmtOywtGE6eZ6H4WNEb6quWFEnVHxa3VzHvXEYMxpdJD9WswIcK6Ul4o09DU+fBUrmDmOatOOR+Cu+OciIO6835hhvx0ZNLwvoscuBtzyC7QEOc9GKwuoan2KkLCQj0gSkJ12KdYE2XkR1mwt3v6H+Uboyu/70z8XPZX4Cnz0YjbN/3xXjZ6YcGkPOYFHCI9Vd87J06EbCKLkEMp6GgwkQLdd2iaq4BnL+x3qhrD9TK7zf7D7TSaWcn8Zv1ogsUjRC/vdWa1nhFQqxm8n2Fwu1uZGSOodKZ9IsazFkw92iFggr5ozZ4MPgpZV84F58oa1Xxn8TVPrPNNcQhsO+IfZsWT8oBGlt4OkPRXLms68zpxuD4rg0ooTvZzIIvPwAko8PD8g3T8rBpP4GOUHRhNO6UA6e/x6XKzKP60a9EDrbEgUH/qJNIvtJbURGavkdjinKMJc7XMIZgc7eHu/7fZ4PFbvyfOJFs4Xiq1dZFaTg+ZEkZSeX6eRfEzzCZxBL04yrfnm4Zmn1al9nY3LHs8d7q+uDdESUeSIWnvxWt0nwGZxoP+FQugrIDpC5cphlNc26+LZ8QlDaR6NDSAm3advG+ArH/naHL3C3O9/307K1PCeENpsp0vBnjLZGFhwGhUSdkS+Rv6mjav8ABv DpktZZOI 9O03Ek4lO7xLPkWNJ43IKcHzZfm1PUT9zZdNTDo8sHUQo/G0BWe3qj/hq7Y4ZwaZWnrAWn5zl07K4pVKtrze1hRmQwo2TXmIkPD8GmJVXBvvk//e/1AV2wZjjhIU1qkKXFJLiNibw5+vFlz7FMLB1eERUd3SkiCljoXP58oj/7Arz7Wg3HZyZOxLLt6mEUkCs6gq3KUBoKzO1/N8kBNXK/ttN2lAGNnL31Q6LQPjGoR3//vthYqskxApNRpV1L4XcMfE6EDQUh7K3ux/bn4Qgqb7A8gs/n//Bb2k5Dcb/wAMR0JYs+++bjvoho1lG8t0m4hQjjWYez3XzHZOAnfhTyCIoervxvBaGk2L/CCgU46l6zYCW5unWQeo2ZvkwG4QEqtE7F0ZTxw6u16cemwctj9giYoWrK3MLC1CURclp25eScwQgjdvTwyBK3HsdEB8768yFQJ6xcZIDMVgeI3GGTusA6BDWf3qhpbB6hMoUVSjhDNSLP6BhTV++k5pbr9v+I4jEdy7zpOFKyBX4UG5p53OL8A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 15.07.24 03:33, Alex Shi wrote: > > > On 7/8/24 2:33 PM, alexs@kernel.org wrote: >> From: Alex Shi (Tencent) >> >> According to Metthew's plan, the page descriptor will be replace by a 8 >> bytes mem_desc on destination purpose. >> https://lore.kernel.org/lkml/YvV1KTyzZ+Jrtj9x@casper.infradead.org/ >> >> Here is a implement on zsmalloc to replace page descriptor by 'zpdesc', >> which is still overlay on struct page now. but it's a step move forward >> above destination. >> >> To name the struct zpdesc instead of zsdesc, since there are still 3 >> zpools under zswap: zbud, z3fold, zsmalloc for now(z3fold maybe removed >> soon), and we could easyly extend it to other zswap.zpool in needs. >> >> For all zswap.zpools, they are all using single page since often used >> under memory pressure. So the conversion via folio series helper is >> better than page's for compound_head check saving. >> >> For now, all zpools are using some page struct members, like page.flags >> for PG_private/PG_locked. and list_head lru, page.mapping for page migration. >> >> This patachset does not increase the descriptor size nor introduce any >> functional changes, and could save about 122Kbytes zsmalloc.o size. >> >> Thanks >> Alex >> > > Any comments for this patchset? Planning on taking a peek soon (busy traveling), but I'm hoping that people more familiar with the code can provide feedback. -- Cheers, David / dhildenb