From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4B0FAC79F9E for ; Mon, 7 Sep 2026 12:23:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 64F996B00A0; Mon, 7 Sep 2026 08:23:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 627296B00A1; Mon, 7 Sep 2026 08:23:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5173D6B00A2; Mon, 7 Sep 2026 08:23:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 28CC46B00A0 for ; Mon, 7 Sep 2026 08:23:14 -0400 (EDT) Received: from smtpin01.hostedemail.com (lb01a-stub [10.200.18.249]) by unirelay05.hostedemail.com (Postfix) with ESMTP id AE3F740144 for ; Mon, 7 Sep 2026 12:23:13 +0000 (UTC) X-FDA: 85186881066.01.E8FE206 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf30.hostedemail.com (Postfix) with ESMTP id 4BB8E8000A for ; Mon, 7 Sep 2026 12:23:11 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=g3naaP8h; spf=pass (imf30.hostedemail.com: domain of frankja@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=frankja@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1788783791; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1oB401PRChNM94BBOkC+2/OTgtouFWztcLaE/fiOs9A=; b=3MNEVFfJs8k1RlpS3u2En0O72Sj6fm/StESPy6cIo78s+rkemnJw1uYU4mEXTYGKZDbzGM truO9uwqteeLt8NuhEKIx7nXDxMnAdompwWxgdvL+otS173Y4VhBmL061uCmjzQfgB6BSU 0TitorDvAVgnxRzrcs0yjXdw2Gw7Ok8= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=g3naaP8h; spf=pass (imf30.hostedemail.com: domain of frankja@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=frankja@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Seal: i=1; a=rsa-sha256; d=hostedemail.com; s=arc-20220608; cv=none; t=1788783791; b=MX5isCF63SPGxAIVEzJuvVDvHYqA8dSePRkqrxs77DfQVeibACAogxz3bBwQidHuOxtc7J NAL2Oa6A1DNwva1qI/DAb5niusU+yfKDkhysSR7QCBvOC3Cdb2iubSTY062jLL2YnEfmSr Ryhf7gLspZqMn2nMJKCEtg7fTngM9m0= Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 687B1bNI627746; Mon, 7 Sep 2026 12:23:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=1oB401 PRChNM94BBOkC+2/OTgtouFWztcLaE/fiOs9A=; b=g3naaP8hxzYj/uqzO8A0VG o2mIpjsr5spK/ZZnw2I+LSlH2Kf86hQDVnwXDWaKZ79PtAV7crImUnHf7YXg9TaJ oE6ezSTpTWSwS8xm/paI1WtXS/hhIIwY+cQVdVzmkG7mUyWCe11tK3+Bfib5707T 1jB5Ui/jICh6WHgGV2kc/9SqYiBi634BVR9dztmyOMrQFFmudr37fuhYjCf0078M fkToSfFTHH3M+5eHKu8kuLNAfUeEG9X+hpHzFURyg84550ys82VvykFvBPyAJgLX aMB6GAWX/G5ariMl50wL55CJU8Jl2DiRPjJl5yCvXpcGmoIkW3lZnvWHwCLfBoyg == Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4ggbjrggxs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 07 Sep 2026 12:23:08 +0000 (GMT) Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 687BuFbT027688; Mon, 7 Sep 2026 12:23:07 GMT Received: from smtprelay02.fra02v.mail.ibm.com ([9.218.2.226]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4ggwsvwy8j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 07 Sep 2026 12:23:07 +0000 (GMT) Received: from smtpav03.fra02v.mail.ibm.com (smtpav03.fra02v.mail.ibm.com [10.20.54.102]) by smtprelay02.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 687CN30v46072304 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 7 Sep 2026 12:23:03 GMT Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4158A2004B; Mon, 7 Sep 2026 12:23:03 +0000 (GMT) Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E76C320043; Mon, 7 Sep 2026 12:23:02 +0000 (GMT) Received: from [9.87.132.113] (unknown [9.87.132.113]) by smtpav03.fra02v.mail.ibm.com (Postfix) with ESMTP; Mon, 7 Sep 2026 12:23:02 +0000 (GMT) Message-ID: Date: Mon, 7 Sep 2026 14:23:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/4] KVM: s390: Replace get_zeroed_page() with kzalloc() for the STHYI buffer To: "Mike Rapoport (Microsoft)" , Christian Borntraeger , Claudio Imbrenda Cc: Alexander Gordeev , David Hildenbrand , Heiko Carstens , Sven Schnelle , Vasily Gorbik , Vlastimil Babka , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org References: <20260906-s390-kvm-v2-0-2cf6434e6646@kernel.org> <20260906-s390-kvm-v2-1-2cf6434e6646@kernel.org> Content-Language: en-US From: Janosch Frank Autocrypt: addr=frankja@linux.ibm.com; keydata= xsFNBFubpD4BEADX0uhkRhkj2AVn7kI4IuPY3A8xKat0ihuPDXbynUC77mNox7yvK3X5QBO6 qLqYr+qrG3buymJJRD9xkp4mqgasHdB5WR9MhXWKH08EvtvAMkEJLnqxgbqf8td3pCQ2cEpv 15mH49iKSmlTcJ+PvJpGZcq/jE42u9/0YFHhozm8GfQdb9SOI/wBSsOqcXcLTUeAvbdqSBZe zuMRBivJQQI1esD9HuADmxdE7c4AeMlap9MvxvUtWk4ZJ/1Z3swMVCGzZb2Xg/9jZpLsyQzb lDbbTlEeyBACeED7DYLZI3d0SFKeJZ1SUyMmSOcr9zeSh4S4h4w8xgDDGmeDVygBQZa1HaoL Esb8Y4avOYIgYDhgkCh0nol7XQ5i/yKLtnNThubAcxNyryw1xSstnKlxPRoxtqTsxMAiSekk 0m3WJwvwd1s878HrQNK0orWd8BzzlSswzjNfQYLF466JOjHPWFOok9pzRs+ucrs6MUwDJj0S cITWU9Rxb04XyigY4XmZ8dywaxwi2ZVTEg+MD+sPmRrTw+5F+sU83cUstuymF3w1GmyofgsU Z+/ldjToHnq21MNa1wx0lCEipCCyE/8K9B9bg9pUwy5lfx7yORP3JuAUfCYb8DVSHWBPHKNj HTOLb2g2UT65AjZEQE95U2AY9iYm5usMqaWD39pAHfhC09/7NQARAQABzSVKYW5vc2NoIEZy YW5rIDxmcmFua2phQGxpbnV4LmlibS5jb20+wsF3BBMBCAAhBQJbm6Q+AhsjBQsJCAcCBhUI CQoLAgQWAgMBAh4BAheAAAoJEONU5rjiOLn4p9gQALjkdj5euJVI2nNT3/IAxAhQSmRhPEt0 AmnCYnuTcHRWPujNr5kqgtyER9+EMQ0ZkX44JU2q7OWxTdSNSAN/5Z7qmOR9JySvDOf4d3mS bMB5zxL9d8SbnSs1uW96H9ZBTlTQnmLfsiM9TetAjSrR8nUmjGhe2YUhJLR1v1LguME+YseT eXnLzIzqqpu311/eYiiIGcmaOjPCE+vFjcXL5oLnGUE73qSYiujwhfPCCUK0850o1fUAYq5p CNBCoKT4OddZR+0itKc/cT6NwEDwdokeg0+rAhxb4Rv5oFO70lziBplEjOxu3dqgIKbHbjza EXTb+mr7VI9O4tTdqrwJo2q9zLqqOfDBi7NDvZFLzaCewhbdEpDYVu6/WxprAY94hY3F4trT rQMHJKQENtF6ZTQc9fcT5I3gAmP+OEvDE5hcTALpWm6Z6SzxO7gEYCnF+qGXqp8sJVrweMub UscyLqHoqdZC2UG4LQ1OJ97nzDpIRe0g6oJ9ZIYHKmfw5jjwH6rASTld5MFWajWdNsqK15k/ RZnHAGICKVIBOBsq26m4EsBlfCdt3b/6emuBjUXR1pyjHMz2awWzCq6/6OWs5eANZ0sdosNq dq2v0ULYTazJz2rlCXV89qRa7ukkNwdBSZNEwsD4eEMicj1LSrqWDZMAALw50L4jxaMD7lPL jJbazsFNBFubpD4BEADAcUTRqXF/aY53OSH7IwIK9lFKxIm0IoFkOEh7LMfp7FGzaP7ANrZd cIzhZi38xyOkcaFY+npGEWvko7rlIAn0JpBO4x3hfhmhBD/WSY8LQIFQNNjEm3vzrMo7b9Jb JAqQxfbURY3Dql3GUzeWTG9uaJ00u+EEPlY8zcVShDltIl5PLih20e8xgTnNzx5c110lQSu0 iZv2lAE6DM+2bJQTsMSYiwKlwTuv9LI9Chnoo6+tsN55NqyMxYqJgElk3VzlTXSr3+rtSCwf tq2cinETbzxc1XuhIX6pu/aCGnNfuEkM34b7G1D6CPzDMqokNFbyoO6DQ1+fW6c5gctXg/lZ 602iEl4C4rgcr3+EpfoPUWzKeM8JXv5Kpq4YDxhvbitr8Dm8gr38+UKFZKlWLlwhQ56r/zAU v6LIsm11GmFs2/cmgD1bqBTNHHcTWwWtRTLgmnqJbVisMJuYJt4KNPqphTWsPY8SEtbufIlY HXOJ2lqUzOReTrie2u0qcSvGAbSfec9apTFl2Xko/ddqPcZMpKhBiXmY8tJzSPk3+G4tqur4 6TYAm5ouitJsgAR61Cu7s+PNuq/pTLDhK+6/Njmc94NGBcRA4qTuysEGE79vYWP2oIAU4Fv6 gqaWHZ4MEI2XTqH8wiwzPdCQPYsSE0fXWiYu7ObeErT6iLSTZGx4rQARAQABwsFfBBgBCAAJ BQJbm6Q+AhsMAAoJEONU5rjiOLn4DDEP/RuyckW65SZcPG4cMfNgWxZF8rVjeVl/9PBfy01K 8R0hajU40bWtXSMiby7j0/dMjz99jN6L+AJHJvrLz4qYRzn2Ys843W+RfXj62Zde4YNBE5SL jJweRCbMWKaJLj6499fctxTyeb9+AMLQS4yRSwHuAZLmAb5AyCW1gBcTWZb8ON5BmWnRqeGm IgC1EvCnHy++aBnHTn0m+zV89BhTLTUal35tcjUFwluBY39R2ux/HNlBO1GY3Z+WYXhBvq7q katThLjaQSmnOrMhzqYmdShP1leFTVbzXUUIYv/GbynO/YrL2gaQpaP1bEUEi8lUAfXJbEWG dnHFkciryi092E8/9j89DJg4mmZqOau7TtUxjRMlBcIliXkzSLUk+QvD4LK1kWievJse4mte FBdkWHfP4BH/+8DxapRcG1UAheSnSRQ5LiO50annOB7oXF+vgKIaie2TBfZxQNGAs3RQ+bga DchCqFm5adiSP5+OT4NjkKUeGpBe/aRyQSle/RropTgCi85pje/juYEn2P9UAgkfBJrOHvQ9 Z+2Sva8FRd61NJLkCJ4LFumRn9wQlX2icFbi8UDV3do0hXJRRYTWCxrHscMhkrFWLhYiPF4i phX7UNdOWBQ90qpHyAxHmDazdo27gEjfvsgYMdveKknEOTEb5phwxWgg7BcIDoJf9UMC In-Reply-To: <20260906-s390-kvm-v2-1-2cf6434e6646@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Authority-Analysis: v=2.4 cv=E7T9Y6dl c=1 sm=1 tr=0 ts=6a9eacac cx=c_pps a=5BHTudwdYE3Te8bg5FgnPg==:117 a=5BHTudwdYE3Te8bg5FgnPg==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=V8glGbnc2Ofi9Qvn3v5h:22 a=VwQbUJbxAAAA:8 a=VnNF1IyMAAAA:8 a=kt7I_EveaTZZBW9BUTwA:9 a=QEXdDO2ut3YA:10 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTA3MDEzMyBTYWx0ZWRfX+arVqquRJ31Y mcur1fAZHm1KhQjKFpEM4QT5CY3JEzwzs6kz7MSULeLhzhiSs9DY+//BC4oFwcl1Ly9dXRHVpou X6VXmXQl1ar9eUD5I4aNZJDx5wLN9EU= X-Proofpoint-ORIG-GUID: ARgD4si-5RsW5zhRgTmw5-dvPcupNIC9 X-Proofpoint-GUID: ARgD4si-5RsW5zhRgTmw5-dvPcupNIC9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTA3MDEzMyBTYWx0ZWRfXw0ZzwHzoN1qi RWFmUX6QSzbsv8a+zREfzUN//ueiMOlh8GTtu6CVVbstAx1PPj+NyO7Va5LqAb/35ad9NTw9Ejr JYEwwpM36tgawvzjDayZkpbiFzrPW3fsSRGYk4XI0WxCYKrTWT9NqE64PF1Z5GM7ITD1WlMx70d QAkzJk/Pu8X7lX1cf7mCxpJQYU/e2mXqhmlsLY+zQXggLjSlUZjnZeRvJGxcM7uQ1cEbf93TWVG CQC14GKgZsuiuBedkIOKtuaPwkOxql5o3bcK83h1YRtVUUBEmnrHUYlfMJ21TQA7rvD9ErvHsO6 o3ePU05j5MjRRc9JOhC6HnY9cr7fyE5bay/xFwNWXdnt+pqgN6MKirXdZxGpnfoRVnY2Zyrgmsy kHMaUjEaThkeVKpu+FLb2v1PEXeNbMHjEfFNiLoXShRL8r5nhvOpkFIKvFAJlqpPNH95yerzK54 Y55V0YFeE0oSYQHklpQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-07_03,2026-09-07_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1011 phishscore=0 spamscore=0 suspectscore=0 priorityscore=1501 bulkscore=0 impostorscore=0 malwarescore=0 lowpriorityscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609070133 X-Stat-Signature: cw6w7ery999ttq9kxccjcykknjis81ak X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 4BB8E8000A X-Rspam-User: X-HE-Tag: 1788783791-668135 X-HE-Meta: U2FsdGVkX1+sGJqYIdbogmbHR2BaO3UlJvawA9I6FYY/3Ipnu91SDBjuox2OPfmeCxRJQq6qg0g5IrgxJbPJfq3+InzWu9I4NN+EkMd7ZGCl9Rybr8SZ6vzuX+A/Q1o12ZqrtNI5YpGu+3aQwJhp7MOLIGucj2CE32AoRUGhV/pgslim3tygUoTlrqZahRnMmy5kvQ7/qt5tlLw1eQG01vnPFtYiH/xPjdnO9wO4KM/tOzDZKrQui/4NiLu+B+4Ro+0p1EV0w1AbINqB0gxleufDvKjjJ+oaTxHBTJHwz5kQtrMhNdUlNRXLnWkqQ/YDLAKA2tmu/56ty1UKdBfd1AmsKwvyLmFs4jCn6TqsQwGsc2PsUU7W/+Vn+vp5JO3buu1GIz5aD/kJFZjymp8Gs7YA+vrHssgSrCMsNuJRpfpvNXM0rC8OYUrPXAYW0yXW5suhMWMKGqHzGuPPN8MxYRTbYxk3d2D714vAA6ES5Wh169QyM4qnq73uHCE1fRXrBnZGsujK+I85x+X9UlGOLM4ex0199jypdzZDuDq6nYfX/ujUZKEhltw48/vHQ9pKrhZkg/CCQpD967Pw7+oQSWqO+VF7AuI4+u9IFlWJg/469bnWxptUweeBCoEaICMkA+90onJr9XprJcxZ8RARAATInYJ/RfhEks0HZ1rPe4mymvx6lYRXD8DTtWaTnh2UdbXyHap/rxc7YK/5eBPXBz/E7sx3BSjPiGCawR7zDzexRyCfVlLycK44wxjKDKmvz69NR0weEWxesQSoW1fQL5ZYy1CFgVKb8NQU6A+MZtDWv7KuONj5LzfObqG7xBLTeoQLjmURi2HvYFLQUuajqKqxyCTaeLt1//xlRibNcrG93+mq12Fo4DdFLTKVoboff/wQnAJE18YkIIocZZFVLbp7XMZVpgJh8vkrjaOhHWMoUFRH8Nw0L9/BMe7WYixfs1JQvFmgpHmgfFAXV4W KbDiicAE KQ0djkSIGWdlGBtKxUbbOiTUIA2ZmABnXH3+T3NqYkS/1JXIqZd5MtGSPU6SkFONXIAjY9GEfw2C7U+CKimaEdRgw0Kcm+vFR5Y23vOR0TaUwumFOPHy9dzxJDloOLTwkioD+3rBZiKI1Ej0FAPKB+XMNE4f4mgySviNh/wA0vW3ZaHfYTDo+DlLa1RmyItcACreQPLHKV2nIYQKM8QDswYYUbbRJffhWDaBYJxsU/o8A1MC4tQoIO7bdSQrJbQLqVPwXVv4ojWzGru/NvM9+4eo+lNLCyZBTrFAZXcnCEOcf84c5IQXkeuLu0mRB3gn46Bo+ Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/6/26 10:27 AM, Mike Rapoport (Microsoft) wrote: > handle_sthyi() allocates the buffer that receives the STHYI response > block before it is copied to the guest. > > This buffer can be allocated with kmalloc() as there's nothing special > about it to go directly to the page allocator. > > kmalloc() provides a better API that does not require ugly casts and > kfree() does not need to know the size of the freed object. > > Performance difference between kmalloc() and __get_free_pages() is not > measurable as both allocators take an object/page from a per-CPU list for > fast path allocations. > > For the slow path the performance is anyway determined by the amount of > reclaim involved rather than by what allocator is used. > > The only goto in that function does not unwind anything, it merely skips > to the exit when the function code is invalid. Turn it into an early > return so that the buffer can be freed with __free(kfree). > > Replace use of get_zeroed_page() with kzalloc() and free_page() with > kfree(). > > Assisted-by: copilot:claude-opus > Signed-off-by: Mike Rapoport (Microsoft) Yup, there's no alignment requirement anyway. Reviewed-by: Janosch Frank Looking at the kernel's sthyi.c there are a couple more locations we could change: I don't see a need for the syscall to allocate a page and the cache doesn't need page allocation either. We should even be able to have them byte aligned since they are never the destination for one of the diagnose instructions, a kvzalloc should be fine if I didn't miss something... Diag224 needs a 4k aligned 31-bit physical address for some reason so that needs GFP_DMA. diag204 is vmallocing anyway since subcode 7 uses logical addresses.