From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 885CEC2BA1A for ; Fri, 21 Jun 2024 07:33:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AF69F6B0376; Fri, 21 Jun 2024 03:33:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A2EE56B0374; Fri, 21 Jun 2024 03:33:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7E6F36B036C; Fri, 21 Jun 2024 03:33:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4FA8F6B035B for ; Fri, 21 Jun 2024 03:33:07 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 062B81A0AE6 for ; Fri, 21 Jun 2024 07:33:07 +0000 (UTC) X-FDA: 82254079614.16.CE995A9 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf06.hostedemail.com (Postfix) with ESMTP id C6DAA180007 for ; Fri, 21 Jun 2024 07:33:04 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QGRU40+h; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf06.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718955176; a=rsa-sha256; cv=none; b=xPQFpvX11CpG7qOW31Wtu/ccU71c1cGYnOpqEYlg6ndR3Vs4fkSsdQq7VgBsUYmVjQzimd r29mDC7o7XnLwFRAX5DDurHj5MFppXSZNWrM6k+tLq0c1Uhw+BKLx6cBbCqOqVzs1bkEm6 U1QRYvGBCxw6KkOqFEB42WIFlhlGbvg= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QGRU40+h; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf06.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718955176; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Bqd2pgnOZP6fdE4BQRa2Va/7Qsx+b1mw8cKvo7/G0Rg=; b=Zv/BQvkrDMUr24dM4d0EKGOKZqwq7fpLvgya9wZ4Hm2ARxQH9ubZYwp79py60mE3H13BCq SlmmL3r30JjOZH3Iv3hEXHbJRekK1/RR2CdGgtOiQO1ZLNPqPBFi2XALRjmeDvMCJJpE8O 63kfbUV++HE2Xuwakwuu9kPJ1RXASOo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718955184; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Bqd2pgnOZP6fdE4BQRa2Va/7Qsx+b1mw8cKvo7/G0Rg=; b=QGRU40+hGjvNy7X1xCqvpwHUrHiiqJ0VhdNZlkKyCd+9AHY2Z+QKajUYWp8NBV0dGsLkgS k2qLmUxXFq9nl2cM0ySwayRTTAJ7/UZx7aDKt9S9KHVZecGqVfpfdoZNz5WMAiwEn3LjGb D8dmnlpfHIzR0h6NCon6J70iPs2/IIE= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-557-v7_j-CCqNQCsq0tUiHrmbQ-1; Fri, 21 Jun 2024 03:33:00 -0400 X-MC-Unique: v7_j-CCqNQCsq0tUiHrmbQ-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-36536118656so728223f8f.1 for ; Fri, 21 Jun 2024 00:33:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718955179; x=1719559979; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Bqd2pgnOZP6fdE4BQRa2Va/7Qsx+b1mw8cKvo7/G0Rg=; b=YV9AUMLqNAD3lmiqc4BuCPHkbQmJzhKZ73wRho0AqualqczrOGpastJidC/0G1m+3N HmdTT7yalm1GZ6lhbpwPKCAiF8k2SVi11kU+55q629iHy2/YZHIUdgHLqVkcW93EKLG1 r7CknYnCnWBt98F+oARU7eN8crU0RQSwg6J8s/ORj+8654ufVrIqz/L5XIp1hlNzC0Bq USgtFLwURoGD0qBvrvAqLBDTKiq11KlSl80QVBVdamFk8Xv5dQOVd7YlaWp5LrdqBOxU BqwaBi4AF+7FzHULqbpRB0wapH6r15FITHlrcBrhrtGhb7FqUf7eBxeNdinjE0QIc26Y SjDQ== X-Forwarded-Encrypted: i=1; AJvYcCWeeLm7StKsMnQZXrJVon8bLyDvS8TwzPD5nqEY/GHDmaMkSdBPermsMxt9DcN527payIs4dS8/M1pGeM601TvWFQ0= X-Gm-Message-State: AOJu0Yyu+09H0rWIWHHRZckCW0WM4ujimPD2FaD/V4xze5zC+KK/wYeL ZGo/DNQUyI/ycS2m9g5GuB3Xrf/wMhADRS4ldUP1cxYwQbrHQHzqpTxL1BcZl8uF2NDIDrdasbk glJmUfk3oAFcx2EcyHZqZTuiCr8yRdLJDH01XgjgYuvyJxBtd X-Received: by 2002:adf:fd08:0:b0:362:4d2a:7bea with SMTP id ffacd0b85a97d-3631998f66fmr5462829f8f.62.1718955179290; Fri, 21 Jun 2024 00:32:59 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEprnZY7FnMxYF076ylYvUMCQtBhU6btjzD9tXYDUwp7sAA8hBINMtavaNjLa6GVaXRTEUeBw== X-Received: by 2002:adf:fd08:0:b0:362:4d2a:7bea with SMTP id ffacd0b85a97d-3631998f66fmr5462810f8f.62.1718955178810; Fri, 21 Jun 2024 00:32:58 -0700 (PDT) Received: from ?IPV6:2003:cb:c725:e600:4063:2059:fd18:9d65? (p200300cbc725e60040632059fd189d65.dip0.t-ipconnect.de. [2003:cb:c725:e600:4063:2059:fd18:9d65]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3663a2f8268sm908751f8f.79.2024.06.21.00.32.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Jun 2024 00:32:58 -0700 (PDT) Message-ID: Date: Fri, 21 Jun 2024 09:32:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 2/2] mm/migrate: move NUMA hinting fault folio isolation + checks under PTL To: Zi Yan Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton References: <20240620212935.656243-1-david@redhat.com> <20240620212935.656243-3-david@redhat.com> <3F1DAB9F-2CC0-4FED-AD5E-D013E19EB998@nvidia.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <3F1DAB9F-2CC0-4FED-AD5E-D013E19EB998@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: C6DAA180007 X-Stat-Signature: b58dxfhisujfq6oyyfaf7bd4oxnz1kzq X-Rspam-User: X-HE-Tag: 1718955184-23700 X-HE-Meta: U2FsdGVkX18mTUAtxdz0qCyxj2UfDd7TfusyrI0LsjpsUaFa8csJfrJr6l4DIm7IBksJ5avRLYEcP9hTL31FGgag7OCLX+kY3G4KXZ1XU2l3zh+Gcf5x3ZhYYJVLdbILx/a3vxwL7RNbFrAgCNBLErRIje+H51wCvPEGz1FMXhXPI836IPHfPtyln/N9KA8+lm8FNDP1HQMSwRmf8sUJ66YOBLm8o7CVsmGj7WRGsq633T0xC4iOYDpQbuj00eRksuw6fGfaKwHdr6+Zw6BJIrhy/cgd5qolkZoCaxexi1ysDrq8vdIkgerOvy69CPdAQln3sUqfV0KwFXsbzMZeTPZ+4eX5Ac+t8elQAaLrX0MccO+I1vCUfccTNLX79WyNo5sHw9qiTM+uB1QvUVUn36NSeS/de5/r/CQK+DA6oH4USaWYcwtCV8BdvuBmFh8rXUgM6bOEvt055KjynQg+Df+3YcGfmbk3zwk7+UkgdbQ/AP3O/cs98g20JGaEzr+OzlLuY6Qy7Bv43KeSAPv9ObDnkPGSPKifrjU3pJX7jYWAtGkiPIGFnvXb3rw3YAt5UjjY5tY05NHszbRHTrc+fxkzO9VB1ZH09Vqsk5hbAS44/9YtuxSG5X1JFitUoyvgRZKjI8qPsKSrj4X8m/EeSJ2GwdJOsTHxraP52NqfIPwIzTa/tvI3k0BsVg7N0skfY3O2i79O/+XdgK1U9DYAIMqH++XPoCLJRBRnLj7g+fFMYjfK4AhNsp3nCighsSh/GAFI16drNxjB/rP44PGAN8fqszDoHkhcoQEMtlVEME5aljOBT6fK97/pkFIEhlg7/xEue+3J6MN4K+MBjCkoDyjHzEBAAqcquLlU3hd3udJJw4foifE0jMcXbFwbRFPy9hyGq2SWnU/5gwMPM1XH7LB3UyHw+U6FwmWCzPvyfe3yWqjawDJjggzo69Hx1PEGuBUf6+XkknDWmym6KNY NXeW31Mh T6Yg7tnYAoQNmPAtpszUgCbeTChCS11KLNoBBLonzh3WvPqPuY8OwdIvafvribOnFIjg6nJAtJkK+y+okDNJk7EwES+3HDW4KPh0muVXeUmvdp5zgN1uXoovI7JPiJJPV2PdxysdbeaqlVdJLnwpD34jzUUAPl+suFnFTD7H58pHbUDHgeLlSJu1tK2KGyM71djJOnauAuySv+Dk/x3fgRHVzJ70jA1BbPrW9zcflH9QoEspy1fdSjivN2mFjTq24OWoucnnrB3GrXBI+vRsz6azjpYiTQRq198cntePZbL40/+XijazWXxglpEwohOxObx6pf5zBDS+4dbokYixOjdoiVl4MnjoHRAp4HAg8sfZRhpDVw9c1ZrLsMBrENIJCLIluoYv0r8EJD9M= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 21.06.24 04:05, Zi Yan wrote: > On 20 Jun 2024, at 17:29, David Hildenbrand wrote: > >> Currently we always take a folio reference even if migration will not >> even be tried or isolation failed, requiring us to grab+drop an additional >> reference. >> >> Further, we end up calling folio_likely_mapped_shared() while the folio >> might have already been unmapped, because after we dropped the PTL, that >> can easily happen. We want to stop touching mapcounts and friends from >> such context, and only call folio_likely_mapped_shared() while the folio >> is still mapped: mapcount information is pretty much stale and unreliable >> otherwise. >> >> So let's move checks into numamigrate_isolate_folio(), rename that >> function to migrate_misplaced_folio_prepare(), and call that function >> from callsites where we call migrate_misplaced_folio(), but still with >> the PTL held. >> >> We can now stop taking temporary folio references, and really only take >> a reference if folio isolation succeeded. Doing the >> folio_likely_mapped_shared() + golio isolation under PT lock is now similar >> to how we handle MADV_PAGEOUT. >> >> While at it, combine the folio_is_file_lru() checks. >> >> Signed-off-by: David Hildenbrand >> --- >> include/linux/migrate.h | 7 ++++ >> mm/huge_memory.c | 8 ++-- >> mm/memory.c | 9 +++-- >> mm/migrate.c | 81 +++++++++++++++++++---------------------- >> 4 files changed, 55 insertions(+), 50 deletions(-) >> >> diff --git a/include/linux/migrate.h b/include/linux/migrate.h >> index f9d92482d117..644be30b69c8 100644 >> --- a/include/linux/migrate.h >> +++ b/include/linux/migrate.h >> @@ -139,9 +139,16 @@ const struct movable_operations *page_movable_ops(struct page *page) >> } >> >> #ifdef CONFIG_NUMA_BALANCING >> +int migrate_misplaced_folio_prepare(struct folio *folio, >> + struct vm_area_struct *vma, int node); >> int migrate_misplaced_folio(struct folio *folio, struct vm_area_struct *vma, >> int node); >> #else >> +static inline int migrate_misplaced_folio_prepare(struct folio *folio, >> + struct vm_area_struct *vma, int node) >> +{ >> + return -EAGAIN; /* can't migrate now */ >> +} >> static inline int migrate_misplaced_folio(struct folio *folio, >> struct vm_area_struct *vma, int node) >> { >> diff --git a/mm/huge_memory.c b/mm/huge_memory.c >> index fc27dabcd8e3..4b2817bb2c7d 100644 >> --- a/mm/huge_memory.c >> +++ b/mm/huge_memory.c >> @@ -1688,11 +1688,13 @@ vm_fault_t do_huge_pmd_numa_page(struct vm_fault *vmf) >> if (node_is_toptier(nid)) >> last_cpupid = folio_last_cpupid(folio); >> target_nid = numa_migrate_prep(folio, vmf, haddr, nid, &flags); >> - if (target_nid == NUMA_NO_NODE) { >> - folio_put(folio); >> + if (target_nid == NUMA_NO_NODE) >> + goto out_map; >> + if (migrate_misplaced_folio_prepare(folio, vma, target_nid)) { >> + flags |= TNF_MIGRATE_FAIL; >> goto out_map; >> } >> - >> + /* The folio is isolated and isolation code holds a folio reference. */ >> spin_unlock(vmf->ptl); >> writable = false; >> >> diff --git a/mm/memory.c b/mm/memory.c >> index 118660de5bcc..4fd1ecfced4d 100644 >> --- a/mm/memory.c >> +++ b/mm/memory.c >> @@ -5207,8 +5207,6 @@ int numa_migrate_prep(struct folio *folio, struct vm_fault *vmf, >> { >> struct vm_area_struct *vma = vmf->vma; >> >> - folio_get(folio); >> - >> /* Record the current PID acceesing VMA */ >> vma_set_access_pid_bit(vma); > > Without taking a reference here, is it safe to call mpol_misplaced() on the folio > at the return? Can this folio be freed? As long as we are holding the PTL, the folio cannot get unmapped and consequently not freed. Note that if that would be the case (being able to get freed concurrently), even the folio_get() would have been wrong: if it could get freed concurrently, we would have to use folio_try_get*(). Thanks! -- Cheers, David / dhildenb