From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAAE8C61D85 for ; Fri, 24 Nov 2023 00:19:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0FB788D005B; Thu, 23 Nov 2023 19:19:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 084A88D0002; Thu, 23 Nov 2023 19:19:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E40A48D005B; Thu, 23 Nov 2023 19:19:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id CFDF68D0002 for ; Thu, 23 Nov 2023 19:19:46 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id B06101CAC4E for ; Fri, 24 Nov 2023 00:19:46 +0000 (UTC) X-FDA: 81490939572.01.719AFDA Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf17.hostedemail.com (Postfix) with ESMTP id 555FC40003 for ; Fri, 24 Nov 2023 00:19:43 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=qoMKvIi5; dmarc=none; spf=none (imf17.hostedemail.com: domain of rdunlap@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=rdunlap@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700785184; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hdx62OaweghTuxJKy40I6uvLAL8EQr33RCrXQ1/BSAM=; b=rb6Xvtg1o8gXDsNf+vDiJ448FwZrc8md8ZpKsz2iFXjosXFnvROFDmOX7ygF98rFBMrgAi lmx8NGF3e6v/7H7qIkpTj1ADbnRQdIXhAKaWwUjyZLCsm7hHt0NbvmQvVMAvCjGVpdjfbo r+28iMdcpgMpBZ4zPH+kdmxXCzCAiS0= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=qoMKvIi5; dmarc=none; spf=none (imf17.hostedemail.com: domain of rdunlap@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=rdunlap@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700785184; a=rsa-sha256; cv=none; b=ScKdcnKbXkYqisOp0oGlgbO41h0EbMyn/Vdjtj3Vz6/rNXSJbCzV47Bqv+AdutkgdkxMRo oubs96pLpOjSgQ4aZqLtek3hM2KqDiIDyCdxtBPn8WhrI7TTfM0K++x4DWnziB9Q5vFZLl VhWfsMxuEOAchijDwebrUR9/UCLTBEU= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=hdx62OaweghTuxJKy40I6uvLAL8EQr33RCrXQ1/BSAM=; b=qoMKvIi5r5oZJ2h7x8vFmUTFH/ 6RnF4ojppprty21w1nQzLV+gYTyUE4lCmMtNjsF2raI02Tj2zpioiEHk4QGyt4w80YieSspGf2fnF RdZRC9oVIcBI16G2r6MR/+OK8pEpqzFEY+VmTHuFOVKFA72Hxy3SU2K/MPEWO7wtkEbOOfJtCRU+t Fb+CxW/aGVJPIEp7iveJx5p/wbXkbqzEWI4vun00r/uijzTewRLZ4jBALwZ2C79tsCA5CFVU7WWfd rGLd+dPY6HGv0OOdqjDDJEBd7/1eXu2bHnuKHns+Wwyz2AEoYtVgn6u7VCekpLJN+iDWmcJTUKdYi FPaTQFTA==; Received: from [50.53.46.231] (helo=[192.168.254.15]) by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1r6Juy-005rtQ-0Z; Fri, 24 Nov 2023 00:19:36 +0000 Message-ID: Date: Thu, 23 Nov 2023 16:19:35 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] fs/Kconfig: Make hugetlbfs a menuconfig Content-Language: en-US To: Peter Xu , linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: Andrew Morton , Mike Kravetz , Muchun Song , linux-fsdevel@vger.kernel.org References: <20231123223929.1059375-1-peterx@redhat.com> From: Randy Dunlap In-Reply-To: <20231123223929.1059375-1-peterx@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 555FC40003 X-Stat-Signature: bb5yp6exr8qr7hw8akiedkydtzasqchs X-HE-Tag: 1700785183-255880 X-HE-Meta: U2FsdGVkX1/DvPjRIVGy2pVoyvz6jyIUjUbqf09+BNNXGIciTiYnb9Y5xWYBqqhrzEawEdv99stGtDkhhBrjgR2uajnY4llEOO3HwzTDPGQ4doqsYZWf5V10WGVd+/RX6jf3IwF0AQthTitV9bZybvWWcMW1adRhJOkesKmEFMHrnfh1Kg6tSMzjJNnJKBzy+2logUbtlGADnngAxFzcWaM9vqAQyJKhPXvCRUMEChgTEPhhZlM/60OuBMqOG8oTy3oWXv4QfkL1ZzTj/qjG3TDGMgg7IjUn65FZe8GP6avnGRzhmqZTblnL4B8pDirwIA/gJTd93+BMWcCtkAF1j1NVhkZAfX/zEbigWHUDtlISEomeMZ9lfE9YiYTOR/k5DuthNRJCNlgR/2hjlqlyR3L75sWx2NnfA5lkQEEkzSLUq7Wn8B0zPRXBccepEKJ+XN1xDEwi8A8Ta+9hOF6NYcYKqvwkzeS2tjdaUpoWYqDQpENsfli+D+qDKdYEhHT49M/IrZ7bwkHYWG7K0sZue5cyRtqx2+2tHWE59gY8ukHvSe/qNwCGs27+8lpHZ67bJncNR9jZy7FWNGq4Wp/rKQfmm5/1qdabovkpsVIDHaEiti2aFR3VlUNI2g4lU5+CAxa0dklNabWGOFuqcnOHmPzZghkA0HgCNkIQqgRBfKUIS5MpdZNrSmmxkS5DlQFq6qxf6I099iinpl5QLirHrqnZkfMiHKnljmAeYa/CoAmx4D3/xAuALarqcqCGo6VzEoDn5ztA+5GN8jlTXfI8o/1+zW0f4MSf5WP20w6qm5qaLnYCb8WZuD45dOtMEguEaIvcktOIye4ZUiSqJl3DWRTHLDKIOpw6DfXRWrIPJl5m6/830M6VokC1YaY/VJE8ETz2+z3C1CkcDI3+XZdY2Gy6E54P2YLvIK9gH3gO5IwxYXd/WXb9Jpnp0wDvcODQ73klg57Iu1Z2Bw6By1V Oev6Z9Tp 2sBI1+0L4y56lgk0qzfAWw+h0dazPg2fpVHY58AichJtlQZO3aKslNReUMP5s+9A7Wqf0GDmrR8hI4X8Wo5wu0vZpSNvm7t+vpgBHLm5NiijmY5S+iqh5odG9o5r1EQqG4cdDHFR5t5TE/14vZbv/4C8Wz7t/C5PCVzgAtM6FIOxy8XyeN+zLVBY72wXE32diLDI3SjApTu7r9bTEYAKpzgBopCVKBv8s7bm8lsxSfdjHnpk/vSbAOLuOASZVUyqzitTDEhic5pZRJQ+inq9vUCQhdQOioOrLUkYsTUkGcA4QdPbks0HOgBpd5SM11N7+1QR3uHU0h5l2TZ+Hsw9deh1LnohwtaWyKGluuFqIynzsl2YiCReYZtT2+Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: BTW: On 11/23/23 14:39, Peter Xu wrote: > Hugetlb vmemmap default option (HUGETLB_PAGE_OPTIMIZE_VMEMMAP_DEFAULT_ON) > is a sub-option to hugetlbfs, but it shows in the same level as hugetlbfs > itself, under "Pesudo filesystems". > Make the vmemmap option a sub-option to hugetlbfs, by changing hugetlbfs > into a menuconfig. > > Cc: Mike Kravetz > Cc: Muchun Song > Cc: linux-fsdevel@vger.kernel.org > Signed-off-by: Peter Xu > --- > fs/Kconfig | 20 +++++++++++--------- > 1 file changed, 11 insertions(+), 9 deletions(-) > > diff --git a/fs/Kconfig b/fs/Kconfig > index fd1f655b4f1f..8636198a8689 100644 > --- a/fs/Kconfig > +++ b/fs/Kconfig > @@ -254,7 +254,7 @@ config TMPFS_QUOTA > config ARCH_SUPPORTS_HUGETLBFS > def_bool n > > -config HUGETLBFS > +menuconfig HUGETLBFS > bool "HugeTLB file system support" > depends on X86 || SPARC64 || ARCH_SUPPORTS_HUGETLBFS || BROKEN > depends on (SYSFS || SYSCTL) > @@ -266,14 +266,7 @@ config HUGETLBFS > > If unsure, say N. > > -config HUGETLB_PAGE > - def_bool HUGETLBFS > - > -config HUGETLB_PAGE_OPTIMIZE_VMEMMAP > - def_bool HUGETLB_PAGE > - depends on ARCH_WANT_OPTIMIZE_HUGETLB_VMEMMAP > - depends on SPARSEMEM_VMEMMAP > - > +if HUGETLBFS > config HUGETLB_PAGE_OPTIMIZE_VMEMMAP_DEFAULT_ON > bool "HugeTLB Vmemmap Optimization (HVO) defaults to on" > default n > @@ -282,6 +275,15 @@ config HUGETLB_PAGE_OPTIMIZE_VMEMMAP_DEFAULT_ON > The HugeTLB VmemmapvOptimization (HVO) defaults to off. Say Y here to Is this small 'v' ^ a typo? thanks. > enable HVO by default. It can be disabled via hugetlb_free_vmemmap=off > (boot command line) or hugetlb_optimize_vmemmap (sysctl). > +endif # HUGETLBFS > + > +config HUGETLB_PAGE > + def_bool HUGETLBFS > + > +config HUGETLB_PAGE_OPTIMIZE_VMEMMAP > + def_bool HUGETLB_PAGE > + depends on ARCH_WANT_OPTIMIZE_HUGETLB_VMEMMAP > + depends on SPARSEMEM_VMEMMAP > > config ARCH_HAS_GIGANTIC_PAGE > bool -- ~Randy