From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9369C71157 for ; Wed, 18 Jun 2025 17:38:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 620236B009E; Wed, 18 Jun 2025 13:38:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5F7CC6B00A1; Wed, 18 Jun 2025 13:38:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 534BD6B00A2; Wed, 18 Jun 2025 13:38:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 454466B009E for ; Wed, 18 Jun 2025 13:38:10 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B15525B7C0 for ; Wed, 18 Jun 2025 17:38:09 +0000 (UTC) X-FDA: 83569229898.29.EFA0270 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf15.hostedemail.com (Postfix) with ESMTP id F3A54A001B for ; Wed, 18 Jun 2025 17:38:07 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=tMjYJJMN; spf=pass (imf15.hostedemail.com: domain of dakr@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=dakr@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750268288; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ksy71DBVbYK2izOfpBeLCIEG6pCGGeVt3z+tSB9ZIZI=; b=QDkmdRsJiUN1Tk4o7VSn/AXQlzxJHcB5ejlyDogvR/wZr+WOvvjE58Jgm+tg75EsW0PZlI KvpH9laHjyUAtiCyFInf/VPn95SFAUIbRgn29tqHGTynfwhsjXLd4LEC0XJsBZ9YycQG+w uhUHPGuQzmnKCMKhM06yHRSXEweubF0= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=tMjYJJMN; spf=pass (imf15.hostedemail.com: domain of dakr@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=dakr@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750268288; a=rsa-sha256; cv=none; b=dsDiiK/hOFRylq9rTJnd0cx/rmHF8QtGl2sL6Zntz94n73boRgW9b6gonQNrRCkUpUHAFV 5gwVEh+/1BZVIdYMoS9fGSSgFts9rcTCQplzvgWCOIEWw0bc095b+ejdq8ook6d+k8YwAm +1BGIwDsp8q/41Js0Yl/6ykkB5K4qiU= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id D5C10A525DD; Wed, 18 Jun 2025 17:38:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A2905C4CEF0; Wed, 18 Jun 2025 17:37:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1750268286; bh=iW9LufXJIvbvUBrzExqn4UB+Dl7RTb6MInZzRTsd/gE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=tMjYJJMNrwSXJJKi8YsQ2JJzCWZzP3aUZRw8z5zFfnRs1PXkskRU1Uy/yMHhyjNDZ aYyZvuF39WCJ0xfMW8VeWBs9XfgsxQPF+pfQhST331PYbTu5SMofDob0J6zFVIuQiD xSNdKxYMYh7U71x0eBK5yeKhMdcB9wxpVvFZ3qE1TB+ZhJbwwiFeANK7gl5OpRQQfV HSlnFlW678e57cd/6TC7LCfpEXAcYmojJXL5MBRF9yft0mAOs/z5mLjzxKGeOOJg26 w8zV/ffBD4jrvfjL7VmhG/U0wMlv2WpMERp1XRhsOUdVpC+tBSoJP0eHtbj0yJFIBz Dl2uipre8dPhQ== Message-ID: Date: Wed, 18 Jun 2025 19:37:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v12 4/6] rust: enable `clippy::as_underscore` lint To: Tamir Duberstein Cc: Masahiro Yamada , Nathan Chancellor , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Andreas Hindborg , Alice Ryhl , Trevor Gross , Greg Kroah-Hartman , "Rafael J. Wysocki" , Brendan Higgins , David Gow , Rae Moar , Bjorn Helgaas , Luis Chamberlain , Russ Weight , Rob Herring , Saravana Kannan , Abdiel Janulgue , Daniel Almeida , Robin Murphy , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , FUJITA Tomonori , Nicolas Schier , Frederic Weisbecker , Lyude Paul , Thomas Gleixner , Anna-Maria Behnsen , Benno Lossin , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , John Stultz , Stephen Boyd , Lorenzo Stoakes , "Liam R. Howlett" , Breno Leitao , Viresh Kumar , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-pci@vger.kernel.org, linux-block@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, netdev@vger.kernel.org, linux-mm@kvack.org, linux-pm@vger.kernel.org, nouveau@lists.freedesktop.org References: <20250615-ptr-as-ptr-v12-0-f43b024581e8@gmail.com> <20250615-ptr-as-ptr-v12-4-f43b024581e8@gmail.com> From: Danilo Krummrich Content-Language: en-US In-Reply-To: <20250615-ptr-as-ptr-v12-4-f43b024581e8@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: F3A54A001B X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: p5ieuaqqhhij8xxz6k1ntkwm7h4k3jk5 X-HE-Tag: 1750268287-731210 X-HE-Meta: U2FsdGVkX1/cuwNisxdcs5oH/Ju/ZJcNFYeOHj0nWccXJhTqFHg81LzTJYgkaPjWyS7m9BrmGTXsSUTUmstYfPdO3i4gM/5Uu/ekNw04S8NhkmIgO7LHaaYZYP8w4rDrJiIxMCZ1lcYl5OAvhf7xlLD9Z/wxcLGzLPSXBeZ7CSsPeIE6I2EmdyWSO2Wo5A2nQ15KKGsEsgz2L+0wyaukOo9na4VxCKHTkwp8/7t6x6tVK84BJItPbO890mOjhMzZ3goZc9zKgSaLuYr2l7nH6DCUd4XFWe+w6jZhA2XiNKYnnu14Wn+p4INwf1vGGSesgNKdmkTIkyOO/bA3ydiASOAp4u1ITDmT72MhXLTzrKmPPc6/u5D9rYCGWDdMpTTnXDV7JFIGwHMntSF1P6w9g7waPtoteUiZBGeP2D1HdIo46Nja5mjk63kyUUz3//M2QrjmluH/LzsQKnkXZSxSj+aw/rRfmTqAufm7bvX1PZYuCAImIZPj4urgA0SfKciuKNXfx8eS7nhuQMUdaDFNhSXA/MM6wd8+B7BsWQqRmPhGoHvthRqpNjlkMM4xDCvYATxU8HWJhFCnV6SHXgf7GCrYSO0rzHjHPPCAvdXuzr70GO7K+dx3QhTXvDYhIpPatJkU1g+Au/Tabt5F1LEsSgnXWQIOLgOqGUauXOPoyMTzzhY9sJ/90f8QI/7gLvvtI0u3UhL8vp54Pdr0OgUp5E3K14VYlyZ+v0FzgsNL/e++PthPuiROJtO8YI3xHR8rSDW6SuhdhiP1aasGC0ICxPbbXn3Xp7cwG9gkXZojpG6+mL6Im2EZNZXkNyB4j4gxhMa7nPtUwHsPIbDEVjSW/MrXbkgiVJKRelNAH2c+D1mZuCke2618jsuCDpZKpUPEPuo8N1jCb5spZ3qYKUIRmjAhfns3Qtu/czaxbVzwD2+ufNKcf2Tzad5Dbdc4H8lmYhBqEK7REPwFNfqYp+9 P/n4mNnd Ub9F7EeuZQHSSKphgfTCLCjewFeZIsXEA2BOCdryVTb/hpcug5YGLi9BwrxrQ3Q7cwKvcUoMnWEtj8KpBHn1eYO9Zg/1tVlWL5j0GCaVwuUtrG9XY0NUDaj7o0ccvcYsFuYMwzs1dp3vSguvLt2wWgMGV4PEp6KL473bbBxnwoVf1vjWTqNnZZYTuzcJzDcZiTkr1hSY8K9sKC0eFZk1xe2BHSmrNTDVKrOjRhPzU+nBEOQvlaNY6q2zIrqDXecST78y+xfDloJyNlPC25gF8tVu86BYoLVmVao5b1lE3NBiAolRHUQsvLhEDqIpYrSkRTzq1Z25JkSTE0jFzJ91tfOAd6zDkjnEGlBK0Ok+TnmbgHo4Th3ArvLU66w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/15/25 10:55 PM, Tamir Duberstein wrote: > diff --git a/rust/kernel/error.rs b/rust/kernel/error.rs > index afcb00cb6a75..fd7a8b759437 100644 > --- a/rust/kernel/error.rs > +++ b/rust/kernel/error.rs > @@ -153,7 +153,7 @@ pub(crate) fn to_blk_status(self) -> bindings::blk_status_t { > /// Returns the error encoded as a pointer. > pub fn to_ptr(self) -> *mut T { > // SAFETY: `self.0` is a valid error due to its invariant. > - unsafe { bindings::ERR_PTR(self.0.get() as _).cast() } > + unsafe { bindings::ERR_PTR(self.0.get() as isize).cast() } Shouldn't this be `c_long`?