From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8CD3C3DA49 for ; Tue, 16 Jul 2024 10:42:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 607B86B0085; Tue, 16 Jul 2024 06:42:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 590766B0088; Tue, 16 Jul 2024 06:42:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 432286B0089; Tue, 16 Jul 2024 06:42:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2759C6B0085 for ; Tue, 16 Jul 2024 06:42:11 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 9B91A141659 for ; Tue, 16 Jul 2024 10:42:10 +0000 (UTC) X-FDA: 82345276020.12.2F9804A Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf04.hostedemail.com (Postfix) with ESMTP id D9E3040003 for ; Tue, 16 Jul 2024 10:42:08 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf04.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721126491; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cegXjSkyOYbDjU6cjElIjhj9l3hhGzL2op6r8BCQRaY=; b=uqRz2ugTO7jprAazP07UojM7KZEUv/vtWueXIQ6YTZ6L1+M7ln47Di99QwYBZE1U20mRb2 SO784AlIc4KpbdkNKahx4hxLg1npCqBfvl5K7Th4RdHdhYjoMpIWlHwPeHSwqVU0xICOAZ X1XH9VmL7qOPDAjFysez2Kw8eW83k3I= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721126491; a=rsa-sha256; cv=none; b=paGwPZxw11znJrD1doQvQq6WKHLxrbqTGr7l1gPFkQRxJ4hyGqpe6JKzFBifttVKxXBIdi b20cgDhJg1TJJ9EqMQ81O5mEhHBM8We3ffSjSoZEpk1rA1KIsdj16audoNl1HBkKMCwOaL FUizRAaynDcns+JHj8ZG/j6Am46vkv8= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf04.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 644EA1063; Tue, 16 Jul 2024 03:42:33 -0700 (PDT) Received: from [10.163.52.225] (unknown [10.163.52.225]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A5F513F762; Tue, 16 Jul 2024 03:41:58 -0700 (PDT) Message-ID: Date: Tue, 16 Jul 2024 16:11:54 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 20/29] arm64: enable POE and PIE to coexist To: Joey Gouly , linux-arm-kernel@lists.infradead.org Cc: akpm@linux-foundation.org, aneesh.kumar@kernel.org, aneesh.kumar@linux.ibm.com, bp@alien8.de, broonie@kernel.org, catalin.marinas@arm.com, christophe.leroy@csgroup.eu, dave.hansen@linux.intel.com, hpa@zytor.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, maz@kernel.org, mingo@redhat.com, mpe@ellerman.id.au, naveen.n.rao@linux.ibm.com, npiggin@gmail.com, oliver.upton@linux.dev, shuah@kernel.org, szabolcs.nagy@arm.com, tglx@linutronix.de, will@kernel.org, x86@kernel.org, kvmarm@lists.linux.dev References: <20240503130147.1154804-1-joey.gouly@arm.com> <20240503130147.1154804-21-joey.gouly@arm.com> Content-Language: en-US From: Anshuman Khandual In-Reply-To: <20240503130147.1154804-21-joey.gouly@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: D9E3040003 X-Stat-Signature: 9thmhidyr4fcjeiw7n49ihmy4b6kwmy4 X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1721126528-538556 X-HE-Meta: U2FsdGVkX19T89kQYNU2F7d8f0hmU/3Ex8/qm4CF2tc1EOBNzeR5ss8nb4rKquQy+rU9qiMCIYsj2XiBWUNlD/pf3Ig0+7AI1RWcAic8u5t5v6lJnmgkcSjnvYh3lZQ4zY3Dy1me5W2si9L7IbQGeucBy9Nr9Bl55zpuTSs+j7vCBeQOLaA21TPvlHEpv2e2MeJa2g4bWbF3umBUp+H/gjF1jDHhjlZv4aGOQRKqSA5Krw235zza0ldZfjQ1TZESnNTmQC4tijMbi6Z1d40qrdRtpJAE4ZFHx7WrQP1R5X4EbYsKcOHxFFcs4Vr+TyADF764uB/gWay+UL5m1H+1GmJqpZfOSF3G/Jj9OxYkkWHlpEVY0rxWHf8HmlOOI8b/wL3vbDu1w/0gp9EaEZoVQ/RREJrWDAtaMVz/J2mpI9FB9bGazF/QEwKKpeTMJHYoIak9sW+SPic1tQnKqJiCSj4h5xECrmFhKDhgd+6ctETFFRE7X0quQFQAc+PnPd/lq2hzpJWxAca6ocPoSJWc6ZIOCJeboJcnTzr9Mj6D/yaauzYOaPdDjm6ru6ggxXzymKhjxu/Bk1wu/alSkO6jol+EEP/HVq3J6oDTC6CqW6WDF/SDeHG4Zmai+evRwRZUwPikZWGNKejqtCWINHBwVGcNhmK3LxsO7VFq6n6XuIU1jQjfMTcXAJ5s4VYLYQUZA1wT88aJXni9Ag/nguxUjc40oQcrjUE4reRCM0f1hiY+giE+QeoHTtjvVo8m3ot4zThFpxtzvwY4PpwfsD5zzddBKZNWDB9dBAMiUoj7TsemJFTOvNhuQ4coDtzPvX5HD3a3UydmG56tfMwHsugceGbKxY9pQqdyNWKplTlH32ZJcz7GobKddxkBpcQyh7U6LlGGBCYBWhfrtrp8WdJxNw9F9i3TDCPMPiw/UZ6MlZkVJt7t+MCqUe6er4VGFHeJYWx32GSl09cmwhGcU4T /qazdn91 TvoABg3eMwXAqFoxyqG8ggx3iccTwTVJKGSOsvSne3si0AapzVvnRU03kzXxONBQKG80Nwkiw8envwPjibHQesJJXvOQy1VbQjr1H8DSJrDVhRULNt1PsJ8ueHOj1BN6Zy2LQccelHLmD6o//NP1F9/PMgyTfU8hfyDL/X34lFRVc6xaiZ+05gp7khW772PhyJ+81gh/HNk21TeUOJix48rY0L1YEeBIQG4nVMjhQ6dPHWzYYpqvxraehszThgvTXafwtBThFgILDX7Y= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/3/24 18:31, Joey Gouly wrote: > Set the EL0/userspace indirection encodings to be the overlay enabled > variants of the permissions. Could you please explain the rationale for this ? Should POE variants for pte permissions be used (when available) instead of permission indirection ones. > > Signed-off-by: Joey Gouly > Cc: Catalin Marinas > Cc: Will Deacon > --- > arch/arm64/include/asm/pgtable-prot.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/include/asm/pgtable-prot.h b/arch/arm64/include/asm/pgtable-prot.h > index dd9ee67d1d87..4f9f85437d3d 100644 > --- a/arch/arm64/include/asm/pgtable-prot.h > +++ b/arch/arm64/include/asm/pgtable-prot.h > @@ -147,10 +147,10 @@ static inline bool __pure lpa2_is_enabled(void) > > #define PIE_E0 ( \ > PIRx_ELx_PERM(pte_pi_index(_PAGE_EXECONLY), PIE_X_O) | \ > - PIRx_ELx_PERM(pte_pi_index(_PAGE_READONLY_EXEC), PIE_RX) | \ > - PIRx_ELx_PERM(pte_pi_index(_PAGE_SHARED_EXEC), PIE_RWX) | \ > - PIRx_ELx_PERM(pte_pi_index(_PAGE_READONLY), PIE_R) | \ > - PIRx_ELx_PERM(pte_pi_index(_PAGE_SHARED), PIE_RW)) > + PIRx_ELx_PERM(pte_pi_index(_PAGE_READONLY_EXEC), PIE_RX_O) | \ > + PIRx_ELx_PERM(pte_pi_index(_PAGE_SHARED_EXEC), PIE_RWX_O) | \ > + PIRx_ELx_PERM(pte_pi_index(_PAGE_READONLY), PIE_R_O) | \ > + PIRx_ELx_PERM(pte_pi_index(_PAGE_SHARED), PIE_RW_O)) > > #define PIE_E1 ( \ > PIRx_ELx_PERM(pte_pi_index(_PAGE_EXECONLY), PIE_NONE_O) | \