From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F548C3DA42 for ; Wed, 17 Jul 2024 09:01:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A950B6B0082; Wed, 17 Jul 2024 05:01:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A1DDA6B0083; Wed, 17 Jul 2024 05:01:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8706A6B0092; Wed, 17 Jul 2024 05:01:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 6AAF26B0082 for ; Wed, 17 Jul 2024 05:01:21 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id A759E1609A4 for ; Wed, 17 Jul 2024 09:01:20 +0000 (UTC) X-FDA: 82348650720.10.94967A8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf10.hostedemail.com (Postfix) with ESMTP id 485A1C0007 for ; Wed, 17 Jul 2024 09:01:18 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XMbpEB5t; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721206858; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4whu2Jila3KV0H07+HRRBzZYVtq7DRMPfPg+ykzdDfc=; b=1BrFZAYhl+ObR5+4taL/y8Wo5j6dwjVUaVQNDy1Uslck0mc1JMu5u6i4317uot0mzOC/T7 qrlj2qOrOz9fLCFk+FzdzEtSw3bT6YSZ5FFt/0Ip6DuT8YTMDzdc5RAE38JfLYcqgP6++C 0/s3+tYqcHIGfvYvbgp1U84UQW2jNUA= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XMbpEB5t; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721206858; a=rsa-sha256; cv=none; b=50k0it5zpFGzym6S1Y5mNSlPnjHxni6pMRTavqp5plHX2fbasz/9p54P7VsoERGzAMu9Q7 3KVheocIFV9NE79aUYb7APp8S4QjuXRw+IEODmq2+byNRdIKI1bHMYiqANVUIVO9qxebX8 oSIDlj88zXjwuvXdLSveDVqiKzsEMaQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1721206877; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=4whu2Jila3KV0H07+HRRBzZYVtq7DRMPfPg+ykzdDfc=; b=XMbpEB5t9GLWd8ZNwKp6WgQuMFvnkj8NBNkzaUopBkwcyB2FjSokTZLObcbIFyZhCcCoX/ yVh6KwVtgfD1B5q9VHSp2bvOTxEUC+tpRncTv67X9ToPocCqqn51fj0Gg305zzz4sMedcP UugnsObAPMyopSp0DPGyBifd4SoIgE4= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-504-Ni2gn4obMgyJeeKurR0sYA-1; Wed, 17 Jul 2024 05:01:13 -0400 X-MC-Unique: Ni2gn4obMgyJeeKurR0sYA-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4266945770eso43118925e9.2 for ; Wed, 17 Jul 2024 02:01:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721206872; x=1721811672; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=4whu2Jila3KV0H07+HRRBzZYVtq7DRMPfPg+ykzdDfc=; b=GD+t6bA/WEKRQmzs2HayPMSh+um37JavM9m0CsVh71PzsNdEZgjeU80+nhcCLaCI9M YfZfZ+LEV9WkUhl5ye4WjX6uf52CW/xDR2QXcJSE63kL4xa6xy/ko+mzmWVyMi3tMF+U HiTt0pINdfiofaP9pfWdOe3GEOVLzC7wlgHH8nxRYpcSpkTNQ+e98PrjIVjm1kXemvWN cv5MJt3WLZnCa3O8PdGPYsfflDDnjdGbfXwcCBLYq9XTzxiJiBrN424pxdU0GcpssCoq 6KOFC+uVJmL9IjqEL/oEk1SS3AHZW9wq3e24a4wHMpqnKf5nlkpBvP9fDtSoDpWoxZzF MOKg== X-Forwarded-Encrypted: i=1; AJvYcCXzcgDSQPnbfAs4NTjDOzfosGJARnuo3iKec1eSR8EFe8LhYeBx9wte2EYxoYQNaFe6SMjBljKU1DcbdaqJf40EBEw= X-Gm-Message-State: AOJu0YyGt+shnZ9Dcux7w8uIi5+E0HnNRrtdF+Rq8zo7pR3KR6ufi+xt uY9mPFy+CQLPeFQRWlKCadxdg/tHugoUQJ03taFvDdhRlz+K4RtVG8/EiCyaxLkezGsNPFOEk3T yxwnzJdfPqxAJUCjGb1mrM7a+axD0x+YDxBEpVXZD3aJQtadr X-Received: by 2002:a5d:4286:0:b0:367:4dce:1ff7 with SMTP id ffacd0b85a97d-3683160059bmr886531f8f.6.1721206872523; Wed, 17 Jul 2024 02:01:12 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEnbr3y6fu4cF3gZaIX+vjPt8ec9OK6exUHqYFxBVTNQXPEJNiV08SzJOAmv94N8Nncl303Vg== X-Received: by 2002:a5d:4286:0:b0:367:4dce:1ff7 with SMTP id ffacd0b85a97d-3683160059bmr886507f8f.6.1721206872052; Wed, 17 Jul 2024 02:01:12 -0700 (PDT) Received: from ?IPV6:2003:cb:c714:c00:b08b:a871:ce99:dfde? (p200300cbc7140c00b08ba871ce99dfde.dip0.t-ipconnect.de. [2003:cb:c714:c00:b08b:a871:ce99:dfde]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3680dafbe9esm11096103f8f.78.2024.07.17.02.01.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Jul 2024 02:01:11 -0700 (PDT) Message-ID: Date: Wed, 17 Jul 2024 11:01:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/memory-failure: fix VM_BUG_ON_PAGE(PagePoisoned(page)) when unpoison memory To: Miaohe Lin , Andrew Morton Cc: nao.horiguchi@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240712064249.3882707-1-linmiaohe@huawei.com> <20240712140921.9aa90b18d22e67417d59dfc1@linux-foundation.org> <8fe349f9-d3d3-65ab-6045-da0bd19249ea@huawei.com> <00e18339-d911-4332-8732-e31bcecbf823@redhat.com> <5f8107e2-2b37-d899-f7f2-5a6093d8b089@huawei.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <5f8107e2-2b37-d899-f7f2-5a6093d8b089@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 485A1C0007 X-Stat-Signature: q8m5637f34tgqyjieo4waupekmmno36a X-HE-Tag: 1721206878-90395 X-HE-Meta: U2FsdGVkX196iGoBNyJsmml6350kntlQCWRb50t/7M2T13eD7AsTt3mBdjZO4l2p2jbrAjRHAoJtmLD+GlXFVgAl6fYxENDGhYXIRKmUOjWjD90RSRlyqbIjF/tdLYY+GNE8tSxiCwILfSeSKAI6+G+emdxIfkJlFYiNSSEurmH9UF15rTgTLToSYjZ0uDt/Wh9SCG7u47v8WPI/IdxM9BUDzzZE2gv8HWuxB/2XVwpnYGiv47KRBBh/X9lxZ6/oMZTPTHTNLUo8heJKekjFq4xq83QLBLuEg2lcEQGGxlv1nKaqVZjWMUgABeujludIUYpJcdBeQxSj0nf1FWuRl78bCHJYcWHL6xT6tUYc0HPJa2p1huvHFP3X4WBFrbcV1X4LbC+EgezZWB413JpubLR9sz8CkrgD1e8BVtS9eEM7RJEcxo7M/wlpVbOs1jmMEwqAoW7MTNGMQ0f3cNOIH21h5nlaWz2uP4Al/Id4sw//Fh+gyJ4TiFD+A3amllc+e9U9hTWSBCy/LJSOZC6AJnnWntXcKMSwk2nzdDd8RrmkO7WjDytsuvZiFgfgRpwNfQ5AyR/9bl7fadMacIWuJxKrYal+L5aU93hs0feOcW8XfQpxoZ1TRkzlqa9Veg/UKielsIz0S4c36lQdg9k8m/RK5IpONq3baNrUOVEg/VXEfZ1BYUsbDUNy+bAI5H7QEM083GGqF+JMYe5onpFJJLgHs1KbTx0sYdxbPFX+kbXHdb2q9eHWiaVQQPlqpBl3Txmr3XAvvbgLs6MswWfRnVqd48mJL06L0h1NgLEIjEqDzk3mfMoWAWirdCD4TnTIIsoIg5lA6VefkGDWjUc/P9KAatZb6hMQFSLhcb3RDNycMSsZ/gNnXX79osj67Y48Wl2TDjrNAPTldLNNUBP26Ufu2f9xWdSLy+q7WeiaZrxhM8gG9XKJAmGNAeTm9zSJ5Mu9dJQUcGKuK4pXRi3 Zcp1nTTF 7uggjUuFJosq4ohpRbIJKdeuvGBeLCVLVTf/GQ6tyfeVE/Pw2efMLuWcG9WX9gbNLW2ozyjPZFFcPmWyKQ3WZioYbZA84svAHC/3jgNdit127QngUebvVOC1MVBQjxN07VX9Y2APRtrCLCSJ971gNG3ZTjuUcvrvrAx5wAUKDRVZhMj1DglHSmvkf63NJkSVvVFc/wTXTziADKe29O+tUA+pJavuTJdcUPn3D+H1KM9ZGxBbi7fDjoY2FPvk+HhYnlkymgH0SfRKh0oN2K8UeqQEE7iAiMq0pJgc6N3rjaPKv1ZzxrQmHYmn81lQCU3FGvCxSQo8cQHeexTHe9vI66mwnzPyPsfX52HNWFvrrXaael7sZyXtZDkbNJvsynX+Rp9I7YU2Tb6Oyxij0D6bcXYkQPVGbQ2kK858g+6trKoJ1d4obRTa3FWkmmG7B982w4OudPGhXj857oWrB1PcOXrP3TsAmT9lst4jRFO3ZUACkb1pUjkIzU5agbadIQ2nmF/VZ+GYCSLCGtDLTXPlmAG3XlnOEVGZDdFYi X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 16.07.24 04:34, Miaohe Lin wrote: > On 2024/7/16 0:16, David Hildenbrand wrote: >> On 15.07.24 08:23, Miaohe Lin wrote: >>> On 2024/7/13 5:09, Andrew Morton wrote: >>>> On Fri, 12 Jul 2024 14:42:49 +0800 Miaohe Lin wrote: >>>> >>>>> When I did memory failure tests recently, below panic occurs: >>>>> >>>>> page dumped because: VM_BUG_ON_PAGE(PagePoisoned(page)) >>>>> kernel BUG at include/linux/page-flags.h:616! >>>>> Oops: invalid opcode: 0000 [#1] PREEMPT SMP NOPTI >>>>> CPU: 3 PID: 720 Comm: bash Not tainted 6.10.0-rc1-00195-g148743902568 #40 >>>>> RIP: 0010:unpoison_memory+0x2f3/0x590 >>>>> RSP: 0018:ffffa57fc8787d60 EFLAGS: 00000246 >>>>> RAX: 0000000000000037 RBX: 0000000000000009 RCX: ffff9be25fcdc9c8 >>>>> RDX: 0000000000000000 RSI: 0000000000000027 RDI: ffff9be25fcdc9c0 >>>>> RBP: 0000000000300000 R08: ffffffffb4956f88 R09: 0000000000009ffb >>>>> R10: 0000000000000284 R11: ffffffffb4926fa0 R12: ffffe6b00c000000 >>>>> R13: ffff9bdb453dfd00 R14: 0000000000000000 R15: fffffffffffffffe >>>>> FS:  00007f08f04e4740(0000) GS:ffff9be25fcc0000(0000) knlGS:0000000000000000 >>>>> CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033 >>>>> CR2: 0000564787a30410 CR3: 000000010d4e2000 CR4: 00000000000006f0 >>>>> Call Trace: >>>>>   >>>>>   unpoison_memory+0x2f3/0x590 >>>>>   simple_attr_write_xsigned.constprop.0.isra.0+0xb3/0x110 >>>>>   debugfs_attr_write+0x42/0x60 >>>>>   full_proxy_write+0x5b/0x80 >>>>>   vfs_write+0xd5/0x540 >>>>>   ksys_write+0x64/0xe0 >>>>>   do_syscall_64+0xb9/0x1d0 >>>>>   entry_SYSCALL_64_after_hwframe+0x77/0x7f >>>>> RIP: 0033:0x7f08f0314887 >>>>> RSP: 002b:00007ffece710078 EFLAGS: 00000246 ORIG_RAX: 0000000000000001 >>>>> RAX: ffffffffffffffda RBX: 0000000000000009 RCX: 00007f08f0314887 >>>>> RDX: 0000000000000009 RSI: 0000564787a30410 RDI: 0000000000000001 >>>>> RBP: 0000564787a30410 R08: 000000000000fefe R09: 000000007fffffff >>>>> R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000009 >>>>> R13: 00007f08f041b780 R14: 00007f08f0417600 R15: 00007f08f0416a00 >>>>>   >>>>> Modules linked in: hwpoison_inject >>>>> ---[ end trace 0000000000000000 ]--- >>>>> RIP: 0010:unpoison_memory+0x2f3/0x590 >>>>> RSP: 0018:ffffa57fc8787d60 EFLAGS: 00000246 >>>>> RAX: 0000000000000037 RBX: 0000000000000009 RCX: ffff9be25fcdc9c8 >>>>> RDX: 0000000000000000 RSI: 0000000000000027 RDI: ffff9be25fcdc9c0 >>>>> RBP: 0000000000300000 R08: ffffffffb4956f88 R09: 0000000000009ffb >>>>> R10: 0000000000000284 R11: ffffffffb4926fa0 R12: ffffe6b00c000000 >>>>> R13: ffff9bdb453dfd00 R14: 0000000000000000 R15: fffffffffffffffe >>>>> FS:  00007f08f04e4740(0000) GS:ffff9be25fcc0000(0000) knlGS:0000000000000000 >>>>> CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033 >>>>> CR2: 0000564787a30410 CR3: 000000010d4e2000 CR4: 00000000000006f0 >>>>> Kernel panic - not syncing: Fatal exception >>>>> Kernel Offset: 0x31c00000 from 0xffffffff81000000 (relocation range: 0xffffffff80000000-0xffffffffbfffffff) >>>>> ---[ end Kernel panic - not syncing: Fatal exception ]--- >>>>> >>>>> The root cause is that unpoison_memory() tries to check the PG_HWPoison >>>>> flags of an uninitialized page. So VM_BUG_ON_PAGE(PagePoisoned(page)) is >>>>> triggered. >>>> >>>> I'm not seeing the call path.  Is this BUG happening via >>>> >>>> static __always_inline void __ClearPage##uname(struct page *page)    \ >>>> {                                    \ >>>>     VM_BUG_ON_PAGE(!Page##uname(page), page);            \ >>>>     page->page_type |= PG_##lname;                    \ >>>> } >>>> >>>> ? >>>> >>>> If so, where's the callsite? >>> >>> It is BUG on PF_ANY(): >>> >>> PAGEFLAG(HWPoison, hwpoison, PF_ANY) >>> >>> #define PF_ANY(page, enforce)    PF_POISONED_CHECK(page) >>> >>> #define PF_POISONED_CHECK(page) ({                    \ >>>     VM_BUG_ON_PGFLAGS(PagePoisoned(page), page);        \ >>>     page; }) >>> >>> #define    PAGE_POISON_PATTERN    -1l >>> static inline int PagePoisoned(const struct page *page) >>> { >>>     return READ_ONCE(page->flags) == PAGE_POISON_PATTERN; >>> } >>> >>> The offlined pages will have page->flags set to PAGE_POISON_PATTERN while pfn is still valid: >>> >>> offline_pages >>>    remove_pfn_range_from_zone >>>      page_init_poison >>>        memset(page, PAGE_POISON_PATTERN, size); >> >> Worth noting that this happens after __offline_isolated_pages() marked the covering sections as offline. >> >> Are we missing a pfn_to_online_page() check somewhere, or are we racing with offlining code that marks the section offline? > > I was thinking about to use pfn_to_online_page() instead of pfn_to_page() in unpoison_memory() so we can get rid of offlined pages. > But there're ZONE_DEVICE pages. They're not-onlined too. And unpoison_memory() should work for them. So we can't simply use > pfn_to_online_page() in that. Or am I miss something? Right, pfn_to_online_page() does not detect ZONE_DEVICE. That has to be handled separately if pfn_to_online_page() would fail. ... which is what we do in memory_failure(): p = pfn_to_online_page(pfn); if (!p) { if (pfn_valid(pfn)) { pgmap = get_dev_pagemap(pfn, NULL); put_ref_page(pfn, flags); if (pgmap) { ... } } ... } -- Cheers, David / dhildenb