From: David Hildenbrand <david@redhat.com>
To: Peter Xu <peterx@redhat.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Cc: Andrea Arcangeli <aarcange@redhat.com>,
Mike Rapoport <rppt@linux.vnet.ibm.com>,
Jerome Glisse <jglisse@redhat.com>,
Alistair Popple <apopple@nvidia.com>,
Yang Shi <shy828301@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Miaohe Lin <linmiaohe@huawei.com>,
"Kirill A . Shutemov" <kirill@shutemov.name>,
Matthew Wilcox <willy@infradead.org>,
Hugh Dickins <hughd@google.com>
Subject: Re: [PATCH 3/5] mm: Drop first_index/last_index in zap_details
Date: Thu, 2 Sep 2021 09:22:07 +0200 [thread overview]
Message-ID: <df28392f-faa3-5677-5e49-c56e297db578@redhat.com> (raw)
In-Reply-To: <20210901205622.6935-4-peterx@redhat.com>
On 01.09.21 22:56, Peter Xu wrote:
> The first_index/last_index parameters in zap_details are actually only used in
> unmap_mapping_range_tree(). At the meantime, this function is only called by
> unmap_mapping_pages() once. Instead of passing these two variables through the
> whole stack of page zapping code, remove them from zap_details and let them
> simply be parameters of unmap_mapping_range_tree(), which is inlined.
>
> Reviewed-by: Alistair Popple <apopple@nvidia.com>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
Looks good, thanks
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2021-09-02 7:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-01 20:56 [PATCH 0/5] mm: A few cleanup patches around zap, shmem and uffd Peter Xu
2021-09-01 20:56 ` [PATCH 1/5] mm/shmem: Unconditionally set pte dirty in mfill_atomic_install_pte Peter Xu
2021-09-01 21:48 ` Axel Rasmussen
2021-09-01 23:00 ` Peter Xu
2021-09-02 21:54 ` Axel Rasmussen
2021-09-02 23:30 ` Peter Xu
2021-09-01 20:56 ` [PATCH 2/5] mm: Clear vmf->pte after pte_unmap_same() returns Peter Xu
2021-09-02 7:20 ` David Hildenbrand
2021-09-01 20:56 ` [PATCH 3/5] mm: Drop first_index/last_index in zap_details Peter Xu
2021-09-02 7:22 ` David Hildenbrand [this message]
2021-09-01 20:57 ` [PATCH 4/5] mm: Introduce zap_details.zap_flags Peter Xu
2021-09-02 7:28 ` David Hildenbrand
2021-09-02 14:48 ` Peter Xu
2021-09-01 20:57 ` [PATCH 5/5] mm: Introduce ZAP_FLAG_SKIP_SWAP Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df28392f-faa3-5677-5e49-c56e297db578@redhat.com \
--to=david@redhat.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=hughd@google.com \
--cc=jglisse@redhat.com \
--cc=kirill@shutemov.name \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peterx@redhat.com \
--cc=rppt@linux.vnet.ibm.com \
--cc=shy828301@gmail.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).