From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C476C61D85 for ; Tue, 21 Nov 2023 17:11:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3102B6B0183; Tue, 21 Nov 2023 12:11:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2C04B6B0193; Tue, 21 Nov 2023 12:11:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 160926B01F5; Tue, 21 Nov 2023 12:11:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id F415B6B0183 for ; Tue, 21 Nov 2023 12:11:42 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B4F1940909 for ; Tue, 21 Nov 2023 17:11:42 +0000 (UTC) X-FDA: 81482603244.01.B3C0487 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf30.hostedemail.com (Postfix) with ESMTP id B5EA380014 for ; Tue, 21 Nov 2023 17:11:40 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=none; spf=pass (imf30.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700586701; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JnxMTMST5jr+hBwEtloCPJQi50EUTROA3ffvB060v2U=; b=GAQj5F/rxeOy9nj8LWQN8ArIsikcQtfa7Ip9m3UP63FQZIDa+Tu9grpNRH0RQcgk3srXgL qlJCLosVk9n8ZrNuC9Lwv6Oat8MFrPuplpwIPJz82yDfpKQIWLtLQ+4sI43J5hCpIz6slH NNYify4LsMUP4i62YQ7m67dEia2EmZ4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700586701; a=rsa-sha256; cv=none; b=wQEj8FCIKvSKWSBsbGe080GDiTL63uUscTcuKBa9kTzWqsYrRXVjeZOLuEUKB24a220x6U bnRDGm0Hgdc5cWwo8+Wco/aBiZvQDIgUHpqgjc4kYYnDyFdVCGruuXD/Vl5iemeNAO6bCY C7Cwx9+MLQSbTPvuhR5BlbIVEEbnkcQ= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=none; spf=pass (imf30.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 551321042; Tue, 21 Nov 2023 09:12:26 -0800 (PST) Received: from [10.1.26.189] (XHFQ2J9959.cambridge.arm.com [10.1.26.189]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3EF3A3F6C4; Tue, 21 Nov 2023 09:11:37 -0800 (PST) Message-ID: Date: Tue, 21 Nov 2023 17:11:36 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 0/4] Enable >0 order folio memory compaction Content-Language: en-GB To: Zi Yan Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Huang, Ying" , Andrew Morton , "Matthew Wilcox (Oracle)" , David Hildenbrand , "Yin, Fengwei" , Yu Zhao , Vlastimil Babka , "Kirill A . Shutemov" , Johannes Weiner , Baolin Wang , Kemeng Shi , Mel Gorman , Rohan Puri , Mcgrof Chamberlain , Adam Manzanares , "Vishal Moola (Oracle)" References: <20231113170157.280181-1-zi.yan@sent.com> <1e7cf758-ac0e-4eda-a8e2-90db5eed7f7a@arm.com> <7ED1378A-AC39-48A2-8A2A-E06C7858DCE1@nvidia.com> From: Ryan Roberts In-Reply-To: <7ED1378A-AC39-48A2-8A2A-E06C7858DCE1@nvidia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Stat-Signature: wbpm9jsjsg4ec1ef4bpsfqkbq7gjpt94 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: B5EA380014 X-Rspam-User: X-HE-Tag: 1700586700-211021 X-HE-Meta: U2FsdGVkX1/R+ZFaCv5xByI+viTFpMkFIzeHASgzmGlkhoY0Bp+RwOOJvVgwlpi7C0UxZYgCVjc7FtX1gp7valPPG3kWIsT+WnCKgV7xZXH1fs5970+ZXniglw1sU60lUyrNLv8muQlQZfyCz75Jt2nDbPYuFZEJV5bRq4RjHaBqUv0hg3syyj6LGpy8gQUlu+85uIc3oA4e4fLw13rMsLLYcdmBxCUjN1iHgRVd4Q3pRRckQ2yc+w7UKDZurXGlXCQJmHcW7SWEhRD2sXZHUNey4FqvLjd/eT1/doFPwPbUQ+/pXCANoYDoHNRjj7EFcLlKGlJcutlZoOtjxuc37svBu3f5107DXcHzncHIqzvfAiJOrwZtWJ/4lUS98IlifLA2MgLF20qjY6o+PNfD21PWPIJEzzieYnnCRMarZOmtN73CCxz3wg/QvQ0p5ivubFL9t4/BYh4YdzG8M/kSAh7g2dDyA1nXyt/34lTpfJ3SfiluKuAma+HdaOyE4ZVt6YggXAqSwQKGsOJYNgbZJdSaWWwsX/puc577cxUKBUPEXHv2Dqftmf+lcx292yw1gcVxI2AlnHqtpqzauFIRqzvXWMREjSgsrTRwvJfU3c5pK6jeACLSCWEwou71V9Ke6olCABm617zBty1PU9PUi7NPitDUEiCktm9OVCtUmxw+AMPPP37M5UbFTdq6P92m/2gXEPf73IY627iVjRTRUi9dG3Jy3iax9rOtpMOTduMNB9hRqTTPNFM6IYn0/ELav/tr1iDW5wDTEI4JepuxsHEjsapYVoAJSZXWbjp3Vq2VhjRb6+LEU1b25sADGU2b2AQCOXSnljATxBe9Tjx5FJNEOCxZZaeV/zqvqBrdITLcU6v/QPO2wvce6nBBC3tsfOMp4bT8hki0FZRkwRblvZyho6QvT70vUcG+H2iNI1xJHMwfOKRPSIXNlrof361xZ2qy+M4u3AMPySwCKPx 19AFdpH8 3+25CYBICqbPDvEvseSlFEzbUPYHB0xMe1Wo5FrLyF8ZZH7KO57vYSm57mwWHolMMnZfZllg9ZOnRJWXscefMMDGp77kVV+DzagXPe5sPULlFmzAu7QpQCJRuuQ4x1BGg+L53WNl8CMb/q+oIdtidZ8KwXQoX0RmbsfHIH9OAUdaEInSd4DjP2gTI23Acq/BBz2TALpIrhuYQw6kDajdZ8sYxRg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 21/11/2023 16:45, Zi Yan wrote: > On 21 Nov 2023, at 10:46, Ryan Roberts wrote: > >>> >>> vm-scalability results >>> === >>> >>> ========================================================================================= >>> compiler/kconfig/rootfs/runtime/tbox_group/test/testcase: >>> gcc-13/defconfig/debian/300s/qemu-vm/mmap-xread-seq-mt/vm-scalability >>> >>> commit: >>> 6.6.0-rc4-mm-everything-2023-10-21-02-40+ >>> 6.6.0-rc4-split-folio-in-compaction+ >>> 6.6.0-rc4-folio-migration-in-compaction+ >>> 6.6.0-rc4-folio-migration-free-page-split+ >>> 6.6.0-rc4-folio-migration-free-page-split-sort-src+ >>> >>> 6.6.0-rc4-mm-eve 6.6.0-rc4-split-folio-in-co 6.6.0-rc4-folio-migration-i 6.6.0-rc4-folio-migration-f 6.6.0-rc4-folio-migration-f >>> ---------------- --------------------------- --------------------------- --------------------------- --------------------------- >>> %stddev %change %stddev %change %stddev %change %stddev %change %stddev >>> \ | \ | \ | \ | \ >>> 12896955 +2.7% 13249322 -4.0% 12385175 ± 5% +1.1% 13033951 -0.4% 12845698 vm-scalability.throughput >> >> Hi Zi, >> >> Are you able to add any commentary to these results as I'm struggling to >> interpret them; Is a positive or negative change better (are they times or >> rates?). What are the stddev values? The title suggests percent but the values >> are huge - I'm trying to understand what the error bars look like - are the >> swings real or noise? > > The metric is vm-scalability.throughput, so the larger the better. Some %stddev > are not present since they are too small. For 6.6.0-rc4-folio-migration-in-compaction+, > %stddev is greater than %change, so the change might be noise. Ahh got it - thanks! > > Also, I talked to DavidH in last THP Cabal meeting about this. He suggested that > there are a lot of noise in vm-scalability like what I have here and I should > run more iterations and on bare metal. I am currently rerun them on a baremetal > and more iterations on the existing VM and report the results later. Please > note that the runs really take some time. Ahh ok, I'll wait for the bare metal numbers and will disregard these for now. Thanks! > > In addition, I will find other fragmentation-related benchmarks, so we can see > the impact on memory fragmentation. > > -- > Best Regards, > Yan, Zi