From: "Vlastimil Babka (SUSE)" <vbabka@kernel.org>
To: Hao Li <hao.li@linux.dev>
Cc: Harry Yoo <harry@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Shakeel Butt <shakeel.butt@linux.dev>,
Alexander Potapenko <glider@google.com>,
Marco Elver <elver@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Christoph Lameter <cl@gentwo.org>,
David Rientjes <rientjes@google.com>,
Roman Gushchin <roman.gushchin@linux.dev>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
cgroups@vger.kernel.org
Subject: Re: [PATCH v2 12/13] mm/slab: add cache_ and slab_needs_objcg() helpers
Date: Fri, 24 Jul 2026 18:31:51 +0200 [thread overview]
Message-ID: <df871664-09ea-4e83-bff0-bbd3ff9f3ccc@kernel.org> (raw)
In-Reply-To: <amMt7baftCrU-OJq@fedora>
On 7/24/26 11:41, Hao Li wrote:
> On Mon, Jul 20, 2026 at 04:16:26PM +0200, Vlastimil Babka (SUSE) wrote:
>> Slabs of some caches never need the objcg part of struct slabobj_ext.
>> Introduce helpers to query this for a cache or a slab.
>>
>> Introduce SLAB_MAY_ACCOUNT flag that is currently only internal and only
>> is_kmalloc_normal() caches don't have the flag.
>
> it seems this could be "only type == KMALLOC_NORMAL caches don't have this
> flag".
I think not, because with SLUB_TINY, a KMALLOC_NORMAL cache can have
SLAB_RECLAIM_ACCOUNT flag and thus is not is_kmalloc_normal() and may need
objcgs?
Yep it's subtle :/
next prev parent reply other threads:[~2026-07-24 16:32 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-20 14:16 [PATCH v2 00/13] mm/slab, alloc_tag: reduce obj_ext memory waste Vlastimil Babka (SUSE)
2026-07-20 14:16 ` [PATCH v2 01/13] mm/slab: skip kfence objects in allocation profiling Vlastimil Babka (SUSE)
2026-07-21 5:43 ` Harry Yoo
2026-07-21 9:20 ` Vlastimil Babka (SUSE)
2026-07-21 15:41 ` Harry Yoo
2026-07-22 12:47 ` Hao Li
2026-07-24 15:58 ` Vlastimil Babka (SUSE)
2026-07-20 14:16 ` [PATCH v2 02/13] mm/slub: skip handle_failed_objexts_alloc() with profiling disabled Vlastimil Babka (SUSE)
2026-07-21 5:51 ` Harry Yoo
2026-07-21 9:23 ` Vlastimil Babka (SUSE)
2026-07-20 14:16 ` [PATCH v2 03/13] mm/slab: remove objs_per_slab() Vlastimil Babka (SUSE)
2026-07-21 5:53 ` Harry Yoo
2026-07-23 11:29 ` Hao Li
2026-07-20 14:16 ` [PATCH v2 04/13] mm: move struct slabobj_ext to mm/slab.h Vlastimil Babka (SUSE)
2026-07-21 5:55 ` Harry Yoo
2026-07-23 11:29 ` Hao Li
2026-07-20 14:16 ` [PATCH v2 05/13] mm/slab: make slab_obj_ext() determine object index Vlastimil Babka (SUSE)
2026-07-21 6:02 ` Harry Yoo
2026-07-23 11:30 ` Hao Li
2026-07-20 14:16 ` [PATCH v2 06/13] mm/slab: abstract slabobj_ext.objcg access Vlastimil Babka (SUSE)
2026-07-23 11:32 ` Hao Li
2026-07-23 17:23 ` Suren Baghdasaryan
2026-07-20 14:16 ` [PATCH v2 07/13] mm/slab: abstract slabobj_ext.ref access Vlastimil Babka (SUSE)
2026-07-23 11:32 ` Hao Li
2026-07-20 14:16 ` [PATCH v2 08/13] mm/slab: replace slab.stride with obj_exts_in_object Vlastimil Babka (SUSE)
2026-07-23 11:32 ` Hao Li
2026-07-20 14:16 ` [PATCH v2 09/13] mm/slab: change struct slabobj_ext to a union Vlastimil Babka (SUSE)
2026-07-23 3:05 ` Hao Li
2026-07-23 6:27 ` Harry Yoo
2026-07-23 9:56 ` Hao Li
2026-07-24 15:42 ` Vlastimil Babka (SUSE)
2026-07-20 14:16 ` [PATCH v2 10/13] mm/slab: introduce slab_obj_ext_has_codetag() Vlastimil Babka (SUSE)
2026-07-20 14:16 ` [PATCH v2 11/13] mm/slab: reduce slabobj_ext memory with allocation profiling disabled Vlastimil Babka (SUSE)
2026-07-20 14:16 ` [PATCH v2 12/13] mm/slab: add cache_ and slab_needs_objcg() helpers Vlastimil Babka (SUSE)
2026-07-23 9:25 ` Hao Li
2026-07-23 9:30 ` Vlastimil Babka (SUSE)
2026-07-23 10:01 ` Hao Li
2026-07-24 9:41 ` Hao Li
2026-07-24 16:31 ` Vlastimil Babka (SUSE) [this message]
2026-07-24 16:38 ` Vlastimil Babka (SUSE)
2026-07-20 14:16 ` [PATCH v2 13/13] mm/slab: stop allocating objcg pointers when unnecessary Vlastimil Babka (SUSE)
2026-07-24 9:57 ` Hao Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df871664-09ea-4e83-bff0-bbd3ff9f3ccc@kernel.org \
--to=vbabka@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=cl@gentwo.org \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=hao.li@linux.dev \
--cc=harry@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=shakeel.butt@linux.dev \
--cc=surenb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox