From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D81D4C3ABD8 for ; Fri, 16 May 2025 17:42:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2C0436B0246; Fri, 16 May 2025 13:42:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 246DC6B0248; Fri, 16 May 2025 13:42:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0C2E36B0249; Fri, 16 May 2025 13:42:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id DD91E6B0246 for ; Fri, 16 May 2025 13:42:50 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 74DF7140F91 for ; Fri, 16 May 2025 17:42:52 +0000 (UTC) X-FDA: 83449491384.24.C56AE9E Received: from mail-pj1-f73.google.com (mail-pj1-f73.google.com [209.85.216.73]) by imf30.hostedemail.com (Postfix) with ESMTP id AA96F80006 for ; Fri, 16 May 2025 17:42:50 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=c339aisi; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf30.hostedemail.com: domain of 3GXknaAsKCPASUcWjdWqlfYYggYdW.Ugedafmp-eecnSUc.gjY@flex--ackerleytng.bounces.google.com designates 209.85.216.73 as permitted sender) smtp.mailfrom=3GXknaAsKCPASUcWjdWqlfYYggYdW.Ugedafmp-eecnSUc.gjY@flex--ackerleytng.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747417370; a=rsa-sha256; cv=none; b=e/OJCV45SpMUjmE31GaUcMdLDquqkx6C8NIxiXMP3NW8Ou033faN4atMATid9W83Gjg9d/ sA9o45FKk/WgBYh95xUV7A5G2AspSv6pGTiXg88PJaelZDT650kym45zzPBKaSTx3tOfkC Br3avqg084RmgUozUXH3HdcyT6qM/F8= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=c339aisi; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf30.hostedemail.com: domain of 3GXknaAsKCPASUcWjdWqlfYYggYdW.Ugedafmp-eecnSUc.gjY@flex--ackerleytng.bounces.google.com designates 209.85.216.73 as permitted sender) smtp.mailfrom=3GXknaAsKCPASUcWjdWqlfYYggYdW.Ugedafmp-eecnSUc.gjY@flex--ackerleytng.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747417370; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UHtggF1Xmmx8sunRLPpEo5y2n3Fbz0jNKo8YthXyxlY=; b=m8YEQcsKLp6jyfmHfuhzHEUvPhSvv90sxhgdT4tkUsYB8BWEvOIw5Lm+PTThne9Kpkn5Up fcyzqWiFS60rbPLWqrj4uT7BIcrhAnkWDRMnWvHIs1TAgkf/nXorWP4y6Ln2LU5tWeo05T UaT/uGVbYXF/szlzOZG04OlThVatCxE= Received: by mail-pj1-f73.google.com with SMTP id 98e67ed59e1d1-30e9e8d3e85so139095a91.1 for ; Fri, 16 May 2025 10:42:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1747417369; x=1748022169; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=UHtggF1Xmmx8sunRLPpEo5y2n3Fbz0jNKo8YthXyxlY=; b=c339aisipiD5ruoDQRfaBaNe0Bb+UN3FykVo+lD4CyFKiYHBWIelFuggfsHXC6i5jn olnOtfbS/FKJCKKtYZ5AQuV8qdgj0D1Ga9vVHkIAUqldVPtK0OrvmWM7/9BrIZ/dGrYE v9tlKv6I+MQkGXYQnzYzyvq92yudTbXYRJHlXk6C8fQBtqlLf0A0jxc2u0YI84Qn18Lw OnTkZAqZjLaQT8x3FfjdOtunWjDsVBYfI++ENmkpr1Gm06b0LzBUuW7xT0CpjJi1BQU+ 8VRpVtDSR0YXMKJJatvDmElQF8DiNs6pN/XixY2evTmchm3uFhDMlUtqqBLi0lsMNYOk lv/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747417369; x=1748022169; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UHtggF1Xmmx8sunRLPpEo5y2n3Fbz0jNKo8YthXyxlY=; b=T6N5kfOEHspzxqY3vxkbwZfzJl/5VYToENnYtO++Y3yP/QK7ebR5y9BLYkw2CWD5RP 0Ch3aOFEbE07sy0iodUmNjatuTIRJZ1VT+RUogeltcSNoC616e0JMZnNE6vf69THdius jRpDiqVwuzrchXRdKSLum3SNCrtr9elunYFrQ3LqeV1e4Qu/BKdHnYTpY9vjpdk9B9kq CQcHGXMfVVfpvEJJIH7YHlM+3Ga+4kH7YJITgMpCbopwa4jIoBszjC9nRdha+LvbzCPB BXoCLP+ZL3BEeWLUMyuGrYtOqFhnKkOAPg48Cm4a9AJZckKxEHiaZvCv4AHQMfBY/8Fe V+AA== X-Forwarded-Encrypted: i=1; AJvYcCXq3lfkg7OqVIWVK3fwovWiVt4HH1uCNfnFoGUNVRJ7m5xilygptBrpFQ4jQqFG/lY0KC07mCUycg==@kvack.org X-Gm-Message-State: AOJu0YyiUVHor+pqnPAYb+wgY+f8pODu+pTR0zACo8MLSoVE/NHjoVPk VnB4O5dnBy2rYorN8AIz7iwV/vmJhY2cEE/BpKYpcWQYjKUuE0TZwl9PkLuv8KsKftHn8TSNXKJ PnvTB24BcbA+enP62C0XY4N8m8Q== X-Google-Smtp-Source: AGHT+IFZZue4eVCNyGlBlVu3FOMYDdiN/+lNxD2W2guGukj7N1aj09nrbw9YDmV/sDzoeyH8oFlR4vBN8C7KtAQknw== X-Received: from pjyp15.prod.google.com ([2002:a17:90a:e70f:b0:2ef:d283:5089]) (user=ackerleytng job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:4b0f:b0:2fe:b907:562f with SMTP id 98e67ed59e1d1-30e7d527e41mr6797759a91.14.1747417369222; Fri, 16 May 2025 10:42:49 -0700 (PDT) Date: Fri, 16 May 2025 10:42:47 -0700 In-Reply-To: <6825f0f3ac8a7_337c392942d@iweiny-mobl.notmuch> Mime-Version: 1.0 References: <65afac3b13851c442c72652904db6d5755299615.1747264138.git.ackerleytng@google.com> <6825f0f3ac8a7_337c392942d@iweiny-mobl.notmuch> Message-ID: Subject: Re: [RFC PATCH v2 03/51] KVM: selftests: Update guest_memfd_test for INIT_PRIVATE flag From: Ackerley Tng To: Ira Weiny , kvm@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, x86@kernel.org, linux-fsdevel@vger.kernel.org Cc: aik@amd.com, ajones@ventanamicro.com, akpm@linux-foundation.org, amoorthy@google.com, anthony.yznaga@oracle.com, anup@brainfault.org, aou@eecs.berkeley.edu, bfoster@redhat.com, binbin.wu@linux.intel.com, brauner@kernel.org, catalin.marinas@arm.com, chao.p.peng@intel.com, chenhuacai@kernel.org, dave.hansen@intel.com, david@redhat.com, dmatlack@google.com, dwmw@amazon.co.uk, erdemaktas@google.com, fan.du@intel.com, fvdl@google.com, graf@amazon.com, haibo1.xu@intel.com, hch@infradead.org, hughd@google.com, ira.weiny@intel.com, isaku.yamahata@intel.com, jack@suse.cz, james.morse@arm.com, jarkko@kernel.org, jgg@ziepe.ca, jgowans@amazon.com, jhubbard@nvidia.com, jroedel@suse.de, jthoughton@google.com, jun.miao@intel.com, kai.huang@intel.com, keirf@google.com, kent.overstreet@linux.dev, kirill.shutemov@intel.com, liam.merwick@oracle.com, maciej.wieczor-retman@intel.com, mail@maciej.szmigiero.name, maz@kernel.org, mic@digikod.net, michael.roth@amd.com, mpe@ellerman.id.au, muchun.song@linux.dev, nikunj@amd.com, nsaenz@amazon.es, oliver.upton@linux.dev, palmer@dabbelt.com, pankaj.gupta@amd.com, paul.walmsley@sifive.com, pbonzini@redhat.com, pdurrant@amazon.co.uk, peterx@redhat.com, pgonda@google.com, pvorel@suse.cz, qperret@google.com, quic_cvanscha@quicinc.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, quic_svaddagi@quicinc.com, quic_tsoni@quicinc.com, richard.weiyang@gmail.com, rick.p.edgecombe@intel.com, rientjes@google.com, roypat@amazon.co.uk, rppt@kernel.org, seanjc@google.com, shuah@kernel.org, steven.price@arm.com, steven.sistare@oracle.com, suzuki.poulose@arm.com, tabba@google.com, thomas.lendacky@amd.com, usama.arif@bytedance.com, vannapurve@google.com, vbabka@suse.cz, viro@zeniv.linux.org.uk, vkuznets@redhat.com, wei.w.wang@intel.com, will@kernel.org, willy@infradead.org, xiaoyao.li@intel.com, yan.y.zhao@intel.com, yilun.xu@intel.com, yuzenghui@huawei.com, zhiquan1.li@intel.com Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: AA96F80006 X-Stat-Signature: z4p3yug9aj39nehewfn9dgqx67oa9qoz X-HE-Tag: 1747417370-853607 X-HE-Meta: U2FsdGVkX1+BK7OkLn+sTbaguGNIqjeoHOlmuNlcZ4jKEl56CssI9lwcHUjvVCOIsJjRG7h/lWshd/8sAVvbnuzwRpy5r63qMxUPj/7IrGIIUdE/BIUpmcm1QPg9q/wHFbg7yWEN3R3k8FsUWmYuSLfMBUOTkS1pK5swX2J9J4SvWWnTIUctPuBqdvNDDtGuH9cabS3xniauIu9Muuuj1UmYXOuldVpYnlUY6VVIBnJeADlm1cSLUxLzChbRgPkCM61t0T4qvWRuRaaM/tZQh17L/rnYxysXaKcoKMtTlsYtWSd61pyg1ApEXnxuLnJHGsnlk4q1ic1N3MRKAUdckmu4S2sZKPcNewpv7SI044UkGV9JA2LeBzWfPa12SQbnYmROLuqXh9Yk7lvfaRAUYFe3CZM38ogqIzSYf5VV7h8Zm+GsqCuotX54nEQMzfqgLqwLt5qoZ6rPS6DkU7BE6Lf9W2UVRqJ+7lZxR3zecJxUZeHcUXxYWr8GN3oUwkrTOVtbpe1IzzXPe9H/wYt1DpGmZl301F/b2EnocEXDhY9bDvmiDOBYIlfePBgtXvx3Q2cmI3MgkYtpKUaSa5gaNKEiq7Qw7oe+IV7VNhwJZtu68eUNsRzidCckWrujLr9hgmXW2FcA6wieE/4YXlGW+YOMDkiuvQvPvUqVP2MtbvHKDDQznk4cJBJuUIKIoFKTrAmvhhxWLfHX8aTp8UfqI1ld/un3aDEu1B3dIkL6UpsXQq858C6gRt3GTfNdTp99oxeqn9jQrNLIgaGbYfyGT5M3hZcPdRB3YsPk1SYjxgjpHcxJRXH4G33DAgOcY3oQCNWWAFWIn/bt7CvrGTG/ck2TuEXbQ32tVAuuN9mB1IWex/MJUDGLNPQY1fhpO1xRBMuziGTwBOBK+DJCc1ox5fItP5jnyKn25GgrR4jOrliGNL6kU+Tkvj6HAXJHSXxSZYpm+aFyUnpVXSl1JPk CZhCKC/t O46574Yz75QHjiGy8yNja5R8NvsO76YrPgj0WDxaxjts3k97A0HPLXfiMFF2tnX2Wmo5+LTFcx14XDALL/ZNY4rWY4FDiT/p52Wb2Qr3aCjbgcthQlz17MCfcvGZ1bY0i8N/lxPvFdRoV57qvdFW4po5EYKSUq38oXz06Ef0jhjOt3Hft2VpzVNtWXNPzec/lAiOxVsEFdEFbkYbyFGrHP4UVRC85uxJfbdTnbkrrntIXrIwTrLcMcW4VOh91t2rlx4ohHBVs1NPIfidRxIFJRtjfXW00KlefwrDs8qDjogQ2p5+gJ5AeTpoOinS+UywTcZDw4vc6qycyCEb3/07wjqQMZv+t2HBseCS9fnz9um++b5d6mQ1vm8e3T7TF5yNW1R6NhVVRWvakegZmOTuwNN/+BoNo9QYB2R9XUDj59jAAabaZ5eo3eVfs7v+ZKxvOnz3z9Tu+vL4ZGt7uBYP/75IQ0We5vyiKcn2fPwpYdJmbhZE8dIyAMa/Jn9VUe4vDi2CkdrFhJi6ib1NPCmo/GOdN5HJOdOVHDl6Vw5QENRKP0SjK+RMhtcB4tlLlZU9QTHP2+OI6CByG9weO95TYbqvbpqSAaGxaBLQtEmhRI5fkzm7Ha103iVvamg3X1R17sLy74aVoHFskVa30ujAmt6PWZfiOdWDN/HmlRtvlH2nFksUvHd5GFLU2OGu2fD+7fjhfOPJePZR1ngY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Ira Weiny writes: > Ackerley Tng wrote: >> Test that GUEST_MEMFD_FLAG_INIT_PRIVATE is only valid when >> GUEST_MEMFD_FLAG_SUPPORT_SHARED is set. >> >> Change-Id: I506e236a232047cfaee17bcaed02ee14c8d25bbb >> Signed-off-by: Ackerley Tng >> --- >> .../testing/selftests/kvm/guest_memfd_test.c | 36 ++++++++++++------- >> 1 file changed, 24 insertions(+), 12 deletions(-) >> >> diff --git a/tools/testing/selftests/kvm/guest_memfd_test.c b/tools/testing/selftests/kvm/guest_memfd_test.c >> index 60aaba5808a5..bf2876cbd711 100644 >> --- a/tools/testing/selftests/kvm/guest_memfd_test.c >> +++ b/tools/testing/selftests/kvm/guest_memfd_test.c >> @@ -401,13 +401,31 @@ static void test_with_type(unsigned long vm_type, uint64_t guest_memfd_flags, >> kvm_vm_release(vm); >> } >> >> +static void test_vm_with_gmem_flag(struct kvm_vm *vm, uint64_t flag, >> + bool expect_valid) >> +{ >> + size_t page_size = getpagesize(); >> + int fd; >> + >> + fd = __vm_create_guest_memfd(vm, page_size, flag); >> + >> + if (expect_valid) { >> + TEST_ASSERT(fd > 0, >> + "guest_memfd() with flag '0x%lx' should be valid", >> + flag); >> + close(fd); >> + } else { >> + TEST_ASSERT(fd == -1 && errno == EINVAL, >> + "guest_memfd() with flag '0x%lx' should fail with EINVAL", >> + flag); >> + } >> +} >> + >> static void test_vm_type_gmem_flag_validity(unsigned long vm_type, >> uint64_t expected_valid_flags) >> { >> - size_t page_size = getpagesize(); >> struct kvm_vm *vm; >> uint64_t flag = 0; >> - int fd; >> >> if (!(kvm_check_cap(KVM_CAP_VM_TYPES) & BIT(vm_type))) >> return; >> @@ -415,17 +433,11 @@ static void test_vm_type_gmem_flag_validity(unsigned long vm_type, >> vm = vm_create_barebones_type(vm_type); >> >> for (flag = BIT(0); flag; flag <<= 1) { >> - fd = __vm_create_guest_memfd(vm, page_size, flag); >> + test_vm_with_gmem_flag(vm, flag, flag & expected_valid_flags); >> >> - if (flag & expected_valid_flags) { >> - TEST_ASSERT(fd > 0, >> - "guest_memfd() with flag '0x%lx' should be valid", >> - flag); >> - close(fd); >> - } else { >> - TEST_ASSERT(fd == -1 && errno == EINVAL, >> - "guest_memfd() with flag '0x%lx' should fail with EINVAL", >> - flag); >> + if (flag == GUEST_MEMFD_FLAG_SUPPORT_SHARED) { >> + test_vm_with_gmem_flag( >> + vm, flag | GUEST_MEMFD_FLAG_INIT_PRIVATE, true); > > I don't understand the point of this check. In 2/51 we set > GUEST_MEMFD_FLAG_INIT_PRIVATE when GUEST_MEMFD_FLAG_SUPPORT_SHARED is set. > > When can this check ever fail? > > Ira In 02/51, GUEST_MEMFD_FLAG_INIT_PRIVATE is not set by default, GUEST_MEMFD_FLAG_INIT_PRIVATE is set as one of the valid_flags. The intention is that GUEST_MEMFD_FLAG_INIT_PRIVATE is only valid if GUEST_MEMFD_FLAG_SUPPORT_SHARED is requested by userspace. In this test, the earlier part before the if block calls test_vm_with_gmem_flag() all valid flags, and that already tests GUEST_MEMFD_FLAG_SUPPORT_SHARED individually. Specifically if GUEST_MEMFD_FLAG_SUPPORT_SHARED is set, this if block adds a test for when both GUEST_MEMFD_FLAG_SUPPORT_SHARED and GUEST_MEMFD_FLAG_INIT_PRIVATE are set, and sets that expect_valid is true. This second test doesn't fail, it is meant to check that the kernel allows the pair of flags to be set. Hope that makes sense.