public inbox for linux-mm@kvack.org
 help / color / mirror / Atom feed
From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Aditya Sharma <adi.sharma@zohomail.in>
Cc: linux-mm@kvack.org, akpm@linux-foundation.org, ljs@kernel.org,
	Liam.Howlett@oracle.com, vbabka@kernel.org, rppt@kernel.org,
	surenb@google.com, mhocko@suse.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: update stale locking comment in do_anonymous_page()
Date: Wed, 1 Apr 2026 20:47:05 +0200	[thread overview]
Message-ID: <e0417e55-1de9-4b77-bea4-b889dc2ac01e@kernel.org> (raw)
In-Reply-To: <19d49eccfcb.5f815dde233268.9181527708613952801@zohomail.in>

On 4/1/26 18:42, Aditya Sharma wrote:
> Sorry about that. The comment was AI assisted and probably too long. I
> had this confusion myself spending half a day debugging only to realise
> that the comment was stale. Will send an updated patch with a concise
> comment

Right "mmap lock or vma lock held", for example, is sufficient. While at
it, please look for other cases in the file that need similar care.

-- 
Cheers,

David


  reply	other threads:[~2026-04-01 18:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-31 14:29 [PATCH] mm: update stale locking comment in do_anonymous_page() Aditya Sharma
2026-04-01 10:52 ` David Hildenbrand (Arm)
2026-04-01 16:42   ` Aditya Sharma
2026-04-01 18:47     ` David Hildenbrand (Arm) [this message]
2026-04-05 17:18 ` [PATCH v2] mm/memory: update stale locking comments for fault handlers Aditya Sharma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e0417e55-1de9-4b77-bea4-b889dc2ac01e@kernel.org \
    --to=david@kernel.org \
    --cc=Liam.Howlett@oracle.com \
    --cc=adi.sharma@zohomail.in \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ljs@kernel.org \
    --cc=mhocko@suse.com \
    --cc=rppt@kernel.org \
    --cc=surenb@google.com \
    --cc=vbabka@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox