From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30CEEC77B7A for ; Tue, 13 Jun 2023 08:44:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B5476900002; Tue, 13 Jun 2023 04:44:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B33C08E0002; Tue, 13 Jun 2023 04:44:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A1AA8900002; Tue, 13 Jun 2023 04:44:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 933D18E0002 for ; Tue, 13 Jun 2023 04:44:18 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 68C0DA03F6 for ; Tue, 13 Jun 2023 08:44:18 +0000 (UTC) X-FDA: 80897087796.30.5C1F6FB Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf04.hostedemail.com (Postfix) with ESMTP id 1ECD840015 for ; Tue, 13 Jun 2023 08:44:15 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=D1YeR1Rz; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686645856; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DwCdfz6qIzvNJOkrJ4ckCc4rA0w83T1zH7jefpl3y6I=; b=vMS6a04bI4VmMcdWF1TgK64oqYzpULh4F3+0LGaPCCorWsfdO6aAHUYTj2m8WS4E23SLfo jr8ZHVNC3+u+8TbOhnlxPrcaNZlD0ZdWRIjbYzYfAvPtHtG+tx6hWqE3P2fGzmPtgAm87X yAylUGSc4k6pC713ltvZjOW+xXjslhM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686645856; a=rsa-sha256; cv=none; b=erRO3yPBUdHoT+OzBCL3xH7BjkBOIF6Rzw38YQxomvaYIbp9UbSOxL1hIeCwIk9yorB6zd RfgdOYCQYUPJUuuyzj6DU587qE1bX6GFZP2dUHRZjs7vWu37LNo1K9fJY4J9KtE/zfRGXV uPYq7ALipTBIDhPAIyq99YQaA8iArDo= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=D1YeR1Rz; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686645855; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DwCdfz6qIzvNJOkrJ4ckCc4rA0w83T1zH7jefpl3y6I=; b=D1YeR1RzA5/q+94ZSdJM0DH9jc36QQyrmsYQ55sUUZlS9R2/INJfO37th4Dhwt8puQQN44 pfdeEilnpXiCRyqYs+2GjTraDLpOInb9PtM76arATwYdyEY7/oTQ03WkZwmyns0pN2P6j2 JlbGBrATpfiRBJK7zS44q2fc/JiWZsA= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-41-Xg9F20e9MFeiYHv_23hjlA-1; Tue, 13 Jun 2023 04:44:13 -0400 X-MC-Unique: Xg9F20e9MFeiYHv_23hjlA-1 Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-4f621c76606so3507095e87.0 for ; Tue, 13 Jun 2023 01:44:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686645852; x=1689237852; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DwCdfz6qIzvNJOkrJ4ckCc4rA0w83T1zH7jefpl3y6I=; b=hLFTj5pYLmsK8382Qem8uyZuCOVf6o/fCxOvCP1Ys4O15Wd3ybJyZLy+qfAFwDQSQp FHzNPJVJjHVMqBVJ+fLDlogZpAsq3lxifSdg7+MkDnuMvEsRFP0+fOPRTs6//h9GKM4J mjBbfCv0+fSO3VOcFXCizprPhWtfZfizrBEN93WmnZSI4K2CE5G/tn2vtYZ4o9JdFS4m LqFHxsEq5GBbk4s7qy4TKkQWdpl2K1Zf45jZb5VSgrVUy15rR4UzEEjMEeLjWMnPAskf /m0ZgMrY97Cn4YL+s05OVrg/eB8MCmGTgSlf2GvgEljDcgsURYKOqmAW3ZqHS3EuM7mJ JVjg== X-Gm-Message-State: AC+VfDwq1Kk5ycpqbX6FpA8sliU2Z3C2SAX2XYbhl+BGo/doKkO+NUyA RBjEhjr5ZCrMBNVFj/0fm5JxfzELQBK50LuTHpg3MNa8IOMDHKSECh1LApfeTUqhDAR9HKuOw4+ uEHAIzhVTsxdCCA12vaM= X-Received: by 2002:a19:2d4e:0:b0:4f6:3ef4:5c78 with SMTP id t14-20020a192d4e000000b004f63ef45c78mr4880072lft.50.1686645852116; Tue, 13 Jun 2023 01:44:12 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ76OwP/icHsCrkIlrQSybTRFDNzeJVkIcmQL7YrFmVBPuSL+xWxlAH6cjj+YWuxrRnJybU+Ww== X-Received: by 2002:a19:2d4e:0:b0:4f6:3ef4:5c78 with SMTP id t14-20020a192d4e000000b004f63ef45c78mr4880059lft.50.1686645851644; Tue, 13 Jun 2023 01:44:11 -0700 (PDT) Received: from ?IPV6:2003:cb:c710:ff00:1a06:80f:733a:e8c6? (p200300cbc710ff001a06080f733ae8c6.dip0.t-ipconnect.de. [2003:cb:c710:ff00:1a06:80f:733a:e8c6]) by smtp.gmail.com with ESMTPSA id 14-20020a05600c024e00b003f8044b3448sm13350961wmj.9.2023.06.13.01.44.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Jun 2023 01:44:11 -0700 (PDT) Message-ID: Date: Tue, 13 Jun 2023 10:44:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH] selftests: lib.mk: fix out-of-tree builds To: Muhammad Usama Anjum , Anders Roxell , shuah@kernel.org, Andrew Morton , "open list : MEMORY MANAGEMENT" , John Hubbard Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230613074931.666966-1-anders.roxell@linaro.org> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 1ECD840015 X-Rspam-User: X-Stat-Signature: cz97ik1ia55pbhqsrnu3mw4szhujs4oy X-Rspamd-Server: rspam03 X-HE-Tag: 1686645855-688869 X-HE-Meta: U2FsdGVkX19/w51I6E4HsLpGK2/u1mRei7G0rg2Pszv42SyyNFxxK4gTETRAxkHbA8fZqTL6pK+sKdkARgDfyNpfH21XiF++/cm8pOZctAtBy0Dd66yym1jBmbApJRgAR4TC/wUQQ9Uhiwea/5u2pwYpw4zjmC6cGjuZ51BRzVBJ6GzQJw4cYkZ2W2nHEegAsm43hDjNX5MGaY2CnXDSBLhMHX4JP/eKh79Kua+SpmSaLnUA1ocTAGLQeVWs4Bqq5qTGv7Lcn2kmDI4KF4oh9Me7X9irR3qQg/bF8BdEZqiq9j3ILS4pqqSxTqt9fo/Wms228sYZEp57FoMYNBoWA/rLtr6nCYp2F0Vo6+POXo3P7I5Y03jRTU32nDjgkh0DiPBCtH1OgV+zeWriLaUHVLxRaiGz18EGPju5gwDaErpCvEgaW9EIkUXi4jUCwWiBLoI/TEXC1ILS3Gr+pcZRFlxTMyK3OoNJyLbz3dsi7DGAOzltXRh58hq0EawFi539fhmoBPJbeTvmwahpgIAdv15xkOPYEZMaWVFtATpMJ6EIK4S2uF1gorQs0Z5V4pbsEhf2+XUw222OusgAg/ROZ/iRUha5sxhXUdeo5J5OAjZS2uDNmhZY0kBNsKcIlt5a3gXhx5MWRXUbaOeyCMtWS887WF5Dx/rUDSt0kZCHGrCp04c7fF4Zb7iGH60HEMm3iY+iOlRkmvNIxfn9c5cItMGqnRcRlFu87cnnIJ77iyKZafO49u3pV/Vn4SMQoZ0N/kIan1TdDhcRChkdUG5n/a7dMSRVv+PikvlPeYDi46WnGgSpzZZeBDVNMxWFB9sOHGC9hAx+bcmOOgXDmukejlxLUlE/mfi8iePY56Px88E1PF3Drn/u39GrdyLOEJ5r2SUXi5kuCL5WXKzrGkI6tB+rOTBGrn6SwV3jfL7Z1K7Q1da0leWcoclzBTTJfAZ2TH0A2+nnIBvSSArRQM5 jub2QjwH Vg+92j+sYwuCoODZTLFKNj6vS/+h/3rSKIQsex/Es3AoSecpBTfo29CrQZ+DOxhY+ipmW/hGXjlvw8gxuFRgRugIIImgmrsfZit9DKziFBFp8AKfGzw5+6v5g8VYvY7oeyNZPbBC5m1DGmgjrKGyLz9V8YGx0LXCrYdkF4uvF3YOjXThtEZssBAS8jjCi9/xT3Uo1+iO5AGamK3ldqdkR+lWkjiRkFmViVshlpS7n8/eBj3ouaSrhN8RYpmN/qSTfJFR+KrnOoPFtgq/8vwGBsjq1CfzWk9JS6UVUNA6RLlFUMtj8Y959j97vvG/vniiN+DKHhV46aFxqfpMW9YrJnsKesusFHw1GhjDK6+/np6qcS6jnP7x73HPn6DdFDEjEvLj1jBENWIhlC40trBHbN3pchd7Zuy5eMHCFkekSRCzwa5XF4U0zxg6jGs7BZ1CrabmGpncxHnFmk25jJj0f4fXS5ZooI5cxxjcDScPGB6OeeuQs/LQaQvPDnQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000008, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 13.06.23 10:16, Muhammad Usama Anjum wrote: > This patch needs to go through mm tree as the commit which it fixes is in mm. > > On 6/13/23 12:49 PM, Anders Roxell wrote: >> Since commit ("selftests: error out if kernel header files are not yet >> built") got merged, the kselftest build correctly because the >> KBUILD_OUTPUT isn't set when building out-of-tree and specifying 'O=' >> This is the error message that pops up. >> >> make --silent --keep-going --jobs=32 O=/home/anders/.cache/tuxmake/builds/1482/build INSTALL_PATH=/home/anders/.cache/tuxmake/builds/1482/build/kselftest_install ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- V=1 CROSS_COMPILE_COMPAT=arm-linux-gnueabihf- kselftest-install >> make[3]: Entering directory '/home/anders/src/kernel/next/tools/testing/selftests/alsa' >> >> -e error: missing kernel header files. >> Please run this and try again: >> >> cd /home/anders/src/kernel/next/tools/testing/selftests/../../.. >> make headers >> >> make[3]: Leaving directory '/home/anders/src/kernel/next/tools/testing/selftests/alsa' >> make[3]: *** [../lib.mk:77: kernel_header_files] Error 1 >> >> Fixing the issue by assigning KBUILD_OUTPUT the same way how its done in >> kselftest's Makefile. By adding 'KBUILD_OUTPUT := $(O)' 'if $(origin O)' >> is set to 'command line'. This will set the the BUILD dir to >> KBUILD_OUTPUT/kselftest when doing out-of-tree builds which makes them >> in its own separete output directory. >> >> Signed-off-by: Anders Roxell > Please add fixes tag. ("selftests: error out if kernel header files are not > yet built") > > Tested-by: Muhammad Usama Anjum This should get squashed into the original patch unless it's already in mm-stable (which it isn't) and we have a stable commit id. -- Cheers, David / dhildenb