From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D821C43331 for ; Fri, 6 Sep 2019 22:31:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E9FB12082C for ; Fri, 6 Sep 2019 22:31:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="cKiY0E1y" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E9FB12082C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4E6336B0005; Fri, 6 Sep 2019 18:31:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 495686B0006; Fri, 6 Sep 2019 18:31:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3AC216B0007; Fri, 6 Sep 2019 18:31:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0168.hostedemail.com [216.40.44.168]) by kanga.kvack.org (Postfix) with ESMTP id 1C8976B0005 for ; Fri, 6 Sep 2019 18:31:48 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id C4A54824CA3F for ; Fri, 6 Sep 2019 22:31:47 +0000 (UTC) X-FDA: 75905944254.19.flame68_f97b07e0e03c X-HE-Tag: flame68_f97b07e0e03c X-Filterd-Recvd-Size: 5055 Received: from hqemgate16.nvidia.com (hqemgate16.nvidia.com [216.228.121.65]) by imf28.hostedemail.com (Postfix) with ESMTP for ; Fri, 6 Sep 2019 22:31:46 +0000 (UTC) Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate16.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Fri, 06 Sep 2019 15:31:48 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Fri, 06 Sep 2019 15:31:45 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Fri, 06 Sep 2019 15:31:45 -0700 Received: from [10.110.48.28] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 6 Sep 2019 22:31:44 +0000 Subject: Re: [PATCH] mm, notifier: Fix early return case for new lockdep annotations To: Daniel Vetter , LKML CC: DRI Development , , Jason Gunthorpe , Daniel Vetter , Andrew Morton , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Ralph Campbell , Jason Gunthorpe , Ira Weiny , Michal Hocko , Sean Christopherson , Jean-Philippe Brucker , References: <20190906174730.22462-1-daniel.vetter@ffwll.ch> X-Nvconfidentiality: public From: John Hubbard Message-ID: Date: Fri, 6 Sep 2019 15:31:44 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190906174730.22462-1-daniel.vetter@ffwll.ch> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1567809108; bh=HMZ0qlWEBQ226w28k44JWwaPPo4f1iFeti/9oDWU1G0=; h=X-PGP-Universal:Subject:To:CC:References:X-Nvconfidentiality:From: Message-ID:Date:User-Agent:MIME-Version:In-Reply-To: X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=cKiY0E1yN7X0N9uQOvluxNcsXjklOOdWSsKNEQJzFwvVuOhhwiSp2iMiyAEyIJOmD BbNOqTrKkB+K/AMpJHdkNp6An2OKlfdVg57QX431Su/mfYlRFTMKGe34TSl+VLUxLf kXrpfkAZYbhFfBQpBAzM2YwRvhLxtIciId7pvonZQD1rEbZ4MgX8f0mE3iE8er4MTx NgCtHIENpw+87hfnh6ykdRYIc2YLZ5sohIGN5OK4F3vZmkem5XZ0hsqqs3PBY5bSKJ GYgctkGF6W3oKq4urLWEVnKHa3sBLQElqnm9gZ2ZM4T5SiA4M9xvEpPNeqG/LdlSi6 Pf19VtL3+4R7w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 9/6/19 10:47 AM, Daniel Vetter wrote: > I missed that when extending the lockdep annotations to the > nonblocking case. >=20 > I missed this while testing since in the i915 mmu notifiers is hitting > a nice lockdep splat already before the point of going into oom killer > mode :-/ >=20 > Reported-by: syzbot+aaedc50d99a03250fe1f@syzkaller.appspotmail.com > Fixes: d2b219ed03d4 ("mm/mmu_notifiers: add a lockdep map for invalidate_= range_start/end") > Cc: Jason Gunthorpe > Cc: Daniel Vetter > Cc: Andrew Morton > Cc: "J=C3=A9r=C3=B4me Glisse" > Cc: Ralph Campbell > Cc: Jason Gunthorpe > Cc: Ira Weiny > Cc: Michal Hocko > Cc: Daniel Vetter > Cc: Sean Christopherson > Cc: Jean-Philippe Brucker > Cc: linux-mm@kvack.org > Signed-off-by: Daniel Vetter > --- > include/linux/mmu_notifier.h | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) >=20 > diff --git a/include/linux/mmu_notifier.h b/include/linux/mmu_notifier.h > index 5a03417e5bf7..4edd98b06834 100644 > --- a/include/linux/mmu_notifier.h > +++ b/include/linux/mmu_notifier.h > @@ -356,13 +356,14 @@ mmu_notifier_invalidate_range_start(struct mmu_noti= fier_range *range) > static inline int > mmu_notifier_invalidate_range_start_nonblock(struct mmu_notifier_range *= range) > { > + int ret =3D 0; > lock_map_acquire(&__mmu_notifier_invalidate_range_start_map); > if (mm_has_notifiers(range->mm)) { > range->flags &=3D ~MMU_NOTIFIER_RANGE_BLOCKABLE; > - return __mmu_notifier_invalidate_range_start(range); > + ret =3D __mmu_notifier_invalidate_range_start(range); > } > lock_map_release(&__mmu_notifier_invalidate_range_start_map); > - return 0; > + return ret; > } > =20 > static inline void >=20 Reviewed-by: John Hubbard thanks, --=20 John Hubbard NVIDIA