From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53001C61CE7 for ; Fri, 6 Jun 2025 18:36:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DF29D6B008C; Fri, 6 Jun 2025 14:36:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DCBA36B0093; Fri, 6 Jun 2025 14:36:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CBA216B0095; Fri, 6 Jun 2025 14:36:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id AD8AC6B008C for ; Fri, 6 Jun 2025 14:36:47 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 5A6C3BB229 for ; Fri, 6 Jun 2025 18:36:47 +0000 (UTC) X-FDA: 83525832054.02.6589C7E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf24.hostedemail.com (Postfix) with ESMTP id E7A90180007 for ; Fri, 6 Jun 2025 18:36:44 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="U/FY4aU+"; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749235005; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ETXo+kNhv5Vh+fUDoc90IncohVidEafEgeEXooy5dQo=; b=6M0WJTT5Jg+cBjRxTugETbMnRMp+i1G12S+b4D81FCWsjErWGKRFNdchITJgLJ/7SrYw7i umkqA3TnRLIOjQ04+FmyyG7s2XsKLpiQ+dt7uuh6Sezg2sL5SJgMcv3IyD8FEl/pQ4Jho3 qMa+bHiX3+64UNLzHGptNwcC6ZzKbcU= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="U/FY4aU+"; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749235005; a=rsa-sha256; cv=none; b=XK/mjV8N7W8UUoez+ArrqR+bPlcfxN0oitTNy8Zh4tiUF/i22Koli+Mcq34llD1jJu0zJp K0iJw9alncIT9GTqsBHW8D1ZiUDhwJe+hSaH2xMkFx7cbWLWWat62zMOqIFxWOiYSuvmAI L2iEOYVDt+6N6qvJKcaDnxziVyPHFn4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749235003; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ETXo+kNhv5Vh+fUDoc90IncohVidEafEgeEXooy5dQo=; b=U/FY4aU+la/vgvxZ3B6qxCbMZV+QO2XjNNIvYWpOisMkdgqfm+ETgywicKbJH1nWWXU5B5 CVUbTLXfUcGIR72ifd+dk0GwDQZt9a6ltNJk8QwrhhmBjcRb2cf5hXWORUiEIeYPRy+uW/ v4u5P/Mg1XPAk7gLQDLhYdjh+pjOLkU= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-256-tujCbKZVNNKnVUrNRphwwQ-1; Fri, 06 Jun 2025 14:36:42 -0400 X-MC-Unique: tujCbKZVNNKnVUrNRphwwQ-1 X-Mimecast-MFC-AGG-ID: tujCbKZVNNKnVUrNRphwwQ_1749234998 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-452ff9e054eso704355e9.2 for ; Fri, 06 Jun 2025 11:36:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749234998; x=1749839798; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=ETXo+kNhv5Vh+fUDoc90IncohVidEafEgeEXooy5dQo=; b=oFv1yXSJSujP/RnM+7f1v4T1KeK27D7818zWf9mIfGsa/OR8Qmm6S7KqmB1ThNcqLw q/3x/BnUG9W8BD+NnPlbwy9jPJsUbn92IpnMa1owFOsIM+lamsDMZjCQi44QSuVtlCfG sua/4qAUvhf4M9b2J8pzbpO/VT3Y2Mnv/ka6ji12zAuyJlPekKxPgmCZFS18MAE4C2TN l3bRjDW6Joy68zhvv+7NI7yXBPGay199mlzpaqs1gedeU9pRIkLstpG9aRW4LdYPATOC riyaoOMFTsJ2z71sPi2fz2jlp+IMOdtGf2C+sQRoQkUun5g57YgoBBxtZvbA1gqkdkRQ HynA== X-Forwarded-Encrypted: i=1; AJvYcCWP1xkEgOVfoz4SlUQeSJnGWXXD4wLhXp/3YSiWnGGNHezY9EfxwCx/e5csrFsxSECSBaEkjy930A==@kvack.org X-Gm-Message-State: AOJu0YwPDnHEBHCQwxwrMAMBk/Jiy9hCvWOnh4n2TALSJYa6kQ63F+fJ 8nOC2V6dCJbSDmuRY+16xGMUx/Qe2b21SisifSC3GjAZKIAr6EM/m1wBN1hbnRZZ0hoxqkqnKbC exvBWj4APGy5RpKo08vjLrqbQI4+bCKn2BFVvRslEvZzBsQNrPRyW X-Gm-Gg: ASbGncsLc8e94wBZBr9Sek8ZWxHMyMOgGs7HuAX5UXmI2F5yX2NXTetXKSU9DMAUhEZ 5Jydr/QklRkhRcKv1BYEdb1zFowKcwAJf+uxBCd1v0Zmfk5r2KW1ZSTZ36a5iEFB+moaQymBH+N m5ikHum3Yr9EzBcWNhklfP7x2pu3PgAvBo54snVKCSsKc0YGoWg/VmNADaPu2Bj13gsthKFted+ avO2S2sR9Z92Qr2tGgddAbi/Qevxya73GiLI46AksSL9YFb53txXZcZntMpgq8wP2ymdzFcq9aZ YyWFR283wFXKWK+kyhSEzqiGFL7RHNk3qxcRe/wfGKTf1IJ5bpyTfnaSQVwa31HohD6BlBdBjnc eMFsSoc7Y/vWZOpB1m9yBp11d8IBsTIbaCsOp2VU4OQ== X-Received: by 2002:a05:600c:3e84:b0:450:d00d:cc with SMTP id 5b1f17b1804b1-45201417068mr48055685e9.2.1749234998479; Fri, 06 Jun 2025 11:36:38 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF4Ona8cC63T7ugk0ilSFASiLSAqyndxjm/MnJNHcFCOx0BTqY9MXZDy3OKqQOcNsnCIUG9QQ== X-Received: by 2002:a05:600c:3e84:b0:450:d00d:cc with SMTP id 5b1f17b1804b1-45201417068mr48055465e9.2.1749234998104; Fri, 06 Jun 2025 11:36:38 -0700 (PDT) Received: from ?IPV6:2003:d8:2f19:9c00:568:7df7:e1:293d? (p200300d82f199c0005687df700e1293d.dip0.t-ipconnect.de. [2003:d8:2f19:9c00:568:7df7:e1:293d]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-451f8ef98b1sm48644065e9.1.2025.06.06.11.36.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Jun 2025 11:36:36 -0700 (PDT) Message-ID: Date: Fri, 6 Jun 2025 20:36:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] mm/gup: remove (VM_)BUG_ONs To: John Hubbard , Lorenzo Stoakes Cc: Michal Hocko , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Jason Gunthorpe , Peter Xu References: <20250604140544.688711-1-david@redhat.com> <1a65d0e6-6088-4a15-9c19-537203fe655c@redhat.com> <50ff9149-2824-4e57-8d74-d8d0c063c87e@lucifer.local> <1a7513cf-4a0a-4e58-b20d-31c1370b760f@lucifer.local> <72bb36f2-65b6-4785-af9d-5b1f8126fc78@lucifer.local> <2f866f12-2aa0-4456-b215-08ddc9b13b1e@redhat.com> <3dfbbd63-697d-42aa-8906-539d74df9123@nvidia.com> <44af8f5a-2d94-498b-a3e0-31f5dde74538@redhat.com> <5d0d0542-5994-49e1-820a-02fd7e7551c5@nvidia.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <5d0d0542-5994-49e1-820a-02fd7e7551c5@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 2iXyrEBgO_asfgO-ZgoK-W6khrcjK4F1IL_NL0LJzhA_1749234998 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: E7A90180007 X-Rspamd-Server: rspam09 X-Stat-Signature: idsxu6hag8d9zjfsexdd1yimr3m6zq4n X-HE-Tag: 1749235004-362919 X-HE-Meta: U2FsdGVkX1+S1bA3rNwjKqz5lgZKXH3X8+RbcjL3aVR5b+bq9rIxYxc4d4K3Nj8EDhrlXEjMUImqPxAlVDhshvV34dke1AHA/+P9bF3LBecboh5cJrcpnrfAGDX4uZjGxBUdH/9S4n99aocTCQZ752rkLqTwPW/YO9+9ZGJxPaa9WsiaMaxvCSagyCU+1WzEvhCcGmPUttYICruakDQLQBQX8GVGsN4TnlSC17hoVzMeGCG5RhigAFTJWFyC+zzoiQuBkptl8JmVdJZSRtnyfuggT9OXfXdLaxSFqoVDU9OM0nB4L/oPsPFBfaAKD+qsFlA1UKyY3Wi+orbUqqa1K3aEAlMRUs29J8FY77iMjE5dS+UsKtTpMkplu2SEe1JFbYSbGK0hs29XJj+oqefgBml4Bhb+wMsZDdCdbiEHEX7OCAqQpaKFTAFe9W0ixAaaunV7UnYRYYlvQcux4qlnGItzkfWDHKNAEhhQQ+sQomQJxIqhrrBjFF2FrJxtyaObG6Hk71oKiOmraK7ZFgCjKQVgnNgj8/3uqIpvsVcp8lvUMDMAh5Pd1XqsUr3I4I7qw5dKfao/hvYIglnTU+r1qauZFHD9v81tf3BuDTrJ38dnSk5/xAHXQrw03a1WrEdr42rWVeGtIOdgTmtDcuAin2+ZLmNceSxKZs83pALPEFtpSRIDdMgDZGkwE33dkkU95dWuYjpYYGZignj8LWncXHbwUTHdo7xEU3q3qigH+YL5dQmcYXzinXpN2aOKlYsY+DDS70shh/MXfOF8Rtk5IEKYOw/Fj66mVCB7yvBcrk/na8s4vkvMZZMjHFvZw/bbBYIMCk5TymybLBftYc3k6V+jE4YHHSk8Zr51oZJtYILYH+/f6PyD6EJuW5lQX4xPsrZUnlJnB/uHCHjt8fE1c0Sl0ZZqQ1EqKy8xRkaqIObMUC0Af97kUgBhCoPiia11duXIi1UE+B6wkxsw8/z De0BPXIr O3cURD0p0f5K5USvEg5pjquPI7SW7fn5k+a6IodnyWKBFCgND1yf4gHDHUwqV4F/VA21+Vf2ypiVio0NoZRT1UFCyfS7Qrzgns9s8Q/2zbjugPm7NCpQfvZC94a0tQiYQcmnVLTc7DgYOJrYdpBY9CKwrXygoQybRCeAaj6HpWMtYT/zhzy9QmDo+poj7oHP5D+BpeCBpgo904HosE4ZgbgiS2byRk9xt6gBaUnIRkFMmC/33tqlINpARqtJBxkDB1GJ1bNT9XbC8ZTqjfy7x+R5mU49QTWI1YaLmywsgAZsCbD3oHtBD5zUHLWN4ulln0ZW1kmMwHReyn7XfGDMHcPhjza02+CNObTkiab7n8EwImlhVzUKpEu8rF9fKkbv7Lf8+BPpOf4Na7HzfTzOFNDjXXp48Hf8wQ4OWkondyP+ibOzOZRX1y18bzS+I+zxQ4wpuaRy+DnltVZU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 06.06.25 20:31, John Hubbard wrote: > ... >>>>> David, what do you think? >>>> >>>> Well, in this patch here I deliberately want _ONCE for the unpin sanity >>>> checks. Because if they start happening (IOW, now after 5 years observed >>>> for the first time?) I *absolutely don't* want to get flooded and >>>> *really* figure out what is going on by seeing what else failed. >>>> >>>> And crashing on VM_BUG_ON() and not observing anything else was also not >>>> particularly helpful :) >>>> >>>> Because ... they shouldn't be happening ... >>>> >>>> (well, it goes back to my initial point about requiring individual >>>> decisions etc ...) >>>> >>>> Not sure what's best now in the general case, in the end I don't care >>>> that much. >>>> >>>> Roll a dice? ;) >>> >>> One last data point: I've often logged onto systems that were running >>> long enough that the dmesg had long since rolled over. And this makes >>> the WARN_ON_ONCE() items disappear. >> >> I think what would be *really* helpful would be quick access to the very >> first warning that triggered. At least that's what I usually dig for ... :) >> > > These two use cases cannot be simultaneously solved, at least not > perfectly. I guess we'd have to store the first WARN data separately away, just like when tainting the kernel or so. Not sure. Fortunately, since a VM_BUG_ON() case cannot ever happen, I mean, also WARN and friends are for things that should never happen ... :) -- Cheers, David / dhildenb