Re: [PATCH v5 04/10] mm,slub: Use node-notifier instead of memory-notifier

[David Hildenbrand <david@redhat.com>]

On 06.06.25 14:28, Oscar Salvador wrote:
> On Fri, Jun 06, 2025 at 01:56:15PM +0200, David Hildenbrand wrote:
>>> @@ -6217,15 +6217,12 @@ static int slab_memory_callback(struct notifier_block *self,
>>>    	int ret = 0;
>>>    	switch (action) {
>>> -	case MEM_GOING_ONLINE:
>>> +	case NODE_ADDING_FIRST_MEMORY:
>>>    		ret = slab_mem_going_online_callback(arg);
>>
>> In slab_mem_going_online_callback we will cast arg to "struct
>> memory_notify", no?
> 
> Uhm... not sure if I understood this correctly but slab_mem_going_online_callback looks
> like this:
> 
>   static int slab_mem_going_online_callback(void *arg)
>   {
>           struct kmem_cache_node *n;
>           struct kmem_cache *s;
>           struct node_notify *narg = arg;
>           int nid = narg->nid;
>           int ret = 0;
> 

I'm stupid and missed that hunk, sorry.

> 
> 
>> Probably needs to get fixed.
>>
>> ... and probably best to pass marg directly.
> 
> You mean to cast it directly in slab_memory_callback and pass 'narg'
> to slab_mem_going_online_callback?

Yes :)



-- 
Cheers,

David / dhildenb