From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FD7EC6FA82 for ; Tue, 13 Sep 2022 03:42:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EF7848D0001; Mon, 12 Sep 2022 23:42:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E7F126B0073; Mon, 12 Sep 2022 23:42:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CF94B8D0001; Mon, 12 Sep 2022 23:42:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id BA66E6B0072 for ; Mon, 12 Sep 2022 23:42:15 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 6D7D3160A18 for ; Tue, 13 Sep 2022 03:42:15 +0000 (UTC) X-FDA: 79905664230.23.FCFC213 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf27.hostedemail.com (Postfix) with ESMTP id DCA95400F4 for ; Tue, 13 Sep 2022 03:42:14 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 20ED9B80E03; Tue, 13 Sep 2022 03:42:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C2227C433C1; Tue, 13 Sep 2022 03:42:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663040531; bh=VUeq6MUzXB3MhRWXQ1REV1K4QwHMVaOsxFDEM74s2JM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=EQ7adyotaOphDX46uv9SLP9FXSj7XTK0+OvL+hiaeepzepf6FMmqcAZJuORYxsoqL QGKm+7lx121CEUPtZ6WN21dExX2Ju8x2yQ60Nx7xcP6obu3F6QerPdFMyXPyXQsXXQ VwcSjxRwCkWCkj3SZdqV2MGXjUaXtdLW4cQ5q6ZabcLYDZx+NuswOALS4ALnihXCSQ bAYATikAnNwroYqQ3LDlXlPAJm58OycpOnN5RWm0u4R9JjmIzdVYDcg/AncOVws4Ft 91/nAde33ArG3aT5zPxKXYRn4kXXG8b0/Rbx2ZiyYihQ6kqKxQYQ6AwhGiEMi44/XM 6yE/2b/TtQW4g== Message-ID: Date: Tue, 13 Sep 2022 11:42:04 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] mm/slub: fix to return errno if kmalloc() fails Content-Language: en-US To: Christophe JAILLET , "Vlastimil Babka (SUSE)" , linux-mm@kvack.org Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, Chao Yu , muchun.song@linux.dev References: <20220830141009.150075-1-chao@kernel.org> <2025305d-16db-abdf-6cd3-1fb93371c2b4@wanadoo.fr> From: Chao Yu In-Reply-To: <2025305d-16db-abdf-6cd3-1fb93371c2b4@wanadoo.fr> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=EQ7adyot; spf=pass (imf27.hostedemail.com: domain of chao@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=chao@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663040535; a=rsa-sha256; cv=none; b=tiDanu+vG5f7DQTP/YY5wpF1gjEnr/2LVziqu7lcLtZsCA4gI/jk5TpRAeljWUqCGSeSgi KqNp/9KHjMxMJBBtAXN61StHWQrxq72YRHXtoG0jxhcj1J6fVeVeRdpIh+2jMvotiwc5Pd Gh2LvM7H6sWQYbEVnTmVCLZuduLetlk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663040535; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/FPxtsbdI4azn33/vL0P4c95Rw+66XO95lRy745bJyU=; b=ogxFKnlsKhzb7Mxm4x6U7ArXNqhRcwreVYZUValPirzj161vC9+ioj8Al3iB8l2JPxAwEQ NVYysw0CzJT0cOeH0zaclHTsq93GV2VxB1Bj/mah50LHqkOlv0gx8/R0S3ANpVDwXz363s 65WD7axhTN/Bj3WG3Nqk6Ku4RJnHI/8= X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: DCA95400F4 X-Rspam-User: Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=EQ7adyot; spf=pass (imf27.hostedemail.com: domain of chao@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=chao@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Stat-Signature: bgi5p6jkkhoei8r38c1pifbbpqwdkoyd X-HE-Tag: 1663040534-764661 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/9/10 0:47, Christophe JAILLET wrote: > Le 30/08/2022 à 16:10, Chao Yu a écrit : >> From: Chao Yu >> >> In create_unique_id(), kmalloc(, GFP_KERNEL) can fail due to >> out-of-memory, if it fails, return errno correctly rather than >> triggering panic via BUG_ON(); >> >> kernel BUG at mm/slub.c:5893! >> Internal error: Oops - BUG: 0 [#1] PREEMPT SMP >> >> Call trace: >>   sysfs_slab_add+0x258/0x260 mm/slub.c:5973 >>   __kmem_cache_create+0x60/0x118 mm/slub.c:4899 >>   create_cache mm/slab_common.c:229 [inline] >>   kmem_cache_create_usercopy+0x19c/0x31c mm/slab_common.c:335 >>   kmem_cache_create+0x1c/0x28 mm/slab_common.c:390 >>   f2fs_kmem_cache_create fs/f2fs/f2fs.h:2766 [inline] >>   f2fs_init_xattr_caches+0x78/0xb4 fs/f2fs/xattr.c:808 >>   f2fs_fill_super+0x1050/0x1e0c fs/f2fs/super.c:4149 >>   mount_bdev+0x1b8/0x210 fs/super.c:1400 >>   f2fs_mount+0x44/0x58 fs/f2fs/super.c:4512 >>   legacy_get_tree+0x30/0x74 fs/fs_context.c:610 >>   vfs_get_tree+0x40/0x140 fs/super.c:1530 >>   do_new_mount+0x1dc/0x4e4 fs/namespace.c:3040 >>   path_mount+0x358/0x914 fs/namespace.c:3370 >>   do_mount fs/namespace.c:3383 [inline] >>   __do_sys_mount fs/namespace.c:3591 [inline] >>   __se_sys_mount fs/namespace.c:3568 [inline] >>   __arm64_sys_mount+0x2f8/0x408 fs/namespace.c:3568 >> >> Cc: >> Reported-by: syzbot+81684812ea68216e08c5@syzkaller.appspotmail.com >> Signed-off-by: Chao Yu >> --- >>   mm/slub.c | 5 ++++- >>   1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/mm/slub.c b/mm/slub.c >> index 862dbd9af4f5..e6f3727b9ad2 100644 >> --- a/mm/slub.c >> +++ b/mm/slub.c >> @@ -5890,7 +5890,8 @@ static char *create_unique_id(struct kmem_cache *s) >>       char *name = kmalloc(ID_STR_LENGTH, GFP_KERNEL); > > Hi, > > looks that ID_STR_LENGTH could even be reduced to 32 or 16. > > The 2nd BUG_ON at the end of the function could certainly be just removed as well or remplaced by a: >        if (p > name + ID_STR_LENGTH - 1) { >         kfree(name); >         return -E; >     } Hi Christophe, Vlastimil, Should I include this in v3? or may be in another patch? Thanks, > > Just my 2c, > > CJ > >>       char *p = name; >> -    BUG_ON(!name); >> +    if (!name) >> +        return ERR_PTR(-ENOMEM); >>       *p++ = ':'; >>       /* >> @@ -5948,6 +5949,8 @@ static int sysfs_slab_add(struct kmem_cache *s) >>            * for the symlinks. >>            */ >>           name = create_unique_id(s); >> +        if (IS_ERR(name)) >> +            return PTR_ERR(name); >>       } >>       s->kobj.kset = kset; >