From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E871C5B555 for ; Wed, 4 Jun 2025 06:02:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1B6536B0595; Wed, 4 Jun 2025 02:02:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 166EC6B0597; Wed, 4 Jun 2025 02:02:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 055EF6B0598; Wed, 4 Jun 2025 02:02:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id DA9046B0595 for ; Wed, 4 Jun 2025 02:02:52 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 6670C1204F3 for ; Wed, 4 Jun 2025 06:02:52 +0000 (UTC) X-FDA: 83516674584.13.4F622AF Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf30.hostedemail.com (Postfix) with ESMTP id E03C68000A for ; Wed, 4 Jun 2025 06:02:49 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OwMIDZ50; spf=pass (imf30.hostedemail.com: domain of gshan@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=gshan@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749016970; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=k5uLUF947dFAnsNE7++/VYYbP4qG+tIlvwWDVTd+HiU=; b=kIq7MI8SomIJtXm+UA5sA4+lgHEnGmilnL9z69bJ2APBm6nBkyi0VoAjh8w22HiagIsk3s 4JGnDCYO3DytK4Ku/cvQkFNw0xpw6TNiGbhUMKeHpdFvJWs6lV8ZJ9if74pvsuKQ4p3Vdq q1y5yq+2yz22lJitNKwbI+Fy/AmJoHE= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OwMIDZ50; spf=pass (imf30.hostedemail.com: domain of gshan@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=gshan@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749016970; a=rsa-sha256; cv=none; b=CGDVK/UGjktWP9rhLDFTGrAvW2xrAijnK5YQ85m+75dmNKJfA+3RCU3XcYSixChILJDiL5 SnP8jXRCJ6/N0Zf9xO3bghIA0mbSR6JsJqaGUXZdO8Nhg4wdpThjRHcFBX0jfPxOaUThFG dbGWU1SLbxzKId+ksqNFZ+YTSL1F/qw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749016969; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=k5uLUF947dFAnsNE7++/VYYbP4qG+tIlvwWDVTd+HiU=; b=OwMIDZ50HYW3sxUHziLdQpd12urGmS9AHGAK5Fj2YahpDVhnr1ocq4VxNEiqnKCumdJaT6 ZF2RIL3ruZFmWC+2OV6F8TUPsNH6dPuOo+AiYAQhYmxJ0QbNVFwI9+mxrc5wOnvIxljHDm u/c27Qxr0UcKY4vkUFPPoCUhnNbYH3M= Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-611-V08e0insPd2xk8JMn1UHVw-1; Wed, 04 Jun 2025 02:02:47 -0400 X-MC-Unique: V08e0insPd2xk8JMn1UHVw-1 X-Mimecast-MFC-AGG-ID: V08e0insPd2xk8JMn1UHVw_1749016966 Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-747dd44048cso2853307b3a.3 for ; Tue, 03 Jun 2025 23:02:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749016966; x=1749621766; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=k5uLUF947dFAnsNE7++/VYYbP4qG+tIlvwWDVTd+HiU=; b=rdOtjxVhVfmJRx2wIti/T6b+Y6VSec2g3TiKIspFkZQ00YGyf5ha1+fOSPqYj03jNc cGnNOvUdYdRUqqbm/BGqzlBkiWaO5teTunsF23OW7dQXezki7HNIzJx633NVaAASs7zK 45FmO8cbJdHrMiTYutuzRSauFEN/8/FA4rNOPaY8HN4/yxjEXmqIPW+WegFdrQmVOKLG vlAw+0M/GzSQEF0Th+nu3iIfziVvFxN5ua+jGBx2mQ0n4Hp9Ajt+ymn09qeYNebwLNkl 2lAFpLSHmz4CWU8MVeAdUaRD374gfI2snOLWdm2L4PYN8JM0/GkobtR7B/i3iuhuI2QU yZww== X-Forwarded-Encrypted: i=1; AJvYcCXjQQV6uCrX45bdxaGx7xJqS1GZRhlqnqO3kQ0ecU076Jfh/JbXc9YQkEACBF/VIXoBTVM1ymSpVQ==@kvack.org X-Gm-Message-State: AOJu0Yz8lmNPUa2kM75y2rqKt4cIjB+BjlXBkofrN/G2Vwz9RNq78cKl jLsVQZHUkdjcM8CnU/tUcMTZtVU5VqglPbkI0a5sUAxrB8JklF23xxIRQqR49A/YffpR/TFmrsO p32MOQn2I/VS+oFQ5q6AGgLHBZ2V0X5wuXGrQhDiUeCZv+E74WAIY X-Gm-Gg: ASbGncuRLHxTwtsqYrCcN6+tqxPKDD08FYJZ8aHNY2+FHsNQQN2S22z0yjtrbKaqawS vTm76fuVB8xGH3JJ3L3QQK9Eg9C+t83v0Csb0mRGlG9+TIDW+uBcv/ovIMtqQlv8oDIRXwWW3xP x5zSjTnWD/UMejEdA7rXdNRMU1QvhzHrbJ7bn/VK39FdGlmRARDX+JWjhfM2463ic7+Kh6F6vOr lfYnAilwwYO1D2dVvf8u7KobLgcgbOwSNvDMDs9NCmFewtAKZ6HgW6AWVDrBuDTHSiDe3RELimm mEzyBXpzGh1mC+Vu1/MF8gL71VKwKKsiUYDIV5Mws/Mqg2q8ugs= X-Received: by 2002:a05:6a21:4cc1:b0:1f3:2e85:c052 with SMTP id adf61e73a8af0-21d22b7f532mr2763381637.35.1749016966126; Tue, 03 Jun 2025 23:02:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEbPgoAdH13lfHhim2/QFoHMd+Hf9TCaoInZNikaO5lQ5+Ego2tu4vOwUsU7zQXeW98WoOuzw== X-Received: by 2002:a05:6a21:4cc1:b0:1f3:2e85:c052 with SMTP id adf61e73a8af0-21d22b7f532mr2763286637.35.1749016965618; Tue, 03 Jun 2025 23:02:45 -0700 (PDT) Received: from [192.168.68.51] (n175-34-62-5.mrk21.qld.optusnet.com.au. [175.34.62.5]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b2eceb96f74sm7965235a12.62.2025.06.03.23.02.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Jun 2025 23:02:45 -0700 (PDT) Message-ID: Date: Wed, 4 Jun 2025 16:02:23 +1000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v10 08/16] KVM: guest_memfd: Allow host to map guest_memfd pages To: Fuad Tabba , kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org Cc: pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, david@redhat.com, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com, peterx@redhat.com, pankaj.gupta@amd.com, ira.weiny@intel.com References: <20250527180245.1413463-1-tabba@google.com> <20250527180245.1413463-9-tabba@google.com> From: Gavin Shan In-Reply-To: <20250527180245.1413463-9-tabba@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 7AjSBnTVvPXYPzQGSQoW2W8i0EEL-zlNKS6utQem2Ec_1749016966 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: ow7bp5wbwqeebucgwg1yactbnbetnwx5 X-Rspamd-Queue-Id: E03C68000A X-Rspam-User: X-Rspamd-Server: rspam02 X-HE-Tag: 1749016969-432453 X-HE-Meta: U2FsdGVkX1/kGGP3mnX0K1JucqY0qsnQ+sVMwfRB5CbV9BIsQTKbjfa79H1RWm7ZbKDtanuLbqLJHiJ7gVo5abf4ChrEbjTdYGGbWGl6VyYsfxTIH8Yp63cr1NLrT9niHyXUTP5iJ03RBQDyJZo3WokcCvbBpRA218FM3OEExO7oV4OW+FvW9Kdhe2eOy+SbHTcfbTJYhHdEQQdO/D2vnbdZNTh5LpSV20KENtFC9K4z2bYt/ryzBohZR8/Li1ZoqfAksrUlNh0H1AcA+PvG6PIS4bZIkjCuVhHqLp7WkE5UghT19LtDX8sCiu6Hwqve12/oqEp5RuermwvhQhFiA0BpvJz0bUrDgiaGMY4oVu+AtS4BOuZ+VHCz2yxlxN62VXYsP2xKmQV45uteSV8/W1+dd1XFwU4F6O1y8pe/A5LnUlPAJhB1NLVR22aRJbSi+hdgIddXWluwwFXLvOZBMUjUYNbnToZZ1FueSc4ADjEcKnHOCwvKWDN9jU3+IsLXsT7bcvn37DWw1ktaOXv7f2gaKL5vxA2FFapBr81y64zFgMjRO6eVhJwqn6MZhU3eIeQ45heDRvypVXJZJpW/kNSFcsNXpKYFtlnqFdutAaH1dVLOTuwpc3cyvBphQhyMZLGN4ALQZzTn/ygySc3Qvf3RpJrN7qq4Aa2QX9sY+B7D9741fsCXsdqq+1JXGGU665CgyIh5CWZWqYRYKG/7PK+gsgyHb/amBr0U0oARdlTwFm+8XgXmzoJzq/dn2U5go2bC9od3NX9k1PZUeMz8cdk5p8NsDbBNzu/Y65UAWyIljc1DsGu2/9y1DVUe866YoqvfjX/5HHug+R3D8NqLRUDwkMdVudKpLD8R8GphG3TC1YY3EMmgfIgWznxVn7yrOssGOHbEOafPk/xBSKLTaDPv3ZgurMqwTvHXM/tGXlRmCTuGfiPgmFHVp7JkFygL5K0hDY1JxjOij0NqagL jKKVS0aC Lkihd6epkgOtTTg9QF7E/Oqz0tSuymHBhCXPKyhniKjO+jaHe8LuG15rA9C0PCbrcIpnQ2j+lrKFH+MuGUFFsSiP40EYH+WAZTcz5uOAd2pXCFW63rrNBN/+ByGd+PuWoR3kxvMd/XJUL6aOMWikqgnEVIn92Ut+twunmXZ1YL6nlpzKdRz9cHYFLVDX15S+khLEQjuG414vt1o7dRHIGIrA4Zhny7qARUq+GJoYG/I9QTbXksiDljUddAr9dKdQqSTvt8IwB2pepOO+ufS9hPeylxmDm1envdzfNn2PWRixQXtP+V59jKxSHkmxOvSSm2ceAsBUa5uA62Td69jH2tEF2ILi69dA4m6D7CGLwxt+3gqKl1atdUfngNUGUk9IKvqquJPLSZCXqUimxh5RGNIokTnKK1nSi7hVDqCVAYj1prLhFPxZEhHoO3nQSAxipEKQFIjY3uyVYyivik7uxnZTQ1EPJGm99iAyHaBIM0X/zJ5xnPlTvChtx2eZCojGTDkl5mIrUD/hTqjCbkRFZQ5WQtQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Fuad, On 5/28/25 4:02 AM, Fuad Tabba wrote: > This patch enables support for shared memory in guest_memfd, including > mapping that memory at the host userspace. This support is gated by the > configuration option KVM_GMEM_SHARED_MEM, and toggled by the guest_memfd > flag GUEST_MEMFD_FLAG_SUPPORT_SHARED, which can be set when creating a > guest_memfd instance. > > Co-developed-by: Ackerley Tng > Signed-off-by: Ackerley Tng > Signed-off-by: Fuad Tabba > --- > arch/x86/include/asm/kvm_host.h | 10 ++++ > arch/x86/kvm/x86.c | 3 +- > include/linux/kvm_host.h | 13 ++++++ > include/uapi/linux/kvm.h | 1 + > virt/kvm/Kconfig | 5 ++ > virt/kvm/guest_memfd.c | 81 +++++++++++++++++++++++++++++++++ > 6 files changed, 112 insertions(+), 1 deletion(-) > > diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h > index 709cc2a7ba66..ce9ad4cd93c5 100644 > --- a/arch/x86/include/asm/kvm_host.h > +++ b/arch/x86/include/asm/kvm_host.h > @@ -2255,8 +2255,18 @@ void kvm_configure_mmu(bool enable_tdp, int tdp_forced_root_level, > > #ifdef CONFIG_KVM_GMEM > #define kvm_arch_supports_gmem(kvm) ((kvm)->arch.supports_gmem) > + > +/* > + * CoCo VMs with hardware support that use guest_memfd only for backing private > + * memory, e.g., TDX, cannot use guest_memfd with userspace mapping enabled. > + */ > +#define kvm_arch_supports_gmem_shared_mem(kvm) \ > + (IS_ENABLED(CONFIG_KVM_GMEM_SHARED_MEM) && \ > + ((kvm)->arch.vm_type == KVM_X86_SW_PROTECTED_VM || \ > + (kvm)->arch.vm_type == KVM_X86_DEFAULT_VM)) > #else > #define kvm_arch_supports_gmem(kvm) false > +#define kvm_arch_supports_gmem_shared_mem(kvm) false > #endif > > #define kvm_arch_has_readonly_mem(kvm) (!(kvm)->arch.has_protected_state) > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > index 035ced06b2dd..2a02f2457c42 100644 > --- a/arch/x86/kvm/x86.c > +++ b/arch/x86/kvm/x86.c > @@ -12718,7 +12718,8 @@ int kvm_arch_init_vm(struct kvm *kvm, unsigned long type) > return -EINVAL; > > kvm->arch.vm_type = type; > - kvm->arch.supports_gmem = (type == KVM_X86_SW_PROTECTED_VM); > + kvm->arch.supports_gmem = > + type == KVM_X86_DEFAULT_VM || type == KVM_X86_SW_PROTECTED_VM; > /* Decided by the vendor code for other VM types. */ > kvm->arch.pre_fault_allowed = > type == KVM_X86_DEFAULT_VM || type == KVM_X86_SW_PROTECTED_VM; > diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h > index 80371475818f..ba83547e62b0 100644 > --- a/include/linux/kvm_host.h > +++ b/include/linux/kvm_host.h > @@ -729,6 +729,19 @@ static inline bool kvm_arch_supports_gmem(struct kvm *kvm) > } > #endif > > +/* > + * Returns true if this VM supports shared mem in guest_memfd. > + * > + * Arch code must define kvm_arch_supports_gmem_shared_mem if support for > + * guest_memfd is enabled. > + */ > +#if !defined(kvm_arch_supports_gmem_shared_mem) && !IS_ENABLED(CONFIG_KVM_GMEM) > +static inline bool kvm_arch_supports_gmem_shared_mem(struct kvm *kvm) > +{ > + return false; > +} > +#endif > + > #ifndef kvm_arch_has_readonly_mem > static inline bool kvm_arch_has_readonly_mem(struct kvm *kvm) > { > diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h > index b6ae8ad8934b..c2714c9d1a0e 100644 > --- a/include/uapi/linux/kvm.h > +++ b/include/uapi/linux/kvm.h > @@ -1566,6 +1566,7 @@ struct kvm_memory_attributes { > #define KVM_MEMORY_ATTRIBUTE_PRIVATE (1ULL << 3) > > #define KVM_CREATE_GUEST_MEMFD _IOWR(KVMIO, 0xd4, struct kvm_create_guest_memfd) > +#define GUEST_MEMFD_FLAG_SUPPORT_SHARED (1ULL << 0) > > struct kvm_create_guest_memfd { > __u64 size; > diff --git a/virt/kvm/Kconfig b/virt/kvm/Kconfig > index 559c93ad90be..df225298ab10 100644 > --- a/virt/kvm/Kconfig > +++ b/virt/kvm/Kconfig > @@ -128,3 +128,8 @@ config HAVE_KVM_ARCH_GMEM_PREPARE > config HAVE_KVM_ARCH_GMEM_INVALIDATE > bool > depends on KVM_GMEM > + > +config KVM_GMEM_SHARED_MEM > + select KVM_GMEM > + bool > + prompt "Enable support for non-private (shared) memory in guest_memfd" > diff --git a/virt/kvm/guest_memfd.c b/virt/kvm/guest_memfd.c > index 6db515833f61..5d34712f64fc 100644 > --- a/virt/kvm/guest_memfd.c > +++ b/virt/kvm/guest_memfd.c > @@ -312,7 +312,81 @@ static pgoff_t kvm_gmem_get_index(struct kvm_memory_slot *slot, gfn_t gfn) > return gfn - slot->base_gfn + slot->gmem.pgoff; > } > > +static bool kvm_gmem_supports_shared(struct inode *inode) > +{ > + u64 flags; > + > + if (!IS_ENABLED(CONFIG_KVM_GMEM_SHARED_MEM)) > + return false; > + > + flags = (u64)inode->i_private; > + > + return flags & GUEST_MEMFD_FLAG_SUPPORT_SHARED; > +} > + > + > +#ifdef CONFIG_KVM_GMEM_SHARED_MEM > +static vm_fault_t kvm_gmem_fault_shared(struct vm_fault *vmf) > +{ > + struct inode *inode = file_inode(vmf->vma->vm_file); > + struct folio *folio; > + vm_fault_t ret = VM_FAULT_LOCKED; > + > + folio = kvm_gmem_get_folio(inode, vmf->pgoff); > + if (IS_ERR(folio)) { > + int err = PTR_ERR(folio); > + > + if (err == -EAGAIN) > + return VM_FAULT_RETRY; > + > + return vmf_error(err); > + } > + > + if (WARN_ON_ONCE(folio_test_large(folio))) { > + ret = VM_FAULT_SIGBUS; > + goto out_folio; > + } > + > + if (!folio_test_uptodate(folio)) { > + clear_highpage(folio_page(folio, 0)); > + kvm_gmem_mark_prepared(folio); > + } > + > + vmf->page = folio_file_page(folio, vmf->pgoff); > + > +out_folio: > + if (ret != VM_FAULT_LOCKED) { > + folio_unlock(folio); > + folio_put(folio); > + } > + > + return ret; > +} > + > +static const struct vm_operations_struct kvm_gmem_vm_ops = { > + .fault = kvm_gmem_fault_shared, > +}; > + > +static int kvm_gmem_mmap(struct file *file, struct vm_area_struct *vma) > +{ > + if (!kvm_gmem_supports_shared(file_inode(file))) > + return -ENODEV; > + > + if ((vma->vm_flags & (VM_SHARED | VM_MAYSHARE)) != > + (VM_SHARED | VM_MAYSHARE)) { > + return -EINVAL; > + } > + > + vma->vm_ops = &kvm_gmem_vm_ops; > + > + return 0; > +} > +#else > +#define kvm_gmem_mmap NULL > +#endif /* CONFIG_KVM_GMEM_SHARED_MEM */ > + nit: The hunk of code doesn't have to be guarded by CONFIG_KVM_GMEM_SHARED_MEM. With the guard removed, we run into error (-ENODEV) returned by kvm_gmem_mmap() for non-sharable (or non-mapped) file, same effect as to "kvm_gmem_fops.mmap = NULL". I may have missed other intentions to have this guard here. > static struct file_operations kvm_gmem_fops = { > + .mmap = kvm_gmem_mmap, > .open = generic_file_open, > .release = kvm_gmem_release, > .fallocate = kvm_gmem_fallocate, > @@ -463,6 +537,9 @@ int kvm_gmem_create(struct kvm *kvm, struct kvm_create_guest_memfd *args) > u64 flags = args->flags; > u64 valid_flags = 0; > > + if (kvm_arch_supports_gmem_shared_mem(kvm)) > + valid_flags |= GUEST_MEMFD_FLAG_SUPPORT_SHARED; > + > if (flags & ~valid_flags) > return -EINVAL; > > @@ -501,6 +578,10 @@ int kvm_gmem_bind(struct kvm *kvm, struct kvm_memory_slot *slot, > offset + size > i_size_read(inode)) > goto err; > > + if (kvm_gmem_supports_shared(inode) && > + !kvm_arch_supports_gmem_shared_mem(kvm)) > + goto err; > + This check looks unnecessary if I'm not missing anything. The file (inode) can't be created by kvm_gmem_create(GUEST_MEMFD_FLAG_SUPPORT_SHARED) on !kvm_arch_supports_gmem_shared_mem(). It means "kvm_gmem_supports_shared(inode) == true" is indicating "kvm_arch_supports_gmem_shared_mem(kvm) == true". In this case, we won't never break the check? :-) > filemap_invalidate_lock(inode->i_mapping); > > start = offset >> PAGE_SHIFT; Thanks, Gavin