From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55D17CCA470 for ; Wed, 1 Jun 2022 14:14:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 60BF98D0019; Wed, 1 Jun 2022 10:14:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5B7ED8D000E; Wed, 1 Jun 2022 10:14:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4A8588D0019; Wed, 1 Jun 2022 10:14:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 3B0EF8D000E for ; Wed, 1 Jun 2022 10:14:53 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E713D3462E for ; Wed, 1 Jun 2022 14:14:52 +0000 (UTC) X-FDA: 79529863224.16.91D0C35 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf07.hostedemail.com (Postfix) with ESMTP id C862740057 for ; Wed, 1 Jun 2022 14:14:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1654092890; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rh2kKuq7JT9nDpWOkwBlkZKD7rfR/HcqZJvN8704Ov8=; b=XacoGPHNIrh8ciDbRRgBelrWCc13fSlTXKHEUN95B0hr4SAJEKAmhUXda3WlI5N78S1zg6 dZxeXdRB11XOlKgUlVHSFzXY03h5uXn1lhut4tSZuupnzZHsKxZlfCS+FwPtSeKDWLAQO+ PFRgc/ybJkn2eUhMZwItLCRWoqmuatg= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-125-2WtMPqV0M7a4ByfagnG6rg-1; Wed, 01 Jun 2022 10:14:49 -0400 X-MC-Unique: 2WtMPqV0M7a4ByfagnG6rg-1 Received: by mail-wr1-f69.google.com with SMTP id c11-20020adffb4b000000b0020ff998391dso331852wrs.8 for ; Wed, 01 Jun 2022 07:14:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:from:to:references:organization:in-reply-to :content-transfer-encoding; bh=rh2kKuq7JT9nDpWOkwBlkZKD7rfR/HcqZJvN8704Ov8=; b=Dp6w2aVLQ9Nr/CwBaVDTlEBxD94kN9cMsh4qogRzVYZOAVAL/AjSbIbwNtXMEUvqf/ 9ua5sIR7JNXZ0FfPVyxRf9P1/aOeuC9gLW8zfSNaMFrxQZDzoZ8WmhX6sf/Rp43qipGU br8aXDZKSHlqLwUYnGYzGpoQRWeQwYg3FR2Sn6JJ9cczHq/uRp5SSXfjbYKh7LAFSUoC jqpsOI5rsP3LJLxxlpnxXvw2CEvZTL/7Tz6Cyk/FaEvmNrpoX9allIsPCoxdBmgef+Ug Gkfj1lNDD8+YJf5T1JbW8Mm43dVut0NYO1V+6pYLAjHwHgLg+u+qDf3gMiV7x1ovfnFF JSsg== X-Gm-Message-State: AOAM531eL8WS1yC8RuRyuZMavv6ar6P6D2wtgIVRlE+OqaQHjfQXa4Lj OnYYFtZbSgc2PDxPxVLxklUg7PxaBNBNb73Yx5+lhoiWLsImg9+U1plQwtSYa38hlGurM3r0GbU Dc7t8+y8XG0c= X-Received: by 2002:a05:6000:1006:b0:210:353e:32b2 with SMTP id a6-20020a056000100600b00210353e32b2mr12507733wrx.303.1654092888648; Wed, 01 Jun 2022 07:14:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx06pbtg967o6yanU0JAOXaZhgBCD/uDgV3zu70cIyg/nWCso+q8JR5Wi8x68ONFFSPJwAlVg== X-Received: by 2002:a05:6000:1006:b0:210:353e:32b2 with SMTP id a6-20020a056000100600b00210353e32b2mr12507708wrx.303.1654092888431; Wed, 01 Jun 2022 07:14:48 -0700 (PDT) Received: from ?IPV6:2003:cb:c705:2600:951d:63df:c091:3b45? (p200300cbc7052600951d63dfc0913b45.dip0.t-ipconnect.de. [2003:cb:c705:2600:951d:63df:c091:3b45]) by smtp.gmail.com with ESMTPSA id m15-20020a05600c3b0f00b003974ca9fa6dsm7705633wms.2.2022.06.01.07.14.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jun 2022 07:14:47 -0700 (PDT) Message-ID: Date: Wed, 1 Jun 2022 16:14:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 2/4] mm/shmem: return -EINVAL for addr not PAGE_SIZE aligned From: David Hildenbrand To: Chen Wandun , hughd@google.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220601124417.2872001-1-chenwandun@huawei.com> <20220601124417.2872001-3-chenwandun@huawei.com> Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XacoGPHN; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf07.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: C862740057 X-Stat-Signature: zuxzzibdsnfzotsadc4b5idcf3p7tjqm X-HE-Tag: 1654092878-460354 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 01.06.22 15:37, David Hildenbrand wrote: > On 01.06.22 14:44, Chen Wandun wrote: >> If addr is not PAGE_SIZE aligned, return -EINVAL directly. > > Why is this one to be treated in a special way compared to all of the > other related checks? Ah, I see you modify other places in other patches. Maybe just combine all these return value changes into a single patch? That makes it look less "special". -- Thanks, David / dhildenb