From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Muchun Song <muchun.song@linux.dev>
Cc: Longlong Xia <xialonglong2025@163.com>,
osalvador@suse.de, akpm@linux-foundation.org,
mike.kravetz@oracle.com, mhocko@suse.com, linmiaohe@huawei.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Longlong Xia <xialonglong@kylinos.cn>
Subject: Re: [PATCH 1/1] mm/hugetlb: do not dissolve gigantic pages without runtime support
Date: Thu, 20 Aug 2026 19:33:03 +0200 [thread overview]
Message-ID: <e29e8bbf-5a10-4868-87f4-09d48625f6e6@kernel.org> (raw)
In-Reply-To: <F06EC17D-2A3D-43DA-968B-1DD4E1253EF7@linux.dev>
On 8/20/26 11:38, Muchun Song wrote:
>
>
>> On Aug 19, 2026, at 16:52, David Hildenbrand (Arm) <david@kernel.org> wrote:
>>
>> On 8/17/26 18:20, Longlong Xia wrote:
>>> From: Longlong Xia <xialonglong@kylinos.cn>
>>>
>>> dissolve_free_hugetlb_folio() doesn't check hstate_is_gigantic_no_runtime(h)
>>> though remove_hugetlb_folio()/update_and_free_hugetlb_folio() silently
>>> bail for such folios
>>
>> That's odd. Why do they silently skip such folios instead of warning that
>> something unexpected is happening?
>>
>> This screams for a cleanup unless I am missing something :)
>
> Hi David,
>
> Sashiko actually has a pretty detailed description [1]. So I think it deserves a fix.
That's not what I meant. I agree that its a valid fix, but I think the code
should possibly be reworked to not get silent rejection from these
functions--IOW, likely the callers should make sure to never call them in this
scenario, and then VM_WARN_ON() instead of handling it silently.
--
Cheers,
David
prev parent reply other threads:[~2026-08-20 17:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-17 16:20 [PATCH 1/1] mm/hugetlb: do not dissolve gigantic pages without runtime support Longlong Xia
2026-08-18 3:26 ` Muchun Song
2026-08-19 8:52 ` David Hildenbrand (Arm)
2026-08-20 7:25 ` Longlong Xia
2026-08-20 9:38 ` Muchun Song
2026-08-20 17:33 ` David Hildenbrand (Arm) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e29e8bbf-5a10-4868-87f4-09d48625f6e6@kernel.org \
--to=david@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=mike.kravetz@oracle.com \
--cc=muchun.song@linux.dev \
--cc=osalvador@suse.de \
--cc=xialonglong2025@163.com \
--cc=xialonglong@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox