From: David Hildenbrand <david@redhat.com>
To: Mike Kravetz <mike.kravetz@oracle.com>, Jason Gunthorpe <jgg@nvidia.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Andrew Morton <akpm@linux-foundation.org>,
Peter Xu <peterx@redhat.com>, John Hubbard <jhubbard@nvidia.com>,
syzbot+f0b97304ef90f0d0b1dc@syzkaller.appspotmail.com
Subject: Re: [PATCH v1] mm/gup: disallow FOLL_FORCE|FOLL_WRITE on hugetlb mappings
Date: Mon, 21 Nov 2022 09:05:43 +0100 [thread overview]
Message-ID: <e2e59601-ced3-a62e-48e8-69fd24b1297e@redhat.com> (raw)
In-Reply-To: <Y2BIbyxT0Bh6bCUr@monkey>
On 31.10.22 23:13, Mike Kravetz wrote:
> On 10/31/22 13:14, Jason Gunthorpe wrote:
>> On Mon, Oct 31, 2022 at 04:25:24PM +0100, David Hildenbrand wrote:
>>> Cc: Andrew Morton <akpm@linux-foundation.org>
>>> Cc: Mike Kravetz <mike.kravetz@oracle.com>
>>> Cc: Peter Xu <peterx@redhat.com>
>>> Cc: John Hubbard <jhubbard@nvidia.com>
>>> Cc: Jason Gunthorpe <jgg@nvidia.com>
>>> Reported-by: syzbot+f0b97304ef90f0d0b1dc@syzkaller.appspotmail.com
>>> Signed-off-by: David Hildenbrand <david@redhat.com>
>>> ---
>>>
>>> I assume this has been broken at least since 2014, when mm/gup.c came to
>>> life. I failed to come up with a suitable Fixes tag quickly.
>>
>> I'm worried this would break RDMA over hugetlbfs maps - which is a
>> real thing people do.
>
> Yes, it is a real thing. Unfortunately, I do not know exactly how it is used.
>
>>
>> MikeK do you have test cases?
>
> Sorry, I do not have any test cases.
>
> I can ask one of our product groups about their usage. But, that would
> certainly not be a comprehensive view.
With
https://lkml.kernel.org/r/20221116102659.70287-1-david@redhat.com
on it's way, the RDMA concern should be gone, hopefully.
@Andrew, can you queue this one? Thanks.
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2022-11-21 8:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-31 15:25 [PATCH v1] mm/gup: disallow FOLL_FORCE|FOLL_WRITE on hugetlb mappings David Hildenbrand
2022-10-31 16:14 ` Jason Gunthorpe
2022-10-31 22:13 ` Mike Kravetz
2022-11-21 8:05 ` David Hildenbrand [this message]
2022-11-21 21:33 ` Andrew Morton
2022-11-22 9:05 ` David Hildenbrand
2022-11-22 17:41 ` Mike Kravetz
2022-11-22 17:59 ` Jason Gunthorpe
2022-11-22 23:03 ` Andrew Morton
2022-11-22 23:48 ` Mike Kravetz
2022-11-23 8:40 ` David Hildenbrand
2022-11-02 9:14 ` David Hildenbrand
2022-11-02 11:38 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2e59601-ced3-a62e-48e8-69fd24b1297e@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=jgg@nvidia.com \
--cc=jhubbard@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=peterx@redhat.com \
--cc=syzbot+f0b97304ef90f0d0b1dc@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).