From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 775A9C83F1A for ; Fri, 11 Jul 2025 13:29:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E89716B008C; Fri, 11 Jul 2025 09:29:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E3A0A6B00A5; Fri, 11 Jul 2025 09:29:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D02296B00A6; Fri, 11 Jul 2025 09:29:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id BF30D6B008C for ; Fri, 11 Jul 2025 09:29:48 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 647775EFB8 for ; Fri, 11 Jul 2025 13:29:48 +0000 (UTC) X-FDA: 83652066456.01.803B0AA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf29.hostedemail.com (Postfix) with ESMTP id D4662120007 for ; Fri, 11 Jul 2025 13:29:45 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EAB94ZzS; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752240586; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FWayNqEof3CPboKcwRiBzu8zVRh187wq4qLQtMB2hoc=; b=8C83rZkVR+RrQyfV2wEZlsGW6ZPcR8F6j89J0WVwwUzTBhI0L2K4SVJyx2x9KEApgZmm5x zBc9JqW27WWfIN7o9YkthG/b9d/AFq1HtbsrUssiPiqoYSIv1ab5PPnyj33+WJuQab5h0C MJu3exapf9wmA1DFV6hPmAsDe8MWT44= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752240586; a=rsa-sha256; cv=none; b=jyhsY6sxCoWAzCa10N1BoQjfXKFVvw3eccZ3snLkNTBekUYYsFwourWAjzYagfJYDHN16/ +66wFYImOwqbfqYFS7w8pNd8WVV/CijS4tr5bDN7h/Zk/syVPWwyNuz6QISzEcky+4gJzH RR4/BHRyQB7MWHuFdoXDxwC/po6hsGY= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EAB94ZzS; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752240585; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=FWayNqEof3CPboKcwRiBzu8zVRh187wq4qLQtMB2hoc=; b=EAB94ZzSnMlzR6A27sCx32IGefvko9kExXDEKlk5woe4Mn3FSUzKc0pP+GKFw5IATYQOLE NPYxlG3DVhu2nftpjvNugCc5FkBsNRPqtk8yj6mDjqOtOeYNKCsxNO1ix0GzFu5Pj8cHco mFo+8+6xwIa0oBK+lnrCUdFRgCtKpH0= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-62-4ak3wpo3O4K-1AE9EoFlWA-1; Fri, 11 Jul 2025 09:29:39 -0400 X-MC-Unique: 4ak3wpo3O4K-1AE9EoFlWA-1 X-Mimecast-MFC-AGG-ID: 4ak3wpo3O4K-1AE9EoFlWA_1752240578 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-45311704d1fso14243205e9.1 for ; Fri, 11 Jul 2025 06:29:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752240578; x=1752845378; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=FWayNqEof3CPboKcwRiBzu8zVRh187wq4qLQtMB2hoc=; b=RlWaECqqtpEkeB+Tzc1xt4/9ikhGdkmJBWX0yfWZRsAxuY89ORyop8jMBLEYvSA1OQ QyC9NSjRPh3iytsY3NYxCY0jCpoGgekI3+OYC2u7y/f1kEJG03xduXnAJExJk7fHxI1E 2fz45yFzbdm2pvdl07/2OQ6MEHeMkC8mjZnigoFshhLcOQ4aln+WdCJQRfaovRiuIiZ1 OzByydpa3WNUTx7XQ2pYacH6ckROyS3LRWCEKtOzpHIk3LWDvJ2g5CjHhdd3JRw/IWSy A7m7eOYeVa5DDmO4F2Nbf4HJVb02XHhRLukd8YetG9sFNcC9Uho377jCqm/Y58FbQh5x Ei4w== X-Forwarded-Encrypted: i=1; AJvYcCVK1bc3jUDFXC006FqChSRawaF0M19RFnW5Nn7aimSVvz+fX/mg33VPIe67qSZKeI5afU5H+NdfPA==@kvack.org X-Gm-Message-State: AOJu0YwnQTt+4LhVQeVqIieiVeMoBu4xWMnOpkAPnXti5JqhY1Wpno5G OaiBpzRWnBCZIJsu+x+OTwi85U8J3j2ETTcgm1sYjRxLaZgZAtPRUy5MIF5j/U5cURTQfltCbUC bsbwsg85Xr7EEaY/MpdXDSthU6PRKYPoDTgxd9PgNOquSr2QdgH1mySXUfbyYvGE= X-Gm-Gg: ASbGnctDbw/O2yUPTGB78aOgxQgrwaCCtckU3sZb6FoM1w7XopDPsDnCT40DDBZ9zmN 0ItDzhFER5dzWqjKBi/Hu3WGbZD2VZv1z1pu6pq3gfDcKbl2NBz1kI9FrSEUp33ARFRmGMH47Uh 8F+0jHUn5aGohIbuTILIuLqTL4KHoYxYYCSTGypADWMaItWNk3TBC67y8tutzoMXxGpxG3aKjlk XPf4+ybwFnftjrMIgpMFs78t0fzqcvePxZewwqKVsNafmGIN2Ks2Zjkdldbx6GHSruSz2Lqw4yc hivzCuWVg6S0SDfEdHTpkcviB+ehByt1EDE7MoqHlIK/rRkpgXDtyg41Y32bVRL4nbrrAkaSXIZ I/dJunfSwY1er1vNw+OODE3bzTPP3s/cVu5wf4XM7OKiKNkVEr5XAaVkgLRZ+1fk1tD0= X-Received: by 2002:a05:600c:8289:b0:43d:26e3:f2f6 with SMTP id 5b1f17b1804b1-454ec1516b8mr30227045e9.5.1752240577722; Fri, 11 Jul 2025 06:29:37 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHVapk8szymRwH8B2XrHeKjUHAvOctlqenT0WRp5OlN8BT5l3R1n4X9nsu/EyRKLbJS0bzhIw== X-Received: by 2002:a05:600c:8289:b0:43d:26e3:f2f6 with SMTP id 5b1f17b1804b1-454ec1516b8mr30226815e9.5.1752240577292; Fri, 11 Jul 2025 06:29:37 -0700 (PDT) Received: from ?IPV6:2003:d8:2f3c:3a00:5662:26b3:3e5d:438e? (p200300d82f3c3a00566226b33e5d438e.dip0.t-ipconnect.de. [2003:d8:2f3c:3a00:5662:26b3:3e5d:438e]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b5e8dc9349sm4418063f8f.45.2025.07.11.06.29.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Jul 2025 06:29:36 -0700 (PDT) Message-ID: Date: Fri, 11 Jul 2025 15:29:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] selftests/mm: fix split_huge_page_test for folio_split() tests. To: Zi Yan , Andrew Morton , linux-mm@kvack.org Cc: Lorenzo Stoakes , Baolin Wang , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Shuah Khan , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250709012800.3225727-1-ziy@nvidia.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250709012800.3225727-1-ziy@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 4O4KIYrhKzEMdE0YugZK7e2vI1T8zHbrcrGy7prBnXY_1752240578 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: D4662120007 X-Stat-Signature: h6e78xwasc4x46b3t3yu81dq7p89urb7 X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1752240585-698914 X-HE-Meta: U2FsdGVkX18wRFiR9LqrLwkor8hbMRqs/9dFCAaDglVnngr0AXhRva5PgtvshhYc2sv+BM4uzU7evaUyk6VtmHREUdumeTDfcKtdZ+e3duftjfZDhBMdsRrtawF216f9MG7z/33SspewMAL05XvVFeKuqmK5kS7oEcq/FYsciXYY00qktWqmdsRhHkK3xKlPgGnNQdOiAteCZ9d2DFOryP+EiX6frgFVgjLEMcn0CQ+D40XSzkh31O4QZ6/8PXT2M5CR0LS8dpaVzlK1/8z3/kHdig6uqXsYJn/o9r8+ri6TUvKKGV/nReuXAIfM7cvjavi8P9FUHg/nI+zlQPJQQm/J57Y/bOcb+u7HICDmC9mHjX5ARg6QfRIBpH0uATqo1+ce5b3sSTEcLX2o0sEFV6+JCoblKMRguRq5/5/7aw8JxYsYtNuw4t1QE8UXTtJsdT9qZ+f3pt0Kyru1Mzc6kKz6QcDvmKZ2A3PXhWFs7YSV7uvyMOte2WCjDMeRrB3uqvcQAzzLLgYuoVlW2Fwqu4riGYktKbsdFXXpccDFZG53gtSNEA/T4Nr1cy8/QSPT2+SWp/rXYYenkok43MbGCRim2BWIO2Lll9SJNm0xq61rRH+xbc4F7OnXtGFJ2DX27Z9AlyH+QGtheWgB3zPIH4h3ushI2WCRlSyFucFDK97TlI1d79xVZViJOmmFVvC15CjKvZSn9G+vZLpltCNOe1ZmXaCzdClXhvT/AWv0T03DqEfi+H3o2X3mZ99glbrOB47iM8AIyuNKCDf+KO2J3yYZb1aqhii1ndNfl2uQ3vN8fkpy7yMHQ1S/OW2uO6LHsg8Yg0ERqmj/89hTwgQLqe0p1vCB5Q5eJg6iLtanoRvBWjQ62acFye8tsn90PVLh0dNbyb5vIS5d2QArImvcqFihP8Vq/VlR5V0WZNcXXBNa2Z1ipe9Ho4AlSPFYIJtOGpXT9NpQ7jYxVdqaLM4 s6L5Jcqb j5b9KvCcE30ehIy5HXyY5DMawgS2bFlEQDnorsmH8LOvqAXBa8YfgCXU1NSOEd8V2fyIxBmO7DCZpthWwGQFlxVUe0yzSfTpedSvviE4+l/CGLUv4J5lFo9iuBR89ZxGTgqnOvJkXTCnLbL9pkcFKo2U9qdAhswCejWFShsMm6ftH0yGoRzFkFx1qpYA1NFnK8o0RtEzy+sVVs3hOw8mpEEZMfH8ywsAf/8Gz0qPbAraxy8wErSMZFanTA2ep9YVUMOmhNSWfwe1RhLhUnJma/y5CQwF/onuNvB7q2pfSIcovUkvupqiEm7+rcqLXnqdSMIlqG+GTHVDCT+nMLsEvc0epsfeERecrYon3JwKFfol/M/0zQAuJ5O7Z8MzuMr26CYZQQbuUB5OCibZCBLG2jz0pEG45A65SYOHsAtt3yfnwvSqX7ZbNwohMUuW3gXBd1zyZVbasPQtGSQRIrV/obI5pzZJG7lstaApmhrB+Ww1nuPnCiLm6l8FTX0ITW2nIEZlLyPmjbgMsse2P3L4TugANOA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 09.07.25 03:27, Zi Yan wrote: > PID_FMT does not have an offset field, so folio_split() tests are not > performed. Add PID_FMT_OFFSET with an offset field and use it to perform > folio_split() tests. > > Fixes: 80a5c494c89f ("selftests/mm: add tests for folio_split(), buddy allocator like split") > Signed-off-by: Zi Yan > --- > tools/testing/selftests/mm/split_huge_page_test.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/mm/split_huge_page_test.c b/tools/testing/selftests/mm/split_huge_page_test.c > index aa7400ed0e99..f0d9c035641d 100644 > --- a/tools/testing/selftests/mm/split_huge_page_test.c > +++ b/tools/testing/selftests/mm/split_huge_page_test.c > @@ -31,6 +31,7 @@ uint64_t pmd_pagesize; > #define INPUT_MAX 80 > > #define PID_FMT "%d,0x%lx,0x%lx,%d" > +#define PID_FMT_OFFSET "%d,0x%lx,0x%lx,%d,%d" > #define PATH_FMT "%s,0x%lx,0x%lx,%d" > > #define PFN_MASK ((1UL<<55)-1) > @@ -483,7 +484,7 @@ void split_thp_in_pagecache_to_order_at(size_t fd_size, const char *fs_loc, > write_debugfs(PID_FMT, getpid(), (uint64_t)addr, > (uint64_t)addr + fd_size, order); > else > - write_debugfs(PID_FMT, getpid(), (uint64_t)addr, > + write_debugfs(PID_FMT_OFFSET, getpid(), (uint64_t)addr, > (uint64_t)addr + fd_size, order, offset); > > for (i = 0; i < fd_size; i++) So I assume the tests still passed. Would there be a way to have made them fail? (IOW, detect that the wrong kind-of split was performed) Acked-by: David Hildenbrand -- Cheers, David / dhildenb