From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDC83C8303C for ; Tue, 8 Jul 2025 15:57:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 815686B0098; Tue, 8 Jul 2025 11:57:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 777256B0099; Tue, 8 Jul 2025 11:57:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5CA566B009A; Tue, 8 Jul 2025 11:57:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4BCA56B0098 for ; Tue, 8 Jul 2025 11:57:43 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id EA7851606AE for ; Tue, 8 Jul 2025 15:57:42 +0000 (UTC) X-FDA: 83641552764.16.678080A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf01.hostedemail.com (Postfix) with ESMTP id 67AA540005 for ; Tue, 8 Jul 2025 15:57:40 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=L0nYS9H5; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751990260; a=rsa-sha256; cv=none; b=m5l9nZEl3Bwqt+szU3IFQ5iEuVjpcP+YsK1JzK4eRaOVnF3FOtkeGFY3wU+nATbwY80/Kp 5R5zyvGoL2KKyJ3zgfIx5+UyBQocX7aTp/42fzXmvEISGut4ZeMCBw5akCm7HRbvaAbxnc tjrXmreckLBV2MpJisAF1degM4edqqM= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=L0nYS9H5; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751990260; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4RZO/B6cckBZV2TmP8OYCYVRHKXld2Kk5UsEofX/mOs=; b=OIqQtTCnSIVtjnPrtLIz1HsOQBUhmztSPJuYRvN08wj90NwfMhRhQuY8ItUJf+ZH5yVGcb SFmuAPX2j350BYqMz7wYe71RMflCfbg340biOdEgLaS9VuTFW5VYvQ42Uys2GbYaK435tg s1cML/VbSXpYwHRs/wkotZ7NC/rWsIQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751990259; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=4RZO/B6cckBZV2TmP8OYCYVRHKXld2Kk5UsEofX/mOs=; b=L0nYS9H56WAIOr5ziWkPK8LlPiXgZ1sdvHt4JfHYIna5hBOsFBiIFHgAqF4DAQpp3ytcBw Eunyy4tMOJ8LRaElKFDktiD0N6p461dxFetto2oW8JR+7EGDw1yFCa6+GTdNU2d+ReO4xO PsFJ9f7qzE8t6FaoOQ98D9YPUZEeGcE= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-597-2L_LdE9cNe63WIs1EEi3LA-1; Tue, 08 Jul 2025 11:57:36 -0400 X-MC-Unique: 2L_LdE9cNe63WIs1EEi3LA-1 X-Mimecast-MFC-AGG-ID: 2L_LdE9cNe63WIs1EEi3LA_1751990255 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3a4f6ba526eso2737570f8f.1 for ; Tue, 08 Jul 2025 08:57:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751990255; x=1752595055; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=4RZO/B6cckBZV2TmP8OYCYVRHKXld2Kk5UsEofX/mOs=; b=cUAp+9EU5eNdsuLrRVxdHz/HTaBWMjUC0ENwQc6JQOshxbFO6k0xnVhMhZi5Mv13wG TYw5/gGPCyNFJ2XoOrj+axO68+EyNMQw1eIzU1Wq+482SXDs2+/+fOs44gj7j8HbODal CbZBJJ9QchqN9AlpulEbTj8ZUPuurV0YLDbcxS12tK6RQxxXIVe0WoOhxNm00ZWRISur FR2ir3XGsAo/ZI4bRpHYUzZ/W+CfANYJqW1GRJzxSrpz8xWkrjOFqm2ECjPUV17BB9SA LJXLwCSmiN748Tfi7xBQfa+88D+hbqbTGHNFqzA+DrK51keqyvzKKFhx162SlMldYi4Z UiJw== X-Forwarded-Encrypted: i=1; AJvYcCWex/e6MRAJc1e2ugwbkeRMcUdAcuppJd6BfdAhk9A3rOXVzBYdjnAPgamashhYT6U6kqLjBjgwPw==@kvack.org X-Gm-Message-State: AOJu0Yzhvj39JNax26Eo6sy1QRh5/pXqNVLCW8LLDJ/4vY6DSig3oIn6 f2rBBhzCuRQSmRLD7m2BWC/EHIW8dDSLrGEbaYPVpRjb9WIvS9nU9Wh3jg8CgKneGrSX2Wvpk51 5MdRQJvlI8C6xzOLUdzrLvVV6v1u8xNKodmu17S5dYwOI7awDOBaS X-Gm-Gg: ASbGncvfJsmmKsC6/9R5C4/tkk1AS5/9n70olJH9ZTvlgft5tlwwuWFuzdntUZnRXz3 eKJbI+/VLBFkSRI45KidRyBR0Nqiih/qkMJg7ukDqLCIPCOKl51DJ9nH0YKqyoVD5jUYo4Tw2x+ 4mm/TALvTulLcGVFBaS7St9c57f0FUTSCNL+pKAUji5E5uiNK645VM1mZIfJFw6FhcdrswUmDOC nQ7s4wYzWpcwc/in9ry2junMW/r0vEp+ctBgi/nQrvewaoR5qNIKh02CJmJ+SgPheyXgFOz3DOg TRhV81AjjDu0Owa12c30dTU1EsJqG9c/PoJvuMMfVuCHZIkk6ozQYt3e0QDDAACgNrbFbrqOtxV 7zTUdUCdrmorgtMsY3I2ItPvD/forMdkdaiVYFJzavTPhmS7IGA== X-Received: by 2002:a05:6000:41d4:b0:3a6:f30b:2dd6 with SMTP id ffacd0b85a97d-3b4965f6d96mr17901691f8f.26.1751990255346; Tue, 08 Jul 2025 08:57:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEcGSrfGZ1BZUugI8BDX663vUiqM3J2TknJLhq+/2BgGK2arLtn/575E++y4wnCR+TyAdpncw== X-Received: by 2002:a05:6000:41d4:b0:3a6:f30b:2dd6 with SMTP id ffacd0b85a97d-3b4965f6d96mr17901669f8f.26.1751990254893; Tue, 08 Jul 2025 08:57:34 -0700 (PDT) Received: from ?IPV6:2003:d8:2f1a:f500:4346:f17c:2bde:808c? (p200300d82f1af5004346f17c2bde808c.dip0.t-ipconnect.de. [2003:d8:2f1a:f500:4346:f17c:2bde:808c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-454cd3d3f73sm26143715e9.0.2025.07.08.08.57.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Jul 2025 08:57:34 -0700 (PDT) Message-ID: Date: Tue, 8 Jul 2025 17:57:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 01/15] khugepaged: rename hpage_collapse_* to khugepaged_* To: Dev Jain , Nico Pache , linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Cc: ziy@nvidia.com, baolin.wang@linux.alibaba.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, ryan.roberts@arm.com, corbet@lwn.net, rostedt@goodmis.org, mhiramat@kernel.org, mathieu.desnoyers@efficios.com, akpm@linux-foundation.org, baohua@kernel.org, willy@infradead.org, peterx@redhat.com, wangkefeng.wang@huawei.com, usamaarif642@gmail.com, sunnanyong@huawei.com, vishal.moola@gmail.com, thomas.hellstrom@linux.intel.com, yang@os.amperecomputing.com, kirill.shutemov@linux.intel.com, aarcange@redhat.com, raquini@redhat.com, anshuman.khandual@arm.com, catalin.marinas@arm.com, tiwai@suse.de, will@kernel.org, dave.hansen@linux.intel.com, jack@suse.cz, cl@gentwo.org, jglisse@google.com, surenb@google.com, zokeefe@google.com, hannes@cmpxchg.org, rientjes@google.com, mhocko@suse.com, rdunlap@infradead.org References: <20250702055742.102808-1-npache@redhat.com> <20250702055742.102808-2-npache@redhat.com> <9076b4be-8b1d-4434-a72f-d7a829a1a30a@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <9076b4be-8b1d-4434-a72f-d7a829a1a30a@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 7ALI9QLyLtv7EhSSMmj8W98fKKonDRermHdEhUiZ1mY_1751990255 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 67AA540005 X-Stat-Signature: nk7mmyso1a7b5j8458o1ek78uwzmj5mx X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1751990260-885909 X-HE-Meta: U2FsdGVkX1+Jcw3CCAQkBVTwfX6GvihXnpSa4BJF0B048Pk1kmwkOJDczf8cxK6uhKBRrz6oAa7OcIUVdd00lIKtY6PJZvTZCdZyxGvKtJUHCyZ2DE3+gRvQEfUsDQ+B7Shv3YEtj0RnzpjUzs9uaGScQx92U93Wi5FrymHIVhX+PFlQgFH+E7HsiChmPenXNrG3B6O9P7FhffRm9Pyhs8IxybswE0woHS0dwWZHojNTrXQVBGCGoBCRF3AxkfVMGrr4ZXM3Z3cmSfzwEvRYZ4rneFlff4wYqDlKY7CduCDWICQ6r0GTu8h3l7ZVYm4s3jJfG+6n63YW6qhd9lnMqYuIeoc7AkrV2t4jKdPeP0OIAiPTPosJfekrySY4edMrMf+ppCVhJbhd6sFyucIIiwcOkD/wmy8oIQx3ILdZAfVdGxywIlyUG1XMZQuxYXTZDo3OPBilS//gGnuQelEWjO1pckNV8nbG2pUUjdqPGeSbl0MwZFx/8cPSlFTUNxERyBboXrUBetrVujSCO0iSE0oHsGbW7CSQdM7aWkPWVKM6xr97li2CvgjXSLIPKydLQAAeiwlDY3vMnwYF7sBLCTxrKLNketxygN0aNBuKNEmZ2WNTs1R/4Ot7dJnoPEwwLbCEAWrCQidZtsSdAOBBitAsUjluAiX2ekykFWAaa3ezGAtqugaT57+PQf4TSZDN7gbhb3QolewWwhEsQALnVYgVAku18fQJaZR7V76cQjYm2iJgYleC8QLawKqLhTBobv2tRe58+IMLKV+ZR2zsed/wVahNF4RHtuVJpZ1KihNLoNIZzahjBxQ87vKnzeCSMp/irTj6nucBgUcAJfBTH7nsjPVKceOH/AcI5aTDpHckjq81pUUBGoU6hYvAoHOd6Rw+N9w5DMPHmA3nbMmRW22gOifblbEGfzYlYu/9W1E7JUhLpKCVvwUng1e0BSHCtzzIw3/GRNAoGHDx9KO AEpFQHq6 oNbRzn2fU2dYGA5pK+DFDKFvZorgs2No+tWy5wUum30VqOT6QdLMagxeDV4ifTR2vA/gteBD4HIAPQD1jGB2T1WPCCo9MtF7nsW4BBmXUEn9B2neBTvJrhD94LYxpUAAmOrnjKQSF2lTEJBW1GfCs8l0mNagz2VCI/90iFPre2xFEWKdPD9AnAV1fWt9Ly5ZJcIUSL7Eru6Yn0lz/DsEh3xHdvvCRiI0cPgXPmtqe0fUVJE/oeeI6SgMxb0L/w6Ki2RcTJ2IA7CQnABJ1wW4DG0/qVhdVwX6v0NjspUwf+H1b3O5ZbHlyOr6rTv0u35s2RsNmtZxfzVUsCg1bRMAf/H2w2sImJ5wvGex81cYz+6WnWdrRbiKPUOwO4RsgxaGjmv9i2pbQfDyMsSmNDe4y/8L775BSqlEXDkfcwCaonbVpU6TONssA9IO5dw+Mg5z+iRY0fP2a4fRhDzUJJ1Y8x/lndwa8TGl8gikI2+zLAVlE9b8N7/4/rTYMkK3Vq7aRiwjSgH+9iBzuEtl/oyCvKKs3jMsbUGvxuLPY4WVcGUxORc/gNf9yWGQfFGP7fPCTRLi2pNbvahbO2+wzDxxGI7+5XHjabwljWnDsPP3Jf/XavXw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 04.07.25 07:14, Dev Jain wrote: > > On 02/07/25 11:27 am, Nico Pache wrote: >> functions in khugepaged.c use a mix of hpage_collapse and khugepaged >> as the function prefix. >> >> rename all of them to khugepaged to keep things consistent and slightly >> shorten the function names. >> >> Reviewed-by: Zi Yan >> Reviewed-by: Baolin Wang >> Signed-off-by: Nico Pache >> --- >> > > You are essentially reverting commit 7d8faaf15545 which adds the > hpage_collapse_ prefix. Since in the next patch you also unify > madvise and khugepaged, removing hpage_collapse prefix would > make sense, but then I tend to agree with Liam that dropping > the prefix altogether is better. Having all the functions in > khugepaged.c prefixed with khugepaged_ seems unnecessary work. Yeah. Or just "collapse_". Anything is better than this "hpage" stuff. > > @David, I forgot where you replied but I remember you saying > that we should not introduce MADV_COLLAPSE mTHP support for > now? Yes, that's what Lorenzo and me discussed. Better to keep it at PMDs for now, as that's what the current interface promises. In theory, we could do something like the following without causing too much trouble: Collapse to the largest THP spanned by the range. I.e., when collapsing a 2M aligned range, only use a 2M THP. when collapsing a 64K aligned range, only use a 64K THP. etc. Because that would keep existing behavior mostly unchanged. But I would defer all that for now ... -- Cheers, David / dhildenb