From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17625C6379F for ; Sat, 11 Feb 2023 08:18:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1FCA46B0074; Sat, 11 Feb 2023 03:18:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1AE4F6B0075; Sat, 11 Feb 2023 03:18:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 075B56B0078; Sat, 11 Feb 2023 03:18:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id EC7D66B0074 for ; Sat, 11 Feb 2023 03:18:05 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id C03DE1A140F for ; Sat, 11 Feb 2023 08:18:05 +0000 (UTC) X-FDA: 80454308130.01.EB1D45C Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) by imf20.hostedemail.com (Postfix) with ESMTP id BCB5C1C0008 for ; Sat, 11 Feb 2023 08:18:03 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=mQCPAzWf; spf=pass (imf20.hostedemail.com: domain of bagasdotme@gmail.com designates 209.85.210.182 as permitted sender) smtp.mailfrom=bagasdotme@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676103483; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rW1BUSMrAhrgql9xxXVd047UVudLKi81PnrH+oLQFDk=; b=VHHw60tf6Ihn9BW7c3FL8L+M20yUNyLqkqLJniWYdICTYVUEZzZ8J5fZWShzTsX2761bUA kkQLgTDno+IrC7AQgN/CfrpwfsFQxFWaNpUPlD87yh8Mc3WCOhBz2aFdmxMAm51CxfS0ec mVk516aGKYm++lQyWCU1Tc/vf/c8+eQ= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=mQCPAzWf; spf=pass (imf20.hostedemail.com: domain of bagasdotme@gmail.com designates 209.85.210.182 as permitted sender) smtp.mailfrom=bagasdotme@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676103483; a=rsa-sha256; cv=none; b=kIt4gmJCP4jKVdVqcy/EcDMCzoCxziEuJIb/zLjp8GnX85LJHQSOfApXxUwWfls8c2eOMZ 4BNDRratdpD/QhKrqbM03u86nhl+AFAdF2PDdX+oxfjsbRjpD3iaaU0gcmGhBVbx+QoLBn MFJ1i0m+bxqeal8N3sayNHcRYrVRMUo= Received: by mail-pf1-f182.google.com with SMTP id s20so4994673pfe.2 for ; Sat, 11 Feb 2023 00:18:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=rW1BUSMrAhrgql9xxXVd047UVudLKi81PnrH+oLQFDk=; b=mQCPAzWfOgLYC4qODRKK/T87mp9xSEFeVo9A4LGi3kdivVhsxe+22zzSO+cChGtl/V d3PSYmNQMMMae0idpmILhADiHWN+LZII/ChSF4AwIo9KABUJB8Mh4TT+AIzk5s93jyZe uDvkBv4gJSquGbaa9TSN2/h9mZqU8ofUu6P6enmwXSIIQ1AQz385sgbMIJa+J6owZ/It 62VSgk1jt9QTmU/rvZToHuMYV6RG1DcbdH9VcKN7GveOsaE/0EVdO93lEznT3nU1wVWS osOA/wK9pOFwW1EBaXXvbMnAeKEXnUAwaodzGNdp2sUvf6mLQYoJPMzA8jbm0/gtdUQH kFJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rW1BUSMrAhrgql9xxXVd047UVudLKi81PnrH+oLQFDk=; b=hntyoNkdoY08Mq0gnnyf9Lslj880XnFFiNYNzzZOREgAt4IRI4zZItY3sp5o34AQuS +oICx6xX+T5pVmc4yk7gVVYJuQ9RSIZU9xUx7BgyEVebe6/4os/IGdUsnP8l0I6zNuPG nfVGrPM54s9DIcgZ44H+GX6Rc+PZs1Wq9W4j20K72d6MhZzH/KvUds1QAdBiVVsc3gOF 0IVYRNFQFIaBqXuJACG6Bbrta+/N0iVzZZeIZtBconYUcZnvQ8CRaTa0LZZ/QVhtOhpB 4V+cGZw1QY5+UcyQnu16KnfYotKuffMky0sjPAjWe1i/qsUOuCr3VRHUWF8sBx+50YuQ oC+A== X-Gm-Message-State: AO0yUKV4z55RBzUGdwJxZ/Ge7NgAt6Eq7Toe/nnYfb1bfW14+5QcjDpi v9eevvjBANuLR90Ccf6Fp5Q= X-Google-Smtp-Source: AK7set9VLKH+usjF9sXvLVOUzWF+B/aliECXdUwnqlV6PwGm2640y3tu5l+HODFuNrfkb3kwe68svA== X-Received: by 2002:a62:7bd6:0:b0:587:f436:6ea8 with SMTP id w205-20020a627bd6000000b00587f4366ea8mr14567193pfc.16.1676103482489; Sat, 11 Feb 2023 00:18:02 -0800 (PST) Received: from [192.168.43.80] (subs32-116-206-28-35.three.co.id. [116.206.28.35]) by smtp.gmail.com with ESMTPSA id a23-20020a62bd17000000b005a816b7c3e8sm4424615pff.24.2023.02.11.00.17.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 11 Feb 2023 00:18:02 -0800 (PST) Message-ID: Date: Sat, 11 Feb 2023 15:17:57 +0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [RFC PATCH v2 09/19] docs: document general_profit sysfs knob Content-Language: en-US To: Stefan Roesch , kernel-team@fb.com Cc: linux-mm@kvack.org, riel@surriel.com, mhocko@suse.com, david@redhat.com, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org, akpm@linux-foundation.org References: <20230210215023.2740545-1-shr@devkernel.io> <20230210215023.2740545-10-shr@devkernel.io> From: Bagas Sanjaya In-Reply-To: <20230210215023.2740545-10-shr@devkernel.io> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: BCB5C1C0008 X-Stat-Signature: p5pz1h5gxfzwwcttodnxc4yuqk6idgnm X-Rspam-User: X-HE-Tag: 1676103483-606161 X-HE-Meta: U2FsdGVkX1+zj6VRqLZm4KWncQL6wLL9Bg4rie52tHQaKF+UnW4f895XlfRlH3x4tLJOQXoJUnqSkblrK8xjwPL5+k2l5gpA/aAwJ8L+RPwT+J0dLu8qx/1M3OJcLebP4xuoK7PLgSJmXhCkACALGvsgRoIXj0dVkUnufTwUTRfVJnQquI7Sz7ThZ3PL3rUDa72/50lg0pkBn9QG6AXFz7ns6cLkc9B1+yS8Sw0VCRGesfQuMNvysVC1tL5u9CyoUKy2ze5eLge78F7WQ2PToC/m1a/lqnGSiNO1sUjWCPsC2IvQqJ8VA9lxLBwzrsFj0ekV39kyMGWatT3WRdL4mMMTvJF6RRmxnM+bbN8ebd9CA6Ilhgo4CrCujYu1SmB/l8n9ealoYFEkRZ+NNQ98HP9UImG/u0mg+wYOaFdnN39XRWr3G1Bt/z56FfwsPIKDfan9yl4DHEYQkN3ROyjSDF4e8Jso1lnbTxMBs+624+Oxwmv9R1cldjXbM7oMwZiRcuALuYsdeyPr9EMWmTlyWApUc7fNZXuHCaSfl5ZXKIrCsFiVcpWN1z+3q5aXuC0uGd3C9M1LcW75/nbJZNAaghSr8m8O1xtecrz3VDXlpJRi+uD+DZ/XqsoGE3PKmmPMK7i3Dql3b/jdscSwORKv30kYnkdbqj6X5Eaf242D1WyTvG5JvWenurevgzlPDAK8wcPGo8VYmz3aBMRaGHEbdptQnnidULJWMLl2wyV+3CfbbVqMM0DaxRYAdnVRciHQlZvBe5vcW0KboTPpVYSyKDx+guUlZx92tfwg2BseE/lTgOxap5OxVoG1oYAcEFPuQRSy/ygUGRaUQYO6+fcB9U8Bmm1tBjZ53encOl+NWHyw2qpIs+0S94hi5ZvoHhTWlR4mgvZI5jPJn6TQFFSs2q6vdDlRUayAFCOfx0VC6gAByD7yML9AX6iMLPw5ve98u8VfHNuaTQJe7lDbuXv Znhaw17m v0QgJsgTa4ubxUp70URIL7I1AfBoaGU0oqoAqyv/d6RYkStBaohcnPqB20N3LoFA9949gx0buTxggr06ynExQtPeQWlKVSyrRTg+1mc5dGJ12x8xmHYHTNpa0wdpJekPtzCyYfVcy1sybrd3Gu2ySuITwNgQolK47UGtR8xFwNgYvAzZawqiTsrWHtCSR/TDZqSrSnCFdtRyOi4UJ0mco6gldlZRo8FHpUrHrRzVEnMFqAolOI7VNREzrg5o2neMzgLtAG+xNWufm60WEcnPtqpqd3OCg8OnEWybvKvv55oRmuO1yddIlmirkFhgRkPWkIq2Wr+57dZR1Km/YAwuMZ5eX7sC4I7QE30mivS85FP+2RhDoE79U/VzpVOSwth5K0nCEqrwzSqj0dUXLil1tI3uezxKCslmVRkjbWDeF4N8n/Ft/2GwlAQKyjI7QoKHA+DkQ2IyLzwL9NbX8lmOuWY+FfLjomOVomkbj+cwHIlFPOJzTPUscLVoqZ0foOZHIFA1BneER1fskPOVGyZuydjFu+CvYZfb8ZnOp3n16tZTE/Oph4xfErck7cYaYELpu6lSHwlztvGn4CjgaIka1QJTKksr9ga8rjb0I X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/11/23 04:50, Stefan Roesch wrote: > Document general_progit knob. Book about Git :); it should have been general_profit. > diff --git a/Documentation/ABI/testing/sysfs-kernel-mm-ksm b/Documentation/ABI/testing/sysfs-kernel-mm-ksm > index d244674a9480..7768e90f7a8f 100644 > --- a/Documentation/ABI/testing/sysfs-kernel-mm-ksm > +++ b/Documentation/ABI/testing/sysfs-kernel-mm-ksm > @@ -51,3 +51,11 @@ Description: Control merging pages across different NUMA nodes. > > When it is set to 0 only pages from the same node are merged, > otherwise pages from all nodes can be merged together (default). > + > +What: /sys/kernel/mm/ksm/general_profit > +Date: January 2023 > +KernelVersion: 6.1 > +Contact: Linux memory management mailing list > +Description: Measure how effective KSM is. > + general_profit: how effective is KSM. The formula for the > + calculation is in Documentation/admin-guide/mm/ksm.rst. > diff --git a/Documentation/admin-guide/mm/ksm.rst b/Documentation/admin-guide/mm/ksm.rst > index f160f9487a90..5c4daf44d79d 100644 > --- a/Documentation/admin-guide/mm/ksm.rst > +++ b/Documentation/admin-guide/mm/ksm.rst > @@ -159,6 +159,8 @@ stable_node_chains_prune_millisecs > > The effectiveness of KSM and MADV_MERGEABLE is shown in ``/sys/kernel/mm/ksm/``: > > +general_profit > + how effective is KSM. The calculation is explained below. > pages_shared > how many shared pages are being used > pages_sharing LGTM, thanks! Reviewed-by: Bagas Sanjaya -- An old man doll... just what I always wanted! - Clara