From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D537EC5475B for ; Fri, 8 Mar 2024 17:09:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 61B636B03C2; Fri, 8 Mar 2024 12:09:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5A2776B03C3; Fri, 8 Mar 2024 12:09:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 443886B03C4; Fri, 8 Mar 2024 12:09:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 3119E6B03C2 for ; Fri, 8 Mar 2024 12:09:03 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id F146F408B2 for ; Fri, 8 Mar 2024 17:09:02 +0000 (UTC) X-FDA: 81874506924.24.2C47276 Received: from gentwo.org (gentwo.org [62.72.0.81]) by imf07.hostedemail.com (Postfix) with ESMTP id 159AE40025 for ; Fri, 8 Mar 2024 17:09:00 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=linux.com (policy=none); spf=softfail (imf07.hostedemail.com: 62.72.0.81 is neither permitted nor denied by domain of cl@linux.com) smtp.mailfrom=cl@linux.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709917741; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xj3So1eM3CtEz0vg8r1Z8IzRl3q1ro3PC8icVYall4I=; b=PlB9CYxbdLNtg54rfOFZFutcvjm6a6e6YI43gZgCX5uhOErVqmfObTkn17YBXR7mnnr+WK rfOL0sPaUnGiVWtGT+Yk45uxMv09t9RFcU2ZJVqL+Zg7+ZdtGV+kD6w2jABZlSqx6W8PjU G8EjeSTk43KpQo/7Sb5hoEosh4qHDEk= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=linux.com (policy=none); spf=softfail (imf07.hostedemail.com: 62.72.0.81 is neither permitted nor denied by domain of cl@linux.com) smtp.mailfrom=cl@linux.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709917741; a=rsa-sha256; cv=none; b=eaMalg8so6sgBUXgUa86qwfG7L8ZoOYGCPUkpPkJRHKc/rSY2X//MkfzQGNNi34kZegGpO I+v0J1WX+KwQBKxLozP4v7THPusk4yaMTqhDqBDJQAchYedcMIFIX92wseHnLaPzdSPmwH w3SCnN/2d7j1OEeCaMvy7ktWmmgVwto= Received: by gentwo.org (Postfix, from userid 1003) id A0A2D40A96; Fri, 8 Mar 2024 09:08:59 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by gentwo.org (Postfix) with ESMTP id 9F50A40A93; Fri, 8 Mar 2024 09:08:59 -0800 (PST) Date: Fri, 8 Mar 2024 09:08:59 -0800 (PST) From: "Christoph Lameter (Ampere)" To: Marek Szyprowski cc: Catalin Marinas , Mark Rutland , "linux-pm@vger.kernel.org" , "Rafael J. Wysocki" , Viresh Kumar , Will Deacon , Jonathan.Cameron@huawei.com, Matteo.Carlini@arm.com, Valentin.Schneider@arm.com, akpm@linux-foundation.org, anshuman.khandual@arm.com, Eric Mackay , dave.kleikamp@oracle.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux@armlinux.org.uk, robin.murphy@arm.com, vanshikonda@os.amperecomputing.com, yang@os.amperecomputing.com, Nishanth Menon , Stephen Boyd Subject: Re: [PATCH v3] ARM64: Dynamically allocate cpumasks and increase supported CPUs to 512 In-Reply-To: Message-ID: References: <37099a57-b655-3b3a-56d0-5f7fbd49d7db@gentwo.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed X-Rspamd-Queue-Id: 159AE40025 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: njae4a3sei1omig6dtb8uf6x98d9xino X-HE-Tag: 1709917740-701204 X-HE-Meta: U2FsdGVkX195J9+bA2/3rm+40w1bfLjFAjVzBzm/VV3IbeggN3y8KI/sQ7hovOgg4nnh0RYYx1gk2izlhcwA6alaKtkj3+cQyEcCGpOrG4+j59NnIRdSSSsdCSQkuBfRBsVGoxD9x3ZBkzoUwsVYLgB7l8vde70kytYJqbb9fTtfY3zorDUfmIJ2OqH3KJbwx5C4khdHyxoNQ1CiOLrSxyRzuAIHIad8rTV0RUvjITcCn0/yP2B85AC9zv8TWhXZgo40USGGtD9544TCV2MemPvZ6HMhfcGLgtQkzzRfSoyTwi/KZ5Cq39f+hQzf2i0jQZKQr+BIQ/uXJKP7R4f7QIIxnIXovH2fbd44z3zGE/mmBDP1Cl8pYiXJFEwCCWUN2Yl5U5JkEhw+xJt3wc9+/QnXEEAgo6ixGmLWgXYZITivMO3EQe9ZG+5H8yeWemyBJaebPmmODrD4nKFEK8JIuru+d7IThOtXIlFU5TkpLm4WjkiQuHgxlBYfkIplTvRMebYM1rXW0WG555VREPFWeSmrxxkRYK8KJci4SzIb3pyWpjLVbobEb4BmhS+YSb+M4wFHfzRyZfESopAgWSxJ6pKh5tZEbjwGcM0bwpnK+8kWcmCdrcW2+ecAQKevFmQleqtgsBu56VWvpzmUtG3oHEHOkOn4QDUf2dQ7ERcd3X8fnIRerj6z3hHhckDiIj9FZcJVSgknoThFvCht7NVuUH+s5TSETwAQZu+gqA7T3xmBtQsTGmUsJl0N2ht8gKv8qVuKZE/rNzNHkVha7w/5SbLWvH7uFAjYLwISHRX10mzqkskhGg4LBAuffgUkP8xSjDjsshhbUR1DD7U08+txz79GF4aqrqy9PDjdMOv9osm3Rm/AcHT4MbFoJzOdK3We X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 8 Mar 2024, Marek Szyprowski wrote: >>> >>> It looks that cpufreq-dt and/or opp drivers needs some adjustments >>> related with this change. >> That's strange. Is this with defconfig? I wonder whether NR_CPUS being >> larger caused the issue with this specific code. Otherwise >> CPUMASK_OFFSTACK may not work that well on arm64. cpumask handling must use the accessor functions provided in include/linux/cpumask.h for declaring and accessing cpumasks. It is likely related to the driver opencoding one of the accessors. I.e. you must use alloc_cpumask_var() and not allocate yourself on the stack.