From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C544C5321D for ; Mon, 26 Aug 2024 14:46:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 09AE46B0083; Mon, 26 Aug 2024 10:46:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 04AB16B0085; Mon, 26 Aug 2024 10:46:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E06906B0088; Mon, 26 Aug 2024 10:46:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id C22766B0083 for ; Mon, 26 Aug 2024 10:46:36 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 43D30A11D9 for ; Mon, 26 Aug 2024 14:46:36 +0000 (UTC) X-FDA: 82494672792.24.D54E534 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf21.hostedemail.com (Postfix) with ESMTP id 06B6C1C0011 for ; Mon, 26 Aug 2024 14:46:33 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="M/MANOu5"; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724683550; a=rsa-sha256; cv=none; b=0RlnCd6uAX0iFBD+43R45Cu6hNUxIJ+J76zVJArTqqn5tW9Ih8d0BwoUDihsvLhsfGpK01 Y6frLh0woJpcy6WI+5FPS6I9XMOrORJ1pUHOrva50wdK5N2UlApoXa2sjCYVzQxcy55xq2 vdZfGcBwD/vSS4B9spBA+9suv4t8QRg= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="M/MANOu5"; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724683550; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kbqMMbu6caOP0lR/D0LmakYT5rRJM1rrpPRZiwQPOpE=; b=a9YLQ9wQpmPIdW6Qur93qeo8q6XCMFCYh1jlW9mqIQToed7h+8MU2H7TQ4uCfIIqbyDyhY ZIg2RdQrU6IR0HPcTRvV9AZB5vKoLFh+C7hDcN4g37mbzOlP91lW7AdQmBsWZAa7Y4F/0S muOmwZv/rmgFHZb1Gq4xtR8EzO1IqaI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724683593; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=kbqMMbu6caOP0lR/D0LmakYT5rRJM1rrpPRZiwQPOpE=; b=M/MANOu5fAbE8xWBJGKV1VGZI9ty0iyeOicGZSijFP/ASIV9EdXnRI53SqTEhq6XpCRI5d E70wv5OZ4JnrOaD9bPo31FrRffz7JMX7KPtU1qh2bBP9c2dvPfrarwO0cRPmw2QpWUJhZi 0DfMaQhg4OHri/w8/D6VAA02Op7PwcM= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-186-atcnohO-N42Zvv87HMgX_w-1; Mon, 26 Aug 2024 10:46:32 -0400 X-MC-Unique: atcnohO-N42Zvv87HMgX_w-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-428207daff2so41643365e9.0 for ; Mon, 26 Aug 2024 07:46:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724683591; x=1725288391; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=kbqMMbu6caOP0lR/D0LmakYT5rRJM1rrpPRZiwQPOpE=; b=GHK81N34Pw08jGsm0GvHz/L/8fEtrgwYhKhK/VD+PaKJzBiQ9Wedsoi6jG3d8n+5+W zf453tYzMt0Bwu2G4FgetzKmBXcrqEYzTYdqpXmkq5YCUwU4IFTEUxgrCUAacSlEWgvd iUkEkCkYURwbpSq4gBDnxd8G1EfBgOmE8cv7isxtp8ZVm9mVQG0+Rg/K5IXPfZICqixs O3cC6IPvbgqJmCiJPxfoP5JGV2mzKJMN7bM9j4UbBPby8m/rkLvxVDcfd6PJcMQNDXR+ pFd6qGCYT8/d/vevMswbqDOV7YBWEKmrUn92CNj6euZZhwRX+vq7qA1E1nb2oEb+LMVW x+mQ== X-Forwarded-Encrypted: i=1; AJvYcCWyd75/K3qpZsmghP+wTJLQYEYKis7X5j2UUEiikWtCEVVu9W+jDWG2uw9/l4iTA1Z0HV4UzAtRqA==@kvack.org X-Gm-Message-State: AOJu0YxvPxArKoVjaw0BKJWWqSdlLktKluLgOxwryDe6xGwK+ZsBKZ1i eji/Wd+ZHY9aUVc4PhuSJOEJOk/5rbuJoqT2kBV2aA84UvpWLliCIyPZb6Moxmav9PdWJhTy9cM OESwSXuKaEISv5mr1IUtDsTayqEFLEbbtGhwxQkRAjVe0iUPt X-Received: by 2002:a05:600c:310f:b0:426:51ce:bb14 with SMTP id 5b1f17b1804b1-42acd5d79b1mr62388995e9.30.1724683590698; Mon, 26 Aug 2024 07:46:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHlhwpt2z7GeV5mTNTfVB5Cg7RQQqS4ClxkKScFol2fv5uSDhCB+B1ggAUvvMjLuhCAY7rtEw== X-Received: by 2002:a05:600c:310f:b0:426:51ce:bb14 with SMTP id 5b1f17b1804b1-42acd5d79b1mr62388755e9.30.1724683589831; Mon, 26 Aug 2024 07:46:29 -0700 (PDT) Received: from ?IPV6:2003:cb:c737:1900:16b0:8dc:77e:31af? (p200300cbc737190016b008dc077e31af.dip0.t-ipconnect.de. [2003:cb:c737:1900:16b0:8dc:77e:31af]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42ac51579casm157952675e9.11.2024.08.26.07.46.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Aug 2024 07:46:29 -0700 (PDT) Message-ID: Date: Mon, 26 Aug 2024 16:46:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/5] mm: memory_hotplug: check hwpoisoned page firstly in do_migrate_range() To: Kefeng Wang , Andrew Morton Cc: Oscar Salvador , Miaohe Lin , Naoya Horiguchi , linux-mm@kvack.org References: <20240817084941.2375713-1-wangkefeng.wang@huawei.com> <20240817084941.2375713-4-wangkefeng.wang@huawei.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240817084941.2375713-4-wangkefeng.wang@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: nen696ibhhwdpag7cgpa3zue9kifw6c4 X-Rspamd-Queue-Id: 06B6C1C0011 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1724683593-405204 X-HE-Meta: U2FsdGVkX1+4FfTtW+wVxQKXf5MFbMyoApzJ1UaMZ+SV6x0dWFsNlse1nwgw5eF1dxX5VBv5abri3HLaISkI42rnAF5PH/uD7Kuxiqb0dcEgGCzdkefiytpgyCwSI63XjpV6wOZBqaERsFsh11W/a9HCwO8Q9nMDizr1oh0we+hdL0BDlo42xzPaxpN7UCYCTMQXe+MW9sLLUMkAhYKUY3xTgi5aFeAbRjKqf7ORpcdRmKd8MR/ExQ0zx/MMRxSFwPhkK75w7aoTY/FhGSTR8ijSbedkcxe7lvBw365yGG20EEpI1qc9xsnve7EPboNATn0TY1HDzqWVvAGcgZ8QXRlqQm6g05ZCEKyr6rNU8Azz0LpHxAQIfMSaM+JBDKbyDkJZMsqKE6uOUfCmfUlVswJEO9j06i1EkTyLdBIXonOOGODo7VWWOuERQy2Aw54NMtckUUTGdYCIKSPijr5Vr8LLdsOGB9TIW7dODIcf7wNLliWV6dLmUAWMP2Y6MTEEcFjoe4mNE1v6jf5AJVJwINJkBVadnVYS6RQVDoqWhBQQ2ZmsmXbjGa09QntSXZ4TRghXcBvb0Q0XM6HmjhZzZ+0sATkaPhkHXgo1+Wi67zxy7sibZLjHEddARYNKOS6EraYgsFmDjyQJDSN9sPiDa3ivSpzCEn26SPhDA5O56fIy9aCxynV3qghEGWOPgVBJiMKq23Vqp2v1ckaPidIXKS1FILUfjxGRbPfSWXtZah14ZHi+ZOEBkgKkqnQSWRaVg29i7Giwm9wsz6Y5+4w49ig23RnoIaECU4+Wt3GNw8gSbTWu21s4rmQPkqLEJDV18RdqIFRD7bV6h75k+1mcd0UzDK1ZNNhTPSOLm0BC6OvmhoaB5+fbnlTUrFdnI1X4Ijypll7iVQHQNtg/8WEMSgzb4ssob2xlMUhV7B4lrnSy1/GDhTZDENneNKKsBRitKTIUhvV+dbIBW58qY8g 3nROFMX4 45rg9OGbMEhF1KlPZGkrMB/6Dpl1T+DBsXmty+uHsJX+Mr9FPTFgux24b8UM+QXl9OqNrelYDx+BVwbXoLdWFcpZKxp1Gh6fnWVWy32iiZMbXKeoa1+ma7JwFppO1SBc5VIlqpsRf9j/HSt0i9hPC2RCvuMSsDygY1BxDIcxzVzUVo0ChYu/RZWRp/BaxUlkDjx3xMloJTLfPjYPq0Droh8I0h1NqH3vl3IzvvoW2OSiyLGm9YdSEbPo2PWUOmgj2sVZxGijdxqqluqdLYGxJw62LcpB3XcKidGwAWnJ/bcyrJUJdcI4e5Se9V0J/SfJuCGtTHDQBkY++cIra4l1tDWzf5eQYoXsM8myNeRMBjjwcyMGOTROWGG2vSgyYLwYE9ky4ME+nrVnFnXNIPuScqn2q6CoHCcnV0zBCLdj0wHHdCQu7ceLC4AXk4smP11GOvt8ZmX1oT/r4xliBCwB6vrRzZGmHprDqAOZf6riL7jy41Nw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 17.08.24 10:49, Kefeng Wang wrote: > The commit b15c87263a69 ("hwpoison, memory_hotplug: allow hwpoisoned > pages to be offlined") don't handle the hugetlb pages, the endless > loop still occur if offline a hwpoison hugetlb, luckly, with the > commit e591ef7d96d6 ("mm,hwpoison,hugetlb,memory_hotplug: hotremove > memory section with hwpoisoned hugepage") section with hwpoisoned > hugepage"), the HPageMigratable of hugetlb page will be clear, and > the hwpoison hugetlb page will be skipped in scan_movable_pages(), > so the endless loop issue is fixed. > > However if the HPageMigratable() check passed(without reference and > lock), the hugetlb page may be hwpoisoned, it won't cause issue since > the hwpoisoned page will be handled correctly in the next movable > pages scan loop, and it will be isolated in do_migrate_range() but > fails to migrate. In order to avoid the unnecessary isolation and > unify all hwpoisoned page handling, let's unconditionally check hwpoison > firstly, and if it is a hwpoisoned hugetlb page, try to unmap it as > the catch all safety net like normal page does. > > Signed-off-by: Kefeng Wang > --- > mm/memory_hotplug.c | 17 +++++++++-------- > 1 file changed, 9 insertions(+), 8 deletions(-) > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index dc19b0e28fbc..02a0d4fbc3fe 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -1793,13 +1793,8 @@ static void do_migrate_range(unsigned long start_pfn, unsigned long end_pfn) > * but out loop could handle that as it revisits the split > * folio later. > */ > - if (folio_test_large(folio)) { > + if (folio_test_large(folio)) > pfn = folio_pfn(folio) + folio_nr_pages(folio) - 1; > - if (folio_test_hugetlb(folio)) { > - isolate_hugetlb(folio, &source); > - continue; > - } > - } > > /* > * HWPoison pages have elevated reference counts so the migration would > @@ -1808,11 +1803,17 @@ static void do_migrate_range(unsigned long start_pfn, unsigned long end_pfn) > * (e.g. current hwpoison implementation doesn't unmap KSM pages but keep > * the unmap as the catch all safety net). > */ > - if (PageHWPoison(page)) { > + if (folio_test_hwpoison(folio) || > + (folio_test_large(folio) && folio_test_has_hwpoisoned(folio))) { We have the exact same check already in mm/shmem.c now. Likely this should be factored out ... but no idea what function name we should use that won't add even more confusion :D > if (WARN_ON(folio_test_lru(folio))) > folio_isolate_lru(folio); > if (folio_mapped(folio)) > - try_to_unmap(folio, TTU_IGNORE_MLOCK); > + unmap_posioned_folio(folio, TTU_IGNORE_MLOCK); > + continue; > + } > + > + if (folio_test_hugetlb(folio)) { > + isolate_hugetlb(folio, &source); > continue; > } > Acked-by: David Hildenbrand -- Cheers, David / dhildenb