From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC0E2C4332F for ; Fri, 3 Nov 2023 10:41:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C2A52280018; Fri, 3 Nov 2023 06:41:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BB2DE28000F; Fri, 3 Nov 2023 06:41:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9DEBA280018; Fri, 3 Nov 2023 06:41:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 890B128000F for ; Fri, 3 Nov 2023 06:41:05 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 471691CBD80 for ; Fri, 3 Nov 2023 10:41:05 +0000 (UTC) X-FDA: 81416300490.25.92A7E5B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf02.hostedemail.com (Postfix) with ESMTP id 0266A80014 for ; Fri, 3 Nov 2023 10:41:02 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cRg4+PCq; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf02.hostedemail.com: domain of pbonzini@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=pbonzini@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699008063; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Lp6Jz+POVOM2ymATN0+4roKlcGz/gu2UjTswWR4Ytbw=; b=vDbJkU5S4VDFfIrhewzK85kdIwnOCEguPN5ktGVjdgh5Qn1oYQMiyQ8mo9LY7NzG19T3eg IDKy+vMwPV1d9YDEb0lh10DyyHCE0Ew9U7oAkgrWC7ozSIsNwodpffH54TIZh7HNyYmpVF KeLcJbqZvC4hi50PADd+TiNIo+9D0N0= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cRg4+PCq; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf02.hostedemail.com: domain of pbonzini@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=pbonzini@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699008063; a=rsa-sha256; cv=none; b=1P9F1VjkMMfriYt8S9KhI/Nq2RPwpf8+KBZ7uel3YWlSGfjP+6YMm6JAj0dy8OLLODp+jF n9vt1V2BNh72QcHMMZLAy6qleDBp8pBGAolkWfk8XdwdkVaGoj+Mkg8aASIm/kL2ojktrd sp4JFwhy+I+OeAG4ZKVFDi+NQpE92Ds= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699008062; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Lp6Jz+POVOM2ymATN0+4roKlcGz/gu2UjTswWR4Ytbw=; b=cRg4+PCqqSlOE2s/8+SbHCWChJ/PgzTXRoLzGH2VKsxlFbC6nK51LMuzcKpx7+fFQ85SE9 ZqdCL60k0CdCxvgpyvUtNst78QeZG6G9eFzeg/QI6b37gEj2F0Veh//aj0hpgG1tnhl+/z GKWyOQ93PVAwx6y1OyziDH2saneefoY= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-644-OPDLY7hjMcqFd93cr2D-Uw-1; Fri, 03 Nov 2023 06:41:00 -0400 X-MC-Unique: OPDLY7hjMcqFd93cr2D-Uw-1 Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-9d2606301eeso223862566b.0 for ; Fri, 03 Nov 2023 03:41:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699008060; x=1699612860; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Lp6Jz+POVOM2ymATN0+4roKlcGz/gu2UjTswWR4Ytbw=; b=gHAkn+ocOX9iEIQExxHZK/4vqHMvy+tOxMCTQpMhtrz7GLMSZAf88p8kvTuuumz0M5 9Fg1iyuzRi1wIgqr/WDUsYjzJeW4dJB+kznC38QwSKKJGj4nzWzyyJEq4v4lsbDJ4Wgh ookQitYqHmz9HdiumcwC9i66mdTSknaL3OCo5ywEmDy6mHPRM5rk9vK65Aq4UWM2Hus8 0ukaJC01AdCc6fP5Dajm0w9RJ01qTge7zsRjgFnTIBdwau48yt+G2w+utWdEmsUucd/J Pn7wMicIkke3DPoyW9lqkA/T+a+csGp8dNSFg81w3NKJvTAiS6QYD+PL4KvnFVMwGPG0 2t0w== X-Gm-Message-State: AOJu0YyG2NUsNwLrYymGccd/g6ye3cJUo0+I6FF8xWhUqlgcNMVClGqy 27FSAjxX3UB6wb3oll1dE/O5Atg93WWAKWJzQ7u40jrgTsUDf1E8DQislX9luIpYb/VK5pZFeaU jPQQ3KvypMm8= X-Received: by 2002:a17:906:7950:b0:9bf:c00f:654a with SMTP id l16-20020a170906795000b009bfc00f654amr2302821ejo.24.1699008059857; Fri, 03 Nov 2023 03:40:59 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEYL84kQ58i2cP4K6S7xeuKGH18ZQ7RIKhzKbyX3E6c1jOpr4P+mCWZM0GIPaXqH2aak15cSg== X-Received: by 2002:a17:906:7950:b0:9bf:c00f:654a with SMTP id l16-20020a170906795000b009bfc00f654amr2302775ejo.24.1699008059454; Fri, 03 Nov 2023 03:40:59 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:4783:a68:c1ee:15c5? ([2001:b07:6468:f312:4783:a68:c1ee:15c5]) by smtp.googlemail.com with ESMTPSA id g4-20020a170906394400b009a5f1d15644sm754493eje.119.2023.11.03.03.40.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Nov 2023 03:40:58 -0700 (PDT) Message-ID: Date: Fri, 3 Nov 2023 11:40:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v13 15/35] fs: Export anon_inode_getfile_secure() for use by KVM To: Christian Brauner , Sean Christopherson Cc: Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexander Viro , "Matthew Wilcox (Oracle)" , Andrew Morton , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xiaoyao Li , Xu Yilun , Chao Peng , Fuad Tabba , Jarkko Sakkinen , Anish Moorthy , David Matlack , Yu Zhang , Isaku Yamahata , =?UTF-8?B?TWlja2HDq2wgU2FsYcO8?= =?UTF-8?Q?n?= , Vlastimil Babka , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A . Shutemov" References: <20231027182217.3615211-1-seanjc@google.com> <20231027182217.3615211-16-seanjc@google.com> <20231102-freihalten-vorsah-fdd68051b005@brauner> From: Paolo Bonzini Autocrypt: addr=pbonzini@redhat.com; keydata= xsEhBFRCcBIBDqDGsz4K0zZun3jh+U6Z9wNGLKQ0kSFyjN38gMqU1SfP+TUNQepFHb/Gc0E2 CxXPkIBTvYY+ZPkoTh5xF9oS1jqI8iRLzouzF8yXs3QjQIZ2SfuCxSVwlV65jotcjD2FTN04 hVopm9llFijNZpVIOGUTqzM4U55sdsCcZUluWM6x4HSOdw5F5Utxfp1wOjD/v92Lrax0hjiX DResHSt48q+8FrZzY+AUbkUS+Jm34qjswdrgsC5uxeVcLkBgWLmov2kMaMROT0YmFY6A3m1S P/kXmHDXxhe23gKb3dgwxUTpENDBGcfEzrzilWueOeUWiOcWuFOed/C3SyijBx3Av/lbCsHU Vx6pMycNTdzU1BuAroB+Y3mNEuW56Yd44jlInzG2UOwt9XjjdKkJZ1g0P9dwptwLEgTEd3Fo UdhAQyRXGYO8oROiuh+RZ1lXp6AQ4ZjoyH8WLfTLf5g1EKCTc4C1sy1vQSdzIRu3rBIjAvnC tGZADei1IExLqB3uzXKzZ1BZ+Z8hnt2og9hb7H0y8diYfEk2w3R7wEr+Ehk5NQsT2MPI2QBd wEv1/Aj1DgUHZAHzG1QN9S8wNWQ6K9DqHZTBnI1hUlkp22zCSHK/6FwUCuYp1zcAEQEAAc0j UGFvbG8gQm9uemluaSA8cGJvbnppbmlAcmVkaGF0LmNvbT7CwU0EEwECACMFAlRCcBICGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRB+FRAMzTZpsbceDp9IIN6BIA0Ol7MoB15E 11kRz/ewzryFY54tQlMnd4xxfH8MTQ/mm9I482YoSwPMdcWFAKnUX6Yo30tbLiNB8hzaHeRj jx12K+ptqYbg+cevgOtbLAlL9kNgLLcsGqC2829jBCUTVeMSZDrzS97ole/YEez2qFpPnTV0 VrRWClWVfYh+JfzpXmgyhbkuwUxNFk421s4Ajp3d8nPPFUGgBG5HOxzkAm7xb1cjAuJ+oi/K CHfkuN+fLZl/u3E/fw7vvOESApLU5o0icVXeakfSz0LsygEnekDbxPnE5af/9FEkXJD5EoYG SEahaEtgNrR4qsyxyAGYgZlS70vkSSYJ+iT2rrwEiDlo31MzRo6Ba2FfHBSJ7lcYdPT7bbk9 AO3hlNMhNdUhoQv7M5HsnqZ6unvSHOKmReNaS9egAGdRN0/GPDWr9wroyJ65ZNQsHl9nXBqE AukZNr5oJO5vxrYiAuuTSd6UI/xFkjtkzltG3mw5ao2bBpk/V/YuePrJsnPFHG7NhizrxttB nTuOSCMo45pfHQ+XYd5K1+Cv/NzZFNWscm5htJ0HznY+oOsZvHTyGz3v91pn51dkRYN0otqr bQ4tlFFuVjArBZcapSIe6NV8C4cEiSTOwE0EVEJx7gEIAMeHcVzuv2bp9HlWDp6+RkZe+vtl KwAHplb/WH59j2wyG8V6i33+6MlSSJMOFnYUCCL77bucx9uImI5nX24PIlqT+zasVEEVGSRF m8dgkcJDB7Tps0IkNrUi4yof3B3shR+vMY3i3Ip0e41zKx0CvlAhMOo6otaHmcxr35sWq1Jk tLkbn3wG+fPQCVudJJECvVQ//UAthSSEklA50QtD2sBkmQ14ZryEyTHQ+E42K3j2IUmOLriF dNr9NvE1QGmGyIcbw2NIVEBOK/GWxkS5+dmxM2iD4Jdaf2nSn3jlHjEXoPwpMs0KZsgdU0pP JQzMUMwmB1wM8JxovFlPYrhNT9MAEQEAAcLBMwQYAQIACQUCVEJx7gIbDAAKCRB+FRAMzTZp sadRDqCctLmYICZu4GSnie4lKXl+HqlLanpVMOoFNnWs9oRP47MbE2wv8OaYh5pNR9VVgyhD OG0AU7oidG36OeUlrFDTfnPYYSF/mPCxHttosyt8O5kabxnIPv2URuAxDByz+iVbL+RjKaGM GDph56ZTswlx75nZVtIukqzLAQ5fa8OALSGum0cFi4ptZUOhDNz1onz61klD6z3MODi0sBZN Aj6guB2L/+2ZwElZEeRBERRd/uommlYuToAXfNRdUwrwl9gRMiA0WSyTb190zneRRDfpSK5d usXnM/O+kr3Dm+Ui+UioPf6wgbn3T0o6I5BhVhs4h4hWmIW7iNhPjX1iybXfmb1gAFfjtHfL xRUr64svXpyfJMScIQtBAm0ihWPltXkyITA92ngCmPdHa6M1hMh4RDX+Jf1fiWubzp1voAg0 JBrdmNZSQDz0iKmSrx8xkoXYfA3bgtFN8WJH2xgFL28XnqY4M6dLhJwV3z08tPSRqYFm4NMP dRsn0/7oymhneL8RthIvjDDQ5ktUjMe8LtHr70OZE/TT88qvEdhiIVUogHdo4qBrk41+gGQh b906Dudw5YhTJFU3nC6bbF2nrLlB4C/XSiH76ZvqzV0Z/cAMBo5NF/w= In-Reply-To: <20231102-freihalten-vorsah-fdd68051b005@brauner> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 0266A80014 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 95yjuaxjm4zxd95r1mbbsxshoo3ir5qh X-HE-Tag: 1699008062-271323 X-HE-Meta: U2FsdGVkX192XqdI4SaHLApOF+VPkKlG0bStaNBfRXgTEnhVuqZYceFWLy6XibXZDZlqudPS0GiDbL1lLbL7GdmUJlCfbfj2l3LnywpDwsXsD5d1ASFSAmfZhiHdnVj+M7eoGl0CN/2FZDhF57cbzXH4uTFIFwX6H1VZCxFJ/j92sxsPWx7TdV5iRYg/eGxiZ9LP64r9O0jUlab0zvvK4WvbMoqt1QQX6WIjaqCUO3AydvYDqAgFRIFQoTbNk0/5C9EecG2R1gNWaztuZ9wDVWJS9JjRPQ5TWM8a36V3bIqNEN2gxe+qxpFaVQx/kHZ3vdmX/mGPmo/09hRuaZljU+WZ2HcWPkUD8TuODj47M62/13x5u+0RuJfdOmIAyAsijNfrTU9TZBGVto8npS+KGYyrD7dd84vnw26mTnoIsBY37cqSNV3uPlRy9OObs1OneZvqRaWFmYg31bQ4S7qLZQnNPv7gVH+DPuoMYcgzTznf90A00//VinFuKiVWeeBxBw5BhdtgIN0RSZPW5kn6zlgPBH5DfvcN6JxK6e5LFQG/in2EjSOO9tT7D1HrVvO0sk8WobGZ6OOkIejHLYO7llShRf5PxXFXFgHLYYuQ/F9UNBacPuedqI5w1GwPNGphbku+MxAHWDWl6ZP0DEzYvOllyTPCcXgkULnQtR/ys8l0qdFhcd4onFW184PW+tu4iQRRuZ/QPy1J3iCqVzYDqrNtepRPSYs8sCen49Y+RDukpIKtQMu6R5BLsMq2BHoaOtSslShij+3/cGIpN8aPejuXIDdimfrmo4AMu4BHvDfbmwCIjJSOOShlBiBgCWaohJriaEtTv50vtFkelt/KkmD2rVmOvaZhe/Ptin/VeqU1UVwGbB2fP5hEPGkNlWtfsr+SFhCQXeqK9fy1sRk4gAMUJGMUrz5+gIowARVcCv9PU+bSjLx4PnlbetYfcLwA7O5HTHYYlp41pAuk99A Hebu04/y IyBsk2zF9sz1VoeTik65MMJUcriPSIj59aiy70PTPFEnu6OFMXW0m/43zg+ROLeqyLlM0Pvjo1cnOOYm1RC/AD2AayFr0aqLZANB9EU8LqgA3WUHlNFnjj0/e1Ck+TJxn5Up3HKKjKt42kv5U4WOekn2DMid8xrBnhFvc6Rc1Zjb/belI9oPyErCVu5PNOy754xvMdEz7rgcDJMBMY/2zCZRSVxkfNG7ezTvQLoifPSoLF5bSsVKmOFV8Ha/+B953GvAllu4ItgiesUNidh+KDsnjv1TEBjHw2PY8To+/mz228F18VTZ8LVchmNDAi5/r10HcL4hnHmcChHcgmibhTm24j1rEi9knrsIANxD01KzB7sc4UNgAcBb+ziY//WTnBMzkFwGljvcI/Zk8W/C9tNQJ5EviGulpoakDFxRl+hccOULAQKqulPsxvgzEezuMpSvUEsJtiWF4NJRV+zCQjCkZPFvUFV/D29PH3BTJa+UlmyMBUd9+sIh4nwb2Y29xMxbqiVNHholE4p6ptQjmg2f+1A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11/2/23 17:24, Christian Brauner wrote: > On Fri, Oct 27, 2023 at 11:21:57AM -0700, Sean Christopherson wrote: >> Export anon_inode_getfile_secure() so that it can be used by KVM to create >> and manage file-based guest memory without need a fullblow filesystem. >> The "standard" anon_inode_getfd() doesn't work for KVM's use case as KVM >> needs a unique inode for each file, e.g. to be able to independently >> manage the size and lifecycle of a given file. >> >> Note, KVM doesn't need a "secure" version, just unique inodes, i.e. ignore >> the name. >> >> Signed-off-by: Sean Christopherson >> --- > > Before we enshrine this misleading name let's rename this to: > > create_anon_inode_getfile() > > I don't claim it's a great name but it's better than *_secure() which is > very confusing. So just: > > struct file *create_anon_inode_getfile(const char *name, > const struct file_operations *fops, > void *priv, int flags) I slightly prefer anon_inode_create_getfile(); grepping include/linux for '\ May also just remove that context_inode argument from the exported > function. The only other caller is io_uring. And neither it nor this > patchset need the context_inode thing afaict. True, OTOH we might as well rename anon_inode_getfd_secure() to anon_inode_create_getfd(), and that one does need context_inode. I'll Cc you on v14 and will carry the patch in my tree. Paolo > Merge conflict risk is > extremely low so carrying that as part of this patchset is fine and > shouldn't cause huge issues for you. >