From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 562CFC636CC for ; Wed, 1 Feb 2023 01:33:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 95D416B0074; Tue, 31 Jan 2023 20:33:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 90CCF6B0075; Tue, 31 Jan 2023 20:33:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7FBB86B0078; Tue, 31 Jan 2023 20:33:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 727176B0074 for ; Tue, 31 Jan 2023 20:33:44 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 46C4580D0E for ; Wed, 1 Feb 2023 01:33:44 +0000 (UTC) X-FDA: 80417001168.16.DB3A3E0 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by imf21.hostedemail.com (Postfix) with ESMTP id 7C3BC1C0003 for ; Wed, 1 Feb 2023 01:33:40 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=none; spf=pass (imf21.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675215222; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sjqDApo9FYXxE+CFppXoznnTnyfmJHj5hFAyuD058BI=; b=ALBd9urzwrRZKyJUIwsqtHg72FnzXT6ZfFlGC5OrJd4D8/91rtIr7d8JZyiYVV2OfMZuA+ PwXirlD6gnrnkN/0n655LeqHyAQnMq/oyo7fhh0tSBq+xJSr4YwTSri10tqnUiSFnY03iG KiTm+MF2mna4JxgPR9KwutTe5bUbeBc= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=none; spf=pass (imf21.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675215222; a=rsa-sha256; cv=none; b=jgc6sfsPBJYl7ubb0WIa8EIFBr1QH+5R0kOdoZF6fLbUhVTcevpu+Cb86bCuVi+xe2IcrN K/OV0m5nO02kQdbLcW+WIdz6t86vIYa6lazprM9AekEUCaJGWMsNBqvr9hJWR9Xey2zs1d U+Wp9Ave/0TGc5ynWPHskpz1I9089vk= Received: from dggpemm500001.china.huawei.com (unknown [172.30.72.54]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4P64Bs5ngfz16MYB; Wed, 1 Feb 2023 09:31:33 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 1 Feb 2023 09:33:34 +0800 Message-ID: Date: Wed, 1 Feb 2023 09:33:34 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH -next resend v3] mm: hwposion: support recovery from ksm_might_need_to_copy() Content-Language: en-US To: Andrew Morton CC: , , , , , David Hildenbrand References: <20221213030557.143432-1-wangkefeng.wang@huawei.com> <20221213120523.141588-1-wangkefeng.wang@huawei.com> <20230131163204.2c511663bfece90d56121cc6@linux-foundation.org> From: Kefeng Wang In-Reply-To: <20230131163204.2c511663bfece90d56121cc6@linux-foundation.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected X-Stat-Signature: i3zdahoxcdmrfa5mmz9q8nfn4dqftsbj X-Rspam-User: X-Rspamd-Queue-Id: 7C3BC1C0003 X-Rspamd-Server: rspam06 X-HE-Tag: 1675215220-334895 X-HE-Meta: U2FsdGVkX1/kOvYeqn5+0jdqxEQJM5/5WpO7yrOuw1A1PP6gtauVMWaBl1XWywmM6QFP7s0wh/C6uXNvkMhy7Vuzr7UMi9L0C/bMPsCd8qf5c5UXSuQ2nJQ9nZo4UH6XS1cNLP7h4QYgF956m1u2/78PO3B6B48RyXK0wAyu0I+9vN4Zp0ADFYyNsyhan0YW1GG9sF6u552uoCsbNxv4XsGWueBblTQVM1PKy1VdID/Y1Si/kVuZjTsGtwOOfhrw+lggAN0lRzewDm5FF3Ji6Vsfshac68gRwNIdv9pRfSdOH8KAsYhnXB+VmbCsY+wD+BLlTKDLfnmh6hqXDIFlZ99ucGvIAyBUuK+zJsvv+KXPJN+vjekZpQ8bA9hwkSjUU6ZnVFzXkzlB4ptzYe5Ugt0XZv352P7TKYlTx+xWK5f8uFPxiA5Tl5s6YGKYAV5/1mTxu+O5WCNd/xlAebTKuP8DvMHJPH6bePLGS9Z8jhydDZEVDouxrVUP4Ii/k3qi0n6DhahQ0M5a9dVoeKnKku3+mw56gxWNrfJO+aJN4sRK/kZk/z2rxs/epEq79JvZhVrdSScWwoUtvVbXfuD2ZR/BtoaKqs90smzFLANFZu0IVUDBX3SqUy4Oa2skogbPMIyaSEZcqkxJrFwqZ/h851vvjDT4UY6C7LOTqKnBS/oxSbUxdCwOWvkjah/0EBVq8IzGmvwqDe1VRmduXTkocxwmGCkB54Hq8CasHVAjbFztR4uMFMpf72bMtnruoWS392a237f+dIi4mK6ekJRzuBKJaOYPBgs4W0Nrxo7WGwnB0RBeNQoBBc7j/m5jLLRk1jEbHrXBJ0uulcuZOcOgNCaqJhrknkVTZ4Rj9I78JTLiyUfwa6l9uCyfA4b9TrAqB+a8y2SrWy7+zo49RC+XMMfKzww3oEti/M4505zSq4iAP0RT40w8sNJdLW5jTV/CwQTeS2tEl68Rsqv23yG WUAY8ZxZ yLb5ACA68nugikhYiwwKHKjENye7RNvFmkdQH8kJ1mhODUTamQAq4uHnQg1X7NMV6l1WW2SrEt5Tii+FmUV82yybJ0Sl0Vi18PxmCl2SM6Bei0eEhr1Tt2c96BmVyYBBtKj7NzwSrz6nXWDxfogZAALr3ITjcHMZqLsDB6iCjrsFlnP0nOvItE5JsQX+M27AFkQpy+exlOwi35ZjGdctxRhhiGw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/2/1 8:32, Andrew Morton wrote: > On Tue, 13 Dec 2022 20:05:23 +0800 Kefeng Wang wrote: > >> When the kernel copy a page from ksm_might_need_to_copy(), but runs >> into an uncorrectable error, it will crash since poisoned page is >> consumed by kernel, this is similar to Copy-on-write poison recovery, >> When an error is detected during the page copy, return VM_FAULT_HWPOISON >> in do_swap_page(), and install a hwpoison entry in unuse_pte() when >> swapoff, which help us to avoid system crash. Note, memory failure on >> a KSM page will be skipped, but still call memory_failure_queue() to >> be consistent with general memory failure process. > > I believe we're awaiting a v4 of this? Sorry, forget this one. > > Did we consider a -stable backport? "kernel crash" sounds undesirable... This one depends on Copy-on-write poison recovery patchset, and I check the commit a873dfe1032a ("mm, hwpoison: try to recover from copy-on write faults") is not included into stable, and both of them are enhancement of COPY_MC feature, so it seems that we don't need to backport to stable. > > Can we identify a Fixes: target for this? As it is a part of COPY_MC, I don't think it is need a Fixes tag. I will resend a new one to address the comments of HORIGUCHI NAOYA(堀口 直也). Thanks.