From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79E79C433E0 for ; Wed, 10 Feb 2021 14:22:39 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E35ED64E7A for ; Wed, 10 Feb 2021 14:22:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E35ED64E7A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 412DA6B0006; Wed, 10 Feb 2021 09:22:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 39C5D6B006C; Wed, 10 Feb 2021 09:22:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 264DB6B006E; Wed, 10 Feb 2021 09:22:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0051.hostedemail.com [216.40.44.51]) by kanga.kvack.org (Postfix) with ESMTP id 0D7516B0006 for ; Wed, 10 Feb 2021 09:22:38 -0500 (EST) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id C728A186B566C for ; Wed, 10 Feb 2021 14:22:37 +0000 (UTC) X-FDA: 77802573954.11.tent32_540072027610 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin11.hostedemail.com (Postfix) with ESMTP id A45C0186A4006 for ; Wed, 10 Feb 2021 14:22:37 +0000 (UTC) X-HE-Tag: tent32_540072027610 X-Filterd-Recvd-Size: 5304 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf50.hostedemail.com (Postfix) with ESMTP for ; Wed, 10 Feb 2021 14:22:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612966956; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yKGNdoeE42XjyVSZ4Q+TFvmhULCMg2nknuM5NfQEDVM=; b=W+HoVhliqRNa6mJ9vZyZdkwhuRdJcc9uTlSLDgKQfRio1G1WilL0BiEyYvf5pouMu2uZw3 LWdHv4aCjmMw67nLY7GhJULcHuPJGbwfwOiEtMoY8MV6cDS7InKw7JY0CZlBE+O21k7qYB JAVVXWhfs7JV3kkRjftB+vRmsz8L++8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-359-UVuQvXOOMO2s5-ylVlVaSw-1; Wed, 10 Feb 2021 09:22:33 -0500 X-MC-Unique: UVuQvXOOMO2s5-ylVlVaSw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 769F2801A9A; Wed, 10 Feb 2021 14:22:09 +0000 (UTC) Received: from [10.36.113.218] (ovpn-113-218.ams2.redhat.com [10.36.113.218]) by smtp.corp.redhat.com (Postfix) with ESMTP id F31CA5C6AB; Wed, 10 Feb 2021 14:22:07 +0000 (UTC) Subject: Re: [RFC PATCH 1/2] mm,page_alloc: Make alloc_contig_range handle in-use hugetlb pages To: Oscar Salvador Cc: Mike Kravetz , Muchun Song , Michal Hocko , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20210208103812.32056-1-osalvador@suse.de> <20210208103812.32056-2-osalvador@suse.de> <6aa21eb3-7bee-acff-8f3c-7c13737066ba@redhat.com> <20210210140941.GA3636@localhost.localdomain> <20210210141425.GB3636@localhost.localdomain> From: David Hildenbrand Organization: Red Hat GmbH Message-ID: Date: Wed, 10 Feb 2021 15:22:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <20210210141425.GB3636@localhost.localdomain> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10.02.21 15:14, Oscar Salvador wrote: > On Wed, Feb 10, 2021 at 03:11:05PM +0100, David Hildenbrand wrote: >> On 10.02.21 15:09, Oscar Salvador wrote: >>> On Wed, Feb 10, 2021 at 09:56:37AM +0100, David Hildenbrand wrote: >>>> On 08.02.21 11:38, Oscar Salvador wrote: >>>>> alloc_contig_range is not prepared to handle hugetlb pages and will >>>>> fail if it ever sees one, but since they can be migrated as any other >>>>> page (LRU and Movable), it makes sense to also handle them. >>>>> >>>>> For now, do it only when coming from alloc_contig_range. >>>>> >>>>> Signed-off-by: Oscar Salvador >>>>> --- >>>>> mm/compaction.c | 17 +++++++++++++++++ >>>>> mm/vmscan.c | 5 +++-- >>>>> 2 files changed, 20 insertions(+), 2 deletions(-) >>>>> >>>>> diff --git a/mm/compaction.c b/mm/compaction.c >>>>> index e5acb9714436..89cd2e60da29 100644 >>>>> --- a/mm/compaction.c >>>>> +++ b/mm/compaction.c >>>>> @@ -940,6 +940,22 @@ isolate_migratepages_block(struct compact_control *cc, unsigned long low_pfn, >>>>> goto isolate_fail; >>>>> } >>>>> + /* >>>>> + * Handle hugetlb pages only when coming from alloc_contig >>>>> + */ >>>>> + if (PageHuge(page) && cc->alloc_contig) { >>>>> + if (page_count(page)) { >>>> >>>> I wonder if we should care about races here. What if someone concurrently >>>> allocates/frees? >>>> >>>> Note that PageHuge() succeeds on tail pages, isolate_huge_page() not, i >>>> assume we'll have to handle that as well. >>>> >>>> I wonder if it would make sense to move some of the magic to hugetlb code >>>> and handle it there with less chances for races (isolate if used, >>>> alloc-and-dissolve if not). >>> >>> Yes, it makes sense to keep the magic in hugetlb code. >>> Note, though, that removing all races might be tricky. >>> >>> isolate_huge_page() checks for PageHuge under hugetlb_lock, >>> so there is a race between a call to PageHuge(x) and a subsequent >>> call to isolate_huge_page(). >>> But we should be fine as isolate_huge_page will fail in case the page is >>> no longer HugeTLB. >>> >>> Also, since isolate_migratepages_block() gets called with ranges >>> pageblock aligned, we should never be handling tail pages in the core >>> of the function. E.g: the same way we handle THP: >> >> Gigantic pages? (spoiler: see my comments to next patch :) ) > > Oh, yeah, that sucks. > We had the same problem in scan_movable_pages/has_unmovable_pages > with such pages. > > Uhm, I will try to be more careful :-) > Gigantic pages are a minefield. Not your fault :) -- Thanks, David / dhildenb