From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30E0FC07E9D for ; Mon, 19 Jul 2021 11:30:04 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B8B0960FF3 for ; Mon, 19 Jul 2021 11:30:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B8B0960FF3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 54F798D00F4; Mon, 19 Jul 2021 07:30:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4FF468D00EC; Mon, 19 Jul 2021 07:30:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 379EB8D00F4; Mon, 19 Jul 2021 07:30:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0151.hostedemail.com [216.40.44.151]) by kanga.kvack.org (Postfix) with ESMTP id 11E418D00EC for ; Mon, 19 Jul 2021 07:30:04 -0400 (EDT) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 97673231DD for ; Mon, 19 Jul 2021 11:30:02 +0000 (UTC) X-FDA: 78379118244.14.BC0389A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf15.hostedemail.com (Postfix) with ESMTP id C06BAD0000AD for ; Mon, 19 Jul 2021 11:30:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626694201; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ESnH2S6yBdJz7yr94lSisLVqQUkwCAoXoLcXG4GRyLI=; b=VnA5wtoeaEfCl8yAoFNdPi75f21E2u0bhsrUZW1UjkwrqS2dSyN0b8wavdT4z4FcgB9y6F Lrd3KgDhn2a0IObZgj1Q8Zu4+4Mn+WOVY0Gu29bBhoEF2166XCuWPCxm45dBa7UwaTrd7o /TAOS3uIjycSyeer40w69E3jp8u1vgQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-396-QLcfgylOPmWWZVhyrvl0fA-1; Mon, 19 Jul 2021 07:30:00 -0400 X-MC-Unique: QLcfgylOPmWWZVhyrvl0fA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 78E5D100C660; Mon, 19 Jul 2021 11:29:58 +0000 (UTC) Received: from [10.64.54.195] (vpn2-54-195.bne.redhat.com [10.64.54.195]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5B86E620DE; Mon, 19 Jul 2021 11:29:54 +0000 (UTC) Reply-To: Gavin Shan Subject: Re: [PATCH v2 09/12] mm/vm_debug_pgtable: Use struct pgtable_debug_args in PUD modifying tests To: kernel test robot , linux-mm@kvack.org Cc: clang-built-linux@googlegroups.com, kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, anshuman.khandual@arm.com, catalin.marinas@arm.com, will@kernel.org, akpm@linux-foundation.org, chuhu@redhat.com, shan.gavin@gmail.com References: <20210719054138.198373-10-gshan@redhat.com> <202107191750.5uS1cDBz-lkp@intel.com> From: Gavin Shan Message-ID: Date: Mon, 19 Jul 2021 21:30:10 +1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.0 MIME-Version: 1.0 In-Reply-To: <202107191750.5uS1cDBz-lkp@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VnA5wtoe; spf=none (imf15.hostedemail.com: domain of gshan@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=gshan@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam05 X-Stat-Signature: 9nwmpkcgbpxuqupx8q7but7de1ru8q31 X-Rspamd-Queue-Id: C06BAD0000AD X-HE-Tag: 1626694201-379438 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/19/21 7:13 PM, kernel test robot wrote: > Hi Gavin, > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on linus/master] > [also build test WARNING on v5.14-rc2] > [cannot apply to hnaz-linux-mm/master linux/master next-20210716] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch] > > url: https://github.com/0day-ci/linux/commits/Gavin-Shan/mm-debug_vm_pgtable-Enhancements/20210719-134236 > base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 2734d6c1b1a089fb593ef6a23d4b70903526fe0c > config: arm64-randconfig-r005-20210719 (attached as .config) > compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 5d5b08761f944d5b9822d582378333cc4b36a0a7) > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # install arm64 cross compiling tool for clang build > # apt-get install binutils-aarch64-linux-gnu > # https://github.com/0day-ci/linux/commit/69db26024e6bd48423ebc83b0f83b7b52217b624 > git remote add linux-review https://github.com/0day-ci/linux > git fetch --no-tags linux-review Gavin-Shan/mm-debug_vm_pgtable-Enhancements/20210719-134236 > git checkout 69db26024e6bd48423ebc83b0f83b7b52217b624 > # save the attached .config to linux build tree > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > Thanks for reporting the build warnings. I will fix it in v3. > All warnings (new ones prefixed by >>): > >>> mm/debug_vm_pgtable.c:445:8: warning: variable 'pud' set but not used [-Wunused-but-set-variable] > pud_t pud; > A "WARN_ON(!pud_none(pud)) is missed from PATCH[9/12]. ^ > mm/debug_vm_pgtable.c:1140:17: warning: variable 'protnone' set but not used [-Wunused-but-set-variable] > pgprot_t prot, protnone; > ^ > mm/debug_vm_pgtable.c:1142:36: warning: variable 'pmd_aligned' set but not used [-Wunused-but-set-variable] > unsigned long vaddr, pte_aligned, pmd_aligned; > ^ > mm/debug_vm_pgtable.c:1143:42: warning: variable 'pgd_aligned' set but not used [-Wunused-but-set-variable] > unsigned long pud_aligned, p4d_aligned, pgd_aligned; > ^ > mm/debug_vm_pgtable.c:1143:29: warning: variable 'p4d_aligned' set but not used [-Wunused-but-set-variable] > unsigned long pud_aligned, p4d_aligned, pgd_aligned; > ^ > mm/debug_vm_pgtable.c:1143:16: warning: variable 'pud_aligned' set but not used [-Wunused-but-set-variable] > unsigned long pud_aligned, p4d_aligned, pgd_aligned; > ^ > mm/debug_vm_pgtable.c:1140:11: warning: variable 'prot' set but not used [-Wunused-but-set-variable] > pgprot_t prot, protnone; > ^ > 7 warnings generated. > There are more build warnings introduced by other patches. I need to drop the unused variables in debug_vm_pgtable(). So I need to drop the unused variables in separate patches in v3, instead of dropping all of them in PATCH[v2 11/12]. Thanks, Gavin > > vim +/pud +445 mm/debug_vm_pgtable.c > > 5fe77be6bf14bf Shixin Liu 2021-06-30 442 > 69db26024e6bd4 Gavin Shan 2021-07-19 443 static void __init pud_huge_tests(struct pgtable_debug_args *args) > a5c3b9ffb0f404 Anshuman Khandual 2020-08-06 444 { > 5fe77be6bf14bf Shixin Liu 2021-06-30 @445 pud_t pud; > 5fe77be6bf14bf Shixin Liu 2021-06-30 446 > 69db26024e6bd4 Gavin Shan 2021-07-19 447 if (!arch_vmap_pud_supported(args->page_prot)) > 5fe77be6bf14bf Shixin Liu 2021-06-30 448 return; > 5fe77be6bf14bf Shixin Liu 2021-06-30 449 > 5fe77be6bf14bf Shixin Liu 2021-06-30 450 pr_debug("Validating PUD huge\n"); > 5fe77be6bf14bf Shixin Liu 2021-06-30 451 /* > 5fe77be6bf14bf Shixin Liu 2021-06-30 452 * X86 defined pud_set_huge() verifies that the given > 5fe77be6bf14bf Shixin Liu 2021-06-30 453 * PUD is not a populated non-leaf entry. > 5fe77be6bf14bf Shixin Liu 2021-06-30 454 */ > 69db26024e6bd4 Gavin Shan 2021-07-19 455 WRITE_ONCE(*(args->pudp), __pud(0)); > 69db26024e6bd4 Gavin Shan 2021-07-19 456 WARN_ON(!pud_set_huge(args->pudp, __pfn_to_phys(args->fixed_pud_pfn), > 69db26024e6bd4 Gavin Shan 2021-07-19 457 args->page_prot)); > 69db26024e6bd4 Gavin Shan 2021-07-19 458 WARN_ON(!pud_clear_huge(args->pudp)); > 69db26024e6bd4 Gavin Shan 2021-07-19 459 pud = READ_ONCE(*(args->pudp)); > a5c3b9ffb0f404 Anshuman Khandual 2020-08-06 460 } > 5fe77be6bf14bf Shixin Liu 2021-06-30 461 #else /* !CONFIG_HAVE_ARCH_HUGE_VMAP */ > 54b1f4b50ddb0f Gavin Shan 2021-07-19 462 static void __init pmd_huge_tests(struct pgtable_debug_args *args) { } > 69db26024e6bd4 Gavin Shan 2021-07-19 463 static void __init pud_huge_tests(struct pgtable_debug_args *args) { } > 5fe77be6bf14bf Shixin Liu 2021-06-30 464 #endif /* CONFIG_HAVE_ARCH_HUGE_VMAP */ > 399145f9eb6c67 Anshuman Khandual 2020-06-04 465 > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org >