From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC591C77B72 for ; Mon, 17 Apr 2023 11:14:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 880B1900004; Mon, 17 Apr 2023 07:14:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8387C8E0001; Mon, 17 Apr 2023 07:14:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6F847900004; Mon, 17 Apr 2023 07:14:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 5CE918E0001 for ; Mon, 17 Apr 2023 07:14:08 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id DAAEA1605AD for ; Mon, 17 Apr 2023 11:14:07 +0000 (UTC) X-FDA: 80690623734.01.5CE56B9 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf16.hostedemail.com (Postfix) with ESMTP id 7ED95180010 for ; Mon, 17 Apr 2023 11:14:05 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OyCOWl4j; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681730045; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zAUqMMR70hs25oMWjXxlhHN7VAFevFPXHxG6Ef3AXlI=; b=Q+8R79ptjRpfNUJv0EGZcKq8upOEpWihsy/+57SIcqqPxfTH2pxIFpH4GfEKk7VXkAZ2+o hQ3c7PEKKBJGkC8Al4Nj3Os/mLn1HqPBFcjos4/VmSeFPh230ZeA6KbvTiiadXZg44OKZM 9H7OjyI54Wv44w3HoPr4md26bTNQ12E= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OyCOWl4j; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681730045; a=rsa-sha256; cv=none; b=8c0nrQJTC91TNYRDgbYy8IGe+0sG3i64T80UjAGd56N1wJsv+iY6W6eGXgbZ5ZZ78Fuhv0 9box+Pfcf4d7bdzpd2Hb6GeS5/RzzWRrFDPFDchISMoGRpvf4/a9Bja8kABKVTrfUObjLf g607sta/VAArfvgCjvnahiiYyvikMOY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681730044; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zAUqMMR70hs25oMWjXxlhHN7VAFevFPXHxG6Ef3AXlI=; b=OyCOWl4jSv2aOuxtyrkk/JGbpnpoXVGoUhnTQmi6nD2rY1DQ4fL1bMUZb2DOhCQtJFzIHt hsQIA6Wv1VT6HwL1xFd+cSTrwk/e+8wdIwGw5NrXE1+IoXSBKbA78xEQrA76iaAL8yeFXz X56yFOXZMIj7RLIbNrAxYa9c2hxJwm4= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-439-BGYMxoYGMX-GN8_zLnMBwA-1; Mon, 17 Apr 2023 07:14:01 -0400 X-MC-Unique: BGYMxoYGMX-GN8_zLnMBwA-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-2efb90d132cso372330f8f.3 for ; Mon, 17 Apr 2023 04:14:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681730040; x=1684322040; h=content-transfer-encoding:in-reply-to:subject:organization:from :references:cc:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zAUqMMR70hs25oMWjXxlhHN7VAFevFPXHxG6Ef3AXlI=; b=bWLEXUM287kaTucdqT8NzgARGDHPLTsLp3/mW13GC7dEWXU5DeTbeeX/katx8SBRyX KP47BKu5yW3yWL9F+tp7rDFhUV7uakNhl8+dvJIFEUpjP4lKPlssfdTvcp6dPZi2j0IR poYJJNW+by+gRVxWCM4PKQ71myWaYk1+vcLrKq7DVS8kJK2cY6000+tNroUcC+DGY/n0 aXtL7lBvkmYtuw+PWyX/7EwdrW7ZLw5QrmVpaOnsSN/6xc67be6y0i3IY928YqD+/D59 /O1oghvN0YFGDHY+T1zbINH28qd220XP7MH1jse6hDU7ZykBx2sDhEUg6i0Vhvk6i5Jd fioA== X-Gm-Message-State: AAQBX9dMegl2RnLEU8spYmJ9g7vSxDcfVF5Q2lYtBo1ob9IJqz94H+bn WyR4QYTPEHYzEJxYXvhB+F5ZCbWVPOL1cn4x9rnCfah2NDkZxgEVJO8GV+fBfQDRj433aDM6MEW 3mM+VXk2MbF+5CFMu/0M= X-Received: by 2002:adf:f285:0:b0:2d8:4e4:8cf1 with SMTP id k5-20020adff285000000b002d804e48cf1mr4136252wro.21.1681730040586; Mon, 17 Apr 2023 04:14:00 -0700 (PDT) X-Google-Smtp-Source: AKy350ax7wuZ0Iz3BSuaDK/61BajmIrYjRyEbJKqxJkNyFbcymWg3m+sbjevfS9itJuunEOl+2y01A== X-Received: by 2002:adf:f285:0:b0:2d8:4e4:8cf1 with SMTP id k5-20020adff285000000b002d804e48cf1mr4136237wro.21.1681730040201; Mon, 17 Apr 2023 04:14:00 -0700 (PDT) Received: from ?IPV6:2003:cb:c700:fc00:db07:68a9:6af5:ecdf? (p200300cbc700fc00db0768a96af5ecdf.dip0.t-ipconnect.de. [2003:cb:c700:fc00:db07:68a9:6af5:ecdf]) by smtp.gmail.com with ESMTPSA id b2-20020adfe302000000b002fae2a08089sm1583630wrj.70.2023.04.17.04.13.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Apr 2023 04:13:59 -0700 (PDT) Message-ID: Date: Mon, 17 Apr 2023 13:13:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 To: Lorenzo Stoakes , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton Cc: Matthew Wilcox References: <2feedd2bad6fd1ec4bc4639f9d9012c5ae2faf1f.1681558407.git.lstoakes@gmail.com> From: David Hildenbrand Organization: Red Hat Subject: Re: [PATCH v3 4/7] mm/gup: introduce the FOLL_SAME_FILE GUP flag In-Reply-To: <2feedd2bad6fd1ec4bc4639f9d9012c5ae2faf1f.1681558407.git.lstoakes@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 7ED95180010 X-Stat-Signature: xykbka84h4wtcwtqgon8jbghi6mgcju9 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1681730045-48120 X-HE-Meta: U2FsdGVkX19iCjJ755t28oP708sikrpn+W+hsvJE2n4GEtBOEMgCfCMQi8GQfcIctRfL8hdwUega4lNjsbuV1cWmXZBzsjVc6L679kcYrakldukBOzgMKRIq8GuHS/kZ+4UDVJMwDzquhd/pPDXU7VbN6cI6B6A3QGFCrjg8+FJVYf2tbxWZeWuxKVZWHO8Zl1afwP5OG155BJ5/XD7uMpMaXDZf65WVk6c8trdV7+R41ZGQOpnx7s0sRRIyBlldjFLgcqCHcDVHUykbG2GcGxe3JFFIbsiwdD0byuP5YqnBWDjjon79BSx4SraV5WEFMB00f+oEsQuK5XAUCm9n3PfdyHC7iK6ZWAfjxw/u2JMrG4nNGgC/qhlU3Pl3lSbNQknJIFf/GTiGzXdcI2p8ZanHzvPaWG2WPUdUgAXQRjEcB/RCyCewCrtcp0MHqwqOF3TIqATARtXDFuV/zImmAOocsa2OGsVQ8dUyK9FFhscfEiIerQHalNAW+jUejXKDtIszT1Fg15UjRS3qw8XtVwkdL6FxIjr/NNeXmNsgDTVfhwyHWzXX5a1q1gHeFVN2Y8rlfFm+P54tCaOvbJRq0HcO8gBS/rMWYB2e7tTc7GSPHPy8SMGoxMzglVpKj6bhLBfjFQ7Uc/L/mbWJ8Xoflp6NFYSgYSx2lF/B6GUfKbg+74Y/9qdJgJHafgsPKbCQgpnQbYJbNFEMlNsBfzErZg+n0bonBLdOQ7jp/Lg63UR8nDImX2lDUPt2wPkfu7AXcOVKkd9l1kEqAkUg7YAG7efpJ64KFGActvZqsNEKtALZtfYciqFGTbhdiH9xvafreL1Xr27fZvvMtZIFOh/ShDL6aT7Ow18Du6rOr5uCY/gj4Sxkx1f3eyGhPCqRdL/H69KP/XAw8a8BHdUYq7D9JwVsrm2uhUsTKK7OcEMdQK68tNzJ2jjlhYmxOGGPMb+MIxHecDzKDzFPey/wTeg NoD5/Eir j/ISlFneWmF9l/2nj/EhTWlYlG7d/RNQ6QGBhtHgUnna9YTnqj5TDTP2qYV+QwmYzb3y4PmB52f82NVAU9TRxK9E4bBUOihxt5IGkC0NVbsxafRGKbSLFGb9n+D+uIrSafHCc1uGB7dn8hSpgr6m43cRZ38vurQx5gvGNHA1IX1k1tgYaWuegRw6kc1BcQx+zSTwXk251jXy6f5pso+cUAyUQHtMcen3bD5dWqv1OtgRxxBvR2Krhgmq2SDGUhT2DPrHQvTBM8Hkw8bLvNRf36WJO30WypJgbRLumPfeauLtPpT2UxUnxgkEMNw3caRtSlqZ1OrFY8s5MTt4LQnUXfzyyt7FUdWiAmUa9JxsDpK/iXM11Pd0OEANsBJIGVXhMtY536asEpp6/WoA8qtKDXU7KNNxmvLiagChWR7LSF9SrVjygVV6k2vO7oplOzvv6h5ayT2SZGfKoDtGNqU2YfAyxWQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 15.04.23 14:09, Lorenzo Stoakes wrote: > This flag causes GUP to assert that all VMAs within the input range possess > the same vma->vm_file. If not, the operation fails. > > This is part of a patch series which eliminates the vmas parameter from the > GUP API, implementing the one remaining assertion within the entire kernel > that requires access to the VMAs associated with a GUP range. > > Signed-off-by: Lorenzo Stoakes [...] > --- > &start, &nr_pages, i, > @@ -1595,7 +1603,7 @@ long faultin_vma_page_range(struct vm_area_struct *vma, unsigned long start, > * We want to report -EINVAL instead of -EFAULT for any permission > * problems or incompatible mappings. > */ > - if (check_vma_flags(vma, gup_flags)) > + if (check_vma_flags(vma, vma->vm_file, gup_flags)) > return -EINVAL; FOLL_SAME_FILE is never set here, just pass NULL instead of vma->vm_file. As we're not allowing to drop the mmap lock, why can't io_uring simply go over all VMAs once, after pinning succeeded, and make sure that the files match (or even before pinning)? In most cases, we're dealing with a single VMA only, it's not like the common case is that io_uring pins accross 100s of VMAs. So I really wonder if the GUP complexity is justified by something. (removing the VMAs is certainly a welcome surprise -- as it doesn't make any sense when used with FOLL_UNLOCKABLE). -- Thanks, David / dhildenb