From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29BBCC001B0 for ; Wed, 26 Jul 2023 16:39:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AC9E16B0072; Wed, 26 Jul 2023 12:39:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A7A926B0078; Wed, 26 Jul 2023 12:39:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9423C6B007B; Wed, 26 Jul 2023 12:39:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 849136B0072 for ; Wed, 26 Jul 2023 12:39:47 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 51244C0247 for ; Wed, 26 Jul 2023 16:39:47 +0000 (UTC) X-FDA: 81054324414.25.A5526F2 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf24.hostedemail.com (Postfix) with ESMTP id EEE3618001B for ; Wed, 26 Jul 2023 16:39:44 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aszYLv4H; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690389585; a=rsa-sha256; cv=none; b=yAdQ52NV1fZ/b9ETqsWGyX2D/sJEl3LdPLndjZEqJCyK/5wCgczMlP61tK3NZYKf2euBX9 WIOUnWiSBSiHpKiQ+/ZKTtkHGIDYu4s4kHeSlbRmv6VqFCs8yvzDg68rBkbeZIFaOWv3jd LLf+AGx818/RW8nj1vDDv9BMGw093a0= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aszYLv4H; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690389585; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mBRwboZ65s2wEyxE4FPIAJKpqYqzXSa2YWMDeQT0bz4=; b=rA8pcsM8vVtJwB2C2W8z4zyLTAmI3Sf8E97fIxPyBMUiqHNWMviTiNCF0TVIENHEuSXyp6 TiNV1Wg/PdJsI70ADwwlTkO1GDiDxsPEa30UVkTUgy9dAz4DDbyutIcGudC+jZxo73tew3 vFAeeAz/7ZGeB/Kj73EVXmtrFw1yCCc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690389584; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mBRwboZ65s2wEyxE4FPIAJKpqYqzXSa2YWMDeQT0bz4=; b=aszYLv4HRcut9xgX42dWM8w+9+eSBKWNnPNOR6TkTaEzTVBcBGTXO2YF+2E96llXDGBISr 0rznQUjjQbU2QlXgynUKkrkNhhV0TScSy2z8BBUSPT7JEYiXJmVKLKImRBTLpWQMQjC4FQ 2YIiDYEhdM6336tg13vMpzvUCpZwmX4= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-595-zHV3xwa_OlmumdJiLiasUQ-1; Wed, 26 Jul 2023 12:39:39 -0400 X-MC-Unique: zHV3xwa_OlmumdJiLiasUQ-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-31701b27d19so620767f8f.1 for ; Wed, 26 Jul 2023 09:39:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690389578; x=1690994378; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=mBRwboZ65s2wEyxE4FPIAJKpqYqzXSa2YWMDeQT0bz4=; b=cTS9M2KKbb7KMrIXAN5S8DdyQHTjD17iM0BZzJ+NGdJHQmSoC1QOQJoHZa3ag6o27/ kyvPSHMFImcQFWPjSwFuYp+dUNOk9glX8zIxw18lSRQY7v4sa18pj7aI806CtNdvLDPU 7dHkiLwkNJ1Oa1yVraV4GJN3XzdOSmwfMjjS+JH67eMy0teolwIuUQ3vKecw3P364Agc lbMD3g299jT7ZWchrcnl10peFeDdfWQbA1nzIyEoem3ye4MvmbHNhZjuCY2Sr+wHc1Y5 pptR2VSxIIbery5W55XamGPuVSiDLNqAffSnA73x0nkhPPz37dY/P3tSDrCalYXw0Y58 TSPg== X-Gm-Message-State: ABy/qLaCbtTqDPzOSQ/Pe0PRMrzG94GYom9juxPaDS+gXRC4y5H1aade ltDnvnNuDu3xtTTzwS3sKtsaPF0yZNZ7Gfl2F+nar8Mq4thQzX3+v4IUOyC8ZFtcNQz93l+MEM0 bI12PK1XUIzw= X-Received: by 2002:adf:dcd0:0:b0:314:98f:2495 with SMTP id x16-20020adfdcd0000000b00314098f2495mr31559wrm.12.1690389578674; Wed, 26 Jul 2023 09:39:38 -0700 (PDT) X-Google-Smtp-Source: APBJJlFPADryZnRWsCJW+Me4oefqTHt3zQ2NSSl2lc70Hw6KN5yXHJYzRYB1UeLeLRegTJnEIqxq/Q== X-Received: by 2002:adf:dcd0:0:b0:314:98f:2495 with SMTP id x16-20020adfdcd0000000b00314098f2495mr31543wrm.12.1690389578273; Wed, 26 Jul 2023 09:39:38 -0700 (PDT) Received: from ?IPV6:2003:cb:c705:f600:a519:c50:799b:f1e3? (p200300cbc705f600a5190c50799bf1e3.dip0.t-ipconnect.de. [2003:cb:c705:f600:a519:c50:799b:f1e3]) by smtp.gmail.com with ESMTPSA id z17-20020a5d6411000000b003140f47224csm2309648wru.15.2023.07.26.09.39.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Jul 2023 09:39:37 -0700 (PDT) Message-ID: Date: Wed, 26 Jul 2023 18:39:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v5 4/7] mm/hotplug: Support memmap_on_memory when memmap is not aligned to pageblocks To: Aneesh Kumar K V , linux-mm@kvack.org, akpm@linux-foundation.org, mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org, npiggin@gmail.com, christophe.leroy@csgroup.eu Cc: Oscar Salvador , Michal Hocko , Vishal Verma References: <20230725100212.531277-1-aneesh.kumar@linux.ibm.com> <20230725100212.531277-5-aneesh.kumar@linux.ibm.com> <875y67xpsi.fsf@linux.ibm.com> <9d1448d3-a43a-5305-68aa-d82111fe077a@linux.ibm.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <9d1448d3-a43a-5305-68aa-d82111fe077a@linux.ibm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: EEE3618001B X-Stat-Signature: 98e9pz6kteb7bhh44dk81p7fk7ey6z9j X-Rspam-User: X-HE-Tag: 1690389584-163747 X-HE-Meta: U2FsdGVkX19uJh05CjvpA6EPYaOFtExF/t+QivAjInf0cJOQEn5K+e1ps8RaakqowuVm7p89QqgBGP9odynRnbcc6S48x+Krl1HttWYCDqyPJr7c1AU6XDy7AAMUZWEUF7FOG1U6M8ArTbNDgp5B5pk8ZloecoHC4LvuQVoBELlu8g874unTlodvxmjAI6JRxsH60MO9eyrdVlrqNTzwFfHUxUpzydcvZOC6Pz+M7aa3oBejfmKoHbPbSbTqfgmdwv/kk0+74f3wwsTAcuIJumd603q0QSwcX/YnUw0yR2a/SgSptUAotpIM0pnUdvdopDZmd+EVgihFrh9q2udWDJWEpG0k5YET9PWP+Tf8xiYo2a61u+fylIeHVwwHXg1VCH/V5xFku+6uEt9vguYaR52l9gmnx70f1xCaAo0oBUMC/XJspgoYBmqCseiP5B5Wp9o36FuHNa75U7A2lRoXfdAQlMhRPIrX63SIl6zVcDlHKYwp+s//otyePwFN8JHlIDWs+YNMOmrULF3Ewaf4F/2IsDPAfLrRPHyI2CVakdrlxzmucuZkqqL1SEIjb0iI1MgGJlL6vP0gB5ihwgo1kKVdZO1+s/q0/JfSulOahqf42udmgq8BL+xqb0x3S8SATTo8ORvbLuaD/XtFXpv8wQxRX9Tw85iSbpoMYXiE4CW+QuTTxHI3wmnFqQ3h/o7KO7LYED/i2KQ+xqUw78sPVxwk2vu/x+71g1AvoMQNACPH9ZKBylts7t/OMOsOwG1UZP+M2qtV+1EXalE8ok3U2XqU/LbLcoOULAjSJ4irO2Ra4ce2qWAQ7B2UL3gYJsczRzKZKmug2KS3llGXZpr4TRWAFyUjkK34RMF66Q6WR3ikQkUDZ+DI9TZc4eKWBc268KwcmjsgBwHRr7+Axlx/lXvd18fYW9SPphzIse97mKGZRmgrvpB72uFcW/i0UttQ/8hvqcgg9cZgJ9/VGUQ usq9rr27 wb0rFvMx071Mw2s6zrazY2A90NYzSIsTHllVtu4QQzQNq4nQq65tqetizdbPCTpvdx3ttykNmQkHzytKSWOaaslBzbsGuazV7loBL516f83PAoihOSyng3UkpkXQLBZ2laoF5tYAjRU6HZje+vjTJoRS7g7EB4oPzly9Vm5mqiJ1I/E0WHRFZ/yGT/p8ydDesJ+6fpTDwZJw560gUBtGwOqWtROkkHblZSY+vk+u0SN5oFag/VjL1upbQSoezzdXNwesW7u80xD/1d9etTSYRrvKIXppPVS99a4paO/O9o9JECe1nskdxqAxhoRAXo54ecOB2xyK511gBtxidh4fj6l7PA0f5Wf9YnUQab2fak9opjyiv8kaOw7p6cTViLxrfI0u7CHvQQDuwieTGxsQRobMU1UWJZSCp9A8GogLLqe4IVNM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 26.07.23 11:57, Aneesh Kumar K V wrote: > On 7/26/23 2:34 PM, David Hildenbrand wrote: >> >>>>>    /* >>>>> @@ -1310,7 +1400,10 @@ int __ref add_memory_resource(int nid, struct resource *res, mhp_t mhp_flags) >>>>>    { >>>>>        struct mhp_params params = { .pgprot = pgprot_mhp(PAGE_KERNEL) }; >>>>>        enum memblock_flags memblock_flags = MEMBLOCK_NONE; >>>>> -    struct vmem_altmap mhp_altmap = {}; >>>>> +    struct vmem_altmap mhp_altmap = { >>>>> +        .base_pfn =  PHYS_PFN(res->start), >>>>> +        .end_pfn  =  PHYS_PFN(res->end), >>>> >>>> Is it required to set .end_pfn, and if so, shouldn't we also set it to >>>> base_pfn + memory_block_memmap_on_memory_pages()) ? >>>> >>> >>> We use that in ppc64 for checking altmap boundary condition. As we >>> discussed earlier, ppc64 due to vmemmap mapping size restrictions can't >>> always allocate vmemmap pages from altmap area even if requested. We >>> fallback to regular memory alocation in that case (only used now with >>> pmem). We use altmap.end_pfn for that boundary check. You can refer to >>> altmap_cross_boundary() for more details. >> >> But even then, setting the end to the end of the resource size is wrong, no? We don't want anybody to allocate beyond base_pfn + memory_block_memmap_on_memory_pages(). >> > > altmap.end is the end pfn of the resource Oh, thanks for pointing that out. I wonder why the altmap even has to care about that ... -- Cheers, David / dhildenb