From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBA5AC83F1B for ; Thu, 17 Jul 2025 01:52:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5DED56B0095; Wed, 16 Jul 2025 21:52:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5B6806B00A1; Wed, 16 Jul 2025 21:52:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4CC146B00A3; Wed, 16 Jul 2025 21:52:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 3C5E26B0095 for ; Wed, 16 Jul 2025 21:52:27 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 008AA59BED for ; Thu, 17 Jul 2025 01:52:26 +0000 (UTC) X-FDA: 83672081934.17.378C682 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf11.hostedemail.com (Postfix) with ESMTP id A2F644000D for ; Thu, 17 Jul 2025 01:52:24 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Q7POgnwP; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf11.hostedemail.com: domain of luizcap@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=luizcap@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752717144; a=rsa-sha256; cv=none; b=GhXFOHB4rSGiysRP0Gus5lbyyYIxuq9DbnIKXNDb64t5sq4RQtywtBRge4KFBiII3G4Cv9 lUHdcQSbZLZTjot9jnvNwER6GvOfuV/lMaYwrObvcQTqXB0xYHAL2lnWTxsd8abINrGTUk QgvvUMIc2a31M6jBboolTcX5+RxDluA= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Q7POgnwP; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf11.hostedemail.com: domain of luizcap@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=luizcap@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752717144; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oonJpaJQAFJWZsBx4HwWzksB4jk3QqHG6oMM5XEtJzc=; b=SDEqBx4035aHj+fYI8gmtSG6KDG2NpIM3DIPkI0WHnk9HOiPWPjdMpesK5lDNWdKYbhQTh rFa3QG8/4rFGKRZFRgRCC2tRkzvFXagpZF1wDvHrSg/7if5h5BKmyXn7IJGvG0003rZ+Vy nYii6a6hpPEugGZ+yPS4F+JIeijVqo4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752717144; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oonJpaJQAFJWZsBx4HwWzksB4jk3QqHG6oMM5XEtJzc=; b=Q7POgnwPVqFIOk1OtGYOlq583B4EoaUibf2zJvF0rHY+P56k4j4r4DiTVONepr87hiSabC NKICgrSTq3SN30IGYhg92HxQtOnhN0KEBrzj4urGeiK1BbltP1lPa5CcKFlm4zDiKERrBr cgw6imOvCZcSqIMnF3srC/lOBDQrRII= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-205-YVD_olTVNlqJIy62iaANSQ-1; Wed, 16 Jul 2025 21:52:20 -0400 X-MC-Unique: YVD_olTVNlqJIy62iaANSQ-1 X-Mimecast-MFC-AGG-ID: YVD_olTVNlqJIy62iaANSQ_1752717140 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-6fb3487d422so7689946d6.0 for ; Wed, 16 Jul 2025 18:52:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752717139; x=1753321939; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oonJpaJQAFJWZsBx4HwWzksB4jk3QqHG6oMM5XEtJzc=; b=eW1DF5GYCronaVnEYDvp4Ye64fbQGBRSnOqTQMxemficsTHrp7IS4RmkGYyZLvvFh3 HIit0WObHFdlPdXQ6kt2LT22x4hd4cNg2VKQoLccMdFX3FqYz6scsD6i/XmdEHfVZL60 BwuRBdMWHEt3DdSETs2SyPostMEXTFkPDPKRQqr2cORDU4yN7u9gOiBPZilpJsswF8WV en6/TpRzY9Fti/NwSgHWnW8pcVthF2LK0s0ruUcYmdnyDRn9Kj3z4CmiV1jB/yW9DvrQ /e3ZgLEwUHchOTrxTKf2RLSkevVG0hiuOmztvs8erZFsAJ6AbY8b0BViGtoXv7SvCux+ 4kLQ== X-Forwarded-Encrypted: i=1; AJvYcCVIq6KxSPKUsDKhBJMIwd35lHrszo5v8px1mXDzc0WlJ3n66GCkMsqHNOGkj114sAsxxEgqreJ1Ig==@kvack.org X-Gm-Message-State: AOJu0Yyxw0Sn0IkJBM0lUUVJ7ENfwUasCGJiaYNz7LXn3A3M2Gbhn7ZY +9osN2ls3rJVHOfmdPmLdTTDGXjO3yUwiBhoQWWmgC2t6Lia1U+ukdquIgOU6FwM3sCiskoqw2o sH3FopzMOCUlPcYaIUFmMGvPspuhr1NsDGjbv7nSrJKEnuy482ODS X-Gm-Gg: ASbGncslVPdQvEHtwNL/1DOpj1+2u6TVCE1Dkoy2HHlLvI6h3IpgdCy69AhtT7PrazR TqEYA/3YKZmShRhkD874ggdU4r31lT+YVvKZ6Gjk7rLiwEboVbFteMDIXgNm+vCxGA+27KWNSbZ LGQnKt/o03peHGaYj/FBxiByGR/Hcm/cjM4QXSSD5znJZHGnOVBmOBKMkM+uJ1eyz/v1vYgCOlb jTSg7BSjdY8aVnlqNOiPu+PpjfKJN1sXksHTpXh7Qn/U3bHXBljHGZPpU0RuircqQVwouyw3hAX u6+9Jgs6HEcj+yggRu/7ABHhy76ZRDsFrZtBb6fD X-Received: by 2002:a05:6214:5d87:b0:704:7fda:d174 with SMTP id 6a1803df08f44-704f69fd7a3mr75458746d6.2.1752717139559; Wed, 16 Jul 2025 18:52:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGeNqyzhftnEI+RGrgPgJ/W+j/U4BgacO8D07ayiMNbDZaO2N4D0vHL8lrJF7eKKtR/H82Umg== X-Received: by 2002:a05:6214:5d87:b0:704:7fda:d174 with SMTP id 6a1803df08f44-704f69fd7a3mr75458506d6.2.1752717139091; Wed, 16 Jul 2025 18:52:19 -0700 (PDT) Received: from [192.168.2.110] ([70.29.229.84]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-70497d94538sm77582286d6.99.2025.07.16.18.52.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Jul 2025 18:52:18 -0700 (PDT) Message-ID: Date: Wed, 16 Jul 2025 21:52:08 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/4] mm/util: introduce snapshot_page() To: Andrew Morton , David Hildenbrand Cc: willy@infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, shivankg@amd.com, sj@kernel.org, harry.yoo@oracle.com References: <637a03a05cb2e3df88f84ff9e9f9642374ef813a.1752499009.git.luizcap@redhat.com> <900252c7-b16c-49b9-8c01-60e6a7a48683@redhat.com> <492025a7-4132-4944-b55b-90c6d6e40bba@redhat.com> <20250716151937.6dd71398bf764d073526dc8c@linux-foundation.org> From: Luiz Capitulino In-Reply-To: <20250716151937.6dd71398bf764d073526dc8c@linux-foundation.org> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: H5picEc90EbT6kmH_nj8tKjG5xUZmKuKOXku4gCMmA4_1752717140 X-Mimecast-Originator: redhat.com Content-Language: en-US, en-CA Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: A2F644000D X-Stat-Signature: 7s86x9q5m8u4j3w87dng6zyioipa4xwy X-HE-Tag: 1752717144-979065 X-HE-Meta: U2FsdGVkX1/tAulMF3YHsh8sIDMsFO4biRAswkTmA1wPFDzNn3J4FXshPGSLucGrWHBEOfz3eVTdYoILUpN6cx6NoYfN2Sx+ZHYyz75l9TWnFPpHs1dwpR0OUp9dIdGK2K3GcfbC7K+v3ix3vfq/VzsFC/J9CMyN7aIEA1Q5UqWH30uiEPbWQxLHt6cuFl3sbxx+scupWjJptR1+m1qkO4hKLa5eRc4ryvSpGBQB2ToLGhVdG+ZxujErGbJY9fwt81Dq10R/VAD1D+a5C5pcAYXOeoPxwHZ32/L5l6tNztSe8OOKxfwHGaZXTlWAVO6R/gK6KgvqYWRJ6gkkpa8loL2mTdCK0uhj9zaQVvkFAXvqKLuWAiW6AbHeHbfuRKrRXYtF88uIoafFb2hnMl7EBRJGf59qawOKI7DqVbFWfKoSif8ijfEOw9LSqyW8XhDw5vKRFSl/Pvx6fflmbRwQ+meMN7DrhOf7t/gTg4+SKY2j8zXsGslxOWQy4ryeuNwXrOD0GSVbdjENgqGDQECK0ZtPek2SgNDYJ1/BDeHP1NqOrDgNsKiDQfwVNV9+O7ortUU17lyQxitNZNvkDOW5ri1TEkCmWP1G5i3NRuhGjJ0/R0No0wNk3KZGtoba2034UGxGCJLxxjtAsgWMpBsx9qBqU4eOm48l8SPFY+pD6lGuGFL59mzQ2qpw9s0CB3DOkb+tIuO3FW7su9GM5C6URG9lXJPHI/aCaND5p0pciJ+qwTAj1ef7b1HumNDaa4TXnSJykyaQ32xtDXwiT1GKsA4As7rAt4anaAibyACoCcZ7zNQ+HOHzsxkHqWQd9AnKWMyaYalVAzfCVWIxbK9NNau68qRcueB4WmOWJBTEXV0yn1l276UGSE6ntT4EwrNuh5cMF0rqBjNaXSa13iPEAcwTH0wEi3NGa47Hj2hQyRi7YRXSt6NozGDFtW8bL9d4/BEF5aHwzGlj9OfHpbB grFAijM+ XGsK90qYf6SqZfIAPmIt3HY52To6tq0/kTrxLxr6wDeXTHceJ4XY9qFXpvQL106IuhJNLCcQ+/U3ywdlHFti+V+jjh2Wghavxe1t7OSRmkjG4vjpzJA+ihyxoUQ6AzDm81UL4EmAolhzUDldag5CzRkCNkec8C9q1llzFDlEHwZLLMQC1svxQPdaM0OOdjaq+/FpEcCi14Ke/bPioMP/dgx7FyWEXV40Rf5136ZbsxmOEW94Vc77FpA0fRSiqyBy2Etp8sP8pbZCybTuEu4wLQJ98E0qKV0tRkANDjJ79nqSZHC/Tbfz6NxDNzn9z0EhzXmsyeEH2UGPgnlNcMhMvgOV9eXbKe3AxFSgZVDPhrTrCsXjPfeTA2hzLLRGEDuEpFV91TBdc/x+XdqsYawbLydhpC9Xk+XliLFEkT5f4hnd/MxAD2sLIrvltW/fGKWApy3TJUHirOZ5a8b8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025-07-16 18:19, Andrew Morton wrote: > On Wed, 16 Jul 2025 20:18:00 +0200 David Hildenbrand wrote: > >> On 16.07.25 19:36, Luiz Capitulino wrote: >>> Yes, good catch. This was from an earlier version. >>> >>> Is it fine if I fix only this with a follow up patch for Andrew in this >>> thread or would you prefer that I post v4 with all the other changes as >>> well? >> >> I think the series was part of mm-new, but now I only spot it in >> mm-everything, weird. Maybe because of a conflict with the other >> stable_page_flags() change? > > I think I removed v2 from mm-unstable and added v3 to mm-new. Maybe. > >> So whatever Andrew prefers, really :) > > Either is OK at this stage. I do prefer little fixes so that I and > others can see what changed - it depends how tricky and large they are. I liked some of the other suggestions from David so I'll send v4.