From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC6EBC54E64 for ; Mon, 25 Mar 2024 10:37:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 40AA36B0098; Mon, 25 Mar 2024 06:37:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3BAF26B0099; Mon, 25 Mar 2024 06:37:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 25B346B009A; Mon, 25 Mar 2024 06:37:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 16F6D6B0098 for ; Mon, 25 Mar 2024 06:37:00 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id D862A40C08 for ; Mon, 25 Mar 2024 10:36:59 +0000 (UTC) X-FDA: 81935208558.03.AF0F60F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf04.hostedemail.com (Postfix) with ESMTP id 9A07D40011 for ; Mon, 25 Mar 2024 10:36:57 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ddm3ghKG; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711363017; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nuKAOl0Bry721S4cwoWk8aN4EFhzv2TAB2Qaj6//+9s=; b=jtkSb45aHAhGbbb+wwGXuAHjHlIty8Z1qG+RreUrxjiojqPOgD3yDiseeB0FPrT4upIYS/ rF/Cy/cbyu/HedNGpjqlzmtNvP4akAoZYwjk4pOOtJmCd+enojqC+yj101WE8U5RYJ1fmP si6yk5b4ag5mm9vQouhTOZr4SRstsPo= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ddm3ghKG; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711363017; a=rsa-sha256; cv=none; b=oLswwRDIMTT1Y5Bqp3burL1Ju6gEBB/zWNtVK4tAxL/vURJI6TGJ8LbS1X0En9O1oPNIvC +fvONXWfpR4p+r1EpEcQFxo15zmrhmLtpjTK8dGy8K7r3mONeaa/7ifZSCv8NkGlO8IW/6 /R3REwfg1hOXmDmV3+O02HA69OrhMoc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711363016; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=nuKAOl0Bry721S4cwoWk8aN4EFhzv2TAB2Qaj6//+9s=; b=ddm3ghKG/36JLucDLNO2qB9kFxjOSfHqQI7aQGMtO2xR4rzoW+I+fAe0GOSUHzKkI3IMT1 o6sUgmcjMJAv1DXkmox+CyJ5nmWqs3qObyB5IaAEaNzEgwvxK/4HDJLlPl1m2Px9M4yqTX h0fCS6EA8dgimM0Cb+gnUIadRx1ATa0= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-267-soSImAdcNRCfgCQFyqJbWg-1; Mon, 25 Mar 2024 06:36:55 -0400 X-MC-Unique: soSImAdcNRCfgCQFyqJbWg-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-40e4478a3afso21301835e9.1 for ; Mon, 25 Mar 2024 03:36:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711363014; x=1711967814; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=nuKAOl0Bry721S4cwoWk8aN4EFhzv2TAB2Qaj6//+9s=; b=ORrRM1JBpNWPfKPpAJwzrpvr8Dxhp9GiaC1HKCE1x/IFRWO54EtGu0y4ANlJqd6gLT F9SQWe0xoJ4hrq9TU2ao4B0YzRfElhRrDvsNhHGmUpuu+/4X37BdfOYAoXPRet/zcpe1 Aljh1Jhjf8oPD7JMSoAgw1MwecrsUrB4p2rg+MMAkafIsrRrFINp/Zf+3C0z1YxTACIF ApEPLVYoEqyxsZhzg15RLnqmTnKEUC3D+3EOfE85Vz5AxjR4+mIUJlhkm/Y8AeYuwplw A8ju+8kEfP3WlIBwcz47CaClFK69D7NNQIQrBfIpLzMjzDYGkBlS3NTzRumL2Uqg633u lk5A== X-Forwarded-Encrypted: i=1; AJvYcCWrxNMtdO0wthiNFBAiZACiI3z1SwI5yxrjlw02SBJpgltPoCPcWRxdtD4OymRRPRri9Vjk7MiXSQPuEc7J2GLfRbU= X-Gm-Message-State: AOJu0YwCipP5x8heX+bv1ELE25szFwDl8RQpKtNtDT43UJmV3G3yAqt/ E1eVnekdfGw/Q7gzwQa3ZpAhZ1R+1l1iAq+HOCZg81mVQI2pmXdZGVfCnifk0O7hRecgS6EJATG cdzdCaO0LVaoEkcCl7nVpagrg4cdV/UTa7YRmo/PhOOBmwzpq X-Received: by 2002:a05:600c:511f:b0:413:4299:ec9f with SMTP id o31-20020a05600c511f00b004134299ec9fmr5048421wms.5.1711363014321; Mon, 25 Mar 2024 03:36:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEmtFqtX7J5PVY5oK5JUWJ5+Vl4MC2tjXAYcoH3z8msCb94lGwCeHfsszfkiUoDNryPv45Bgg== X-Received: by 2002:a05:600c:511f:b0:413:4299:ec9f with SMTP id o31-20020a05600c511f00b004134299ec9fmr5048405wms.5.1711363013930; Mon, 25 Mar 2024 03:36:53 -0700 (PDT) Received: from ?IPV6:2003:cb:c738:b400:6a82:1eac:2b5:8fca? (p200300cbc738b4006a821eac02b58fca.dip0.t-ipconnect.de. [2003:cb:c738:b400:6a82:1eac:2b5:8fca]) by smtp.gmail.com with ESMTPSA id n24-20020a05600c3b9800b004147b3e3bedsm8059694wms.12.2024.03.25.03.36.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Mar 2024 03:36:53 -0700 (PDT) Message-ID: Date: Mon, 25 Mar 2024 11:36:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] mm: move follow_phys to arch/x86/mm/pat/memtype.c To: Christoph Hellwig , Andrew Morton , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Fei Li Cc: x86@kernel.org, linux-mm@kvack.org References: <20240324234542.2038726-1-hch@lst.de> <20240324234542.2038726-4-hch@lst.de> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240324234542.2038726-4-hch@lst.de> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 9A07D40011 X-Rspam-User: X-Stat-Signature: 6i1zk1cbimithhqx943ef3m5d8hxie7y X-Rspamd-Server: rspam01 X-HE-Tag: 1711363017-195814 X-HE-Meta: U2FsdGVkX19CTQGKaDXImwyBE6tfGi2NcDLNmTMPxlN3oE0YyUU8ZYjk7FRhir4fBMSmvT4hqEjC3MlgtJE3GSJRBzKEt0scXmS1fVPISzArSp7q2iHJYk0ZYqRVNe/G33yQpYBh27Wgr2x7ogmv3ZEiTelIVIzXaO/7KLd8pZwjszrWt5TB+NzD2CzvS6QzVfITpDJI0ZOBbMiqR01b3fH6fWAy5QhrYUIM5SNZqmB0jZ9sc6tcItddTHkbFOuc50QA4Eui01Cj5377eX+WyRlfsrU1zFIqsXkhZsYlrCeSNhYle3rySxvlmNz2qyKN4j1apFHr+RmTxiuBc7qUAM5QBAS043/HdcGf2JmJ+F0ZxzZtELhWG+Qn75VetVizPPdOFsp8BHvCzVwocoDTsicK56UFNBBzH+9Xaq6Es3wiyq40+9WbjQd85vDpBpgbFJArAbGv28/2JxEWCgJ77LFScWdm3DhwNvgUDxDQu1zrXqxJeueWeY53QgjfYdKk5ABdXK2Qw4TAi1daC+jk5d7iu9G9ASDEbPrXTgXXfvvWk0EJBoKPn8as+oDH0IFjaxIgSBNj9q4fR74vVw+/pb51bmZIi744mdBJawtxnwJlQspwhMPALpqtY/k8e/aQRkVHsaH2zZSAPejUfBPck3V4MePx2N3s5xwYxdU4FaBxyb1TBBYGvbCgv3792iKJEr9X4WK37fslZ9mph1+m5AkUZtuGWAD84yJFIm4tnAZ2ITelThvD+COiqLhZss2/jOiESiJNWBcK5B30yaDKwvnuxw3rvFYNkye3576YkOk7XseVT3cZvAKOA9SOL2jeGp86xU9+y/j6DEC5PPvIjj6k8AfnLu244AfJvoVFhf7bJGmFhFDtZ9By7rEi3Mao3mxUC0b3eLC3hpurL/zg9hm4GgT2tDxPuw3W8raHpQMId6LI3nuzSukNKBUy+yVEOpyO2mUuoUxj/WWIvlg nYcGo6DF 2bp+EMAskFERkSN5dvK1mtwu1zfMogIogAPIIHYvMjN2Pmhu1eRzfjf0qme+zPMStu3uDB74td0QWMmmPzZcYE4C57In6Wf8Pm8RQm/bvJaNQJIg9n/flnnYJ8w1jLc7gCVzoR62WxSfaSnuTz3i8st4BF0gGLHsaKyuNYYm16TdfvloaBhDfImzPsvwJTQy2/vBXpwgMoUUp0ZY86DqW1u9q0/ANM7UTcta/eBz/n2JPk9HN9T6n8mkwZzYAwtX96H4j+iw5kA54r6tYmJ3J/H3AcZMEWBE7xMAMfI3ogJA4Nq/yhGM4rP0LydAOP+itd4/wFdgJHt1S+BBqWp0oXc8+etFgquSH3LimniDXUwHv/g1OKfDZriHcZAFTPSpgtRON5b5AUTPL1QxeYMuL8xmCmCrxu+gjhr4qxxPS2H/4RbVMPjQ0GOHVadFrZTv20SEjhbqiFGX12RIsVCQriF683A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 25.03.24 00:45, Christoph Hellwig wrote: > follow_phys is only used by two allers in arch/x86/mm/pat/memtype.c. > Move it there and hardcode the two arguments that get the same values > passed by both caller. > > Signed-off-by: Christoph Hellwig > --- > arch/x86/mm/pat/memtype.c | 22 ++++++++++++++++++++-- > include/linux/mm.h | 2 -- > mm/memory.c | 28 ---------------------------- > 3 files changed, 20 insertions(+), 32 deletions(-) > > diff --git a/arch/x86/mm/pat/memtype.c b/arch/x86/mm/pat/memtype.c > index 0d72183b5dd028..bad99eb5c95b0d 100644 > --- a/arch/x86/mm/pat/memtype.c > +++ b/arch/x86/mm/pat/memtype.c > @@ -947,6 +947,24 @@ static void free_pfn_range(u64 paddr, unsigned long size) > memtype_free(paddr, paddr + size); > } > > +static int follow_phys(struct vm_area_struct *vma, unsigned long *prot, > + resource_size_t *phys) > +{ > + pte_t *ptep, pte; > + spinlock_t *ptl; > + > + if (!(vma->vm_flags & (VM_IO | VM_PFNMAP))) > + return -EINVAL; > + > + if (follow_pte(vma->vm_mm, vma->vm_start, &ptep, &ptl)) > + return -EINVAL; I have a patch here that (a) makes follow_pte() consume a VMA instead of a MM, and (b) moves the VMA check into follow_pte(). While you're at it, and if you're resending this, you might want to include similar changes; otherwise I'll can send this myself later on top. -- Cheers, David / dhildenb