linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Dan Magenheimer <dan.magenheimer@oracle.com>
To: Dave Hansen <dave@linux.vnet.ibm.com>, Nitin Gupta <ngupta@vflare.org>
Cc: Seth Jennings <sjenning@linux.vnet.ibm.com>,
	Greg KH <greg@kroah.com>,
	gregkh@suse.de, devel@driverdev.osuosl.org,
	cascardo@holoscopio.com, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org, brking@linux.vnet.ibm.com,
	rcj@linux.vnet.ibm.com
Subject: RE: [PATCH v2 0/3] staging: zcache: xcfmalloc support
Date: Tue, 1 Nov 2011 11:35:28 -0700 (PDT)	[thread overview]
Message-ID: <e51b28f7-da4a-4c53-889d-4f12b8dd701a@default> (raw)
In-Reply-To: <1320168615.15403.80.camel@nimitz>

> From: Dave Hansen [mailto:dave@linux.vnet.ibm.com]
> Sent: Tuesday, November 01, 2011 11:30 AM
> To: Nitin Gupta
> Cc: Seth Jennings; Greg KH; gregkh@suse.de; devel@driverdev.osuosl.org; Dan Magenheimer;
> cascardo@holoscopio.com; linux-kernel@vger.kernel.org; linux-mm@kvack.org; brking@linux.vnet.ibm.com;
> rcj@linux.vnet.ibm.com
> Subject: Re: [PATCH v2 0/3] staging: zcache: xcfmalloc support
> 
> On Fri, 2011-09-16 at 13:46 -0400, Nitin Gupta wrote:
> > I think replacing allocator every few weeks isn't a good idea. So, I
> > guess better would be to let me work for about 2 weeks and try the slab
> > based approach.  If nothing works out in this time, then maybe xcfmalloc
> > can be integrated after further testing.
> 
> Hi Nitin,
> 
> It's been about six weeks. :)
> 
> Can we talk about putting xcfmalloc() in staging now?

FWIW, given that I am quoting "code rules!" to the gods of Linux
on another lkml thread, I can hardly disagree here.

If Nitin continues to develop his allocator and it proves
better than xcfmalloc (and especially if it can replace
zbud as well), we can consider replacing xcfmalloc later.
Until zcache is promoted from staging, I think we have
that flexibility.

(Shameless advertisement though:  The xcfmalloc allocator
only applies to pages passed via frontswap, and on
that other lkml thread lurk many people intent on shooting
frontswap down.  So, frankly, I'd prefer time to be spent
on benchmarking zcache rather than on arguing about
allocators which, as things currently feel to me on that
other lkml thread, is not unlike rearranging deck chairs
on the Titanic. Half-:-).

Dan

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2011-11-01 19:02 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-07 14:09 [PATCH v2 0/3] staging: zcache: xcfmalloc support Seth Jennings
2011-09-07 14:09 ` [PATCH v2 1/3] staging: zcache: xcfmalloc memory allocator for zcache Seth Jennings
2011-09-07 14:09 ` [PATCH v2 2/3] staging: zcache: replace xvmalloc with xcfmalloc Seth Jennings
2011-09-07 14:09 ` [PATCH v2 3/3] staging: zcache: add zv_page_count and zv_desc_count Seth Jennings
2011-09-09 20:34 ` [PATCH v2 0/3] staging: zcache: xcfmalloc support Greg KH
2011-09-10  2:41   ` Nitin Gupta
2011-09-12 14:35     ` Seth Jennings
2011-09-13  1:55       ` Nitin Gupta
2011-09-13 15:58         ` Seth Jennings
2011-09-13 21:18           ` Nitin Gupta
2011-09-15 16:31             ` Seth Jennings
2011-09-15 17:29               ` Dan Magenheimer
2011-09-15 19:24                 ` Seth Jennings
2011-09-15 20:07                   ` Dan Magenheimer
2011-10-03 15:59                     ` Dave Hansen
2011-10-03 17:54                       ` Nitin Gupta
2011-10-03 18:22                         ` Dave Hansen
2011-10-05  1:03                           ` Dan Magenheimer
2011-09-15 22:17                   ` Dave Hansen
2011-09-15 22:27                     ` Dan Magenheimer
2011-09-16 17:36                     ` Nitin Gupta
2011-09-16 17:52                   ` Nitin Gupta
2011-09-16 17:46               ` Nitin Gupta
2011-09-16 18:33                 ` Seth Jennings
2011-11-01 17:30                 ` Dave Hansen
2011-11-01 18:35                   ` Dan Magenheimer [this message]
2011-11-02  2:42                     ` Nitin Gupta
2011-09-29 17:47 ` Seth Jennings

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e51b28f7-da4a-4c53-889d-4f12b8dd701a@default \
    --to=dan.magenheimer@oracle.com \
    --cc=brking@linux.vnet.ibm.com \
    --cc=cascardo@holoscopio.com \
    --cc=dave@linux.vnet.ibm.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=greg@kroah.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ngupta@vflare.org \
    --cc=rcj@linux.vnet.ibm.com \
    --cc=sjenning@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).