From: Ralph Campbell <rcampbell@nvidia.com>
To: Christoph Hellwig <hch@lst.de>
Cc: <linux-mm@kvack.org>, <kvm-ppc@vger.kernel.org>,
<nouveau@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
Dan Williams <dan.j.williams@intel.com>,
Ira Weiny <ira.weiny@intel.com>,
Matthew Wilcox <willy@infradead.org>,
Jerome Glisse <jglisse@redhat.com>,
John Hubbard <jhubbard@nvidia.com>,
Alistair Popple <apopple@nvidia.com>,
Jason Gunthorpe <jgg@nvidia.com>,
Bharata B Rao <bharata@linux.ibm.com>, Zi Yan <ziy@nvidia.com>,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
Yang Shi <yang.shi@linux.alibaba.com>,
Paul Mackerras <paulus@ozlabs.org>,
Ben Skeggs <bskeggs@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 1/2] ext4/xfs: add page refcount helper
Date: Mon, 28 Sep 2020 15:20:48 -0700 [thread overview]
Message-ID: <e56a1de5-6bd7-9f18-60ce-0493bcdc6413@nvidia.com> (raw)
In-Reply-To: <20200926063539.GA3540@lst.de>
On 9/25/20 11:35 PM, Christoph Hellwig wrote:
> On Fri, Sep 25, 2020 at 01:44:41PM -0700, Ralph Campbell wrote:
>> error = ___wait_var_event(&page->_refcount,
>> - atomic_read(&page->_refcount) == 1,
>> + dax_layout_is_idle_page(page),
>> TASK_INTERRUPTIBLE, 0, 0,
>> ext4_wait_dax_page(ei));
>
>> +++ b/fs/xfs/xfs_file.c
>> @@ -750,7 +750,7 @@ xfs_break_dax_layouts(
>>
>> *retry = true;
>> return ___wait_var_event(&page->_refcount,
>> - atomic_read(&page->_refcount) == 1, TASK_INTERRUPTIBLE,
>> + dax_layout_is_idle_page(page), TASK_INTERRUPTIBLE,
>> 0, 0, xfs_wait_dax_page(inode));
>> }
>
> I still think a litte helper macro would be nice here:
>
> #define dax_wait_page(_inode, _page, _wait_cb) \
> ___wait_var_event(&(_page)->_refcount, \
> atomic_read(&(_page)->_refcount) == 1, \
> TASK_INTERRUPTIBLE, dax_layout_is_idle_page(_page), \
> TASK_INTERRUPTIBLE, 0, 0, _wait_cb(_inode));
OK, I'll add it in v3.
next prev parent reply other threads:[~2020-09-28 22:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 20:44 [RFC PATCH v2 0/2] mm: remove extra ZONE_DEVICE struct page refcount Ralph Campbell
2020-09-25 20:44 ` [PATCH 1/2] ext4/xfs: add page refcount helper Ralph Campbell
2020-09-25 20:51 ` Dan Williams
2020-09-25 21:17 ` Ralph Campbell
2020-09-26 6:35 ` Christoph Hellwig
2020-09-28 22:20 ` Ralph Campbell [this message]
2020-09-25 20:44 ` [PATCH 2/2] mm: remove extra ZONE_DEVICE struct page refcount Ralph Campbell
2020-09-26 6:41 ` Christoph Hellwig
2020-09-28 22:29 ` Ralph Campbell
2020-09-29 2:59 ` Bharata B Rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e56a1de5-6bd7-9f18-60ce-0493bcdc6413@nvidia.com \
--to=rcampbell@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=bharata@linux.ibm.com \
--cc=bskeggs@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=hch@lst.de \
--cc=ira.weiny@intel.com \
--cc=jgg@nvidia.com \
--cc=jglisse@redhat.com \
--cc=jhubbard@nvidia.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nouveau@lists.freedesktop.org \
--cc=paulus@ozlabs.org \
--cc=willy@infradead.org \
--cc=yang.shi@linux.alibaba.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).